Started by upstream project "gerrit-osmo-hlr" build number 154154gerrit-osmo-hlrjob/gerrit-osmo-hlr/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER43010GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER2GERRIT_PATCHSET_REVISION2ef24d62ab9c1489eb87ac3aaeece084676e76b5GERRIT_PATCHSET_UPLOADER_NAMEosmithGERRIT_PORT29418GERRIT_PROJECTosmo-hlrGERRIT_REFSPECrefs/changes/10/43010/2GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-hlrPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-hlr/154/PROJECT_NAMEosmo-hlrBRANCH_CImaster00001159951159951.0068226822144addc0dc1fd76c9868a774d2532faa2995eafff31addc0dc1fd76c9868a774d2532faa2995eafff31osmith/1.9.1addc0dc1fd76c9868a774d2532faa2995eafff31addc0dc1fd76c9868a774d2532faa2995eafff31osmith/1.9.156a6e983b98550adda992d821f8c0daf92e63ddc1ea6e983b98550adda992d821f8c0daf92e63ddc1eosmith/1.6.2a6e983b98550adda992d821f8c0daf92e63ddc1ea6e983b98550adda992d821f8c0daf92e63ddc1eosmith/1.6.23481335271b9f8c74cbafceeb11ccede5074bc93cc81335271b9f8c74cbafceeb11ccede5074bc93ccosmith/1.5.181335271b9f8c74cbafceeb11ccede5074bc93cc81335271b9f8c74cbafceeb11ccede5074bc93ccosmith/1.5.13142f82975f23b381a2fcfb42aacbd72660a0ee7f442f82975f23b381a2fcfb42aacbd72660a0ee7f4osmith/1.6.142f82975f23b381a2fcfb42aacbd72660a0ee7f442f82975f23b381a2fcfb42aacbd72660a0ee7f4osmith/1.6.11542ef24d62ab9c1489eb87ac3aaeece084676e76b52ef24d62ab9c1489eb87ac3aaeece084676e76b5master2ef24d62ab9c1489eb87ac3aaeece084676e76b52ef24d62ab9c1489eb87ac3aaeece084676e76b5master2ef24d62ab9c1489eb87ac3aaeece084676e76b52ef24d62ab9c1489eb87ac3aaeece084676e76b5masterssh://jenkins@gerrit.osmocom.org:29418/osmo-hlrfalse#154115995117471gerrit-osmo-hlr-build #154154falsefalse154169375SUCCESS1784109326400https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-hlr-build/154/debian/postinstcontrib/osmo-hlr-post-upgrade.shdebian/osmo-hlr.installcontrib/systemd/osmo-hlr.servicecontrib/osmo-hlr-db-upgrade.shcontrib/Makefile.am2ef24d62ab9c1489eb87ac3aaeece084676e76b51784109296000https://jenkins.osmocom.org/jenkins/user/osmithOliver Smithosmith@sysmocom.desystemd: run db-upgrade script in ExecStartPre We have seen in CI jobs that calling the DB upgrade script from debian/postinst does not work reliably. When doing a fresh install of osmo-hlr, it usually works as expected: Setting up osmo-hlr (1.9.2) ... osmo-hlr-post-upgrade: nothing to do (no existing database) But sometimes: Setting up osmo-hlr (1.9.2) ... osmo-hlr-post-upgrade: database upgrade is required osmo-hlr-post-upgrade: stopping osmo-hlr service osmo-hlr-post-upgrade: creating backup: /var/lib/osmocom/hlr.db.20260706135658.bak osmo-hlr-post-upgrade: performing database upgrade <0001> db.c:600 using database: /var/lib/osmocom/hlr.db <0001> db.c:103 (283) recovered 4 frames from WAL file /var/lib/osmocom/hlr.db-wal <0001> db.c:679 Database '/var/lib/osmocom/hlr.db' has HLR DB schema version 0 <0001> db.c:103 (1) duplicate column name: last_lu_seen in "ALTER TABLE subscriber ADD COLUMN last_lu_seen TIMESTAMP default NULL" <0001> db.c:248 Unable to prepare SQL statement 'ALTER TABLE subscriber ADD COLUMN last_lu_seen TIMESTAMP default NULL' <0001> db.c:318 Unable to update HLR database schema to version 1 <0001> db.c:685 Failed to upgrade HLR DB schema to version 1: (rc=1) duplicate column name: last_lu_seen <0000> hlr_db_tool.c:509 Error opening database It seems that osmo-hlr can get started before the osmo-hlr-post-upgrade script runs, then starts to create the database with the current schema, and gets stopped before it is done, leading to the failure above. Rename the script to osmo-hlr-db-upgrade.sh, remove logic for stopping and starting the service and let systemd call it in ExecStartPre. That way we are sure that it runs *before* osmo-hlr starts up. Related: SYS#8125 Change-Id: If13f4c8b49397e6630956e92a7825843c7d55ebd 2026-07-15 11:54:56 +02002ef24d62ab9c1489eb87ac3aaeece084676e76b5systemd: run db-upgrade script in ExecStartPreeditdebian/osmo-hlr.installeditdebian/postinsteditcontrib/Makefile.amdeletecontrib/osmo-hlr-post-upgrade.sheditcontrib/systemd/osmo-hlr.serviceaddcontrib/osmo-hlr-db-upgrade.shgithttps://jenkins.osmocom.org/jenkins/user/osmithOliver Smith154https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-hlr-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/154/