BRANCH_CImasterosmo-ci.git branch
BRANCH_CIStringParameterDefinitionCOMMENT_TYPEset by gerrit verification pipeline jobCOMMENT_TYPEStringParameterDefinitionDISTROset by gerrit verification pipeline jobDISTROStringParameterDefinitionGERRIT_BRANCHset by gerrit verification pipeline jobGERRIT_BRANCHStringParameterDefinitionGERRIT_CHANGE_NUMBERset by gerrit verification pipeline jobGERRIT_CHANGE_NUMBERStringParameterDefinitionGERRIT_HOSTset by gerrit verification pipeline jobGERRIT_HOSTStringParameterDefinitionGERRIT_PATCHSET_NUMBERset by gerrit verification pipeline jobGERRIT_PATCHSET_NUMBERStringParameterDefinitionGERRIT_PATCHSET_REVISIONset by gerrit verification pipeline jobGERRIT_PATCHSET_REVISIONStringParameterDefinitionGERRIT_PATCHSET_UPLOADER_NAMEset by gerrit verification pipeline jobGERRIT_PATCHSET_UPLOADER_NAMEStringParameterDefinitionGERRIT_PORTset by gerrit verification pipeline jobGERRIT_PORTStringParameterDefinitionGERRIT_PROJECTset by gerrit verification pipeline jobGERRIT_PROJECTStringParameterDefinitionGERRIT_REFSPECset by gerrit verification pipeline jobGERRIT_REFSPECStringParameterDefinitionGERRIT_REPO_URLset by gerrit verification pipeline jobGERRIT_REPO_URLStringParameterDefinitionPIPELINE_BUILD_URLset by gerrit verification pipeline jobPIPELINE_BUILD_URLStringParameterDefinitionPROJECT_NAMEset by gerrit verification pipeline jobPROJECT_NAMEStringParameterDefinitionhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/Build job of CI for patches sent to
<a href="https://gerrit.osmocom.org/#/q/status:open+project:osmo-pcap">osmo-pcap</a>
<br/><br/>
<b>Auto-generated using Jenkins Job Builder. DO NOT EDIT MANUALLY!</b>
<!-- Managed by Jenkins Job Builder -->gerrit-osmo-pcap-buildgerrit-osmo-pcap-buildgerrit-osmo-pcap-buildgerrit-osmo-pcap-buildhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/trueStarted by upstream project "gerrit-osmo-pcap" build number 230230gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42838GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION11e5865c22343c9c83a8d0ae464f8b48b11ba1abGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/38/42838/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/230/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002534562534561.007632763224111e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#241253456224824gerrit-osmo-pcap-build #241241falsefalse241145270SUCCESS1781704316907https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/241/- src/osmo_server_network.c11e5865c22343c9c83a8d0ae464f8b48b11ba1ab1781688082000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix misleading data length validation log message
The format string "%u < %u <= %u" was printed with arguments
(min_len, data->len, max_len), placing the offending length in
the middle and mislabeling it. This is confusing. Let's print
the actual length followed by the expected interval instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e
2026-06-17 16:21:22 +070011e5865c22343c9c83a8d0ae464f8b48b11ba1abserver: fix misleading data length validation log messageeditsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/Started by upstream project "gerrit-osmo-pcap" build number 234234gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42841GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION78907797ee46cf1b7a9553a98738e4996e0e9e5aGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/41/42841/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/234/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002099052099051.007846784624078907797ee46cf1b7a9553a98738e4996e0e9e5a78907797ee46cf1b7a9553a98738e4996e0e9e5amaster78907797ee46cf1b7a9553a98738e4996e0e9e5a78907797ee46cf1b7a9553a98738e4996e0e9e5amaster78907797ee46cf1b7a9553a98738e4996e0e9e5a78907797ee46cf1b7a9553a98738e4996e0e9e5amasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#240209905224824gerrit-osmo-pcap-build #240240falsefalse240145269SUCCESS1781704316723https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/240/- src/osmo_server_network.c78907797ee46cf1b7a9553a98738e4996e0e9e5a1781688295000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: do not abort process on short conn message
conn_read_cb() used OSMO_ASSERT() to check that the received
message holds at least a full osmo_pcap_data header. Although
conn_segmentation_cb2() should only ever hand up complete frames,
asserting on a length derived from network input means a framing
anomaly would abort the entire server (taking down all other clients'
captures). Close the offending connection gracefully instead,
consistent with the other error paths in this function.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ia102ff918ef8152d212e10a860f5dc70efec880b
2026-06-17 16:24:55 +070078907797ee46cf1b7a9553a98738e4996e0e9e5aserver: do not abort process on short conn messageeditsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy240https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/240/Started by upstream project "gerrit-osmo-pcap" build number 233233gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42844GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION3657ed527f59a09c4cbc79ce908c6cfc275121e1GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/44/42844/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/233/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002111122111121.00790979092393657ed527f59a09c4cbc79ce908c6cfc275121e13657ed527f59a09c4cbc79ce908c6cfc275121e1master3657ed527f59a09c4cbc79ce908c6cfc275121e13657ed527f59a09c4cbc79ce908c6cfc275121e1master3657ed527f59a09c4cbc79ce908c6cfc275121e13657ed527f59a09c4cbc79ce908c6cfc275121e1masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#239211112224824gerrit-osmo-pcap-build #239239falsefalse239145268SUCCESS1781704316581https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/239/- src/osmo_server_network.c3657ed527f59a09c4cbc79ce908c6cfc275121e11781689072000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix msgb leak on duplicate link header
rx_link_hdr() takes ownership of msg on success (rx_link() only frees
it on failure). Both branches that call update_conn_file_hdr_msg()
free msg, but when an identical link header was already stored neither
branch ran and msg was leaked.
This happens on every duplicate PKT_LINK_HDR, e.g. a client that
periodically resends its header. Free msg explicitly in that case.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I79344fe942342f2a736878142b3cf036fc982eef
2026-06-17 16:37:52 +07003657ed527f59a09c4cbc79ce908c6cfc275121e1server: fix msgb leak on duplicate link headereditsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy239https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/239/Started by upstream project "gerrit-osmo-pcap" build number 239239gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42849GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION85952f14fc87f877fefcea9d7cc72461a5cc4cfeGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/49/42849/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/239/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002279262279261.008216821623885952f14fc87f877fefcea9d7cc72461a5cc4cfe85952f14fc87f877fefcea9d7cc72461a5cc4cfemaster85952f14fc87f877fefcea9d7cc72461a5cc4cfe85952f14fc87f877fefcea9d7cc72461a5cc4cfemaster85952f14fc87f877fefcea9d7cc72461a5cc4cfe85952f14fc87f877fefcea9d7cc72461a5cc4cfemasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#238227926224824gerrit-osmo-pcap-build #238238falsefalse238145267SUCCESS1781704316382https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/238/- include/osmo-pcap/osmo_tls.hsrc/osmo_tls.c85952f14fc87f877fefcea9d7cc72461a5cc4cfe1781689940000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.detls: fix broken certificate hostname verification
verify_cert_cb() retrieved the gnutls session pointer and passed it to
gnutls_certificate_verify_peers3() as the expected hostname. But the
session pointer is set to the osmo_tls_session struct (it is needed by
cert_callback()), not a hostname string. Hostname matching was
therefore performed against raw struct bytes, rendering verification
meaningless and potentially reading out of bounds, even when
"tls verify-cert" was enabled.
Store the configured hostname in struct osmo_tls_session and have
verify_cert_cb() read it from there. Also drop the stray
gnutls_certificate_verify_peers3() call in the client setup: it ran
before any handshake (so there were no peer certificates yet) and its
result was ignored; the real verification happens via the registered
callback during the handshake.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: If64950a698bfcfbf556a37ef1be3e68abc124384
2026-06-17 16:52:20 +070085952f14fc87f877fefcea9d7cc72461a5cc4cfetls: fix broken certificate hostname verificationeditinclude/osmo-pcap/osmo_tls.heditsrc/osmo_tls.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy238https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/238/Started by upstream project "gerrit-osmo-pcap" build number 240240gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42846GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION29624844d004528f2348c1f7c7361c31c1d4d966GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/46/42846/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/240/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002729432729431.008332833223729624844d004528f2348c1f7c7361c31c1d4d96629624844d004528f2348c1f7c7361c31c1d4d966master29624844d004528f2348c1f7c7361c31c1d4d96629624844d004528f2348c1f7c7361c31c1d4d966master29624844d004528f2348c1f7c7361c31c1d4d96629624844d004528f2348c1f7c7361c31c1d4d966masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#237272943224824gerrit-osmo-pcap-build #237237falsefalse237145266SUCCESS1781704316176https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/237/- src/osmo_tls.c29624844d004528f2348c1f7c7361c31c1d4d9661781689456000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.detls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on read
osmo_tls_client_bfd_cb() treated any non-positive return from
gnutls_record_recv() as a fatal error and tore down the session. On a
non-blocking socket gnutls_record_recv() can return GNUTLS_E_AGAIN or
GNUTLS_E_INTERRUPTED (both negative but non-fatal), which would drop
an otherwise healthy TLS session. Handle them as retryable, mirroring
the existing logic in tls_write().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: If2f842b202dd08c07dffe3770c51cf0ce886beee
2026-06-17 16:44:16 +070029624844d004528f2348c1f7c7361c31c1d4d966tls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on readeditsrc/osmo_tls.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy237https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/237/Started by upstream project "gerrit-osmo-pcap" build number 232232gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42839GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION9221dbcc85c929d8fef1f929a4a9629fece4df82GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/39/42839/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/232/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002119282119281.00848684862369221dbcc85c929d8fef1f929a4a9629fece4df829221dbcc85c929d8fef1f929a4a9629fece4df82master9221dbcc85c929d8fef1f929a4a9629fece4df829221dbcc85c929d8fef1f929a4a9629fece4df82master9221dbcc85c929d8fef1f929a4a9629fece4df829221dbcc85c929d8fef1f929a4a9629fece4df82masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#236211928224824gerrit-osmo-pcap-build #236236falsefalse236145265SUCCESS1781704315928https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/236/- src/osmo_client_core.c9221dbcc85c929d8fef1f929a4a9629fece4df821781688089000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.declient: fix off-by-one in wrapped pcap stats counter
When a libpcap stats counter (ps_recv/ps_drop/ps_ifdrop) wraps around
UINT_MAX, get_psbl_wrapped_ctr() computed the delta as
(UINT_MAX - old_val) + new_val, omitting the single increment that
takes the counter from UINT_MAX through zero. Add the missing +1 so
the reported delta matches the real number of increments.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I66581910dbd1e955831a6ff913042059ad4994a7
2026-06-17 16:21:29 +07009221dbcc85c929d8fef1f929a4a9629fece4df82client: fix off-by-one in wrapped pcap stats countereditsrc/osmo_client_core.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy236https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/236/Started by upstream project "gerrit-osmo-pcap" build number 237237gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42845GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION307adc76c26c61e94d0b8fcec2184654d568f0d9GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/45/42845/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/237/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002547752547751.0084878487235307adc76c26c61e94d0b8fcec2184654d568f0d9307adc76c26c61e94d0b8fcec2184654d568f0d9master307adc76c26c61e94d0b8fcec2184654d568f0d9307adc76c26c61e94d0b8fcec2184654d568f0d9master307adc76c26c61e94d0b8fcec2184654d568f0d9307adc76c26c61e94d0b8fcec2184654d568f0d9masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#235254775224824gerrit-osmo-pcap-build #235235falsefalse235145264SUCCESS1781704315711https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/235/- src/osmo_client_core.c307adc76c26c61e94d0b8fcec2184654d568f0d91781689292000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.declient: honor IPv4 header length in GPRS filter
The GPRS-NS/BSSGP filter assumed a fixed 20-byte IPv4 header (IP_LEN)
when locating the UDP header and payload. When the captured packet
carries IPv4 options (ip_hl > 5), udp_data/payload_data pointed into
the middle of the headers and check_gprs() parsed garbage, classifying
packets incorrectly.
Use the actual header length from ip_hl, reject malformed headers
(ip_hl < 5), and re-validate that the larger headers fit within the
captured length before computing the payload.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Iac1fa9cc2a3c06cbe19c3e7799a0b335f2e3dda9
2026-06-17 16:41:32 +0700307adc76c26c61e94d0b8fcec2184654d568f0d9client: honor IPv4 header length in GPRS filtereditsrc/osmo_client_core.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy235https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/235/Started by upstream project "gerrit-osmo-pcap" build number 241241gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42848GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONfb0c81c6bd12139331aa054a671ec4418acfaa09GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/48/42848/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/241/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002320792320791.0087298729234fb0c81c6bd12139331aa054a671ec4418acfaa09fb0c81c6bd12139331aa054a671ec4418acfaa09masterfb0c81c6bd12139331aa054a671ec4418acfaa09fb0c81c6bd12139331aa054a671ec4418acfaa09masterfb0c81c6bd12139331aa054a671ec4418acfaa09fb0c81c6bd12139331aa054a671ec4418acfaa09masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#234232079224824gerrit-osmo-pcap-build #234234falsefalse234145263SUCCESS1781704315355https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/234/- src/osmo_server_network.cfb0c81c6bd12139331aa054a671ec4418acfaa091781689712000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix NULL deref of file_hdr_msg when store is disabled
When a connection has storing disabled (no store), conn->file_hdr_msg
is never populated. The previous link-header handling skipped the
first branch (gated on conn->store) and fell through to the comparison
branch, which dereferenced the still-NULL conn->file_hdr_msg, crashing
the server on the first PKT_LINK_HDR from such a client.
Gate the whole header tracking on conn->store and simply free the
message when not storing, since osmo_pcap_conn_restart_trace() already
no-ops in that case.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I419e1b66d07307c3e49294984887c153cd8494c3
2026-06-17 16:48:32 +0700fb0c81c6bd12139331aa054a671ec4418acfaa09server: fix NULL deref of file_hdr_msg when store is disablededitsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy234https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/234/Started by upstream project "gerrit-osmo-pcap" build number 231231gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42843GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION933c163067c099a0fad5f9eb7147af5aed738cc1GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/43/42843/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/231/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002744992744991.0087298729233933c163067c099a0fad5f9eb7147af5aed738cc1933c163067c099a0fad5f9eb7147af5aed738cc1master933c163067c099a0fad5f9eb7147af5aed738cc1933c163067c099a0fad5f9eb7147af5aed738cc1master933c163067c099a0fad5f9eb7147af5aed738cc1933c163067c099a0fad5f9eb7147af5aed738cc1masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#233274499224824gerrit-osmo-pcap-build #233233falsefalse233145262SUCCESS1781704315067https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/233/- src/osmo_server_core.c933c163067c099a0fad5f9eb7147af5aed738cc11781688643000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix zmq message leak on send failure
zmq_msg_send() only transfers ownership of the message to ZeroMQ on
success. On failure the caller retains ownership, so the previously
init'd zmq_msg_t was leaked on every failed publish. Close it
explicitly on the error path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I501b1bf55bede4e69fa5d9b3f38d87341482ff49
2026-06-17 16:30:43 +0700933c163067c099a0fad5f9eb7147af5aed738cc1server: fix zmq message leak on send failureeditsrc/osmo_server_core.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy233https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/233/Started by upstream project "gerrit-osmo-pcap" build number 235235gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42842GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONf1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/42/42842/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/235/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002559052559051.0087298729232f1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3f1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3masterf1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3f1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3masterf1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3f1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#232255905224824gerrit-osmo-pcap-build #232232falsefalse232145261SUCCESS1781704314765https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/232/- src/osmo_client_network.cf1138f0aebae9aaf7a0d2a63cdeb81bb37c97de31781688456000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.declient: Fix 32-bit overflow when computing pcapng EPB timestamp
tv_sec * 1000 * 1000 was evaluated in int arithmetic. Where time_t /
tv_sec is 32-bit, this overflows for any tv_sec > ~2147, corrupting
the 64-bit timestamp_usec well before the year 2038. Cast tv_sec to
uint64_t before the multiplication so the whole expression
is computed in 64 bits.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I20d3282b8cba1675ce2d0860e66027e5ee8245ef
2026-06-17 16:27:36 +0700f1138f0aebae9aaf7a0d2a63cdeb81bb37c97de3client: Fix 32-bit overflow when computing pcapng EPB timestampeditsrc/osmo_client_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy232https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/232/Started by upstream project "gerrit-osmo-pcap" build number 236236gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42840GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION8aa69c597c2804ac167fbf671e81c1f8b5888277GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/40/42840/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/236/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002360882360881.00872987292318aa69c597c2804ac167fbf671e81c1f8b58882778aa69c597c2804ac167fbf671e81c1f8b5888277master8aa69c597c2804ac167fbf671e81c1f8b58882778aa69c597c2804ac167fbf671e81c1f8b5888277master8aa69c597c2804ac167fbf671e81c1f8b58882778aa69c597c2804ac167fbf671e81c1f8b5888277masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#231236088224824gerrit-osmo-pcap-build #231231falsefalse231145260SUCCESS1781704314504https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/231/- src/osmo_client_vty.c8aa69c597c2804ac167fbf671e81c1f8b58882771781688099000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.declient: vty: do not print NULL tls hostname
conn->tls_hostname defaults to NULL and can be cleared via "no tls
hostname". Writing it unconditionally emitted a "tls hostname (null)"
line, producing a config that does not re-parse. Guard it like the
other optional tls fields.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I5b920337409d8c9fa1edb8d47177882cf0a6c4e7
2026-06-17 16:21:39 +07008aa69c597c2804ac167fbf671e81c1f8b5888277client: vty: do not print NULL tls hostnameeditsrc/osmo_client_vty.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy231https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/231/Started by upstream project "gerrit-osmo-pcap" build number 238238gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42847GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION7c71ec5fc5faf50a370a604f65996fcc6e41a975GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/47/42847/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/238/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002090792090791.00872887282307c71ec5fc5faf50a370a604f65996fcc6e41a9757c71ec5fc5faf50a370a604f65996fcc6e41a975master7c71ec5fc5faf50a370a604f65996fcc6e41a9757c71ec5fc5faf50a370a604f65996fcc6e41a975master7c71ec5fc5faf50a370a604f65996fcc6e41a9757c71ec5fc5faf50a370a604f65996fcc6e41a975masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#230209079224824gerrit-osmo-pcap-build #230230falsefalse230145259SUCCESS1781704314010https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/230/- src/osmo_server_vty.c7c71ec5fc5faf50a370a604f65996fcc6e41a9751781689590000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: vty: validate rotate-localtime modulus against the new interval
apply_rotate_localtime() computed the maximum allowed modulus from
pcap_server->rotate_localtime.intv, the currently-stored (old) interval,
rather than the intv argument being applied. On first configuration the
stored interval is the default 0, so the switch hit the default case and
rejected an otherwise valid command; when changing intervals the modulus
was bounds-checked against the wrong interval. Switch on intv instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I0b367d4e255db3208b41e12adec682026b99cc18
2026-06-17 16:46:30 +07007c71ec5fc5faf50a370a604f65996fcc6e41a975server: vty: validate rotate-localtime modulus against the new intervaleditsrc/osmo_server_vty.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy230https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/230/Started by upstream project "gerrit-osmo-pcap" build number 229229gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42837GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION5c1673a0630fa985b24166a238697f8a6ea27f0fGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/37/42837/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/229/PROJECT_NAMEosmo-pcapBRANCH_CImaster000073742737421.00654965492295c1673a0630fa985b24166a238697f8a6ea27f0f5c1673a0630fa985b24166a238697f8a6ea27f0fmaster5c1673a0630fa985b24166a238697f8a6ea27f0f5c1673a0630fa985b24166a238697f8a6ea27f0fmaster5c1673a0630fa985b24166a238697f8a6ea27f0f5c1673a0630fa985b24166a238697f8a6ea27f0fmasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#22973742224824gerrit-osmo-pcap-build #229229falsefalse229145185SUCCESS1781704223985https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/229/- src/osmo_server_vty.c5c1673a0630fa985b24166a238697f8a6ea27f0f1781702637000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: vty: fix docs for cfg_server_rotate_localtime[_mod_n]
Change-Id: I6fd1d081bba035fbd9d72a1705ab58194edf274e
Fixes: 18747641 ("pcap-server: Make rotate-localtime feature configurable through VTY")
2026-06-17 20:23:57 +07005c1673a0630fa985b24166a238697f8a6ea27f0fserver: vty: fix docs for cfg_server_rotate_localtime[_mod_n]editsrc/osmo_server_vty.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy229https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/229/Started by upstream project "gerrit-osmo-pcap" build number 228228gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42835GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONd95ef64b9b1ae6d185015efdf202f207703fb322GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/35/42835/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/228/PROJECT_NAMEosmo-pcapBRANCH_CImaster000070585705851.0066926692228d95ef64b9b1ae6d185015efdf202f207703fb322d95ef64b9b1ae6d185015efdf202f207703fb322masterd95ef64b9b1ae6d185015efdf202f207703fb322d95ef64b9b1ae6d185015efdf202f207703fb322masterd95ef64b9b1ae6d185015efdf202f207703fb322d95ef64b9b1ae6d185015efdf202f207703fb322masterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#22870585224824gerrit-osmo-pcap-build #228228falsefalse228145113SUCCESS1781701040591https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/228/- doc/manuals/chapters/server.adocdoc/manuals/chapters/client.adocd95ef64b9b1ae6d185015efdf202f207703fb3221781700738000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.dedoc: clarify 'pcap snaplen' / 'max-snaplen'
Change-Id: Ic2c82173c12814d61f0ee9f7454b9e5dcb0c13f4
Related: SYS#8099
2026-06-17 19:52:18 +0700d95ef64b9b1ae6d185015efdf202f207703fb322doc: clarify 'pcap snaplen' / 'max-snaplen'editdoc/manuals/chapters/client.adoceditdoc/manuals/chapters/server.adoc
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy228https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/228/Started by upstream project "gerrit-osmo-pcap" build number 227227gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42836GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/36/42836/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/227/PROJECT_NAMEosmo-pcapBRANCH_CImaster000069573695731.0050005000227ca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eca289302ea9b3b7cfa4c3f9a0f953f67d2c2389emasterca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eca289302ea9b3b7cfa4c3f9a0f953f67d2c2389emasterca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eca289302ea9b3b7cfa4c3f9a0f953f67d2c2389emasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#22769573224824gerrit-osmo-pcap-build #227227falsefalse227145112SUCCESS1781701038799https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/227/- doc/manuals/chapters/server.adocsrc/osmo_client_vty.cinclude/osmo-pcap/common.hsrc/osmo_server_vty.cdoc/manuals/chapters/client.adocca289302ea9b3b7cfa4c3f9a0f953f67d2c2389e1781700757000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.devty: clamp configured snaplen to the wire-framing limit
osmo-pcap carries each captured packet in a frame whose length field
(struct osmo_pcap_data.len) is a uint16_t, so any snaplen above ~64 KiB
cannot be transported and is silently clamped by the server when sizing
its receive buffer (calc_data_max_len() caps at UINT16_MAX). The VTY,
however, advertised libpcap's MAXIMUM_SNAPLEN (262144), misleading users
into configuring values that never take effect.
Introduce OSMO_PCAP_MAX_SNAPLEN (65535) and, in both the client "pcap
snaplen" and server "max-snaplen" handlers, warn and cap the value to it
when a larger one is given. The command syntax keeps the <1-262144>
range for backwards compatibility so existing configs still parse; the
help text now documents the effective 64 KiB limit.
Related: SYS#8099
Related: 6d2f7c52 ("server: Limit rx buffer size to UINT16_MAX")
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ia56cad48e8cefe8ae103f2f7d2e037bf28438b71
2026-06-17 19:52:37 +0700ca289302ea9b3b7cfa4c3f9a0f953f67d2c2389evty: clamp configured snaplen to the wire-framing limiteditdoc/manuals/chapters/client.adoceditsrc/osmo_server_vty.ceditinclude/osmo-pcap/common.heditsrc/osmo_client_vty.ceditdoc/manuals/chapters/server.adoc
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy227https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/227/blueStarted by upstream project "gerrit-osmo-pcap" build number 227227gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42836GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/36/42836/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/227/PROJECT_NAMEosmo-pcapBRANCH_CImaster000069573695731.0050005000227ca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eca289302ea9b3b7cfa4c3f9a0f953f67d2c2389emasterca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eca289302ea9b3b7cfa4c3f9a0f953f67d2c2389emasterca289302ea9b3b7cfa4c3f9a0f953f67d2c2389eca289302ea9b3b7cfa4c3f9a0f953f67d2c2389emasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#22769573224824gerrit-osmo-pcap-build #227227falsefalse227145112SUCCESS1781701038799https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/227/- doc/manuals/chapters/server.adocsrc/osmo_client_vty.cinclude/osmo-pcap/common.hsrc/osmo_server_vty.cdoc/manuals/chapters/client.adocca289302ea9b3b7cfa4c3f9a0f953f67d2c2389e1781700757000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.devty: clamp configured snaplen to the wire-framing limit
osmo-pcap carries each captured packet in a frame whose length field
(struct osmo_pcap_data.len) is a uint16_t, so any snaplen above ~64 KiB
cannot be transported and is silently clamped by the server when sizing
its receive buffer (calc_data_max_len() caps at UINT16_MAX). The VTY,
however, advertised libpcap's MAXIMUM_SNAPLEN (262144), misleading users
into configuring values that never take effect.
Introduce OSMO_PCAP_MAX_SNAPLEN (65535) and, in both the client "pcap
snaplen" and server "max-snaplen" handlers, warn and cap the value to it
when a larger one is given. The command syntax keeps the <1-262144>
range for backwards compatibility so existing configs still parse; the
help text now documents the effective 64 KiB limit.
Related: SYS#8099
Related: 6d2f7c52 ("server: Limit rx buffer size to UINT16_MAX")
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ia56cad48e8cefe8ae103f2f7d2e037bf28438b71
2026-06-17 19:52:37 +0700ca289302ea9b3b7cfa4c3f9a0f953f67d2c2389evty: clamp configured snaplen to the wire-framing limiteditdoc/manuals/chapters/client.adoceditsrc/osmo_server_vty.ceditinclude/osmo-pcap/common.heditsrc/osmo_client_vty.ceditdoc/manuals/chapters/server.adoc
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy227https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/227/Build stability: No recent builds failed.icon-health-80plushealth-80plus.png100falsefalseStarted by upstream project "gerrit-osmo-pcap" build number 230230gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42838GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION11e5865c22343c9c83a8d0ae464f8b48b11ba1abGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/38/42838/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/230/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002534562534561.007632763224111e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#241253456224824gerrit-osmo-pcap-build #241241falsefalse241145270SUCCESS1781704316907https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/241/- src/osmo_server_network.c11e5865c22343c9c83a8d0ae464f8b48b11ba1ab1781688082000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix misleading data length validation log message
The format string "%u < %u <= %u" was printed with arguments
(min_len, data->len, max_len), placing the offending length in
the middle and mislabeling it. This is confusing. Let's print
the actual length followed by the expected interval instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e
2026-06-17 16:21:22 +070011e5865c22343c9c83a8d0ae464f8b48b11ba1abserver: fix misleading data length validation log messageeditsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/Started by upstream project "gerrit-osmo-pcap" build number 230230gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42838GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION11e5865c22343c9c83a8d0ae464f8b48b11ba1abGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/38/42838/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/230/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002534562534561.007632763224111e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#241253456224824gerrit-osmo-pcap-build #241241falsefalse241145270SUCCESS1781704316907https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/241/- src/osmo_server_network.c11e5865c22343c9c83a8d0ae464f8b48b11ba1ab1781688082000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix misleading data length validation log message
The format string "%u < %u <= %u" was printed with arguments
(min_len, data->len, max_len), placing the offending length in
the middle and mislabeling it. This is confusing. Let's print
the actual length followed by the expected interval instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e
2026-06-17 16:21:22 +070011e5865c22343c9c83a8d0ae464f8b48b11ba1abserver: fix misleading data length validation log messageeditsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/Started by upstream project "gerrit-osmo-pcap" build number 230230gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42838GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION11e5865c22343c9c83a8d0ae464f8b48b11ba1abGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/38/42838/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/230/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002534562534561.007632763224111e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#241253456224824gerrit-osmo-pcap-build #241241falsefalse241145270SUCCESS1781704316907https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/241/- src/osmo_server_network.c11e5865c22343c9c83a8d0ae464f8b48b11ba1ab1781688082000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix misleading data length validation log message
The format string "%u < %u <= %u" was printed with arguments
(min_len, data->len, max_len), placing the offending length in
the middle and mislabeling it. This is confusing. Let's print
the actual length followed by the expected interval instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e
2026-06-17 16:21:22 +070011e5865c22343c9c83a8d0ae464f8b48b11ba1abserver: fix misleading data length validation log messageeditsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/Started by upstream project "gerrit-osmo-pcap" build number 230230gerrit-osmo-pcapjob/gerrit-osmo-pcap/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42838GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION11e5865c22343c9c83a8d0ae464f8b48b11ba1abGERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-pcapGERRIT_REFSPECrefs/changes/38/42838/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap/230/PROJECT_NAMEosmo-pcapBRANCH_CImaster00002534562534561.007632763224111e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmaster11e5865c22343c9c83a8d0ae464f8b48b11ba1ab11e5865c22343c9c83a8d0ae464f8b48b11ba1abmasterssh://jenkins@gerrit.osmocom.org:29418/osmo-pcapfalse#241253456224824gerrit-osmo-pcap-build #241241falsefalse241145270SUCCESS1781704316907https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/241/- src/osmo_server_network.c11e5865c22343c9c83a8d0ae464f8b48b11ba1ab1781688082000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix misleading data length validation log message
The format string "%u < %u <= %u" was printed with arguments
(min_len, data->len, max_len), placing the offending length in
the middle and mislabeling it. This is confusing. Let's print
the actual length followed by the expected interval instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e
2026-06-17 16:21:22 +070011e5865c22343c9c83a8d0ae464f8b48b11ba1abserver: fix misleading data length validation log messageeditsrc/osmo_server_network.c
githttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/242BRANCH_CImasterosmo-ci.git branch
BRANCH_CIStringParameterDefinitionCOMMENT_TYPEset by gerrit verification pipeline jobCOMMENT_TYPEStringParameterDefinitionDISTROset by gerrit verification pipeline jobDISTROStringParameterDefinitionGERRIT_BRANCHset by gerrit verification pipeline jobGERRIT_BRANCHStringParameterDefinitionGERRIT_CHANGE_NUMBERset by gerrit verification pipeline jobGERRIT_CHANGE_NUMBERStringParameterDefinitionGERRIT_HOSTset by gerrit verification pipeline jobGERRIT_HOSTStringParameterDefinitionGERRIT_PATCHSET_NUMBERset by gerrit verification pipeline jobGERRIT_PATCHSET_NUMBERStringParameterDefinitionGERRIT_PATCHSET_REVISIONset by gerrit verification pipeline jobGERRIT_PATCHSET_REVISIONStringParameterDefinitionGERRIT_PATCHSET_UPLOADER_NAMEset by gerrit verification pipeline jobGERRIT_PATCHSET_UPLOADER_NAMEStringParameterDefinitionGERRIT_PORTset by gerrit verification pipeline jobGERRIT_PORTStringParameterDefinitionGERRIT_PROJECTset by gerrit verification pipeline jobGERRIT_PROJECTStringParameterDefinitionGERRIT_REFSPECset by gerrit verification pipeline jobGERRIT_REFSPECStringParameterDefinitionGERRIT_REPO_URLset by gerrit verification pipeline jobGERRIT_REPO_URLStringParameterDefinitionPIPELINE_BUILD_URLset by gerrit verification pipeline jobPIPELINE_BUILD_URLStringParameterDefinitionPROJECT_NAMEset by gerrit verification pipeline jobPROJECT_NAMEStringParameterDefinitiontruefalsehudson.plugins.git.GitSCM--ffdefaulta1=default,a2=default,a3=default,a4=default,osmocom-gerritgerrit-osmo-pcap-build ยป a1=default,a2=default,a3=default,a4=default,osmocom-gerritgerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrita1=default,a2=default,a3=default,a4=default,label=osmocom-gerrithttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/true241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/240https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/240/239https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/239/238https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/238/237https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/237/236https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/236/235https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/235/234https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/234/233https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/233/232https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/232/231https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/231/230https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/230/229https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/229/228https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/228/227https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/227/blue227https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/227/Build stability: No recent builds failed.icon-health-80plushealth-80plus.png100falsefalse241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/241https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcap-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/241/242truefalse