Started by upstream project "gerrit-simtrace2" build number 122122gerrit-simtrace2job/gerrit-simtrace2/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER43126GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONb3856f9968c162007d32ed677645dc67ce8bde6bGERRIT_PATCHSET_UPLOADER_NAMEHoernchenGERRIT_PORT29418GERRIT_PROJECTsimtrace2GERRIT_REFSPECrefs/changes/26/43126/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/simtrace2PIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2/122/PROJECT_NAMEsimtrace2BRANCH_CImaster00003004943004941.0058255825555b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.25b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.2122b3856f9968c162007d32ed677645dc67ce8bde6bb3856f9968c162007d32ed677645dc67ce8bde6bmasterb3856f9968c162007d32ed677645dc67ce8bde6bb3856f9968c162007d32ed677645dc67ce8bde6bmasterb3856f9968c162007d32ed677645dc67ce8bde6bb3856f9968c162007d32ed677645dc67ce8bde6bmasterssh://jenkins@gerrit.osmocom.org:29418/simtrace2false#122300494327764gerrit-simtrace2-build #122122falsefalse122181020SUCCESS1785265451389https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/122/firmware/test/card_emu_tests.cfirmware/libcommon/source/card_emu.cb3856f9968c162007d32ed677645dc67ce8bde6b1785257901000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defirmware: card_emu: use Di in the waiting time ISO 7816-3 section 10.2 defines WT = WI x 960 x Fi/f seconds, store as etu, etu = Fi / (D x f) seconds, so the Fi cancels, but the D does not: WT [etu] = WI x 960 x D cemu dropped both (?!) -> WI x 960. The old comment explains why Fi can be dropped, which is right, but what about Di ?! sniffer gets it right (wt_wi * 960UL * wt_d), so the two state machines disagreed here again, by up to a factor of 64???!!?!!? This was fixed in osmo-ccid-firmware in 066489d in 2020 but not ported to st2. Additionally the waiting time was only recalculated at the end of the ATR, where D is still 1 by definition, so a PPS increasing D reprogrammed the baud rate but left the waiting time untouched??! etu duration shrinks with D by the same factor, wall clock WT is independent of D, which is the whole point. The old code decreased the waiting time by a factor of D: after a PPS to D=8 the card emitted its NULL procedure byte at ~0.09s instead of ~0.71s with a reader deadline of ~1.43s, and the inactivity timeout fires 8x too early, which probably led to unexplained wtime_exp errors. Update wt when WI becomes known (end of ATR) and where D changes (after the PPS response) + tests. Change-Id: I4263176d6073029d01f9ff5b11a6311617956af6 2026-07-28 18:58:21 +0200b3856f9968c162007d32ed677645dc67ce8bde6bfirmware: card_emu: use Di in the waiting timeeditfirmware/test/card_emu_tests.ceditfirmware/libcommon/source/card_emu.cgithttps://jenkins.osmocom.org/jenkins/user/ewildewild122https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/122/