Started by upstream project "gerrit-simtrace2" build number 123123gerrit-simtrace2job/gerrit-simtrace2/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER43125GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONaa09a6b5beadfcb133cefc3ac4feb936d9bda675GERRIT_PATCHSET_UPLOADER_NAMEHoernchenGERRIT_PORT29418GERRIT_PROJECTsimtrace2GERRIT_REFSPECrefs/changes/25/43125/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/simtrace2PIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2/123/PROJECT_NAMEsimtrace2BRANCH_CImaster00003011423011421.064636463030760553715371555b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.25b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.2126aa09a6b5beadfcb133cefc3ac4feb936d9bda675aa09a6b5beadfcb133cefc3ac4feb936d9bda675masteraa09a6b5beadfcb133cefc3ac4feb936d9bda675aa09a6b5beadfcb133cefc3ac4feb936d9bda675masteraa09a6b5beadfcb133cefc3ac4feb936d9bda675aa09a6b5beadfcb133cefc3ac4feb936d9bda675masterssh://jenkins@gerrit.osmocom.org:29418/simtrace2https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/126/artifacthttps://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/changeshttps://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/126/https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/126/testReportfalse#126301142327764gerrit-simtrace2-build #126126falsefalse126181024SUCCESS1785265452042https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/126/- firmware/libcommon/source/simtrace_iso7816.cfirmware/libcommon/source/mode_cardemu.cfirmware/libcommon/source/card_emu.caa09a6b5beadfcb133cefc3ac4feb936d9bda6751785256234000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defirmware: use the full 11 bit US_FIDI.FI_DI_RATIO
US_FIDI_FI_DI_RATIO_Msk is 0x7ff,
cemu rejected >= 0x400 in emu_update_fidi() and masked with 0x3ff
in card_emu_uart_update_fidi(), but update_fidi() used by
the sniffer already used 0x7ff.
-> ratios 1024..2047 are unusable in cemu, which is the entire upper
half of ISO 7816-3 Table 7 at Di=1.
A reader trying one of those in a PPS gets the proposal echoed and
accepted, after which the card keeps transmitting at the old rate.
FI_DI_RATIO is clock periods per bit -> larger ratio is a SLOWER link.
The old check rejected slow values but accepted Fi=372/Di=64, ratio 5 !?
Unify and use the register mask (= shifed by 0 so usable as value) and
reject ratios that do not fit rather than truncating to garbage dividers.
Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d
2026-07-28 18:30:34 +0200aa09a6b5beadfcb133cefc3ac4feb936d9bda675firmware: use the full 11 bit US_FIDI.FI_DI_RATIOeditfirmware/libcommon/source/mode_cardemu.ceditfirmware/libcommon/source/card_emu.ceditfirmware/libcommon/source/simtrace_iso7816.c
githttps://jenkins.osmocom.org/jenkins/user/ewildewildewildCOMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER43125GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISIONaa09a6b5beadfcb133cefc3ac4feb936d9bda675GERRIT_PATCHSET_UPLOADER_NAMEHoernchenGERRIT_PORT29418GERRIT_PROJECTsimtrace2GERRIT_REFSPECrefs/changes/25/43125/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/simtrace2PIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2/123/PROJECT_NAMEsimtrace2BRANCH_CImasterStarted by upstream project "gerrit-simtrace2-build" build number 126126gerrit-simtrace2-buildjob/gerrit-simtrace2-build/0021614221614277666776661.0000555b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.25b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.2126aa09a6b5beadfcb133cefc3ac4feb936d9bda675aa09a6b5beadfcb133cefc3ac4feb936d9bda675masteraa09a6b5beadfcb133cefc3ac4feb936d9bda675aa09a6b5beadfcb133cefc3ac4feb936d9bda675masteraa09a6b5beadfcb133cefc3ac4feb936d9bda675aa09a6b5beadfcb133cefc3ac4feb936d9bda675masterssh://jenkins@gerrit.osmocom.org:29418/simtrace2false#1267766691034gerrit-simtrace2-build ยป a1=default,a2=default,a3=default,a4=default,osmocom-gerrit #126126falsefalse126181031SUCCESS1785265452042https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit/126/build5-deb12build-ansible- firmware/libcommon/source/simtrace_iso7816.cfirmware/libcommon/source/mode_cardemu.cfirmware/libcommon/source/card_emu.caa09a6b5beadfcb133cefc3ac4feb936d9bda6751785256234000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defirmware: use the full 11 bit US_FIDI.FI_DI_RATIO
US_FIDI_FI_DI_RATIO_Msk is 0x7ff,
cemu rejected >= 0x400 in emu_update_fidi() and masked with 0x3ff
in card_emu_uart_update_fidi(), but update_fidi() used by
the sniffer already used 0x7ff.
-> ratios 1024..2047 are unusable in cemu, which is the entire upper
half of ISO 7816-3 Table 7 at Di=1.
A reader trying one of those in a PPS gets the proposal echoed and
accepted, after which the card keeps transmitting at the old rate.
FI_DI_RATIO is clock periods per bit -> larger ratio is a SLOWER link.
The old check rejected slow values but accepted Fi=372/Di=64, ratio 5 !?
Unify and use the register mask (= shifed by 0 so usable as value) and
reject ratios that do not fit rather than truncating to garbage dividers.
Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d
2026-07-28 18:30:34 +0200aa09a6b5beadfcb133cefc3ac4feb936d9bda675firmware: use the full 11 bit US_FIDI.FI_DI_RATIOeditfirmware/libcommon/source/card_emu.ceditfirmware/libcommon/source/simtrace_iso7816.ceditfirmware/libcommon/source/mode_cardemu.c
githttps://jenkins.osmocom.org/jenkins/user/ewildewild