Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org000095392953921.006917691713527491c6bc7e94933958cb4557cc9ce3c5650b23137491c6bc7e94933958cb4557cc9ce3c5650b2313origin/master7491c6bc7e94933958cb4557cc9ce3c5650b23137491c6bc7e94933958cb4557cc9ce3c5650b2313origin/master7491c6bc7e94933958cb4557cc9ce3c5650b23137491c6bc7e94933958cb4557cc9ce3c5650b2313origin/masterhttps://gerrit.osmocom.org/libosmo-sigtranfalse#13529539299738master-libosmo-sigtran #13521352falsefalse1352187683SUCCESS1785856267460https://jenkins.osmocom.org/jenkins/job/master-libosmo-sigtran/1352/src/ss7_asp.ctests/vty/ss7_asp_test.vtytests/vty/osmo_stp_test.vtysrc/ss7_asp_vty.cc4ff5608a65076676748cc8f6a5688a2617a03e61785755211000https://jenkins.osmocom.org/jenkins/user/pespinPau Espin Pedrolpespin@sysmocom.deasp: Support setting timer xua beat 0 through VTY Previous VTY configured range for the set of tdefs in timer xua didn't allow to pass a 0 to it, which "timer xua beat 0" should be able to accept in order to disable heartbeat procedure on the ASP. In order to fix it: * Change VTY range to minimal accepted value to 0 for the whole tdef set. * Make sure the VTY command validates and rejects user trying to set a value outside the accepted range of the specific timer. * Set .min_val=1 in SS7_ASP_XUA_T_ACK, so it can't accept value 0. According to spec, T(ack) is always expected to be set, even if the resulting timeout may be handled by LM instead of simply retransmitting the packet. * Write vty tests to validate the restrictions are followed properly in the VTY. Related: SYS#8156 Change-Id: Iadd7c6751ab09640fd2df214afa2ec87274a3210 2026-08-03 13:06:51 +0200c4ff5608a65076676748cc8f6a5688a2617a03e6asp: Support setting timer xua beat 0 through VTYeditsrc/ss7_asp_vty.cedittests/vty/osmo_stp_test.vtyedittests/vty/ss7_asp_test.vtyeditsrc/ss7_asp.ctests/vty/ss7_asp_test.vtytests/vty/osmo_stp_test.vtysrc/xua_default_lm_fsm.csrc/ss7_asp_vty.c7491c6bc7e94933958cb4557cc9ce3c5650b23131785755810000https://jenkins.osmocom.org/jenkins/user/pespinPau Espin Pedrolpespin@sysmocom.deasp: vty: Explicitly test timer lm value ranges Validate the value to be set provided by user over VTY is actually within the range of the specific tdef being set. Mark all of them explicitly as min_val=1 in its tdef, since they are not expected to be set to 0 (see also gen_asp_timer_lm_cmd_strs() defining a VTY range <1..999999>). Change-Id: I9b2c426a1eaceb6e7c5fbe35872ada324fef5733 2026-08-03 13:16:50 +02007491c6bc7e94933958cb4557cc9ce3c5650b2313asp: vty: Explicitly test timer lm value rangesedittests/vty/osmo_stp_test.vtyeditsrc/ss7_asp_vty.cedittests/vty/ss7_asp_test.vtyeditsrc/xua_default_lm_fsm.cgithttps://jenkins.osmocom.org/jenkins/user/pespinPau Espin Pedrol1352https://jenkins.osmocom.org/jenkins/job/master-libosmo-sigtran/WITH_MANUALS=0,WITH_TCAP=0,a3=default,a4=default,label=osmocom-master/1352/1352https://jenkins.osmocom.org/jenkins/job/master-libosmo-sigtran/WITH_MANUALS=1,WITH_TCAP=1,a3=default,a4=default,label=osmocom-master/1352/