Started by user Neels HofmeyrneelsNeels HofmeyrRebuilds build #1212osmo-gsm-tester_manual-runview/osmo-gsm-tester/job/osmo-gsm-tester_manual-run/OSMO_GSM_TESTER_BRANCHrefs/heads/neels/error_reportingOSMO_GSM_TESTER_OPTS13e0d6be2cbf9a25aeabfd7b82bac7e53ab0604c46e0d6be2cbf9a25aeabfd7b82bac7e53ab0604c46refs/remotes/origin/neels/error_reportinge0d6be2cbf9a25aeabfd7b82bac7e53ab0604c46e0d6be2cbf9a25aeabfd7b82bac7e53ab0604c46refs/remotes/origin/neels/error_reportinge0d6be2cbf9a25aeabfd7b82bac7e53ab0604c46e0d6be2cbf9a25aeabfd7b82bac7e53ab0604c46refs/remotes/origin/neels/error_reportinggit://git.osmocom.org/osmo-gsm-tester304testReportloglogtrial-13/last_run/logtrial-13-run.tgztrial-13-run.tgztrial-13-run.tgzfalse#13947043262130osmo-gsm-tester_manual-run #1313falsetrue1329965FAILURE1497266512567https://jenkins.osmocom.org/jenkins/job/osmo-gsm-tester_manual-run/13/osmo-gsm-tester-rndsrc/osmo_gsm_tester/test.pydaf96e449e48ab43fa452d49d3d2d9e7a14e28401497262066000https://jenkins.osmocom.org/jenkins/user/pespinPau Espin Pedrolpespin@sysmocom.detest: Remove unused variable Failure Commit 6ccda11a98afd6f4459e9ff1c24de4ad4450de23 removed its use but forgot to remove it on this line. Change-Id: I90375ce1e4b8e0b7e140df908323bc269e0baf40 2017-06-12 12:07:46 +0200daf96e449e48ab43fa452d49d3d2d9e7a14e2840test: Remove unused variable Failureeditsrc/osmo_gsm_tester/test.pysrc/osmo_gsm_tester/suite.pysrc/osmo_gsm_tester/trial.pysrc/osmo_gsm_tester/report.py61b07213199e40f1fa1c52ec528b11d9ab4bdc471497264474000https://jenkins.osmocom.org/jenkins/user/neelsNeels Hofmeyrnhofmeyr@sysmocom.dejunit result: also write for aborted runs Even if aborted due to signal, write a JUnit report XML, and make sure to indicate the runs as erratic. Change-Id: I7a334ef3463896c543c0fe592d3903c15e67d4c4 2017-06-12 12:47:54 +020061b07213199e40f1fa1c52ec528b11d9ab4bdc47junit result: also write for aborted runseditsrc/osmo_gsm_tester/suite.pyeditsrc/osmo_gsm_tester/trial.pyeditsrc/osmo_gsm_tester/report.pysrc/osmo_gsm_tester/trial.pysrc/osmo_gsm_tester/bts_osmotrx.pysrc/osmo_gsm_tester/ofono_client.pysrc/osmo_gsm_tester/process.pysrc/osmo_gsm_tester/template.pysrc/osmo_gsm_tester/osmo_bsc.pysrc/osmo_gsm_tester/event_loop.pysrc/osmo_gsm_tester/resource.pysrc/osmo_gsm_tester/osmo_nitb.pysrc/osmo_gsm_tester/osmo_ctrl.pysrc/osmo_gsm_tester/osmo_hlr.pysrc/osmo_gsm_tester/test.pysrc/osmo_gsm_tester/schema.pysrc/osmo_gsm_tester/osmo_msc.pysrc/osmo_gsm_tester/config.pysrc/osmo_gsm_tester/bts_sysmo.pysrc/osmo_gsm_tester/suite.pysrc/osmo_gsm_tester/log.pysrc/osmo_gsm_tester/pcap_recorder.pysrc/osmo_gsm_tester/osmo_mgcpgw.pyb068c6e911c11549d1d412d92955e8090e98d1371497266363000https://jenkins.osmocom.org/jenkins/user/neelsNeels Hofmeyrnhofmeyr@sysmocom.derefactor logging: drop 'with', simplify Refactor logging to simplify use: drop the 'with Origin' style completely, and instead use the python stack to determine which objects are created by which, and which object to associate a log statement with. The new way: we rely on the convention that each class instance has a local 'self' referencing the object instance. If we need to find an origin as a new object's parent, or to associate a log message with, we traverse each stack frame, fetching the first local 'self' object that is a log.Origin class instance. We just call log() and it finds an Origin object to log for. When an exception happens, we first escalate the exception to where ever it is handled, and only then the log.log_exn() function finds an Origin object in the traceback's stack frames. Hence the 'with log.Origin' happens implicitly, no more hassles. Furthermore, any frame can place additional information in a local variable called log_ctx. This automatically inserted in the ancestry associated with a log statement. Change-Id: I5f9b53150f2bb6fa9d63ce27f0806f0ca6a45e90 2017-06-12 13:19:23 +0200b068c6e911c11549d1d412d92955e8090e98d137refactor logging: drop 'with', simplifyeditsrc/osmo_gsm_tester/config.pyeditsrc/osmo_gsm_tester/trial.pyeditsrc/osmo_gsm_tester/bts_sysmo.pyeditsrc/osmo_gsm_tester/pcap_recorder.pyeditsrc/osmo_gsm_tester/template.pyeditsrc/osmo_gsm_tester/osmo_msc.pyeditsrc/osmo_gsm_tester/schema.pyeditsrc/osmo_gsm_tester/process.pyeditsrc/osmo_gsm_tester/event_loop.pyeditsrc/osmo_gsm_tester/osmo_ctrl.pyeditsrc/osmo_gsm_tester/osmo_mgcpgw.pyeditsrc/osmo_gsm_tester/resource.pyeditsrc/osmo_gsm_tester/osmo_hlr.pyeditsrc/osmo_gsm_tester/test.pyeditsrc/osmo_gsm_tester/bts_osmotrx.pyeditsrc/osmo_gsm_tester/osmo_nitb.pyeditsrc/osmo_gsm_tester/osmo_bsc.pyeditsrc/osmo_gsm_tester/log.pyeditsrc/osmo_gsm_tester/suite.pyeditsrc/osmo_gsm_tester/ofono_client.pysrc/osmo_gsm_tester/log.pye0d6be2cbf9a25aeabfd7b82bac7e53ab0604c461497266363000https://jenkins.osmocom.org/jenkins/user/neelsNeels Hofmeyrnhofmeyr@sysmocom.delog.Origin: ensure to avoid parent loops Change-Id: I10a2f956beeda38ba1378eace9453eb911aae1a7 2017-06-12 13:19:23 +0200e0d6be2cbf9a25aeabfd7b82bac7e53ab0604c46log.Origin: ensure to avoid parent loopseditsrc/osmo_gsm_tester/log.pygithttps://jenkins.osmocom.org/jenkins/user/neelsNeels Hofmeyrhttps://jenkins.osmocom.org/jenkins/user/pespinPau Espin Pedrol