Started by upstream project "gerrit-osmo-ccid-firmware" build number 125 originally caused by: Triggered by Gerrit: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306 in silent mode. Running as SYSTEM Building remotely on build5-deb12build-ansible (ttcn3 obs osmo-gsm-tester-build qemu io_uring linux-shallow-clone osmocom-gerrit coverity osmocom-master) in workspace /home/osmocom-build/jenkins/workspace/gerrit-lint [ssh-agent] Looking for ssh-agent implementation... $ ssh-agent SSH_AUTH_SOCK=/tmp/ssh-Qo1ftY6Zlyeu/agent.3522515 SSH_AGENT_PID=3522521 [ssh-agent] Started. Running ssh-add (command line suppressed) Identity added: /home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_11004243210938914075.key (/home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_11004243210938914075.key) [ssh-agent] Using credentials jenkins (gerrit.osmocom.org) The recommended git tool is: NONE using credential d5eda5e9-b59d-44ba-88d2-43473cb6e42d Wiping out workspace first. Cloning the remote Git repository Cloning repository ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware > git init /home/osmocom-build/jenkins/workspace/gerrit-lint/code-from-gerrit # timeout=10 Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware > git --version # timeout=10 > git --version # 'git version 2.39.5' using GIT_SSH to set credentials gerrit.osmocom.org Verifying host key using known hosts file, will automatically accept unseen keys > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware # timeout=10 Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware using GIT_SSH to set credentials gerrit.osmocom.org Verifying host key using known hosts file, will automatically accept unseen keys > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/06/42306/1 # timeout=10 > git rev-parse FETCH_HEAD^{commit} # timeout=10 Checking out Revision ac63541db9d1a1b720f0f790db5855ba0141b646 (master) > git config core.sparsecheckout # timeout=10 > git checkout -f ac63541db9d1a1b720f0f790db5855ba0141b646 # timeout=10 Commit message: "ccid: properly emit wait time ext messages" > git rev-parse FETCH_HEAD^{commit} # timeout=10 > git rev-list --no-walk 97caf6244398760ed8b0c5c045867b4bea36f0a0 # timeout=10 [gerrit-lint] $ /bin/sh -xe /tmp/jenkins18399692404554063582.sh + rm -rf osmo-ci + git clone --depth=1 --branch=master https://gerrit.osmocom.org/osmo-ci osmo-ci Cloning into 'osmo-ci'... + git -C osmo-ci log --oneline 538efe3 repo-install-test: run for debian 13 too + readlink -f /tmp/ssh-Qo1ftY6Zlyeu/agent.3522515 + docker run --rm -e GERRIT_HOST=gerrit.osmocom.org -e GERRIT_PORT=29418 -e GERRIT_PROJECT=osmo-ccid-firmware -e GERRIT_CHANGE_NUMBER=42306 -e GERRIT_PATCHSET_NUMBER=1 -e JENKINS_HOME=1 -e SSH_AUTH_SOCK=/ssh-agent -u build -v /tmp/ssh-Qo1ftY6Zlyeu/agent.3522515:/ssh-agent -v ./code-from-gerrit:/build/code-from-gerrit -v ./osmo-ci:/build/osmo-ci -w /build/code-from-gerrit osmocom-build/debian-bookworm-build /build/osmo-ci/lint/lint_diff.sh HEAD~1 Running docker_run_rm.sh on the whole tree... Running checkpatch on 'git diff HEAD~1'... config: .checkpatch.conf Running clang-format on 'git diff HEAD~1'... --- ccid_common/iso7816_fsm.c (before formatting) +++ ccid_common/iso7816_fsm.c (after formatting) @@ -218,27 +218,27 @@ ***********************************************************************/ static const struct value_string iso7816_3_event_names[] = { - { ISO7816_E_RX_SINGLE, "UART_RX_SINGLE" }, - { ISO7816_E_RX_COMPL, "UART_RX_COMPL" }, - { ISO7816_E_TX_COMPL, "UART_TX_COMPL" }, - { ISO7816_E_POWER_UP_IND, "POWER_UP_IND" }, - { ISO7816_E_RESET_REL_IND, "RESET_REL_IND" }, - { ISO7816_E_RX_ERR_IND, "RX_ERR_IND" }, - { ISO7816_E_TX_ERR_IND, "TX_ERR_IND" }, - { ISO7816_E_ATR_DONE_IND, "ATR_DONE_IND" }, - { ISO7816_E_ATR_ERR_IND, "ATR_ERR_IND" }, - { ISO7816_E_TPDU_DONE_IND, "TPDU_DONE_IND" }, - { ISO7816_E_WTIME_EXT_IND, "WTIME_EXT_IND" }, - { ISO7816_E_XCEIVE_TPDU_CMD, "XCEIVE_TPDU_CMD" }, + { ISO7816_E_RX_SINGLE, "UART_RX_SINGLE" }, + { ISO7816_E_RX_COMPL, "UART_RX_COMPL" }, + { ISO7816_E_TX_COMPL, "UART_TX_COMPL" }, + { ISO7816_E_POWER_UP_IND, "POWER_UP_IND" }, + { ISO7816_E_RESET_REL_IND, "RESET_REL_IND" }, + { ISO7816_E_RX_ERR_IND, "RX_ERR_IND" }, + { ISO7816_E_TX_ERR_IND, "TX_ERR_IND" }, + { ISO7816_E_ATR_DONE_IND, "ATR_DONE_IND" }, + { ISO7816_E_ATR_ERR_IND, "ATR_ERR_IND" }, + { ISO7816_E_TPDU_DONE_IND, "TPDU_DONE_IND" }, + { ISO7816_E_WTIME_EXT_IND, "WTIME_EXT_IND" }, + { ISO7816_E_XCEIVE_TPDU_CMD, "XCEIVE_TPDU_CMD" }, /* allstate events */ - { ISO7816_E_WTIME_EXP, "WAIT_TIME_EXP" }, - { ISO7816_E_HW_ERR_IND, "HW_ERR_IND" }, - { ISO7816_E_SW_ERR_IND, "SW_ERR_IND" }, - { ISO7816_E_CARD_REMOVAL, "CARD_REMOVAL" }, - { ISO7816_E_POWER_DN_IND, "POWER_DN_IND" }, - { ISO7816_E_RESET_ACT_IND, "RESET_ACT_IND" }, - { ISO7816_E_ABORT_REQ, "ABORT_REQ" }, - { ISO7816_E_TPDU_CLEAR_REQ, "TPDU_CLEAR_REQ" }, + { ISO7816_E_WTIME_EXP, "WAIT_TIME_EXP" }, + { ISO7816_E_HW_ERR_IND, "HW_ERR_IND" }, + { ISO7816_E_SW_ERR_IND, "SW_ERR_IND" }, + { ISO7816_E_CARD_REMOVAL, "CARD_REMOVAL" }, + { ISO7816_E_POWER_DN_IND, "POWER_DN_IND" }, + { ISO7816_E_RESET_ACT_IND, "RESET_ACT_IND" }, + { ISO7816_E_ABORT_REQ, "ABORT_REQ" }, + { ISO7816_E_TPDU_CLEAR_REQ, "TPDU_CLEAR_REQ" }, { 0, NULL } }; @@ -551,76 +551,48 @@ static const struct osmo_fsm_state iso7816_3_states[] = { [ISO7816_S_RESET] = { .name = "RESET", - .in_event_mask = S(ISO7816_E_RESET_REL_IND) | - S(ISO7816_E_POWER_UP_IND), - .out_state_mask = S(ISO7816_S_WAIT_ATR) | - S(ISO7816_S_RESET), + .in_event_mask = S(ISO7816_E_RESET_REL_IND) | + S(ISO7816_E_POWER_UP_IND), + .out_state_mask = S(ISO7816_S_WAIT_ATR) | + S(ISO7816_S_RESET), .action = iso7816_3_reset_action, .onenter = iso7816_3_reset_onenter, }, [ISO7816_S_WAIT_ATR] = { .name = "WAIT_ATR", - .in_event_mask = S(ISO7816_E_RX_SINGLE), - .out_state_mask = S(ISO7816_S_RESET) | - S(ISO7816_S_IN_ATR), + .in_event_mask = S(ISO7816_E_RX_SINGLE), + .out_state_mask = S(ISO7816_S_RESET) | S(ISO7816_S_IN_ATR), .action = iso7816_3_wait_atr_action, }, [ISO7816_S_IN_ATR] = { .name = "IN_ATR", - .in_event_mask = S(ISO7816_E_RX_SINGLE) | - S(ISO7816_E_RX_ERR_IND) | - S(ISO7816_E_ATR_DONE_IND), - .out_state_mask = S(ISO7816_S_RESET) | - S(ISO7816_S_IN_ATR) | - S(ISO7816_S_WAIT_TPDU), + .in_event_mask = S(ISO7816_E_RX_SINGLE) | S(ISO7816_E_RX_ERR_IND) | S(ISO7816_E_ATR_DONE_IND), + .out_state_mask = S(ISO7816_S_RESET) | S(ISO7816_S_IN_ATR) | S(ISO7816_S_WAIT_TPDU), .action = iso7816_3_in_atr_action, }, [ISO7816_S_WAIT_TPDU] = { .name = "WAIT_TPDU", - .in_event_mask = S(ISO7816_E_XCEIVE_TPDU_CMD) | - S(ISO7816_E_XCEIVE_PPS_CMD), - .out_state_mask = S(ISO7816_S_RESET) | - S(ISO7816_S_WAIT_TPDU) | - S(ISO7816_S_IN_TPDU) | - S(ISO7816_S_WAIT_PPS_RSP), + .in_event_mask = S(ISO7816_E_XCEIVE_TPDU_CMD) | S(ISO7816_E_XCEIVE_PPS_CMD), + .out_state_mask = S(ISO7816_S_RESET) | S(ISO7816_S_WAIT_TPDU) | S(ISO7816_S_IN_TPDU) | S(ISO7816_S_WAIT_PPS_RSP), .action = iso7816_3_wait_tpdu_action, .onenter = iso7816_3_wait_tpdu_onenter, }, [ISO7816_S_IN_TPDU] = { .name = "IN_TPDU", - .in_event_mask = S(ISO7816_E_RX_SINGLE) | - S(ISO7816_E_RX_COMPL) | - S(ISO7816_E_TX_COMPL) | - S(ISO7816_E_RX_ERR_IND) | - S(ISO7816_E_TX_ERR_IND) | - S(ISO7816_E_TPDU_DONE_IND) | - S(ISO7816_E_WTIME_EXT_IND), - .out_state_mask = S(ISO7816_S_RESET) | - S(ISO7816_S_WAIT_TPDU) | - S(ISO7816_S_IN_TPDU), + .in_event_mask = S(ISO7816_E_RX_SINGLE) | S(ISO7816_E_RX_COMPL) | S(ISO7816_E_TX_COMPL) | S(ISO7816_E_RX_ERR_IND) | S(ISO7816_E_TX_ERR_IND) | S(ISO7816_E_TPDU_DONE_IND) | S(ISO7816_E_WTIME_EXT_IND), + .out_state_mask = S(ISO7816_S_RESET) | S(ISO7816_S_WAIT_TPDU) | S(ISO7816_S_IN_TPDU), .action = iso7816_3_in_tpdu_action, }, [ISO7816_S_WAIT_PPS_RSP] = { .name = "WAIT_PPS_RESP", - .in_event_mask = S(ISO7816_E_TX_COMPL) | - S(ISO7816_E_TX_ERR_IND) | - S(ISO7816_E_RX_SINGLE), - .out_state_mask = S(ISO7816_S_RESET) | - S(ISO7816_S_WAIT_TPDU) | - S(ISO7816_S_WAIT_PPS_RSP) | - S(ISO7816_S_IN_PPS_RSP), + .in_event_mask = S(ISO7816_E_TX_COMPL) | S(ISO7816_E_TX_ERR_IND) | S(ISO7816_E_RX_SINGLE), + .out_state_mask = S(ISO7816_S_RESET) | S(ISO7816_S_WAIT_TPDU) | S(ISO7816_S_WAIT_PPS_RSP) | S(ISO7816_S_IN_PPS_RSP), .action = iso7816_3_s_wait_pps_rsp_action, }, [ISO7816_S_IN_PPS_RSP] = { .name = "IN_PPS_RESP", - .in_event_mask = S(ISO7816_E_RX_SINGLE) | - S(ISO7816_E_RX_COMPL) | - S(ISO7816_E_RX_ERR_IND) | - S(ISO7816_E_PPS_DONE_IND) | - S(ISO7816_E_PPS_FAILED_IND), - .out_state_mask = S(ISO7816_S_RESET) | - S(ISO7816_S_WAIT_TPDU) | - S(ISO7816_S_IN_PPS_RSP), + .in_event_mask = S(ISO7816_E_RX_SINGLE) | S(ISO7816_E_RX_COMPL) | S(ISO7816_E_RX_ERR_IND) | S(ISO7816_E_PPS_DONE_IND) | S(ISO7816_E_PPS_FAILED_IND), + .out_state_mask = S(ISO7816_S_RESET) | S(ISO7816_S_WAIT_TPDU) | S(ISO7816_S_IN_PPS_RSP), .action = iso7816_3_s_ins_pps_rsp_action, }, }; --- ccid_common/iso7816_fsm.h (before formatting) +++ ccid_common/iso7816_fsm.h (after formatting) @@ -22,22 +22,22 @@ struct card_uart; enum iso7816_3_event { - ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */ - ISO7816_E_RX_COMPL, /*!< data receive complete on UART */ - ISO7816_E_TX_COMPL, /*!< data transmit complete on UART */ - ISO7816_E_POWER_UP_IND, /*!< Card powered up */ - ISO7816_E_RESET_REL_IND, /*!< Reset released */ - ISO7816_E_RX_ERR_IND, /*!< Uncorrectable Rx [parity] error */ - ISO7816_E_TX_ERR_IND, /*!< Uncorrectable Rx [parity] error */ - ISO7816_E_XCEIVE_TPDU_CMD, /*!< Ask for start of TPDU transmission */ + ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */ + ISO7816_E_RX_COMPL, /*!< data receive complete on UART */ + ISO7816_E_TX_COMPL, /*!< data transmit complete on UART */ + ISO7816_E_POWER_UP_IND, /*!< Card powered up */ + ISO7816_E_RESET_REL_IND, /*!< Reset released */ + ISO7816_E_RX_ERR_IND, /*!< Uncorrectable Rx [parity] error */ + ISO7816_E_TX_ERR_IND, /*!< Uncorrectable Rx [parity] error */ + ISO7816_E_XCEIVE_TPDU_CMD, /*!< Ask for start of TPDU transmission */ /* allstate events */ - ISO7816_E_WTIME_EXP, /*!< WTIME expired */ - ISO7816_E_HW_ERR_IND, /*!< Hardware error (overcurrent, ...) */ - ISO7816_E_SW_ERR_IND, /*!< Software error */ - ISO7816_E_CARD_REMOVAL, /*!< card has been removed from slot */ - ISO7816_E_POWER_DN_IND, /*!< Card powered down */ - ISO7816_E_RESET_ACT_IND, /*!< Reset activated */ - ISO7816_E_ABORT_REQ, /*!< Abort request (e.g. from CCID) */ + ISO7816_E_WTIME_EXP, /*!< WTIME expired */ + ISO7816_E_HW_ERR_IND, /*!< Hardware error (overcurrent, ...) */ + ISO7816_E_SW_ERR_IND, /*!< Software error */ + ISO7816_E_CARD_REMOVAL, /*!< card has been removed from slot */ + ISO7816_E_POWER_DN_IND, /*!< Card powered down */ + ISO7816_E_RESET_ACT_IND, /*!< Reset activated */ + ISO7816_E_ABORT_REQ, /*!< Abort request (e.g. from CCID) */ /* TODO: PPS request */ ISO7816_E_XCEIVE_PPS_CMD, ISO7816_E_PPS_DONE_IND, @@ -47,14 +47,14 @@ /* TODO: Rx FIFO overrun */ /* TODO: Rx buffer overrun */ - ISO7816_E_WTIME_EXT_IND, /*!< Wait Time Extension (NULL byte 0x60) from card */ + ISO7816_E_WTIME_EXT_IND, /*!< Wait Time Extension (NULL byte 0x60) from card */ /* internal events between FSMs in this file */ - ISO7816_E_ATR_DONE_IND, /*!< ATR Done indication from ATR child FSM */ - ISO7816_E_ATR_ERR_IND, /*!< ATR Error indication from ATR child FSM */ - ISO7816_E_TPDU_DONE_IND, /*!< TPDU Done indication from TPDU child FSM */ - ISO7816_E_TPDU_FAILED_IND, /*!< TPDU Failed indication from TPDU child FSM */ - ISO7816_E_TPDU_CLEAR_REQ, /*!< Return TPDU FSM to TPDU_S_INIT */ + ISO7816_E_ATR_DONE_IND, /*!< ATR Done indication from ATR child FSM */ + ISO7816_E_ATR_ERR_IND, /*!< ATR Error indication from ATR child FSM */ + ISO7816_E_TPDU_DONE_IND, /*!< TPDU Done indication from TPDU child FSM */ + ISO7816_E_TPDU_FAILED_IND, /*!< TPDU Failed indication from TPDU child FSM */ + ISO7816_E_TPDU_CLEAR_REQ, /*!< Return TPDU FSM to TPDU_S_INIT */ }; typedef void (*iso7816_user_cb)(struct osmo_fsm_inst *fi, int event, int cause, void *data); Please fix the linting errors above. More information: https://osmocom.org/projects/cellular-infrastructure/wiki/Linting Leaving review comments in gerrit... + git diff -U0 HEAD~1 + /build/osmo-ci/lint/checkpatch/checkpatch_osmo.sh + cd .. + /build/osmo-ci/lint/checkpatch/checkpatch_json.py checkpatch_output gerrit_report.json checkpatch_output {"comments": [], "robot_comments": {}} + ssh -o UserKnownHostsFile=/build/osmo-ci/lint/../contrib/known_hosts -p 29418 -l jenkins gerrit.osmocom.org gerrit review --project osmo-ccid-firmware 42306,1 --json + exit 1 Build step 'Execute shell' marked build as failure $ ssh-agent -k unset SSH_AUTH_SOCK; unset SSH_AGENT_PID; echo Agent pid 3522521 killed; [ssh-agent] Stopped. Finished: FAILURE