{ "comments": [], "robot_comments": { "src/sgsn/gprs_gmm.c": [ { "line": "2568", "message": "braces {} are not necessary for single statement blocks", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "2597", "message": "braces {} are not necessary for single statement blocks", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "2627", "message": "else is not generally useful after a break or return", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" } ], "src/sgsn/gprs_rau_fsm.c": [ { "line": "365", "message": "need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" } ], "src/sgsn/sgsn_libgtp.c": [ { "line": "190", "message": "braces {} are not necessary for single statement blocks", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "913", "message": "Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "918", "message": "Macros with multiple statements should be enclosed in a do - while loop", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "918", "message": "macros should not use a trailing semicolon", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "1085", "message": "'transfered' may be misspelled - perhaps 'transferred'?", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "1125", "message": "braces {} are not necessary for single statement blocks", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "1139", "message": "please, no space before tabs", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "1378", "message": "Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" }, { "line": "1388", "message": "braces {} are not necessary for single statement blocks", "robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21621", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21621/" } ] } }