{ "_class" : "hudson.matrix.MatrixBuild", "actions" : [ { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "org.jenkinsci.plugins.workflow.support.steps.build.BuildUpstreamCause", "shortDescription" : "Started by upstream project \"gerrit-osmo-bts\" build number 1,015", "upstreamBuild" : 1015, "upstreamProject" : "gerrit-osmo-bts", "upstreamUrl" : "job/gerrit-osmo-bts/" } ] }, { }, { "_class" : "hudson.model.ParametersAction", "parameters" : [ { "_class" : "hudson.model.StringParameterValue", "name" : "COMMENT_TYPE", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "DISTRO", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_BRANCH", "value" : "master" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_CHANGE_NUMBER", "value" : "41048" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_HOST", "value" : "gerrit.osmocom.org" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PATCHSET_NUMBER", "value" : "2" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PATCHSET_REVISION", "value" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PATCHSET_UPLOADER_NAME", "value" : "falconia" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PORT", "value" : "29418" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PROJECT", "value" : "osmo-bts" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_REFSPEC", "value" : "refs/changes/48/41048/2" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_REPO_URL", "value" : "ssh://jenkins@gerrit.osmocom.org:29418/osmo-bts" }, { "_class" : "hudson.model.StringParameterValue", "name" : "PIPELINE_BUILD_URL", "value" : "https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts/1015/" }, { "_class" : "hudson.model.StringParameterValue", "name" : "PROJECT_NAME", "value" : "osmo-bts" }, { "_class" : "hudson.model.StringParameterValue", "name" : "BRANCH_CI", "value" : "master" } ] }, { "_class" : "jenkins.metrics.impl.TimeInQueueAction", "blockedDurationMillis" : 2064927, "blockedTimeMillis" : 2064927, "buildableDurationMillis" : 0, "buildableTimeMillis" : 0, "buildingDurationMillis" : 683837, "executingTimeMillis" : 683837, "executorUtilization" : 1.0, "subTaskCount" : 0, "waitingDurationMillis" : 6968, "waitingTimeMillis" : 6968 }, { }, { "_class" : "hudson.plugins.git.util.BuildData", "buildsByBranchName" : { "2023q1" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 374, "buildResult" : None, "marked" : { "SHA1" : "bfdc23b1c676d017da2c1dff26d937be9c9926e2", "branch" : [ { "SHA1" : "bfdc23b1c676d017da2c1dff26d937be9c9926e2", "name" : "2023q1" } ] }, "revision" : { "SHA1" : "bfdc23b1c676d017da2c1dff26d937be9c9926e2", "branch" : [ { "SHA1" : "bfdc23b1c676d017da2c1dff26d937be9c9926e2", "name" : "2023q1" } ] } }, "osmith/1.7.1" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 794, "buildResult" : None, "marked" : { "SHA1" : "f79a23bab0e43959d25363d2a4903127e0a1cb3a", "branch" : [ { "SHA1" : "f79a23bab0e43959d25363d2a4903127e0a1cb3a", "name" : "osmith/1.7.1" } ] }, "revision" : { "SHA1" : "f79a23bab0e43959d25363d2a4903127e0a1cb3a", "branch" : [ { "SHA1" : "f79a23bab0e43959d25363d2a4903127e0a1cb3a", "name" : "osmith/1.7.1" } ] } }, "osmith/1.7.2" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 874, "buildResult" : None, "marked" : { "SHA1" : "75a087d16ba2539b8bcf05102b41d820e8187241", "branch" : [ { "SHA1" : "75a087d16ba2539b8bcf05102b41d820e8187241", "name" : "osmith/1.7.2" } ] }, "revision" : { "SHA1" : "75a087d16ba2539b8bcf05102b41d820e8187241", "branch" : [ { "SHA1" : "75a087d16ba2539b8bcf05102b41d820e8187241", "name" : "osmith/1.7.2" } ] } }, "master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 1015, "buildResult" : None, "marked" : { "SHA1" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "branch" : [ { "SHA1" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "name" : "master" } ] }, "revision" : { "SHA1" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "branch" : [ { "SHA1" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "name" : "master" } ] } } }, "lastBuiltRevision" : { "SHA1" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "branch" : [ { "SHA1" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "name" : "master" } ] }, "remoteUrls" : [ "ssh://jenkins@gerrit.osmocom.org:29418/osmo-bts" ], "scmName" : "" }, { }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" } ], "artifacts" : [ ], "building" : False, "description" : None, "displayName" : "#1015", "duration" : 683837, "estimatedDuration" : 660492, "executor" : None, "fullDisplayName" : "gerrit-osmo-bts-build #1015", "id" : "1015", "inProgress" : False, "keepLog" : False, "number" : 1015, "queueId" : 1985685, "result" : "SUCCESS", "timestamp" : 1757103444463, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/1015/", "builtOn" : "", "changeSet" : { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/osmo-bts-trx/sched_lchan_tchh.c", "src/osmo-bts-trx/sched_lchan_tchf.c", "src/osmo-bts-lc15/tch.c", "include/osmo-bts/msg_utils.h", "src/common/l1sap.c", "src/osmo-bts-oc2g/tch.c", "src/osmo-bts-sysmo/tch.c" ], "commitId" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "timestamp" : 1757100607000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/falcon", "fullName" : "falcon" }, "authorEmail" : "falcon@freecalypso.org", "comment" : "FR/HR/EFR: centralize TCH UL SID classification\u000a\u000aIn any environment where GSM MS may exercise DTXu on TCH/FS, TCH/HS or\u000aTCH/EFS, the BTS receiving this TCH UL has to classify each received\u000atraffic frame as valid SID, invalid SID or non-SID speech. For E1 BTS\u000athis SID classification requirement is explicit as there are dedicated\u000abits in TRAU-UL frames carrying the SID code. For an IP BTS the need\u000afor this classification is less obvious as most RTP payload formats\u000aomit SID indicator bits - however:\u000a\u000a* For HR codec, RTP output in RFC 5993 and TW-TS-002 formats does\u000a include explicit SID classification;\u000a\u000a* Also for HR output in both TS 101 318 and RFC 5993 formats\u000a (but not TW-TS-002), SID classification must be considered in order\u000a to turn valid SID with some bit errors into perfect SID codeword;\u000a\u000a* OsmoBTS already had logic for all 3 of FR/HR/EFR whereby if a frame\u000a is received that is an accepted SID frame in GSM 06.31/06.41/06.81\u000a definition, a flag is set so that the next good speech frame will\u000a be emitted in RTP with marker bit set. This logic implies SID\u000a classification in TCH UL path.\u000a\u000aPrior to this patch, OsmoBTS performed limited, non-consolidated\u000aSID classification:\u000a\u000a* For FR and EFR, the only SID classification in TCH UL path was done\u000a for RTP marker purposes by way of osmo_{fr,efr}_is_any_sid() Boolean\u000a result fed to lchan_set_marker();\u000a\u000a* For the same RTP marker logic with HR codec, only perfect, error-free\u000a SID frames were detected;\u000a\u000a* The same limitation applied to SID classification for RFC 5993 output.\u000a\u000aCentralize this SID classification by moving it from BTS model to common\u000al1sap code and unifying it across all 3 codecs. Immediate functional\u000aeffects from this change are:\u000a\u000a* On TCH/HS we now detect imperfect (partially corrupted) SID frames\u000a and classify them as valid or invalid SID as intended by ETSI,\u000a like we already did for TCH/FS and TCH/EFS;\u000a\u000a* When emitting TS 101 318 or RFC 5993, we apply the inherent limitations\u000a of those RTP formats to valid and invalid SID;\u000a\u000a* With all 3 codecs, the check for a good speech frame as exit criterion\u000a from DTXu state now happens after the link quality check in l1sap,\u000a rather than before.\u000a\u000aAMR speech mode is not affected at all by these changes: AMR DTX model\u000ais completely different from that of FR/HR/EFR.\u000a\u000aRelated: OS#6036\u000aChange-Id: Id6c8c146962de2f173760889eb232693bb4229d3\u000a", "date" : "2025-09-05 19:30:07 +0000", "id" : "d9b456ce6d7c55b139f78e5c5474a3ad3fdcb5ac", "msg" : "FR/HR/EFR: centralize TCH UL SID classification", "paths" : [ { "editType" : "edit", "file" : "src/common/l1sap.c" }, { "editType" : "edit", "file" : "src/osmo-bts-oc2g/tch.c" }, { "editType" : "edit", "file" : "src/osmo-bts-trx/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/osmo-bts-sysmo/tch.c" }, { "editType" : "edit", "file" : "src/osmo-bts-lc15/tch.c" }, { "editType" : "edit", "file" : "include/osmo-bts/msg_utils.h" }, { "editType" : "edit", "file" : "src/osmo-bts-trx/sched_lchan_tchf.c" } ] } ], "kind" : "git" }, "culprits" : [ { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/falcon", "fullName" : "falcon" } ], "runs" : [ { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=lc15,FIRMWARE_VERSION=litecell15,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=lc15,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=lc15,FIRMWARE_VERSION=v2017.01,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=oc2g,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=oc2g,FIRMWARE_VERSION=oc2g,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=oc2g,FIRMWARE_VERSION=oc2g-next,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=oct,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=oct+trx,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=sysmo,FIRMWARE_VERSION=femtobts_v2.7,WITH_MANUALS=1,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=sysmo,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v2.4,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v3.0.1pre,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v3.1,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v5.1,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=trx,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=osmocom-gerrit/1015/" }, { "number" : 1015, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-osmo-bts-build/BTS_MODEL=trx,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=raspbian/1015/" } ] }