{ "_class" : "hudson.matrix.MatrixBuild", "actions" : [ { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "org.jenkinsci.plugins.workflow.support.steps.build.BuildUpstreamCause", "shortDescription" : "Started by upstream project \"gerrit-pysim\" build number 2,151", "upstreamBuild" : 2151, "upstreamProject" : "gerrit-pysim", "upstreamUrl" : "job/gerrit-pysim/" } ] }, { }, { "_class" : "hudson.model.ParametersAction", "parameters" : [ { "_class" : "hudson.model.StringParameterValue", "name" : "COMMENT_TYPE", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "DISTRO", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_BRANCH", "value" : "master" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_CHANGE_NUMBER", "value" : "39742" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_HOST", "value" : "gerrit.osmocom.org" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PATCHSET_NUMBER", "value" : "5" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PATCHSET_REVISION", "value" : "3a2cb239bcc6b4dd71107a2b522da581599931b2" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PATCHSET_UPLOADER_NAME", "value" : "neels" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PORT", "value" : "29418" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_PROJECT", "value" : "pysim" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_REFSPEC", "value" : "refs/changes/42/39742/5" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GERRIT_REPO_URL", "value" : "ssh://jenkins@gerrit.osmocom.org:29418/pysim" }, { "_class" : "hudson.model.StringParameterValue", "name" : "PIPELINE_BUILD_URL", "value" : "https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/2151/" }, { "_class" : "hudson.model.StringParameterValue", "name" : "PROJECT_NAME", "value" : "pysim" }, { "_class" : "hudson.model.StringParameterValue", "name" : "BRANCH_CI", "value" : "master" } ] }, { "_class" : "jenkins.metrics.impl.TimeInQueueAction", "blockedDurationMillis" : 0, "blockedTimeMillis" : 0, "buildableDurationMillis" : 0, "buildableTimeMillis" : 0, "buildingDurationMillis" : 734725, "executingTimeMillis" : 734725, "executorUtilization" : 1.0, "subTaskCount" : 0, "waitingDurationMillis" : 6770, "waitingTimeMillis" : 6770 }, { }, { "_class" : "hudson.plugins.git.util.BuildData", "buildsByBranchName" : { "master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 2142, "buildResult" : None, "marked" : { "SHA1" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "branch" : [ { "SHA1" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "name" : "master" } ] }, "revision" : { "SHA1" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "branch" : [ { "SHA1" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "name" : "master" } ] } } }, "lastBuiltRevision" : { "SHA1" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "branch" : [ { "SHA1" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "name" : "master" } ] }, "remoteUrls" : [ "ssh://jenkins@gerrit.osmocom.org:29418/pysim" ], "scmName" : "" }, { }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" } ], "artifacts" : [ ], "building" : False, "description" : None, "displayName" : "#2142", "duration" : 734725, "estimatedDuration" : 827014, "executor" : None, "fullDisplayName" : "gerrit-pysim-build #2142", "id" : "2142", "inProgress" : False, "keepLog" : True, "number" : 2142, "queueId" : 1838567, "result" : "FAILURE", "timestamp" : 1741611676595, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-pysim-build/2142/", "builtOn" : "", "changeSet" : { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "pySim/esim/saip/personalization.py" ], "commitId" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "timestamp" : 1741611631000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/neels", "fullName" : "Neels Hofmeyr" }, "authorEmail" : "nhofmeyr@sysmocom.de", "comment" : "[2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi\u000a\u000aMain points/rationales of the refactoring, details below:\u000a1) common validation implementation\u000a2) offer classmethods\u000a\u000aThe new features are optional, and will be heavily used by batch\u000apersonalization patches coming soon.\u000a\u000aImplement Iccid and Imsi to use the new way, with a common abstract\u000aDecimalParam implementation.\u000a\u000aSo far leave the other parameter classes working as they always did, to\u000afollow suit in subsequent commits.\u000a\u000aDetails:\u000a\u000a1) common validation implementation:\u000aThere are very common validation steps in the various parameter\u000aimplementations. It is more convenient and much more readable to\u000aimplement those once and set simple validation parameters per subclass.\u000aSo there now is a validate_val() classmethod, which subclasses can use\u000aas-is to apply the validation parameters -- or subclasses can override\u000atheir cls.validate_val() for specialized validation.\u000a(Those subclasses that this patch doesn't touch still override the\u000aself.validate() instance method. Hence they still work as before this\u000apatch, but don't use the new common features yet.)\u000a\u000a2) offer stateless classmethods:\u000aIt is useful for...\u000a- batch processing of multiple profiles (in upcoming patches) and\u000a- user input validation\u000ato be able to have classmethods that do what self.validate() and\u000aself.apply() do, but do not modify any self.* members.\u000aSo far the paradigm was to create a class instance to keep state about\u000athe value. This remains available, but in addition we make available the\u000aparadigm of a singleton that is stateless (the classmethods).\u000aUsing self.validate() and self.apply() still work the same as before\u000athis patch, i.e. via self.input_value and self.value -- but in addition,\u000athere are now classmethods that don't touch self.* members.\u000a\u000aRelated: SYS#6768\u000aChange-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8\u000a", "date" : "2025-03-10 14:00:31 +0100", "id" : "3a2cb239bcc6b4dd71107a2b522da581599931b2", "msg" : "[2/7] personalization: refactor ConfigurableParameter, Iccid, Imsi", "paths" : [ { "editType" : "edit", "file" : "pySim/esim/saip/personalization.py" } ] } ], "kind" : "git" }, "culprits" : [ { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/neels", "fullName" : "Neels Hofmeyr" } ], "runs" : [ { "number" : 2142, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-pysim-build/JOB_TYPE=distcheck,a1=default,a3=default,a4=default,label=osmocom-gerrit/2142/" }, { "number" : 2142, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-pysim-build/JOB_TYPE=docs,a1=default,a3=default,a4=default,label=osmocom-gerrit/2142/" }, { "number" : 2142, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-pysim-build/JOB_TYPE=pylint,a1=default,a3=default,a4=default,label=osmocom-gerrit/2142/" }, { "number" : 2142, "url" : "https://jenkins.osmocom.org/jenkins/view/Jenkins-Gerrit/job/gerrit-pysim-build/JOB_TYPE=test,a1=default,a3=default,a4=default,label=simtester/2142/" } ] }