BRANCHosmith/wipEMAIL_NOTIFICATIONSStarted by user Oliver SmithosmithOliver Smith000046573465731.00002414116df678f9a7887c828e5744d1fab9399c8ef6d3116df678f9a7887c828e5744d1fab9399c8ef6d3origin/master116df678f9a7887c828e5744d1fab9399c8ef6d3116df678f9a7887c828e5744d1fab9399c8ef6d3origin/master2415be7b3124f870855c64815849d5271d80703bf293be7b3124f870855c64815849d5271d80703bf293refs/remotes/origin/osmith/wipbe7b3124f870855c64815849d5271d80703bf293be7b3124f870855c64815849d5271d80703bf293refs/remotes/origin/osmith/wip116862e18147cc4dd566884dcdcca0be3e028c30524562e18147cc4dd566884dcdcca0be3e028c305245refs/remotes/origin/master62e18147cc4dd566884dcdcca0be3e028c30524562e18147cc4dd566884dcdcca0be3e028c305245refs/remotes/origin/masterbe7b3124f870855c64815849d5271d80703bf293be7b3124f870855c64815849d5271d80703bf293refs/remotes/origin/osmith/wiphttps://gerrit.osmocom.org/osmo-ccid-firmwarefalse#24154657342676master-osmo-ccid-firmware #24152415falsefalse241578758SUCCESS1775123145376https://jenkins.osmocom.org/jenkins/view/OsmocomBB/job/master-osmo-ccid-firmware/2415/contrib/jenkins.sh4aec0a62d4537d69daca042006fa456da613accf1768741153000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.decontrib/jenkins.sh: fix build: add --disable-syslog-logging Since recently (see the related patch), libosmocore requires header file syslog.h to be present, unless --disable-syslog-logging is given. Change-Id: Ia49709dfebdf22cb00f70d667c996c3fbb8a1f51 Related: libosmocore.git Ifc54d60e24547696b3059b6eb75572f8c84874d0 2026-01-18 19:59:13 +07004aec0a62d4537d69daca042006fa456da613accfcontrib/jenkins.sh: fix build: add --disable-syslog-loggingeditcontrib/jenkins.shcontrib/jenkins.sh45655c213b3087f073baebbeb4176776ac283d721768996964000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.decontrib/jenkins.sh: fix non-existent include path This helps the compiler to find talloc.h and fixes the build [again]. Change-Id: I7949f31e01d4cb20af1095f8fc20be1571239f37 Related: OS#6929 2026-01-21 19:02:44 +070045655c213b3087f073baebbeb4176776ac283d72contrib/jenkins.sh: fix non-existent include patheditcontrib/jenkins.shcontrib/jenkins.shbef0bd774a513678beac5102781a5e79767f97361768996995000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.decontrib/jenkins.sh: clean up embedded build flags --enable-embedded implies the following flags: * --disable-log-macros * --disable-libsctp * --disable-libusb * --disable-gb * --disable-libmnl * --disable-syslog-logging so they can be safely removed. --enable-external-tests makes no sense for an embedded build. Change-Id: I4b54ecc5b023c7f4e1788814960e179c3818dbda Related: libosmocore.git I164eb461fb59c7675393219102740f40c1119fdd 2026-01-21 19:03:15 +0700bef0bd774a513678beac5102781a5e79767f9736contrib/jenkins.sh: clean up embedded build flagseditcontrib/jenkins.shcontrib/jenkins.sh051e71adc02f16218b6d2ddcadfd69082b72ae8b1768996995000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.decontrib/jenkins.sh: clean up CFLAGS Change-Id: I4e78d6eb3c6c7b40312072fcf70f4b6d80042959 2026-01-21 19:03:15 +0700051e71adc02f16218b6d2ddcadfd69082b72ae8bcontrib/jenkins.sh: clean up CFLAGSeditcontrib/jenkins.shccid_common/iso7816_fsm.c8bb769384e4ade2eca700110ffdfb8e2fe384d391770216277000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defix wait time extension handling wait time ext byte was mishandled as sw1 and sw2, which broke transfers that took a long time, i.e. crypto ops during esim interactions. Closes: SYS#7869 Change-Id: I7527a4337ae857b9b2a4e982606fac770e677d73 2026-02-04 15:44:37 +01008bb769384e4ade2eca700110ffdfb8e2fe384d39fix wait time extension handlingeditccid_common/iso7816_fsm.cccid_common/ccid_slot_fsm.c8bbb9aee39f62cd18ea0181a22ecf488314cc3ca1771666868000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.euccid_common: iso_handle_fsm_events: add missing return Fix warning about control reaches end of non-void function. Change-Id: I4066c8a1ab1eadb3d8f8cbaf5aa0afbbb2e5dd80 2026-02-21 09:41:08 +00008bbb9aee39f62cd18ea0181a22ecf488314cc3caccid_common: iso_handle_fsm_events: add missing returneditccid_common/ccid_slot_fsm.csysmoOCTSIM/main.cf522294dd2e7a9be793954f0dc2175762ca8ebd91772185580000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgAfter initialisation: turn user led on Related: SYS#5158 Change-Id: Ide37ea32648536d333bd5051b142eb15959d29bf 2026-02-27 09:46:20 +0000f522294dd2e7a9be793954f0dc2175762ca8ebd9After initialisation: turn user led oneditsysmoOCTSIM/main.c.clang-format97caf6244398760ed8b0c5c045867b4bea36f0a01772438277000https://jenkins.osmocom.org/jenkins/user/osmithOliver Smithosmith@sysmocom.declang-format: set ColumnLimit: 0 While our coding style says "we accept line lengths of up to 120 characters", in practice we oftentimes end up preferring longer lines (e.g. due to having comments at the end, or to keep them consistent with similar but shorter lines). The checkpatch config has already been adjusted to just ignore the line length completely. Adjust the clang-format config to do the same. Related: osmo-ci I88fd86ac550fddb3017aeceb647c3d9e75367372 Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 2026-03-02 07:57:57 +000097caf6244398760ed8b0c5c045867b4bea36f0a0clang-format: set ColumnLimit: 0edit.clang-formatsysmoOCTSIM/main.cfe7f506cc7464d7887e8fab93e2572866b68e23e1773134977000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgmain: fix crash when ccid_df_write_in() fails The OSMO_ASSERT(msg->list.next != LLIST_POISON1) are checking msgb which has been removed from the llist. All llist members which aren't part of a list have LLIST_POISON1 assigned. These OSMO_ASSERT()s will always trigger this msgb. Fixes: a684bc4e38b4 ("Make ch9 usb tests work") Change-Id: I49c81fba756f3620638b6c6c664f53e4a8758ef9 2026-03-10 09:29:37 +0000fe7f506cc7464d7887e8fab93e2572866b68e23emain: fix crash when ccid_df_write_in() failseditsysmoOCTSIM/main.csysmoOCTSIM/main.cc53871f917f7917b5abb3b57ecfebbfd8cf290c41773134977000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgmain: don't access msgbs after giving them away Because of IRQ, it is dangerous to access a msgb, which has been giving away to a queue (ownership transfer). Further OSMO_ASSERT() should never fail on a queue'd object, except it has been taken already from an IRQ context. Fix a potential crash. Fixes: a684bc4e38b4 ("Make ch9 usb tests work") Change-Id: I79844f77d5cd75e08b0eb44b22c4ad223cb79dcb 2026-03-10 09:29:37 +0000c53871f917f7917b5abb3b57ecfebbfd8cf290c4main: don't access msgbs after giving them awayeditsysmoOCTSIM/main.cccid_common/ccid_device.c969a494769c62ed4402a0febc19e48e57792cbfc1773139531000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgccid_device: Reject XfrBlock with zero-length data While the CCID v1.1 spec seems to declare dwLength == 0 is within the valid range, it's of course a no-op as we cannot transact a TPDU that isn't there. Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Closes: OS#6969 2026-03-10 10:45:31 +0000969a494769c62ed4402a0febc19e48e57792cbfcccid_device: Reject XfrBlock with zero-length dataeditccid_common/ccid_device.cccid_common/ccid_device.cccid_common/ccid_proto.h2dc15fb6727faa05738ee63b53ce3e81cb8f4f421773160033000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum) Our RDR_to_PC_Parameters message was broken, as it was missing the bProtocolNum value after the header. Let's fix that. Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 2026-03-10 16:27:13 +00002dc15fb6727faa05738ee63b53ce3e81cb8f4f42ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum)editccid_common/ccid_device.ceditccid_common/ccid_proto.hccid_common/ccid_proto.hf2f1bb884194f04f306993de16841b606d5c0fc61773160033000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition Our definition of the message was wrong; it is an interrupt endpoint message without the full header of the bulk-in endpoint. Luckily the definition was not used in the code base, so this is not fixing any problem visible on the protocol level. Change-Id: Ieb756c37402c4ebea32cc3cd23ba3842f4c0df3e 2026-03-10 16:27:13 +0000f2f1bb884194f04f306993de16841b606d5c0fc6ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definitioneditccid_common/ccid_proto.hccid_common/ccid_slot_fsm.c9805f86d74edfe6c1d1f2fa20c843370abde768b1773169782000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes The CCID v1.1 ch 6.1.4 specification states a T=0 TPDU must not exceed 260 bytes, so let's properly handle this error case. Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 2026-03-10 19:09:42 +00009805f86d74edfe6c1d1f2fa20c843370abde768bccid_slot_fsm.c: Reject T=0 TPDU > 260 byteseditccid_common/ccid_slot_fsm.csysmoOCTSIM/gcc/Makefileb72e2a90bf8951c1412bf64b9c0ea58738c42f331773346538000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgensure libosmocore logging is properly disabled for builds Change-Id: I169a059d8daff0a3993318a4ea3ab7adcb05fee3 2026-03-12 20:15:38 +0000b72e2a90bf8951c1412bf64b9c0ea58738c42f33ensure libosmocore logging is properly disabled for buildseditsysmoOCTSIM/gcc/Makefileccid_common/ccid_device.ce9b2b3ddc9ae326fc3b866e8d6c12b4859951b301773346669000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgccid: generate proper error for short messages Change-Id: I3bf0bebd361666a2f3d0341444415a6f25d2b4bf 2026-03-12 20:17:49 +0000e9b2b3ddc9ae326fc3b866e8d6c12b4859951b30ccid: generate proper error for short messageseditccid_common/ccid_device.csysmoOCTSIM/main.c639db145ed16f59a3a1cee72dde4dfef32f3d5451773346669000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgfirmware: fix msgb/list mixed irq access handling This fixes the mishandling of in_progress and the queues in the submit functions that are in part irq driven, too, and ensures nothing breaks by preventing concurrent access from irqs to the queues. Applying the same pattern to all functions/cases is fine either way. On top of all of tha the out ep was irq driven, so if submit_next_out fails it was stuck, now fixed by attempted submit from main loop, and of course the queue manipulation should be irq safe here as well. Change-Id: I9212bfa7688cb4d3161ba963b854225744128632 2026-03-12 20:17:49 +0000639db145ed16f59a3a1cee72dde4dfef32f3d545firmware: fix msgb/list mixed irq access handlingeditsysmoOCTSIM/main.csysmoOCTSIM/libosmo_emb.hsysmoOCTSIM/libosmo_emb.c2e49ae297ea4669f5d8359165845101ef4d40b441774546264000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defirmware: add tear-free 64bit load/store helpers for jiffies On Cortex-M4 a 64bit load may compile to two separate LDR instructions which can lead to torn reads due to interrupts. LDRD/STRD are restartable, they either complete or restart from scratch, so the result is always consistent. The only "downside" is the required alignment, which is fine. Change-Id: I729c0fdfb5b228b03c2df1cf098743100b1ea625 2026-03-26 18:31:04 +01002e49ae297ea4669f5d8359165845101ef4d40b44firmware: add tear-free 64bit load/store helpers for jiffieseditsysmoOCTSIM/libosmo_emb.caddsysmoOCTSIM/libosmo_emb.h.checkpatch.confccid_common/iso7816_fsm.cccid_common/ccid_slot_fsm.csysmoOCTSIM/main.cccid_common/cuart.hccid_host/Makefileccid_host/libosmo_emb.cccid_common/cuart.cccid_host/libosmo_emb.h7ae9a65c7fadf3d9d89370761c7352cbcac83a001774641259000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defirmware: replace libosmocore fsm timers Concurrent access from main loop and the different uart irqs was not going well and caused crashes. The libosmocore fsm does still allocate one internal timer, but it is not used by the firmware, so libosmocore will not touch the rbtree. Additionally ignore checkpatch jiffies complaints because we're trying to do firmware here. Closes: SYS#7877 Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd 2026-03-27 20:54:19 +01007ae9a65c7fadf3d9d89370761c7352cbcac83a00firmware: replace libosmocore fsm timerseditccid_common/cuart.hedit.checkpatch.confeditccid_common/iso7816_fsm.ceditccid_host/Makefileaddccid_host/libosmo_emb.ceditccid_common/ccid_slot_fsm.ceditsysmoOCTSIM/main.ceditccid_common/cuart.caddccid_host/libosmo_emb.hsysmoOCTSIM/libosmo_emb.c5a7093d0ce26d8d316ea4156712c83104a68d4c51774879326000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defirmware: fix timers, add missing return Change-Id: I5b12284c88d8fe6e4fe55cc4cd2aad550d276af4 2026-03-30 16:02:06 +02005a7093d0ce26d8d316ea4156712c83104a68d4c5firmware: fix timers, add missing returneditsysmoOCTSIM/libosmo_emb.csysmoOCTSIM/gcc/Makefile116df678f9a7887c828e5744d1fab9399c8ef6d31774879673000https://jenkins.osmocom.org/jenkins/user/ewildewildewild@sysmocom.defirmware: werror on missing return Silently ignoring a missing return just broke all timers, so prevent similar mistakes in the future. Change-Id: I2e25884077af6334c9e9ddace3900b04061fae04 2026-03-30 16:07:53 +0200116df678f9a7887c828e5744d1fab9399c8ef6d3firmware: werror on missing returneditsysmoOCTSIM/gcc/Makefilecontrib/jenkins.shbe7b3124f870855c64815849d5271d80703bf2931775123067000https://jenkins.osmocom.org/jenkins/user/osmithOliver Smithosmith@sysmocom.decontrib/jenkins: add SKIP_FIRMWARE_CLEAN argument If this is set, then don't clean the firmware at the end. This is needed to store the built firmware as artifact in jenkins, for passing it along to another job. Related: SYS#7963 Change-Id: I9e2342b8111645ef5d3b7bf4ac364ca592aa600b 2026-04-02 11:44:27 +0200be7b3124f870855c64815849d5271d80703bf293contrib/jenkins: add SKIP_FIRMWARE_CLEAN argumenteditcontrib/jenkins.shgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyhttps://jenkins.osmocom.org/jenkins/user/ewildewildhttps://jenkins.osmocom.org/jenkins/user/osmithOliver Smithhttps://jenkins.osmocom.org/jenkins/user/lynxislynxishttps://jenkins.osmocom.org/jenkins/user/laforgelaforge2415https://jenkins.osmocom.org/jenkins/view/OsmocomBB/job/master-osmo-ccid-firmware/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/2415/