{ "_class" : "hudson.matrix.MatrixBuild", "actions" : [ { "_class" : "hudson.model.ParametersAction", "parameters" : [ { "_class" : "hudson.model.StringParameterValue", "name" : "BRANCH", "value" : "osmith/wip" }, { "_class" : "hudson.model.StringParameterValue", "name" : "EMAIL_NOTIFICATIONS", "value" : "" } ] }, { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "hudson.model.Cause$UserIdCause", "shortDescription" : "Started by user Oliver Smith", "userId" : "osmith", "userName" : "Oliver Smith" } ] }, { "_class" : "jenkins.metrics.impl.TimeInQueueAction", "blockedDurationMillis" : 0, "blockedTimeMillis" : 0, "buildableDurationMillis" : 0, "buildableTimeMillis" : 0, "buildingDurationMillis" : 64211, "executingTimeMillis" : 64211, "executorUtilization" : 1.0, "subTaskCount" : 0, "waitingDurationMillis" : 0, "waitingTimeMillis" : 0 }, { }, { "_class" : "hudson.plugins.git.util.BuildData", "buildsByBranchName" : { "origin/master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 7773, "buildResult" : None, "marked" : { "SHA1" : "37e216a8eba7fa8ed2f36bd5bb8ea8dbe14bb0ba", "branch" : [ { "SHA1" : "37e216a8eba7fa8ed2f36bd5bb8ea8dbe14bb0ba", "name" : "origin/master" } ] }, "revision" : { "SHA1" : "37e216a8eba7fa8ed2f36bd5bb8ea8dbe14bb0ba", "branch" : [ { "SHA1" : "37e216a8eba7fa8ed2f36bd5bb8ea8dbe14bb0ba", "name" : "origin/master" } ] } }, "refs/remotes/origin/osmith/wip" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 7774, "buildResult" : None, "marked" : { "SHA1" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "branch" : [ { "SHA1" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "name" : "refs/remotes/origin/osmith/wip" } ] }, "revision" : { "SHA1" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "branch" : [ { "SHA1" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "name" : "refs/remotes/origin/osmith/wip" } ] } }, "refs/remotes/origin/master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 5174, "buildResult" : None, "marked" : { "SHA1" : "13fe9ccf55a4758e3de115c0a562f8746eaeae53", "branch" : [ { "SHA1" : "13fe9ccf55a4758e3de115c0a562f8746eaeae53", "name" : "refs/remotes/origin/master" } ] }, "revision" : { "SHA1" : "13fe9ccf55a4758e3de115c0a562f8746eaeae53", "branch" : [ { "SHA1" : "13fe9ccf55a4758e3de115c0a562f8746eaeae53", "name" : "refs/remotes/origin/master" } ] } } }, "lastBuiltRevision" : { "SHA1" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "branch" : [ { "SHA1" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "name" : "refs/remotes/origin/osmith/wip" } ] }, "remoteUrls" : [ "https://gerrit.osmocom.org/osmocom-bb" ], "scmName" : "" }, { }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" } ], "artifacts" : [ ], "building" : False, "description" : None, "displayName" : "#7774", "duration" : 64211, "estimatedDuration" : 105749, "executor" : None, "fullDisplayName" : "master-osmocom-bb #7774", "id" : "7774", "inProgress" : False, "keepLog" : False, "number" : 7774, "queueId" : 2006062, "result" : "FAILURE", "timestamp" : 1759241820303, "url" : "https://jenkins.osmocom.org/jenkins/view/SDR/job/master-osmocom-bb/7774/", "builtOn" : "", "changeSet" : { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/sched_lchan_desc.c", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_rach.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_trx.c", "src/host/trxcon/src/trx_if.c", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "616949a0bec09f566abdff62610aa85c1e32de02", "timestamp" : 1678266191000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: use 3GPP TS 45.002 definitions from libosmogsm\u000a\u000aChange-Id: Ieb3b502e1e5432e425a55c1217211b77e9ca91c9\u000aDepends: libosmocore.git I1c38ccc2b64ba9046bb3b1221d99cc55ec493802\u000a", "date" : "2023-03-08 09:03:11 +0000", "id" : "616949a0bec09f566abdff62610aa85c1e32de02", "msg" : "trxcon: use 3GPP TS 45.002 definitions from libosmogsm", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trx_if.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_rach.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_desc.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trx_if.c" ], "commitId" : "6fe33fd6d43bf51da18ffa9ec9b2a944cd3e16de", "timestamp" : 1678266191000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: do not crash on receipt of 8-PSK modulated bursts\u000a\u000aTRXDv0 PDUs may have 2 additional dummy bytes at the end. Such\u000aa PDU will crash trxcon if it contains an 8-PSK modulated burst:\u000a\u000a Assert failed phybi->burst_len <= sizeof(bi.burst)\u000a\u000aIn this case phybi->burst_len would be 444 + 2, while size of the\u000aburst buffer in struct l1sched_burst_ind is limited to the length\u000aof an 8-PSK modulated burst (444).\u000a\u000aChange-Id: Icfba986ccf0c696ba019b91575b4d69db001c14f\u000a", "date" : "2023-03-08 09:03:11 +0000", "id" : "6fe33fd6d43bf51da18ffa9ec9b2a944cd3e16de", "msg" : "trxcon: do not crash on receipt of 8-PSK modulated bursts", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trx_if.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/main.c", "src/host/layer23/include/osmocom/bb/common/l23_app.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "736438693e4f2b6b1a4959a6cadeafa61640821d", "timestamp" : 1678297624000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/msuraev", "fullName" : "msuraev" }, "authorEmail" : "msuraev@sysmocom.de", "comment" : "mobile: allow configuring local GSMTAP address\u000a\u000aChange-Id: Ia1555db653cf0bb20af74617f33aad31c971bfdb\u000a", "date" : "2023-03-08 17:47:04 +0000", "id" : "736438693e4f2b6b1a4959a6cadeafa61640821d", "msg" : "mobile: allow configuring local GSMTAP address", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/l23_app.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/vty.c" ], "commitId" : "22f12ba92e6f37c569dba13a4ebb214c2d2d5f58", "timestamp" : 1678302307000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/max", "fullName" : "Max" }, "authorEmail" : "msuraev@sysmocom.de", "comment" : "vty: fix local-host docs\u000a\u000aChange-Id: I69d0fa32105a3d114cdcae84ef2cc3ada578f13a\u000a", "date" : "2023-03-08 22:05:07 +0300", "id" : "22f12ba92e6f37c569dba13a4ebb214c2d2d5f58", "msg" : "vty: fix local-host docs", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/l1ctl_proto.h", "src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_proto.h", "src/host/trxcon/include/osmocom/bb/trxcon/Makefile.am", "src/host/trxcon/src/l1ctl.c", "src/host/trxcon/include/osmocom/bb/Makefile.am" ], "commitId" : "5adc13d69db03b594958244726ed1ab1f1f82481", "timestamp" : 1678309887000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: move l1ctl_proto.h to 'include/osmocom/bb/'\u000a\u000aThe upcoming l1gprs library will be using this header too.\u000a\u000aChange-Id: I2101b20637f837038115497873bd905f95a3d0c2\u000a", "date" : "2023-03-08 21:11:27 +0000", "id" : "5adc13d69db03b594958244726ed1ab1f1f82481", "msg" : "trxcon: move l1ctl_proto.h to 'include/osmocom/bb/'", "paths" : [ { "editType" : "add", "file" : "src/host/trxcon/include/osmocom/bb/l1ctl_proto.h" }, { "editType" : "delete", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_proto.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/l1ctl.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/Makefile.am" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/Makefile.am" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/gprsdecode/Makefile.am" ], "commitId" : "c43d4183f514bbbe200048f07d75a5cad79bae55", "timestamp" : 1678650754000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "gprsdecode: Makefile.am: drop -Wno-missing-braces and -O3\u000a\u000aDo not hard-code these CFLAGs, let the user decide on them.\u000a\u000aChange-Id: I3a946b853029cc4cff9c2b15aa7339f84b2cb6c9\u000a", "date" : "2023-03-13 02:52:34 +0700", "id" : "c43d4183f514bbbe200048f07d75a5cad79bae55", "msg" : "gprsdecode: Makefile.am: drop -Wno-missing-braces and -O3", "paths" : [ { "editType" : "edit", "file" : "src/host/gprsdecode/Makefile.am" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/common/apn.c", "src/host/layer23/src/misc/app_cbch_sniff.c", "src/host/layer23/include/osmocom/bb/common/l23_app.h", "src/host/layer23/src/misc/app_bcch_scan.c", "src/host/layer23/src/mobile/main.c", "src/host/layer23/src/misc/app_cell_log.c", "src/host/layer23/src/misc/app_echo_test.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/common/main.c", "src/host/layer23/src/misc/app_ccch_scan.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "9feb5057da41611033a5881409c4fef2628d98a9", "timestamp" : 1678663008000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: refactor the application API concept\u000a\u000aWith this set of changes we have a cleaner l23 app architecture:\u000a\u000a* struct vty_app_info: all l23 applications must define this struct;\u000a* struct vty_app_info: *cfg_supported() becomes a mask of L23_OPT_*;\u000a* struct vty_app_info: explicitly set L23_OPT_* in all l23 apps;\u000a* drop l23_app_info(), there can be only one vty_app_info per an app;\u000a\u000aIt's no more needed to obtain the vty_app_info by calling a function\u000aand checking the returned value against NULL everywhere. This kind\u000aof information is rather static (not dynamically composed) and needs\u000anot to be encapsulated into functions.\u000a\u000aChange-Id: I89004cd5308927305f79b102f7b695709148df6d\u000a", "date" : "2023-03-13 06:16:48 +0700", "id" : "9feb5057da41611033a5881409c4fef2628d98a9", "msg" : "layer23: refactor the application API concept", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/apn.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/app_ccch_scan.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/app_cbch_sniff.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/l23_app.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/app_cell_log.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/app_bcch_scan.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/app_echo_test.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/main.c", "src/host/layer23/src/common/main.c" ], "commitId" : "67943df4b7e59ef4982b586271566099c2f14d4a", "timestamp" : 1678663082000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: fix parsing of command line options\u000a\u000aAfter the recent refactoring, parsing of the command line options is\u000abroken for some arguments. Specifically, the value of '-a'/'--arfcn'\u000ais ignored and hard-coded ARFCN=871 is used instead.\u000a\u000aThe problem is that l23_app_init(), which allocates an MS state and\u000asets the initial ARFCN, is called *before* handle_options(). So the\u000acfg_test_arfcn is used before it gets overwritten from the argv[].\u000a\u000aThe usual approach in osmo-* apps is to parse the command line\u000aarguments first, and only then execute code which depends on\u000aconfigurable parameters. Let's follow this approach too.\u000a\u000aChange-Id: I77ca11c14561fa3fcb9add60ccea5b0b847a20c4\u000a", "date" : "2023-03-13 06:18:02 +0700", "id" : "67943df4b7e59ef4982b586271566099c2f14d4a", "msg" : "layer23: fix parsing of command line options", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trxcon_shim.c" ], "commitId" : "38ef3280d2be5c1451202cc09f0c0ca5c23b4ced", "timestamp" : 1678743825000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: do not send DATA.cnf for L1SCHED_DT_TRAFFIC\u000a\u000aThe event TRXCON_EV_TX_DATA_CNF is not premitted in state\u000aTRXCON_ST_PACKET_DATA, and is not of any use for l1gprs.\u000a\u000aChange-Id: Iee5ee404f1eb77091c388a641d0a78d01a8d7e7f\u000aRelated: OS#5500\u000a", "date" : "2023-03-13 21:43:45 +0000", "id" : "38ef3280d2be5c1451202cc09f0c0ca5c23b4ced", "msg" : "trxcon: do not send DATA.cnf for L1SCHED_DT_TRAFFIC", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_shim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/include/virtphy/l1ctl_sap.h", "src/host/virt_phy/src/virt_prim_rach.c", "src/host/virt_phy/include/virtphy/virt_l1_model.h", "src/host/virt_phy/include/virtphy/virtual_um.h", "src/host/virt_phy/src/virt_prim_data.c", "src/host/virt_phy/include/osmocom/bb/virtphy/virtual_um.h", "src/host/virt_phy/include/osmocom/bb/virtphy/common_util.h", "src/host/virt_phy/include/virtphy/common_util.h", "src/host/virt_phy/include/osmocom/bb/l1ctl_proto.h", "src/host/virt_phy/include/osmocom/bb/virtphy/virt_l1_model.h", "src/host/virt_phy/src/logging.c", "src/host/virt_phy/include/osmocom/bb/virtphy/virt_l1_sched.h", "src/host/virt_phy/include/Makefile.am", "src/host/virt_phy/include/osmocom/bb/virtphy/osmo_mcast_sock.h", "src/host/virt_phy/src/virt_prim_pm.c", "src/host/virt_phy/include/osmocom/Makefile.am", "src/host/virt_phy/src/l1ctl_sock.c", "src/host/virt_phy/src/l1ctl_sap.c", "src/host/virt_phy/src/virt_prim_fbsb.c", "src/host/virt_phy/src/shared/virtual_um.c", "src/host/virt_phy/src/virt_l1_sched_simple.c", "src/host/virt_phy/include/virtphy/logging.h", "src/host/virt_phy/include/osmocom/bb/virtphy/Makefile.am", "src/host/virt_phy/include/osmocom/bb/virtphy/logging.h", "src/host/virt_phy/src/virt_l1_model.c", "src/host/virt_phy/src/virtphy.c", "src/host/virt_phy/include/virtphy/osmo_mcast_sock.h", "src/host/virt_phy/configure.ac", "src/host/virt_phy/include/osmocom/bb/virtphy/gsmtapl1_if.h", "src/host/virt_phy/include/virtphy/virt_l1_sched.h", "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h", "src/host/virt_phy/src/virt_prim_traffic.c", "src/host/virt_phy/include/virtphy/l1ctl_sock.h", "src/host/virt_phy/include/virtphy/l1ctl_proto.h", "src/host/virt_phy/include/virtphy/gsmtapl1_if.h", "src/host/virt_phy/src/gsmtapl1_if.c", "src/host/virt_phy/src/shared/osmo_mcast_sock.c", "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sock.h", "src/host/virt_phy/include/osmocom/bb/Makefile.am" ], "commitId" : "0b51656c06c58f53d7b27ad02de2831858cf31a7", "timestamp" : 1678743825000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: rearrange and clean up header files\u000a\u000a* Build up the usual include directory hierarchy.\u000a* Move l1ctl_proto.h to 'include/osmocom/bb/'.\u000a* System headers first, then libosmo*, the local ones.\u000a\u000aChange-Id: I25145630ec53c2b8065a42fb12a778eec010f10c\u000aRelated: OS#5500\u000a", "date" : "2023-03-13 21:43:45 +0000", "id" : "0b51656c06c58f53d7b27ad02de2831858cf31a7", "msg" : "virt_phy: rearrange and clean up header files", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_rach.c" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/Makefile.am" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/gsmtapl1_if.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/shared/virtual_um.c" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/Makefile.am" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_l1_sched_simple.c" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/virtual_um.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_pm.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_traffic.c" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/gsmtapl1_if.h" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/osmo_mcast_sock.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/shared/osmo_mcast_sock.c" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/virt_l1_sched.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/logging.c" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/virt_l1_sched.h" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/logging.h" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sock.h" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/l1ctl_proto.h" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/common_util.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_fbsb.c" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/osmo_mcast_sock.h" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/l1ctl_sock.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virtphy.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/gsmtapl1_if.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_l1_model.c" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/common_util.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_data.c" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/Makefile.am" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/l1ctl_sap.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/l1ctl_sock.c" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/logging.h" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/virt_l1_model.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/l1ctl_sap.c" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/virtual_um.h" }, { "editType" : "delete", "file" : "src/host/virt_phy/include/virtphy/l1ctl_proto.h" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/virt_l1_model.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/Makefile.am" }, { "editType" : "edit", "file" : "src/host/virt_phy/configure.ac" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/Makefile.am" ], "commitId" : "0504bd028e50d1b04af7eacf77bd593defcdae54", "timestamp" : 1678743825000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: clean up and improve Makefile.am\u000a\u000a* Make virtphy_{SOURCES,LDADD} git-friendly: one file per line;\u000a* Remove '-pthread' from LDADD, it's not really needed;\u000a* Remove debugging leftovers.\u000a\u000aChange-Id: Iccd07614aabfc2845424d25962f48e4231a50a90\u000aRelated: OS#5500\u000a", "date" : "2023-03-13 21:43:45 +0000", "id" : "0504bd028e50d1b04af7eacf77bd593defcdae54", "msg" : "virt_phy: clean up and improve Makefile.am", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/Makefile.am" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/logging.c", "src/host/virt_phy/src/virt_prim_data.c", "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" ], "commitId" : "20ee798ffdc239dc77d0478852d171825a2b9b18", "timestamp" : 1678743825000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: cosmetic: make the linter happy about code indent\u000a\u000aChange-Id: Iba777a4aff261006ae1aec9b583fecd12295c837\u000aRelated: OS#5500\u000a", "date" : "2023-03-13 21:43:45 +0000", "id" : "20ee798ffdc239dc77d0478852d171825a2b9b18", "msg" : "virt_phy: cosmetic: make the linter happy about code indent", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/logging.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_data.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" ], "commitId" : "4b859aae59102a20a5296db2039712a48239d11c", "timestamp" : 1678743825000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: cosmetic: make the linter happy about identifier names\u000a\u000aChange-Id: I415f4b6f65c16a5dac84c75c5f97bf12109c74e5\u000aRelated: OS#5500\u000a", "date" : "2023-03-13 21:43:45 +0000", "id" : "4b859aae59102a20a5296db2039712a48239d11c", "msg" : "virt_phy: cosmetic: make the linter happy about identifier names", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_traffic.c", "src/host/virt_phy/src/gsmtapl1_if.c", "src/host/virt_phy/src/virt_prim_data.c", "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" ], "commitId" : "94bfc1d051bc6ad8d9733ad2b8874cdefbd89220", "timestamp" : 1678743825000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63)\u000a\u000aChange-Id: I4f2982cd8fa1b7a47f983c9cd11bf0180f7878ec\u000aRelated: OS#5500\u000a", "date" : "2023-03-13 21:43:45 +0000", "id" : "94bfc1d051bc6ad8d9733ad2b8874cdefbd89220", "msg" : "virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63)", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_data.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/gsmtapl1_if.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_traffic.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c" ], "commitId" : "7f9c01f00f89b00fd1d52e41fdb757792ed78e81", "timestamp" : 1678794669000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: get rid of app_data.{ccch_mode,si}, use ms->cellsel\u000a\u000aChange-Id: Ib711a3b893c43c0875c431c90cd0a2ebfafe1926\u000aRelated: OS#5500\u000a", "date" : "2023-03-14 18:51:09 +0700", "id" : "7f9c01f00f89b00fd1d52e41fdb757792ed78e81", "msg" : "modem: get rid of app_data.{ccch_mode,si}, use ms->cellsel", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c" ], "commitId" : "6db5f8b9ce2823e0305b55feb2e3a407bfb55447", "timestamp" : 1678794669000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: get rid of app_data.chan_req, use ms->rrlayer\u000a\u000aChange-Id: I77d0a834a73c511f157c6f1524b9e98df3f4def4\u000aRelated: OS#5500\u000a", "date" : "2023-03-14 18:51:09 +0700", "id" : "6db5f8b9ce2823e0305b55feb2e3a407bfb55447", "msg" : "modem: get rid of app_data.chan_req, use ms->rrlayer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sap_interface.c", "src/host/layer23/src/mobile/mncc_sock.c", "src/host/layer23/src/common/l1l2_interface.c" ], "commitId" : "b8c3bef7376fab28d2f71406e4b4e9c3fcddfcf0", "timestamp" : 1678796256000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Call osmo_fd_unregister() before closing and changing bfd->fd\u000a\u000aChange-Id: I886062c1a944acf0982755a7acddf7e2233d13a8\u000a", "date" : "2023-03-14 12:17:36 +0000", "id" : "b8c3bef7376fab28d2f71406e4b4e9c3fcddfcf0", "msg" : "layer23: Call osmo_fd_unregister() before closing and changing bfd->fd", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/sap_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mncc_sock.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/l1l2_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/Makefile.am", "src/host/layer23/include/osmocom/bb/modem/grr.h", "src/host/layer23/include/osmocom/bb/modem/Makefile.am" ], "commitId" : "8240ef74fc386fd95ca0b669e99ee7d0041d2b83", "timestamp" : 1678806386000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: move GRR specific code into its own file\u000a\u000aChange-Id: I25caa0bd01e3d090803512f5b13cad58439f44f8\u000aRelated: OS#5500\u000a", "date" : "2023-03-14 15:06:26 +0000", "id" : "8240ef74fc386fd95ca0b669e99ee7d0041d2b83", "msg" : "modem: move GRR specific code into its own file", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/Makefile.am" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/Makefile.am" }, { "editType" : "add", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "add", "file" : "src/host/layer23/include/osmocom/bb/modem/grr.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/llc.c", "src/host/layer23/src/modem/rlcmac.c", "src/host/layer23/src/modem/sndcp.c" ], "commitId" : "7ea900525cbeed2ad74d866f977f21273ba3afdf", "timestamp" : 1678806386000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: clean up #includes (using include-what-you-use)\u000a\u000aChange-Id: I728f3eea1590f46bef6e0eb4beb9714f6c9a1614\u000a", "date" : "2023-03-14 15:06:26 +0000", "id" : "7ea900525cbeed2ad74d866f977f21273ba3afdf", "msg" : "modem: clean up #includes (using include-what-you-use)", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/llc.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/Makefile.am", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/include/osmocom/bb/common/logging.h", "src/host/layer23/include/osmocom/bb/modem/Makefile.am", "src/host/layer23/include/osmocom/bb/modem/gmm.h", "src/host/layer23/configure.ac" ], "commitId" : "1612c8f8627fbb005e478e880526262eb13724a2", "timestamp" : 1678891134000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Depend on libosmo-gprs-gmm\u000a\u000aRelated: OS#5501\u000aChange-Id: I82a2b9c043eae42435ca781689fc3381e7a31bea\u000a", "date" : "2023-03-15 15:38:54 +0100", "id" : "1612c8f8627fbb005e478e880526262eb13724a2", "msg" : "layer23: modem: Depend on libosmo-gprs-gmm", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/configure.ac" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/logging.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/Makefile.am" }, { "editType" : "add", "file" : "src/host/layer23/include/osmocom/bb/modem/gmm.h" }, { "editType" : "add", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/Makefile.am" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/modem/grr.c", "src/host/layer23/include/osmocom/bb/modem/grr.h" ], "commitId" : "b29a26c6205d3080f21dc15e4f27c967454fb01d", "timestamp" : 1678974413000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: add test VTY command to send CHANNEL REQUEST\u000a\u000aDo not call grr_tx_chan_req() unconditionally from grr_rx_bcch().\u000aAdd a special (hidden, expert mode) VTY command for that.\u000a\u000aChange-Id: I049a8d7f58ae9703d06dff235973ba376702c873\u000aRelated: OS#5500\u000a", "date" : "2023-03-16 13:46:53 +0000", "id" : "b29a26c6205d3080f21dc15e4f27c967454fb01d", "msg" : "modem: add test VTY command to send CHANNEL REQUEST", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/grr.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c" ], "commitId" : "42ca40dd1e9746bab5fac92c1b08eeb7f7d0895a", "timestamp" : 1678974426000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: add test VTY command for sending raw LLC PDUs\u000a\u000aChange-Id: I14f58e715d77a1b1cb40fdd3ddd09084360f2274\u000aRelated: OS#5500\u000a", "date" : "2023-03-16 13:47:06 +0000", "id" : "42ca40dd1e9746bab5fac92c1b08eeb7f7d0895a", "msg" : "modem: add test VTY command for sending raw LLC PDUs", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/include/osmocom/bb/common/l23_app.h", "src/host/layer23/src/common/main.c", "src/host/layer23/src/mobile/main.c" ], "commitId" : "b2dfbb88591395135a494c048cac5c93865720de", "timestamp" : 1679010108000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23/{mobile,modem}: fix segfault on VTY connection\u000a\u000aIt was a mistake to call vty_init(), passing it a pointer to the\u000avty_app_info structure allocated on the stack, because it gets\u000aoverwritten when the calling function _vty_init() returns.\u000a\u000aChange-Id: I75843a964254243c70bedcf8ff97d854107ee21a\u000aFixes: 9feb5057 \"layer23: refactor the application API concept\"\u000a", "date" : "2023-03-16 23:41:48 +0000", "id" : "b2dfbb88591395135a494c048cac5c93865720de", "msg" : "layer23/{mobile,modem}: fix segfault on VTY connection", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/l23_app.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/mobile/app_mobile.c" ], "commitId" : "4949ab7471370bf2d3b63e74c6846340dc638d06", "timestamp" : 1679044308000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23/{mobile,modem}: prefix VTY prompt with project's name\u000a\u000aChange-Id: If7ce89362c75e2c15995dfb08cfcfdcad24e2529\u000a", "date" : "2023-03-17 16:11:48 +0700", "id" : "4949ab7471370bf2d3b63e74c6846340dc638d06", "msg" : "layer23/{mobile,modem}: prefix VTY prompt with project's name", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "e15996378f102b801868f5e5edd687ba9c72c69b", "timestamp" : 1679044860000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: fix modem_gmm_prim_up_cb(): add missing break\u000a\u000aChange-Id: Ibd16232d76d83d90f27d08b47aa38509161270b6\u000aFixes: CID#311019\u000a", "date" : "2023-03-17 16:21:00 +0700", "id" : "e15996378f102b801868f5e5edd687ba9c72c69b", "msg" : "modem: fix modem_gmm_prim_up_cb(): add missing break", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trxcon_inst.c", "src/host/trxcon/include/osmocom/bb/trxcon/logging.h", "src/host/trxcon/src/l1ctl.c", "src/host/trxcon/include/osmocom/bb/l1gprs.h", "src/host/virt_phy/include/osmocom/bb/virtphy/virt_l1_model.h", "src/host/virt_phy/src/logging.c", "include/l1gprs.h", "src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h", "src/host/virt_phy/src/l1ctl_sap.c", "src/host/trxcon/src/l1gprs.c", "src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h", "src/host/virt_phy/src/Makefile.am", "src/host/trxcon/src/Makefile.am", "src/host/trxcon/include/osmocom/bb/Makefile.am", "src/host/trxcon/src/trxcon_fsm.c", "src/host/virt_phy/include/osmocom/bb/virtphy/logging.h", "src/host/virt_phy/src/virtphy.c", "include/l1ctl_proto.h", "src/shared/l1gprs.c", "src/host/virt_phy/src/l1gprs.c", "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h", "src/host/trxcon/src/logging.c", "src/host/virt_phy/src/gsmtapl1_if.c", "src/host/virt_phy/include/osmocom/bb/l1gprs.h", "src/host/virt_phy/src/virt_prim_pdch.c", "src/host/virt_phy/include/osmocom/bb/Makefile.am" ], "commitId" : "2b462dd89db851148c154e30f570a1d2ea4c6567", "timestamp" : 1679055329000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "{trxcon,virt_phy}: shared GPRS L1 (MAC) implementation\u000a\u000aChange-Id: I9567d64f9d00262e36147e8d7e541e5e246bda5f\u000aRelated: OS#5500\u000a", "date" : "2023-03-17 12:15:29 +0000", "id" : "2b462dd89db851148c154e30f570a1d2ea4c6567", "msg" : "{trxcon,virt_phy}: shared GPRS L1 (MAC) implementation", "paths" : [ { "editType" : "add", "file" : "src/host/trxcon/include/osmocom/bb/l1gprs.h" }, { "editType" : "add", "file" : "src/host/virt_phy/src/virt_prim_pdch.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/virt_l1_model.h" }, { "editType" : "add", "file" : "src/host/virt_phy/src/l1gprs.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/logging.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/Makefile.am" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/gsmtapl1_if.c" }, { "editType" : "add", "file" : "src/shared/l1gprs.c" }, { "editType" : "edit", "file" : "include/l1ctl_proto.h" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/l1ctl_sap.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/Makefile.am" }, { "editType" : "add", "file" : "include/l1gprs.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/logging.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/l1ctl.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virtphy.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/logging.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" }, { "editType" : "add", "file" : "src/host/virt_phy/include/osmocom/bb/l1gprs.h" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_inst.c" }, { "editType" : "add", "file" : "src/host/trxcon/src/l1gprs.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/logging.h" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/Makefile.am" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/Makefile.am" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/ms.h", "src/host/layer23/include/osmocom/bb/common/l1ctl.h", "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "bb6df124d20b48d85b2e94683011d2c0525f2848", "timestamp" : 1679055329000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: implement Rx/Tx API for GPRS related messages\u000a\u000aChange-Id: I87950e893ef96ff8328f43f1548111aa9f66439b\u000aRelated: OS#5500\u000a", "date" : "2023-03-17 12:15:29 +0000", "id" : "bb6df124d20b48d85b2e94683011d2c0525f2848", "msg" : "layer23: implement Rx/Tx API for GPRS related messages", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/l1ctl.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/rlcmac.c" ], "commitId" : "3b582af2eb05071961ef1c8b77b4210c2335f4d1", "timestamp" : 1679055329000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: route L1CTL prims to/from libosmo-gprs-rlcmac\u000a\u000aChange-Id: I38e9a686f8edc3fe55f961d75e68602c33bbbaaf\u000aRelated: OS#5500\u000a", "date" : "2023-03-17 12:15:29 +0000", "id" : "3b582af2eb05071961ef1c8b77b4210c2335f4d1", "msg" : "modem: route L1CTL prims to/from libosmo-gprs-rlcmac", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "include/l1ctl_proto.h" ], "commitId" : "080310982df4629f569aa6bcdb7a8f32b5d7b9e1", "timestamp" : 1679136227000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "l1ctl_proto: fix unpacked struct in l1ctl_gprs_dl_block_ind\u000a\u000aThe __attribute__((packed)) does not apply to inner structures.\u000aI found this problem when testing the new TTCN-3 message definitions.\u000a\u000aChange-Id: I90e74330073a9090c2638fc3175ff0216b0da5ec\u000aRelated: OS#5500\u000a", "date" : "2023-03-18 17:43:47 +0700", "id" : "080310982df4629f569aa6bcdb7a8f32b5d7b9e1", "msg" : "l1ctl_proto: fix unpacked struct in l1ctl_gprs_dl_block_ind", "paths" : [ { "editType" : "edit", "file" : "include/l1ctl_proto.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c" ], "commitId" : "590a62a961025a21be7a55539b2f9ddae83ed38c", "timestamp" : 1679144704000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()\u000a\u000aChange-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce\u000aRelated: CID#311449\u000a", "date" : "2023-03-18 20:05:04 +0700", "id" : "590a62a961025a21be7a55539b2f9ddae83ed38c", "msg" : "l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/modem/llc.c", "src/host/layer23/src/modem/gmm.c" ], "commitId" : "e8a3ad221648623dcb6f394cee407bc7cd2a3980", "timestamp" : 1679583013000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Test GMM layer through VTY\u000a\u000aRecent work on libosmo-gprs-gmm already allows triggering GPRS Attach\u000aprocedure. Let's add some code to use it so we can already test the\u000aentire stack GMM->LLC->RLCMAC (SM layer still missing).\u000a\u000aDepends: libosmo-gprs.git Change-Id I212053b3a3f27ef7d63503c3d5ef08453b2d2056\u000aRelated: OS#5501\u000aChange-Id: Iba0663075468670a29aceafe5196cae3cab050eb\u000a", "date" : "2023-03-23 15:50:13 +0100", "id" : "e8a3ad221648623dcb6f394cee407bc7cd2a3980", "msg" : "layer23: modem: Test GMM layer through VTY", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/llc.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/logging.c" ], "commitId" : "848b859f302101dde3527b8f55dd6a451b9923b1", "timestamp" : 1679699059000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: add missing log_info_cat[] entry for DGMM\u000a\u000aChange-Id: Icdc09b6edce7abb3ff88f12650d3b304447d39a6\u000aFixes: 1612c8f86 \"layer23: modem: Depend on libosmo-gprs-gmm\"\u000aRelated: OS#5501\u000a", "date" : "2023-03-25 06:04:19 +0700", "id" : "848b859f302101dde3527b8f55dd6a451b9923b1", "msg" : "layer23: add missing log_info_cat[] entry for DGMM", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/logging.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/rlcmac.c" ], "commitId" : "d692e6ca9c7b5ceada0aa129a8a7c1f0aedd97b7", "timestamp" : 1679699059000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: set logging cat for OSMO_GPRS_RLCMAC_LOGC_TBF{UL,DL}\u000a\u000a... otherwise the library will be using default DLGLOBAL.\u000a\u000aChange-Id: I98efa4c8137c7ec57da6ef7ea1307b4e46b4fc98\u000aRelated: OS#5500\u000a", "date" : "2023-03-25 06:04:19 +0700", "id" : "d692e6ca9c7b5ceada0aa129a8a7c1f0aedd97b7", "msg" : "modem: set logging cat for OSMO_GPRS_RLCMAC_LOGC_TBF{UL,DL}", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trxcon_main.c" ], "commitId" : "2a4fb973415568b703cdda18bec073a5b8727594", "timestamp" : 1679737595000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: add GSMTAP logging target if '-g' is given\u000a\u000aUnlike the other more mature Osmocom projects, trxcon does not have its\u000aown VTY interface and thus does not support the config file parsing,\u000aso currently it's impossible to configure additional logging targets.\u000a\u000aThere is a command line option '-g', which enables GSMTAP Um logging.\u000aLet's also add a GSMTAP logging target if it's given. This is a quick\u000ahack, but good enough for occasional debugging.\u000a\u000aChange-Id: I2c5e630dd508dff12d0116bdc0a4cc1276cac5ed\u000aRelated: OS#5500\u000a", "date" : "2023-03-25 09:46:35 +0000", "id" : "2a4fb973415568b703cdda18bec073a5b8727594", "msg" : "trxcon: add GSMTAP logging target if '-g' is given", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trxcon_fsm.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" ], "commitId" : "a80957b617eca785e7ab3791952e9e6a6cbb1716", "timestamp" : 1679737595000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: l1sched_prim_dequeue(): check TDMA Fn in PDCH prims\u000a\u000aWe shall never be transmitting Uplink PDCH blocks if the current\u000aTDMA Fn does not match the requested TDMA Fn, because Tx timing\u000ais critical for PDCH timeslots. Drop and log an error message.\u000a\u000aChange-Id: I6b2d9cc93ce266524f56a1b6a97beecfc0ad042d\u000aRelated: OS#5500\u000a", "date" : "2023-03-25 09:46:35 +0000", "id" : "a80957b617eca785e7ab3791952e9e6a6cbb1716", "msg" : "trxcon: l1sched_prim_dequeue(): check TDMA Fn in PDCH prims", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c" ], "commitId" : "574177d2cefb5164e8d60a0a319e3ea65b7893b5", "timestamp" : 1679909020000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: rlcmac: Support GMM detaching from VTY\u000a\u000aRelated: OS#5501\u000aDepends: libosmo-gprs.git Change-Id If6cbb1d425b3a9f713348f1dea4747e2b6be0a44\u000aChange-Id: Idca0bff6fc3e6a16b5e8379eae3315e3af012d78\u000a", "date" : "2023-03-27 11:23:40 +0200", "id" : "574177d2cefb5164e8d60a0a319e3ea65b7893b5", "msg" : "layer23: rlcmac: Support GMM detaching from VTY", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/rlcmac.c", "src/host/layer23/src/modem/gmm.c" ], "commitId" : "3e31b3232d2a964f3a2cbd3f0f67edb36a3306e9", "timestamp" : 1679993960000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers\u000a\u000aRelated: OS#5501\u000aChange-Id: I7603d8bbda0cdd437eb7557267efb7bbc3552565\u000a", "date" : "2023-03-28 10:59:20 +0200", "id" : "3e31b3232d2a964f3a2cbd3f0f67edb36a3306e9", "msg" : "layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c" ], "commitId" : "7b8cc36ad04902fd25104870e7a2d96df92cb7fc", "timestamp" : 1679993963000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: fill imsi & imei in vty 'test gmm attach'\u000a\u000aRelated: OS#5501\u000aChange-Id: If93f7e2cbb421d0aa2702b8e130c8602fbc18a97\u000a", "date" : "2023-03-28 10:59:23 +0200", "id" : "7b8cc36ad04902fd25104870e7a2d96df92cb7fc", "msg" : "layer23: modem: fill imsi & imei in vty 'test gmm attach'", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/vty.c" ], "commitId" : "79ea13fccc3ba7edf9156c9dc6393c28a6679637", "timestamp" : 1680088097000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Support cpu-sched vty node from libosmocore\u000a\u000aChange-Id: I1affb401bf355360fe306568c9b5c005dbd0746c\u000a", "date" : "2023-03-29 13:08:17 +0200", "id" : "79ea13fccc3ba7edf9156c9dc6393c28a6679637", "msg" : "layer23: Support cpu-sched vty node from libosmocore", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/Makefile.am", "src/host/layer23/include/osmocom/bb/common/logging.h", "src/host/layer23/src/modem/sm.c", "src/host/layer23/include/osmocom/bb/modem/Makefile.am", "src/host/layer23/src/common/logging.c", "src/host/layer23/include/osmocom/bb/modem/sm.h", "src/host/layer23/configure.ac" ], "commitId" : "a89939a68b132aa6a74b2f6fbb249b45d6723a1f", "timestamp" : 1680177170000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "modem: initial SM layer support through libosmo-gprs-sm\u000a\u000aDepends: libosmo-gprs.git Change-Id I9b4a9a6364f7799540475e7e1d10ab2310768281\u000aRelated: OS#5501\u000aChange-Id: I9476d93954c7dc348e6f97ca89eaa651f802f9a0\u000a", "date" : "2023-03-30 13:52:50 +0200", "id" : "a89939a68b132aa6a74b2f6fbb249b45d6723a1f", "msg" : "modem: initial SM layer support through libosmo-gprs-sm", "paths" : [ { "editType" : "add", "file" : "src/host/layer23/include/osmocom/bb/modem/sm.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/logging.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/logging.h" }, { "editType" : "edit", "file" : "src/host/layer23/configure.ac" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/Makefile.am" }, { "editType" : "add", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/Makefile.am" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/llc.c" ], "commitId" : "7035b8095cb027a5fb8b1f839b2b3cca75c8a4e5", "timestamp" : 1680178667000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: llc: Fix typo LLGM -> LLGMM\u000a\u000aDepends: libosmo-gprs.git Change-Id I59577d27bedd26903c9b1bfc64792f0891cea728\u000aChange-Id: I786661894fc6772784ba6f0d2fdb45bbdca5254c\u000a", "date" : "2023-03-30 14:17:47 +0200", "id" : "7035b8095cb027a5fb8b1f839b2b3cca75c8a4e5", "msg" : "layer23: modem: llc: Fix typo LLGM -> LLGMM", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/llc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/l1sched/logging.h" ], "commitId" : "0927643a323435fca012fdcbfdf9b96d9b891ed2", "timestamp" : 1681430045000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: l1sched: fix copy-paste in LOGP_SCHEDD macro\u000a\u000aChange-Id: I256578ae23e2f2d29a2751169c63d7a3df6d6f56\u000aRelated: OS#5500\u000a", "date" : "2023-04-14 06:54:05 +0700", "id" : "0927643a323435fca012fdcbfdf9b96d9b891ed2", "msg" : "trxcon: l1sched: fix copy-paste in LOGP_SCHEDD macro", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/logging.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_rach.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_trx.c", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "e535c0488d6a3261783693096edbe0dcdb9fc598", "timestamp" : 1681430053000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: rename l1sched[_lchan]_prim_drop()\u000a\u000aMake it clear that this function operates on a logical channel.\u000aAlso take a chance to remove redundant comments and ws.\u000a\u000aChange-Id: I0517bba2be5403d437d3879b2332196d872e11f2\u000aRelated: OS#5500\u000a", "date" : "2023-04-14 06:54:13 +0700", "id" : "e535c0488d6a3261783693096edbe0dcdb9fc598", "msg" : "trxcon/l1sched: rename l1sched[_lchan]_prim_drop()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_rach.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_trx.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" ], "commitId" : "bef3f3804402dc923a765a96242b0652525383a9", "timestamp" : 1681430054000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: cosmetic: rename l1sched_find_lchan()\u000a\u000aAn upcoming patch will add a similar function taking chan_nr/link_id\u000aas the search criteria, so let's clarify the existing API first.\u000a\u000aChange-Id: Ib9f733c22d7fc6bd933219906ca680f246b07f4b\u000aRelated: OS#5500\u000a", "date" : "2023-04-14 06:54:14 +0700", "id" : "bef3f3804402dc923a765a96242b0652525383a9", "msg" : "trxcon/l1sched: cosmetic: rename l1sched_find_lchan()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_trx.c" ], "commitId" : "7264fbfa4aa0e1d01e88f363cbba20f13ceaa08f", "timestamp" : 1681472331000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: use RSL_CHAN_NR_MASK from libosmogsm\u000a\u000aChange-Id: Ibec43dcd4acc104ab5f1930112db6fe9aff917a1\u000aRelated: OS#5500\u000a", "date" : "2023-04-14 18:38:51 +0700", "id" : "7264fbfa4aa0e1d01e88f363cbba20f13ceaa08f", "msg" : "trxcon/l1sched: use RSL_CHAN_NR_MASK from libosmogsm", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_trx.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" ], "commitId" : "24c8cd876a13b400ac96f086839dc28219371885", "timestamp" : 1681472388000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: add l1sched_find_lchan_by_chan_nr()\u000a\u000aChange-Id: I9917a932c9a4aeb4b3ef7053bd58066b3aa41edb\u000aRelated: OS#5500\u000a", "date" : "2023-04-14 18:39:48 +0700", "id" : "24c8cd876a13b400ac96f086839dc28219371885", "msg" : "trxcon/l1sched: add l1sched_find_lchan_by_chan_nr()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/sndcp.c" ], "commitId" : "4ba8db561e36112a8acb1f5154685ee079505c36", "timestamp" : 1681490058000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: sndcp: Apply API change in libosmo-gprs-sndcp\u000a\u000aDepends: libosmo-gprs.git Change-Id Iebce37a50917b13c23de1528469d66c310ced7f2\u000aRelated: OS#5502\u000aChange-Id: I4f559e4a882a85742c45609dec596f0485eafed0\u000a", "date" : "2023-04-14 18:34:18 +0200", "id" : "4ba8db561e36112a8acb1f5154685ee079505c36", "msg" : "layer23: modem: sndcp: Apply API change in libosmo-gprs-sndcp", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/sndcp.c", "src/host/layer23/src/modem/sm.c" ], "commitId" : "1cb78f311440adeb89cbe8f2c491ea165a7dd80f", "timestamp" : 1681491904000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Forward SNSM primitives SNDCP<->SM layers\u000a\u000aRelated: OS#5501\u000aDepends: libosmo-gprs.git Change-Id Ic5525bfa92e2591757d999610c0d59849d022d8d\u000aChange-Id: Iad63f41557fbd078588dd890e2f18ed9606a25f7\u000a", "date" : "2023-04-14 19:05:04 +0200", "id" : "1cb78f311440adeb89cbe8f2c491ea165a7dd80f", "msg" : "layer23: modem: Forward SNSM primitives SNDCP<->SM layers", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/src/sched_lchan_desc.c", "src/host/trxcon/src/trxcon_fsm.c", "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/include/osmocom/bb/l1sched/prim.h", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_xcch.c", "src/host/trxcon/src/sched_lchan_sch.c", "src/host/trxcon/include/osmocom/bb/l1sched/Makefile.am", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_rach.c", "src/host/trxcon/src/trxcon_shim.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_trx.c" ], "commitId" : "ff9db9def78d9c2439c8ff3196746bf6df987886", "timestamp" : 1682021149000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: rework the primitive API\u000a\u000aThe goal is to simplify primitive management, and allow passing data\u000abetween different components without having to re-allocate memory and\u000acopy it over several times. This patch has been tested by running\u000attcn3-bts-test, no regressions observed.\u000a\u000a* Use msgb and prim API from libosmocore,\u000a* Move l1sched_prim definitions to its own header file,\u000a* Move Tx queue from per-timeslot to per-lchan state,\u000a* Route prims via l1sched_prim_{to,from}_user() functions,\u000a* Remove GSMTAP stuff from sched_lchan_desc[].\u000a\u000aChange-Id: I73576bd0ea10a5663ba6254283812c275cc3fa46\u000aRelated: OS#5500\u000a", "date" : "2023-04-21 03:05:49 +0700", "id" : "ff9db9def78d9c2439c8ff3196746bf6df987886", "msg" : "trxcon/l1sched: rework the primitive API", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/Makefile.am" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_desc.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_shim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_rach.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_sch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "add", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/prim.h" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm322.c" ], "commitId" : "46f49131da7140ef40b6ab777d7513102077de4c", "timestamp" : 1682254278000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/msuraev", "fullName" : "msuraev" }, "authorEmail" : "msuraev@sysmocom.de", "comment" : "mobile: log unhandled event name\u000a\u000aChange-Id: Id8e6e8af5756e3527ca1968b24f25e4238f0aa40\u000a", "date" : "2023-04-23 12:51:18 +0000", "id" : "46f49131da7140ef40b6ab777d7513102077de4c", "msg" : "mobile: log unhandled event name", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm322.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm411_sms.c", "src/host/layer23/src/common/subscriber.c", "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/mobile/gsm322.c", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/common/vty.h", "src/host/layer23/src/mobile/mnccms.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/mobile/gsm480_ss.c", "src/host/layer23/include/osmocom/bb/mobile/vty.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "a7bf51ac0e3ac3285a1b1bb77f5a1f6244f88d2d", "timestamp" : 1682348051000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Move vty_notify() to common/\u000a\u000aChange-Id: Ic0a98e66adffa9fefeee6e69a4b5c691e0e9c789\u000a", "date" : "2023-04-24 16:54:11 +0200", "id" : "a7bf51ac0e3ac3285a1b1bb77f5a1f6244f88d2d", "msg" : "layer23: Move vty_notify() to common/", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/vty.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm411_sms.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm480_ss.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/vty.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm322.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/vty.c" ], "commitId" : "a78c3927a0b241b78665e23d6df0d9c6da9f4e55", "timestamp" : 1682348175000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: common/vty: Drop includes pointing to mobile app\u000a\u000aChange-Id: I025b09500547a739240fc07fa04cb38378ed71db\u000a", "date" : "2023-04-24 16:56:15 +0200", "id" : "a78c3927a0b241b78665e23d6df0d9c6da9f4e55", "msg" : "layer23: common/vty: Drop includes pointing to mobile app", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "234c1f14fd0ca8ea71bf75dccc5eb4f37863380a", "timestamp" : 1682348770000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Use libosmocore API to validate IMSI string\u000a\u000aChange-Id: I2d4737dabcfb83a7b675c35ad973029a36658d5b\u000a", "date" : "2023-04-24 17:06:10 +0200", "id" : "234c1f14fd0ca8ea71bf75dccc5eb4f37863380a", "msg" : "layer23: Use libosmocore API to validate IMSI string", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/vty.h", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/mobile/vty.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "7019f1bf2b558f80d3b1699cc467950dd8701b56", "timestamp" : 1682439265000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Move testsim node to common/\u000a\u000aChange-Id: Ife34403a715809b43e7a4cd5ce4dec8616fc08af\u000a", "date" : "2023-04-25 18:14:25 +0200", "id" : "7019f1bf2b558f80d3b1699cc467950dd8701b56", "msg" : "layer23: Move testsim node to common/", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/vty.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/vty.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "65cde7dd0439a937c273be84e4d758eae2e60d27", "timestamp" : 1682439273000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Fix wrong 'radio not started' vty message\u000a\u000aChange-Id: I8871c9d0e820beb75d7820b5a2d8d3c77dac379d\u000a", "date" : "2023-04-25 18:14:33 +0200", "id" : "65cde7dd0439a937c273be84e4d758eae2e60d27", "msg" : "layer23: modem: Fix wrong 'radio not started' vty message", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "f99819a4f21c8d6d0b304268f30964f4e858a6f3", "timestamp" : 1682439273000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "mobile: Fail VTY command if attching test SIM card fails\u000a\u000aChange-Id: Ie5a395de6c926f13ce9324b93da0e348da5438d1\u000a", "date" : "2023-04-25 18:14:33 +0200", "id" : "f99819a4f21c8d6d0b304268f30964f4e858a6f3", "msg" : "mobile: Fail VTY command if attching test SIM card fails", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/include/osmocom/bb/common/osmocom_data.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "651426fee4e847d0d22d5b4845c3ead139a0b574", "timestamp" : 1682439273000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Decouple SIM events from MMR events\u000a\u000alet the specific app handle the events generated from the\u000asubscriber/SIM.\u000aAll the MMR specific code can for now stay in mobile/ while SIM support\u000acan be in common/ without violating layers (common/ calling functions in\u000amobile/).\u000a\u000aChange-Id: I473887e0fd9338d76a69a9774145a04575f14b64\u000a", "date" : "2023-04-25 18:14:33 +0200", "id" : "651426fee4e847d0d22d5b4845c3ead139a0b574", "msg" : "layer23: Decouple SIM events from MMR events", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/osmocom_data.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/apn.c", "src/host/layer23/src/modem/sm.c" ], "commitId" : "0683b9033f40f6f46bcb8ae1cbba8887d3012755", "timestamp" : 1682460986000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Set on tun the IP address received during PDP Ctx Act Accept\u000a\u000aChange-Id: I39c27caeff0ccd08d8d8b5fcba5a1d69238d53ca\u000a", "date" : "2023-04-25 22:16:26 +0000", "id" : "0683b9033f40f6f46bcb8ae1cbba8887d3012755", "msg" : "layer23: modem: Set on tun the IP address received during PDP Ctx Act", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/apn.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_pdch.c" ], "commitId" : "90bf6212b3ddbbf0f44862298420469c1f737862", "timestamp" : 1682501337000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req()\u000a\u000aChange-Id: If29ff1e9cc052576102094d870bf1710da562463\u000aRelated: OS#5500\u000a", "date" : "2023-04-26 16:28:57 +0700", "id" : "90bf6212b3ddbbf0f44862298420469c1f737862", "msg" : "virt_phy: fix memleaks in l1ctl_rx_gprs_ul_block_req()", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_pdch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_pdch.c" ], "commitId" : "0857d47885c7b396fda2672809116cd0c90179cc", "timestamp" : 1682501642000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: fix bogous TDMA Fn check in l1ctl_rx_gprs_ul_block_req()\u000a\u000asched_fn_ul() does not support RSL_CHAN_OSMO_PDCH, so it would always\u000areturn the current time, which in most cases is not the correct time\u000afor scheduling a block. Actually, we don't really need this function\u000abecause the Tx Fn is provided to us by the upper layers - just use it.\u000a\u000aChange-Id: Ieb2c819db1ef9377680866989cbb754fac5e45bd\u000aRelated: OS#5500\u000a", "date" : "2023-04-26 16:34:02 +0700", "id" : "0857d47885c7b396fda2672809116cd0c90179cc", "msg" : "virt_phy: fix bogous TDMA Fn check in l1ctl_rx_gprs_ul_block_req()", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_pdch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "include/l1gprs.h" ], "commitId" : "d0a1ec6204aae39fadb04ed3f70d7c4fc7421471", "timestamp" : 1682502054000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "l1gprs: reorder #includes, add missing \u000a\u000aChange-Id: I6fe3b5d85c79a28bc116155c75f7ccd012007f56\u000aRelated: OS#5500\u000a", "date" : "2023-04-26 16:40:54 +0700", "id" : "d0a1ec6204aae39fadb04ed3f70d7c4fc7421471", "msg" : "l1gprs: reorder #includes, add missing ", "paths" : [ { "editType" : "edit", "file" : "include/l1gprs.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c" ], "commitId" : "e8fc1e922859cd300257914604c8659d8e8ae648", "timestamp" : 1682511248000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Unregister registered callbacks upon app exit\u000a\u000aIt's just a good practice to delete all resources allocated during startup.\u000aThe main aim here is to keep resemblance to what the mobile app is doing,\u000aso that they can slowly be merged and some functionalities from the mobile app can be\u000aadded to the modem app, like shutting down the MS without killing the process eventually.\u000a\u000aChange-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805\u000a", "date" : "2023-04-26 14:14:08 +0200", "id" : "e8fc1e922859cd300257914604c8659d8e8ae648", "msg" : "layer23: modem: Unregister registered callbacks upon app exit", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/mobile/main.c" ], "commitId" : "8cc6740448b3d2aef66ec547f4516f6e082902c5", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: mobile: Mark several functions static\u000a\u000aChange-Id: Ifdeef9373b903d14fb2f4ec4caa1bf8c42b45aa1\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "8cc6740448b3d2aef66ec547f4516f6e082902c5", "msg" : "layer23: mobile: Mark several functions static", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/mobile/main.c", "src/host/layer23/src/common/main.c" ], "commitId" : "3c348f5893622020d4a6d941fa9d6ebf4c2d4366", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Call telnet_exit() during app exit if VTY support is enabled\u000a\u000aChange-Id: Ic8540c73b1b13134e11f254beb6a16f7e4452317\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "3c348f5893622020d4a6d941fa9d6ebf4c2d4366", "msg" : "layer23: Call telnet_exit() during app exit if VTY support is enabled", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/settings.c", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "7626d0816f60af04ad1b596646bca360fffe6ad9", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Use GSM_RESERVED_TMSI from libosmocore everywhere\u000a\u000aChange-Id: Ib9483b8ae4067994aef523291733ae706ffabe7a\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "7626d0816f60af04ad1b596646bca360fffe6ad9", "msg" : "layer23: Use GSM_RESERVED_TMSI from libosmocore everywhere", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "7d45f4d4eea6f73e92ce8e484ca884df943d5ed5", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Use OSMO_IMSI_BUF_SIZE from libosmocore\u000a\u000aNote: GSM_IMSI_LENGTH was 16 octets, and OSMO_IMSI_BUF_SIZE is 17\u000aoctets. Probably a bug in old osmocom-bb code since that code predates\u000athe one in libosmocore.\u000a\u000aChange-Id: I295444bb3b75ed236ea4af5563d9a9c9e590cab7\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "7d45f4d4eea6f73e92ce8e484ca884df943d5ed5", "msg" : "layer23: Use OSMO_IMSI_BUF_SIZE from libosmocore", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/settings.h" ], "commitId" : "95988ff2889bc9b83dbb7a9e49c71364c380e0b4", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Use GSM23003_IMEI(SV)_NUM_DIGITS from libosmocore\u000a\u000aChange-Id: I12a96043947c0f5366f550944a4df5edd2fd2c9d\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "95988ff2889bc9b83dbb7a9e49c71364c380e0b4", "msg" : "layer23: Use GSM23003_IMEI(SV)_NUM_DIGITS from libosmocore", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/ms.c" ], "commitId" : "ae8725fc85882b3bc3bb46d3d11f228873de005f", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "Initialize/release sim & subscriber ms parts in common/\u000a\u000aChange-Id: Ifb88f7e4dcc049a687af213be597d495731b24b9\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "ae8725fc85882b3bc3bb46d3d11f228873de005f", "msg" : "Initialize/release sim & subscriber ms parts in common/", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/ms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/vty.h", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "da13bed837fc479ebeb57e0e8320a8b473f9e876", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Move 'show {subscriber,support}' to common/'\u000a\u000aThose modules are aready in common/, so they can be added to the shared\u000aVTY interface to introspect MS objects.\u000a\u000aChange-Id: Ie4d85bbb1d0af8894683589d8b936f9884f79be9\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "da13bed837fc479ebeb57e0e8320a8b473f9e876", "msg" : "layer23: Move 'show {subscriber,support}' to common/'", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/vty.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "c58b5f0dbccfb03444cf4ace991b20540bf7e3b7", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: vty: Move sim related commands to common/\u000a\u000aChange-Id: I9e95732255c248b000f1045c395a15217d10db78\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "c58b5f0dbccfb03444cf4ace991b20540bf7e3b7", "msg" : "layer23: vty: Move sim related commands to common/", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/vty.c", "src/host/layer23/include/osmocom/bb/modem/gmm.h", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/src/modem/sm.c", "src/host/layer23/include/osmocom/bb/modem/sm.h" ], "commitId" : "6be26a97bfda465ced599c705e47d2f748e3bce9", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Use subscriber information and events to trigger GMMREG Attach\u000a\u000aChange-Id: I1c7cc120ff4098c0b845e13a6e5e5db8b7e18376\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "6be26a97bfda465ced599c705e47d2f748e3bce9", "msg" : "layer23: Use subscriber information and events to trigger GMMREG Attach", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/gmm.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/sm.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "a85b6a7bd532eff6ee1d35518b0d60eba343e5f3", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Forward GMM primitives up to SM layer\u000a\u000aChange-Id: I5c5416775ccce4a1cbc70c8f6ba4fc25ace12d6f\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "a85b6a7bd532eff6ee1d35518b0d60eba343e5f3", "msg" : "layer23: modem: Forward GMM primitives up to SM layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "993c4b4be66c01d359ddb829cc7bc5d3511b28b5", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: vty: Move imei related commands to common/\u000a\u000aChange-Id: I3c71586c0eb437ce63beaae5adf8fac6c27e2896\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "993c4b4be66c01d359ddb829cc7bc5d3511b28b5", "msg" : "layer23: vty: Move imei related commands to common/", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "doc/examples/modem/modem.cfg" ], "commitId" : "291a3f08e557a1337d6a9accf51acf0101ab47bd", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "doc/examples/modem: Update modem.cfg with new features\u000a\u000aUpdate the example config to contain IMSI and IMEI values which are used\u000awhen attaching to the network.\u000a\u000aSet cpu-sched to realtime since RLCMAC is time-constrained.\u000a\u000aChange-Id: I6060c833de2eef7591b7a4f149d9e148455db970\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "291a3f08e557a1337d6a9accf51acf0101ab47bd", "msg" : "doc/examples/modem: Update modem.cfg with new features", "paths" : [ { "editType" : "edit", "file" : "doc/examples/modem/modem.cfg" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c", "src/host/layer23/src/common/subscriber.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/modem/sm.c" ], "commitId" : "9f2561a592fd369733a7ebf9d5dbbe4574b28ead", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Store P-TMSI independently in subscriber\u000a\u000aChange-Id: I6f6d230d8c3c4fce27ba87cf9f953dc9db83cb72\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "9f2561a592fd369733a7ebf9d5dbbe4574b28ead", "msg" : "layer23: modem: Store P-TMSI independently in subscriber", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "09b971d8b94eb907f3052ddfac3b4e71dab8b50c", "timestamp" : 1682511269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Store P-TMSI allocated by the network\u000a\u000aChange-Id: Ide686230336d68153db59e76dd97b7e7c6f500d8\u000a", "date" : "2023-04-26 14:14:29 +0200", "id" : "09b971d8b94eb907f3052ddfac3b4e71dab8b50c", "msg" : "layer23: modem: Store P-TMSI allocated by the network", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trxcon_fsm.c", "src/host/trxcon/src/trxcon_shim.c" ], "commitId" : "712e7cdf24b34bc8c3e33158b0453cb2065f8b13", "timestamp" : 1682533109000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: ignore TRXCON_EV_TX_DATA_CNF in TRXCON_ST_PACKET_DATA\u000a\u000aChange-Id: Ie3c53ffbac1f1906cc97ef66eb74e24aee2cb2c4\u000aRelated: OS#5500\u000a", "date" : "2023-04-27 01:18:29 +0700", "id" : "712e7cdf24b34bc8c3e33158b0453cb2065f8b13", "msg" : "trxcon: ignore TRXCON_EV_TX_DATA_CNF in TRXCON_ST_PACKET_DATA", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_shim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/logging.c" ], "commitId" : "2cb97ba8dafb90e493f99c306fdd9fdc7aa41bca", "timestamp" : 1682533109000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: reduce DGPRS logging level to LOGL_NOTICE\u000a\u000aThis was needed during early testing of l1gprs, but not anymore.\u000a\u000aChange-Id: Ifccf8ccae2d9acc4039db46a87fa43f95a28e6ad\u000aRelated: OS#5500\u000a", "date" : "2023-04-27 01:18:29 +0700", "id" : "2cb97ba8dafb90e493f99c306fdd9fdc7aa41bca", "msg" : "trxcon: reduce DGPRS logging level to LOGL_NOTICE", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/logging.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/logging.c" ], "commitId" : "5dccc1fbd870dbf259efacb746d6a901e439be9d", "timestamp" : 1682533109000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: use non-blocking stderr logging by default\u000a\u000aThe logging in trxcon is initialized by calling osmo_init_logging2(),\u000awhich creates an stderr target in *blocking* mode. Blocking write()s\u000amay cause random burst scheduling delays (due to the whole process\u000abeing stuck). This is not desired and becomes even more critical\u000awhen operating in PS doman, which imposes strict timing requirements.\u000a\u000atrxcon does not have its own VTY interface yet, so there's currently\u000ano easy way to switch to non-blocking mode like in other osmo-apps.\u000aLet's enable it by default in trxcon_logging_init().\u000a\u000aChange-Id: I8cbfd9b4644f8442cbedc7e452ba79816923fc10\u000aRelated: OS#5500\u000a", "date" : "2023-04-27 01:18:29 +0700", "id" : "5dccc1fbd870dbf259efacb746d6a901e439be9d", "msg" : "trxcon: use non-blocking stderr logging by default", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/logging.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_trx.c" ], "commitId" : "b0be904bc610771fabf33cbe62ec1c27d7f220dc", "timestamp" : 1682945173000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: do not call l1sched_prim_dequeue() at ul_bid != 0\u000a\u000aIt may happen that the Tx queue is empty at TDMA Fn corresponding to\u000aul_bid == 0, and then shortly after something appears at ul_bid != 0.\u000a\u000aThe lchan Tx handlers call the encoding functions from libosmocoding\u000aonly at bid == 0, so dequeueing at ul_bid != 0 makes no sense.\u000a\u000aChange-Id: Ic0bbe2ab6c0ccd96c1f8af8aa17ac88adf7f88ed\u000aRelated: OS#5500\u000a", "date" : "2023-05-01 19:46:13 +0700", "id" : "b0be904bc610771fabf33cbe62ec1c27d7f220dc", "msg" : "trxcon: do not call l1sched_prim_dequeue() at ul_bid != 0", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/include/osmocom/bb/modem/gmm.h", "src/host/layer23/include/osmocom/bb/common/ms.h" ], "commitId" : "19c87cf7d4a5f92682dd2dcbd1c5b4fa032b1c17", "timestamp" : 1683023223000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Resolve auth requests coming from GMM layer\u000a\u000aChange-Id: I75dc3fe3e4d9e23443fb778e36ca024f1bc46641\u000a", "date" : "2023-05-02 12:27:03 +0200", "id" : "19c87cf7d4a5f92682dd2dcbd1c5b4fa032b1c17", "msg" : "layer23: modem: Resolve auth requests coming from GMM layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/gmm.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/sndcp.c" ], "commitId" : "fa4293d93a131ce37505441affe565f27590fcbc", "timestamp" : 1683122853000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: sndcp: Forward LL-XID.req SNDCP->LLC\u000a\u000aChange-Id: Icbc033cd0659bba75bb280a3d46e76edd2e20226\u000a", "date" : "2023-05-03 16:07:33 +0200", "id" : "fa4293d93a131ce37505441affe565f27590fcbc", "msg" : "layer23: modem: sndcp: Forward LL-XID.req SNDCP->LLC", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/sm.c" ], "commitId" : "0e836fb0dd2d009b0b9c4a2b7f72cea9ca16082d", "timestamp" : 1683122853000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: sm: Properly inform SM layer of ownership transfer\u000a\u000aChange-Id: I95ed63fe6442369ab3afb75cbd9908b87addbb3e\u000a", "date" : "2023-05-03 16:07:33 +0200", "id" : "0e836fb0dd2d009b0b9c4a2b7f72cea9ca16082d", "msg" : "layer23: modem: sm: Properly inform SM layer of ownership transfer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/sndcp.c" ], "commitId" : "8d996de55b42b9288f7eaaae67c87a41da84ba21", "timestamp" : 1683131866000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: sndcp: Properly inform SNDCP layer of ownership transfer\u000a\u000aChange-Id: Icc3351f360e41d4a95e056b4fd797c7d133e8a83\u000a", "date" : "2023-05-03 18:37:46 +0200", "id" : "8d996de55b42b9288f7eaaae67c87a41da84ba21", "msg" : "layer23: modem: sndcp: Properly inform SNDCP layer of ownership transfer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/include/osmocom/bb/modem/modem.h" ], "commitId" : "fbd2f733a73ffda6545705098b28684b16d4675e", "timestamp" : 1683131914000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Delay GPRS attach at startup until modem is ready\u000a\u000aWait until SIM is ready, network system information ws obtained and\u000ait announced the MS is able to use GPRS against it.\u000a\u000aChange-Id: I5029d9e8a47b8544b3b803c4db6352269bac3c0e\u000a", "date" : "2023-05-03 18:38:34 +0200", "id" : "fbd2f733a73ffda6545705098b28684b16d4675e", "msg" : "layer23: modem: Delay GPRS attach at startup until modem is ready", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/modem.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "c16126317d4ec6c7d499f247d8ea836b902cedfb", "timestamp" : 1683194629000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: grr: Log ignored CCCH ImmAss\u000a\u000aThere seems to be some bug when using virtphy where sometimes the\u000areceived T2 and/or T3 in the ImmASs is not matching what we sent.\u000aThis helps in showing the problem and not failing silently.\u000a\u000aChange-Id: Iaecd2616733d84f35a825916fe888142800b426b\u000a", "date" : "2023-05-04 12:03:49 +0200", "id" : "c16126317d4ec6c7d499f247d8ea836b902cedfb", "msg" : "layer23: modem: grr: Log ignored CCCH ImmAss", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "bb5e13ca23e242dd9b70962065c8c01fbb4c3d7a", "timestamp" : 1683194632000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: gmm: Activate PDP Context of APN after GPRS attach\u000a\u000aChange-Id: Icb667a6a3359267d2eb20e11a40eb27a8c3f7e2d\u000a", "date" : "2023-05-04 12:03:52 +0200", "id" : "bb5e13ca23e242dd9b70962065c8c01fbb4c3d7a", "msg" : "layer23: modem: gmm: Activate PDP Context of APN after GPRS attach", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/common/apn.c", "src/host/layer23/include/osmocom/bb/common/apn_fsm.h", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/src/modem/sm.c", "src/host/layer23/include/osmocom/bb/common/Makefile.am", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/settings.c", "src/host/layer23/src/common/apn_fsm.c", "src/host/layer23/include/osmocom/bb/common/apn.h", "src/host/layer23/src/common/Makefile.am" ], "commitId" : "bbfb569b8ec650060c97d64c5063cd35e851e4d5", "timestamp" : 1683194632000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Introduce apn_fsm\u000a\u000aThis allows further control on the state of the APNs, as well as\u000aa step further towards administering them through VTY.\u000a\u000aChange-Id: I2cc732dfb020d31ab89025e7e22276b819dcb24a\u000a", "date" : "2023-05-04 12:03:52 +0200", "id" : "bbfb569b8ec650060c97d64c5063cd35e851e4d5", "msg" : "layer23: Introduce apn_fsm", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/Makefile.am" }, { "editType" : "add", "file" : "src/host/layer23/include/osmocom/bb/common/apn_fsm.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/Makefile.am" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/apn.c" }, { "editType" : "add", "file" : "src/host/layer23/src/common/apn_fsm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/apn.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/apn.c", "src/host/layer23/include/osmocom/bb/common/apn.h", "src/host/layer23/src/modem/sndcp.c", "src/host/layer23/src/modem/sm.c" ], "commitId" : "00fd8d237be3323e0f36f7d39b4530577d5f426a", "timestamp" : 1683194632000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Store and use SAPI & NSAPI in apn->pdp\u000a\u000aChange-Id: If82c94ca9c84a94e63a9a5d642a27a7b4e3ff089\u000a", "date" : "2023-05-04 12:03:52 +0200", "id" : "00fd8d237be3323e0f36f7d39b4530577d5f426a", "msg" : "layer23: Store and use SAPI & NSAPI in apn->pdp", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/apn.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/apn.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/l1sched/prim.h", "src/host/trxcon/src/trxcon_fsm.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_sch.c", "src/host/trxcon/src/sched_trx.c" ], "commitId" : "7ce8cdd32543312f496824bf82ebbaf565a01b6f", "timestamp" : 1683526619000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: allocate primitives of fixed size (64 + 64)\u000a\u000aWhen running trxcon with GSMTAP Um logging enabled (-g cmd line arg),\u000ain handle_prim_rach_cnf() we msgb_put() one or two bytes to the given\u000amsgb. This causes a segfault, because the L1SCHED_PRIM_T_RACH prims\u000ahave 0 tailroom bytes available.\u000a\u000aWhile we could allocate L1SCHED_PRIM_T_RACH with a few extra bytes,\u000aa more fundamental approach is to allocate all l1sched primitives with\u000aa fixed tailroom.\u000a\u000aChange-Id: Ica87b147e11744a69dcd7c056376dcf6b98f9ca6\u000aFixes: ff9db9de \"trxcon/l1sched: rework the primitive API\"\u000aRelated: OS#5500\u000a", "date" : "2023-05-08 06:16:59 +0000", "id" : "7ce8cdd32543312f496824bf82ebbaf565a01b6f", "msg" : "trxcon/l1sched: allocate primitives of fixed size (64 + 64)", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_sch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/prim.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_rach.c" ], "commitId" : "68556f356673dda2266f3111c6ab114035383a2b", "timestamp" : 1683661067000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: fix l1ctl_rx_rach_req(): send RACH on TS0, not TS1\u000a\u000aChange-Id: I096e377de9e74893e9eb1927707d5e1a44b15ad9\u000a", "date" : "2023-05-10 02:37:47 +0700", "id" : "68556f356673dda2266f3111c6ab114035383a2b", "msg" : "virt_phy: fix l1ctl_rx_rach_req(): send RACH on TS0, not TS1", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_rach.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_rach.c" ], "commitId" : "0684e2313e2e428ce2f0b768ea473c25d319c2a6", "timestamp" : 1683661067000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: l1ctl_rx_rach_req(): use the indicated chan_nr/link_id\u000a\u000aChange-Id: I820f32851f1c7a39695270cc246964a3e212118f\u000a", "date" : "2023-05-10 02:37:47 +0700", "id" : "0684e2313e2e428ce2f0b768ea473c25d319c2a6", "msg" : "virt_phy: l1ctl_rx_rach_req(): use the indicated chan_nr/link_id", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_rach.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_rach.c" ], "commitId" : "8e78ff491babe84416dbb5744b3aa3842b3dd68b", "timestamp" : 1683661245000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: l1ctl_rx_rach_req(): remove TDMA Fn hack\u000a\u000aThis looks like a debugging leftover.\u000a\u000aChange-Id: Id794c76aea48a171f0c5f4604892a82c1a2d3ed4\u000a", "date" : "2023-05-10 02:40:45 +0700", "id" : "8e78ff491babe84416dbb5744b3aa3842b3dd68b", "msg" : "virt_phy: l1ctl_rx_rach_req(): remove TDMA Fn hack", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_rach.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_rach.c" ], "commitId" : "80de799514f20dd9d3759932d7c839902c7b7692", "timestamp" : 1683661442000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: fix TDMA Fn math in l1ctl_rx_rach_req()\u000a\u000aChange-Id: I7922dd2d3257257b3bf8711ec859dd99463adc39\u000aRelated: OS#5500\u000a", "date" : "2023-05-10 02:44:02 +0700", "id" : "80de799514f20dd9d3759932d7c839902c7b7692", "msg" : "virt_phy: fix TDMA Fn math in l1ctl_rx_rach_req()", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_rach.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/ms.c", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/include/osmocom/bb/common/ms.h", "src/host/layer23/src/modem/sndcp.c", "src/host/layer23/src/modem/sm.c" ], "commitId" : "39b04cf6ef81a4bf8e83143b3fbaf06ce095bc81", "timestamp" : 1684145151000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Use in SN SAP the TLLI retrieved from GMM and SM\u000a\u000aDepends: libosmo-gprs.git Change-Id I7b1b8ac414474652b438f15b7f07961032a0f56d\u000aChange-Id: Icac16626a6b89489b7f1ee2ab8ffbaca04e8bacc\u000a", "date" : "2023-05-15 12:05:51 +0200", "id" : "39b04cf6ef81a4bf8e83143b3fbaf06ce095bc81", "msg" : "layer23: modem: Use in SN SAP the TLLI retrieved from GMM and SM", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/ms.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/apn.c", "src/host/layer23/src/modem/sm.c", "src/host/layer23/include/osmocom/bb/common/apn.h" ], "commitId" : "0cbf3afc1585b65f81a91917e7f74314ae2d86d1", "timestamp" : 1684145158000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: pass pco & qos from apn\u000a\u000aChange-Id: I4088e3e96a58bd667627023f144a05137415dd32\u000a", "date" : "2023-05-15 12:05:58 +0200", "id" : "0cbf3afc1585b65f81a91917e7f74314ae2d86d1", "msg" : "layer23: modem: pass pco & qos from apn", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/apn.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/apn.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/sim.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "e5ba8e160362c67ef2b687fe55dcd6a255886852", "timestamp" : 1684313621000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Define EF.LOCI Location Update Status values with an enum\u000a\u000aChange-Id: Ia54026fa8e4fca05da71e1e6a2dbdb8d900f0dd0\u000a", "date" : "2023-05-17 10:53:41 +0200", "id" : "e5ba8e160362c67ef2b687fe55dcd6a255886852", "msg" : "layer23: Define EF.LOCI Location Update Status values with an enum", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sim.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/sim.h" ], "commitId" : "1897218be4a13dd8a671bb655c20831ce7af9962", "timestamp" : 1684313653000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "sim: Introduce EF.LOCIGPRS file structure\u000a\u000aChange-Id: Idf93b4ece0a966754f8caacc665038c321b752bb\u000a", "date" : "2023-05-17 10:54:13 +0200", "id" : "1897218be4a13dd8a671bb655c20831ce7af9962", "msg" : "sim: Introduce EF.LOCIGPRS file structure", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sim.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/settings.c", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "1a720cd176347a3a70dec515d4b7afb2eb3e70a7", "timestamp" : 1684316062000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "Use OSMO_STRLCPY_ARRAY instead of strcpy\u000a\u000aChange-Id: I6b9bfffd715c4238289b693740585ec08f8d8d16\u000a", "date" : "2023-05-17 11:34:22 +0200", "id" : "1a720cd176347a3a70dec515d4b7afb2eb3e70a7", "msg" : "Use OSMO_STRLCPY_ARRAY instead of strcpy", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/settings.c" ], "commitId" : "fd060aecf5d5082a7de7e3e5a9a8bedf0b6262fc", "timestamp" : 1684320955000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: make verify_value_string_arrays_are_terminated.py happy\u000a\u000aChange-Id: I664d9b8f77522126406db5e3a301f1f132748e0b\u000a", "date" : "2023-05-17 10:55:55 +0000", "id" : "fd060aecf5d5082a7de7e3e5a9a8bedf0b6262fc", "msg" : "layer23: make verify_value_string_arrays_are_terminated.py happy", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "contrib/jenkins.sh" ], "commitId" : "a449a39ce1eb94e97b5d6c88e6954af39702f538", "timestamp" : 1684320955000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "contrib/jenkins.sh: uncomment verify_value_string_arrays_are_terminated.py\u000a\u000aChange-Id: Iad9a6546fa7e2a654ed3217c2a875357ef5cc804\u000a", "date" : "2023-05-17 10:55:55 +0000", "id" : "a449a39ce1eb94e97b5d6c88e6954af39702f538", "msg" : "contrib/jenkins.sh: uncomment", "paths" : [ { "editType" : "edit", "file" : "contrib/jenkins.sh" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/ms.c", "src/host/layer23/src/common/apn.c", "src/host/layer23/src/modem/llc.c", "src/host/layer23/src/modem/rlcmac.c", "src/host/layer23/include/osmocom/bb/common/apn.h", "src/host/layer23/src/modem/sndcp.c", "src/host/layer23/src/common/vty.c", "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/src/modem/sm.c", "src/host/layer23/src/common/apn_fsm.c" ], "commitId" : "7a6e1874cbae5da1e5282e0111ff905bc6e423c3", "timestamp" : 1684410675000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH\u000a\u000aChange-Id: I408cde7f2b4642500e5362052365c92856c02bef\u000a", "date" : "2023-05-18 18:51:15 +0700", "id" : "7a6e1874cbae5da1e5282e0111ff905bc6e423c3", "msg" : "copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/apn.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/apn_fsm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/ms.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/apn.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/llc.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sndcp.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/common/subscriber.c", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/settings.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "4ea84d3ae546bb6243ebe3ee90b4d1e7ded0d5b3", "timestamp" : 1684486430000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "layer23: Move all test_sim settings to its own substruct\u000a\u000aThis way it becomes clear those fields are related only to test_sim\u000amodule, and not some general \"test\" feature.\u000a\u000aChange-Id: I56830c6b905bcbce7e19adbfe5427fd826d15e8c\u000a", "date" : "2023-05-19 08:53:50 +0000", "id" : "4ea84d3ae546bb6243ebe3ee90b4d1e7ded0d5b3", "msg" : "layer23: Move all test_sim settings to its own substruct", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "f05ac96fd6213ddc0705d1cfec1624fb615ff997", "timestamp" : 1684486430000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "layer23: Migrate sim_ustate to enum + value_string\u000a\u000aChange-Id: I83607caa0b76b6b30db59c53438a55726483b85d\u000a", "date" : "2023-05-19 08:53:50 +0000", "id" : "f05ac96fd6213ddc0705d1cfec1624fb615ff997", "msg" : "layer23: Migrate sim_ustate to enum + value_string", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/common/subscriber.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "1ad195e28f46c0d132406973f123b9b4e9271062", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: rework store & pass of test_sim param to gsm_subscr_testcard() API\u000a\u000aThis way the gsm_subscr_testcard() API looks similar to that of other\u000abackends (sim, sap). Furthermore, the callers of the API don't need to\u000apass tons of params. This is important since in the future there will be\u000amore params (eg. gprs related ones), so it makes no sense to keep\u000aincreasing the param list in there.\u000a\u000aChange-Id: I07fc5a6ed59e65d6b96c0a2f87b1f496d39ad76d\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "1ad195e28f46c0d132406973f123b9b4e9271062", "msg" : "layer23: rework store & pass of test_sim param to gsm_subscr_testcard()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/subscriber.c", "src/host/layer23/src/common/vty.c" ], "commitId" : "fd1552c22507159a8c4928bbfdf83b8d17f74eff", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Move sap specific code inside subscriber.c\u000a\u000aStep forward towards a generic subscriber interface.\u000a\u000aChange-Id: I780f06203cd6971866d81060a5ecee8bc00782f4\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "fd1552c22507159a8c4928bbfdf83b8d17f74eff", "msg" : "layer23: subscriber: Move sap specific code inside subscriber.c", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c" ], "commitId" : "5906bee946bc235867ee613bbb5a16800931c1a4", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Move generic code to the top out of sim backend\u000a\u000aChange-Id: Ie96621f49122da54c68e40611c1f6553aa37ef11\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "5906bee946bc235867ee613bbb5a16800931c1a4", "msg" : "layer23: subscriber: Move generic code to the top out of sim backend", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/ms.c", "src/host/layer23/src/mobile/app_mobile.c" ], "commitId" : "8be5119702ac8cedc9691badbe71972d0aa4a155", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Move SAP init/close to be done during MS allocation/destruction\u000a\u000aChange-Id: Ic20760228668db4cb2fc6cdea4fd0470c211ce0a\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "8be5119702ac8cedc9691badbe71972d0aa4a155", "msg" : "layer23: Move SAP init/close to be done during MS allocation/destruction", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/ms.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/common/subscriber.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "7b53ad536c6c4fd8cbea4ae0f6f1a5716b72108b", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Generalize subscriber SIM insert API\u000a\u000aWith this patch, during VTY config the SIM type is selected, and the app\u000acalls a generic gsm_subscriber_insert() API which will take of\u000ainternally initializing and starting whatever specific-backend setup is\u000aneeded.\u000a\u000aChange-Id: I5aa34ae297ec0114e1d2355d59fdd77b43b35464\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "7b53ad536c6c4fd8cbea4ae0f6f1a5716b72108b", "msg" : "layer23: Generalize subscriber SIM insert API", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "48382f3797ff02e4eb04931b3e1f843bc873045f", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Split gsm_subscr_generate_kc() internally per-backend\u000a\u000aChange-Id: I88365d23773a4bdc50a51807c775b3caff0bd425\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "48382f3797ff02e4eb04931b3e1f843bc873045f", "msg" : "layer23: subscriber: Split gsm_subscr_generate_kc() internally", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c" ], "commitId" : "99d82d17a19d43ecaa3aff5d1acf4045196e58fa", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Split gsm_subscr_write_loci() internally per-backend\u000a\u000aChange-Id: I5f024972016afe0e161b745236c84b00ee44ad5e\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "99d82d17a19d43ecaa3aff5d1acf4045196e58fa", "msg" : "layer23: subscriber: Split gsm_subscr_write_loci() internally", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "1f525ea71f7275608ddcc54f8ced41f87ff3b1c0", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Split gsm_subscr_sim_pin() internally per-backend\u000a\u000aChange-Id: I10968c5a43632e0e3054c2d6934cae0052c2daae\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "1f525ea71f7275608ddcc54f8ced41f87ff3b1c0", "msg" : "layer23: subscriber: Split gsm_subscr_sim_pin() internally per-backend", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c" ], "commitId" : "09382eca8bf1ff1293ba6ac1d111b455d64d6e21", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: split subscr_write_plmn_na() internally per-backend\u000a\u000aChange-Id: I5e3a4996bbb5cbfbe81342eadb46aa10a2033fd9\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "09382eca8bf1ff1293ba6ac1d111b455d64d6e21", "msg" : "layer23: split subscr_write_plmn_na() internally per-backend", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c" ], "commitId" : "2ee1e23d937eeba86d8288797ebe97570e32669c", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Move generic APIs to the top section\u000a\u000aThis way we end up with the generic section on top, followed by each\u000abackend section clearly delimited. As a result, it is now much clearer\u000athe separation between the generic code and each backend specific\u000aimplementation.\u000a\u000aChange-Id: Ice8ada52f227ee4da90ba37ec6b3eb8070621f85\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "2ee1e23d937eeba86d8288797ebe97570e32669c", "msg" : "layer23: subscriber: Move generic APIs to the top section", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/networks.c" ], "commitId" : "554e7cfb56ff61e83c7321b7737baf4476bf8280", "timestamp" : 1684497418000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "common: Mark gsm_networks static\u000a\u000aChange-Id: I662adb99080a8689dd7c97b1380cc4ec50958215\u000a", "date" : "2023-05-19 13:56:58 +0200", "id" : "554e7cfb56ff61e83c7321b7737baf4476bf8280", "msg" : "common: Mark gsm_networks static", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/networks.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/networks.c", "src/host/layer23/include/osmocom/bb/mobile/gsm322.h", "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/src/common/settings.c", "src/host/layer23/src/misc/cell_log.c", "src/host/layer23/src/common/vty.c", "src/host/layer23/src/common/sysinfo.c", "src/host/layer23/include/osmocom/bb/common/networks.h", "src/host/layer23/src/common/subscriber.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/mobile/gsm322.c", "src/host/layer23/include/osmocom/bb/misc/log.h", "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h", "src/host/layer23/include/osmocom/bb/common/sysinfo.h", "src/host/layer23/src/misc/gsmmap.c", "src/host/layer23/src/misc/log.c" ], "commitId" : "3348f491792788974c6bb3ee75f3a4f1d159aef9", "timestamp" : 1684764724000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "Migrate network identifier fields to modern osmocom structures\u000a\u000aThis allows using well tested standarized API to print, compare, etc. usual\u000aidentifiers like PLMN, LAI, etc.\u000aIt also simplifies code by avoiding passing lots of parameters and\u000amaking it easier to identify which fields go packed together.\u000aThis is specially important since in the future more of those\u000aidentifiers will be added for GPRS.\u000a\u000aChange-Id: I07a9289825c09ed748e53d36a746ea164c8a5d7f\u000a", "date" : "2023-05-22 16:12:04 +0200", "id" : "3348f491792788974c6bb3ee75f3a4f1d159aef9", "msg" : "Migrate network identifier fields to modern osmocom structures", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/misc/log.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/networks.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/gsmmap.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/log.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm322.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/cell_log.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sysinfo.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/networks.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm322.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/vty.c" ], "commitId" : "e1bef2d89c29600eeb655e00fcf496a2b2de3cb1", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: vty: Rename testsim node functions\u000a\u000aChange-Id: If84297f026e6804436a0bf16c5c992161cd71ee4\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "e1bef2d89c29600eeb655e00fcf496a2b2de3cb1", "msg" : "layer23: vty: Rename testsim node functions", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "c2402244c1aa437fe7eadb21013aace446047ac5", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Define imsi_attached field as bool\u000a\u000aChange-Id: I47e234dcef4c5af09023318dda45d40c8c92b312\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "c2402244c1aa437fe7eadb21013aace446047ac5", "msg" : "layer23: Define imsi_attached field as bool", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "4c8017f011d390e13247a8c6fda36754291e2638", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Define always_search_hplmn field as bool\u000a\u000aChange-Id: I0efc16a2362fbfec64cf6ca85bb32db8beb241a3\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "4c8017f011d390e13247a8c6fda36754291e2638", "msg" : "layer23: Define always_search_hplmn field as bool", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c", "src/host/layer23/src/mobile/gsm322.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "741ef88d422e429ab8d68b3d184dfcde5ca8b6eb", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Define (r)plmn_valid field as bool\u000a\u000aChange-Id: Ia2316bae5e4f5035f31b4da3937e025537aaf224\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "741ef88d422e429ab8d68b3d184dfcde5ca8b6eb", "msg" : "layer23: Define (r)plmn_valid field as bool", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm322.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "fd461b0218461b1a2bec20b75cca627fa8935dcf", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Define barr field as bool\u000a\u000aChange-Id: I02b95fa5437be1325cfa80fc40350280540fe802\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "fd461b0218461b1a2bec20b75cca627fa8935dcf", "msg" : "layer23: Define barr field as bool", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/src/common/subscriber.c" ], "commitId" : "ac8460c77ba51ecb6c2636cdb65169bbb27472c3", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: Define sim_pin_required field as bool\u000a\u000aChange-Id: I7c5105da08176f4743f1f3e56ddad9ac170717c7\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "ac8460c77ba51ecb6c2636cdb65169bbb27472c3", "msg" : "layer23: Define sim_pin_required field as bool", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c", "src/host/layer23/src/modem/gmm.c", "src/host/layer23/src/modem/sm.c", "src/host/layer23/include/osmocom/bb/common/subscriber.h" ], "commitId" : "9be9a2ef7ff8e31906803477dc32b13fa84ea9eb", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Implement LOCIGPRS read/write for simcard backend\u000a\u000aChange-Id: Ida5bcfc896c75c238e2eb2d0aee742ae36fb5e16\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "9be9a2ef7ff8e31906803477dc32b13fa84ea9eb", "msg" : "layer23: subscriber: Implement LOCIGPRS read/write for simcard backend", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c", "src/host/layer23/include/osmocom/bb/common/sim.h", "src/host/layer23/include/osmocom/bb/common/subscriber.h", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/vty.c" ], "commitId" : "8bd2e644b5d1a65544979bcd38fc3c7373dbdb2f", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: subscriber: Implement LOCIGPRS read/write for testcard backend\u000a\u000aChange-Id: Ibcaaf430587a3a270398e9a9eeab6ee98514c3c8\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "8bd2e644b5d1a65544979bcd38fc3c7373dbdb2f", "msg" : "layer23: subscriber: Implement LOCIGPRS read/write for testcard backend", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/subscriber.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sim.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/sm.c", "src/host/layer23/src/modem/gmm.c" ], "commitId" : "2dfa84e73dca455900e6522f61f5c610077783b7", "timestamp" : 1684764729000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: pass SIM-stored PTMSI (signature) & RAI to GMM\u000a\u000aDepends: libosmo-gprs.git Change-Id Ia69b6f885d612c42ab015822031e4c7262f4714e\u000aChange-Id: If0eef0a60b310539f2e668238314481ad5b7a5fa\u000a", "date" : "2023-05-22 16:12:09 +0200", "id" : "2dfa84e73dca455900e6522f61f5c610077783b7", "msg" : "layer23: modem: pass SIM-stored PTMSI (signature) & RAI to GMM", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c" ], "commitId" : "74a02a5cacc8a11cc2fd5a8fbc5b9f44b7dae45e", "timestamp" : 1685099528000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "subscriber: Fix condition to print PTMSI signature\u000a\u000aRelated: Coverity CID#316085\u000aChange-Id: Ie9259141290200544981e815f4a1486584373014\u000a", "date" : "2023-05-26 13:12:08 +0200", "id" : "74a02a5cacc8a11cc2fd5a8fbc5b9f44b7dae45e", "msg" : "subscriber: Fix condition to print PTMSI signature", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "ad8f7794c9b7c5c03f34e1d6a273e8b5f7c9da30", "timestamp" : 1685361064000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: remove redundant TCH/[FH] prim length checks\u000a\u000aBoth gsm0503_tch_[fh]r_encode() do check the given payload length in\u000aorder to determine the payload and/or codec type. The same applies\u000ato gsm0503_tch_a[fh]s_encode(). There is no real need to implement\u000aadditional length checks on top of that - drop them.\u000a\u000aChange-Id: Ib1adf4945fb762bc2a51a1008f6bef6784fb7833\u000aRelated: OS#4396\u000a", "date" : "2023-05-29 18:51:04 +0700", "id" : "ad8f7794c9b7c5c03f34e1d6a273e8b5f7c9da30", "msg" : "trxcon/l1sched: remove redundant TCH/[FH] prim length checks", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "66c7ec1bf35b4a2f21c91231f36bd8296a294d6e", "timestamp" : 1685361064000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: drop Tx prims for not supported TCH modes\u000a\u000aOtherwise we'll be attempting to transmit the same prim again and again.\u000a\u000aChange-Id: I2f137a0b931e8e7d05a5d903023c50065f57bfa6\u000aRelated: OS#4396\u000a", "date" : "2023-05-29 18:51:04 +0700", "id" : "66c7ec1bf35b4a2f21c91231f36bd8296a294d6e", "msg" : "trxcon/l1sched: drop Tx prims for not supported TCH modes", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "f81a1711f2f1f1f0b1c419a21033cbb9104fc9d4", "timestamp" : 1685361064000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: cosmetic: get rid of amr_is_cmr/fn_is_cmi\u000a\u000aChange-Id: Ic8df73326befa387daead0a0dcbb8c9a1461021e\u000aRelated: OS#4396\u000a", "date" : "2023-05-29 18:51:04 +0700", "id" : "f81a1711f2f1f1f0b1c419a21033cbb9104fc9d4", "msg" : "trxcon/l1sched: cosmetic: get rid of amr_is_cmr/fn_is_cmi", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c" ], "commitId" : "519f2d9c5b6b6fd7a630d3d0f7089bc7715e8eb1", "timestamp" : 1685361064000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: use sched_tchh_dl_facch_map[] in rx_tchh_fn()\u000a\u000aThis is a more effecient way to check if FACCH/H is allowed. The\u000amapping was added in a53e93fe9 and is already used for AMR.\u000a\u000aChange-Id: Ib4b409956326480679a436d28224b539d00779e2\u000aRelated: a53e93fe9 \"trxcon: Initial support for forwarding AMR\"\u000aRelated: OS#4396\u000a", "date" : "2023-05-29 18:51:04 +0700", "id" : "519f2d9c5b6b6fd7a630d3d0f7089bc7715e8eb1", "msg" : "trxcon/l1sched: use sched_tchh_dl_facch_map[] in rx_tchh_fn()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c" ], "commitId" : "f97238f766d87d3e1e4466559164f2362c2f454f", "timestamp" : 1685441670000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: fix UL FACCH regression in tx_tchh_fn()\u000a\u000aIn ad8f7794 I introduced a regression by removing the line setting\u000alchan->ul_facch_blocks, breaking transmission of Uplink FACCH/H.\u000a\u000aChange-Id: I4f2bbbd30c7d5dbb979b54455561df3c0cc12aac\u000aFixes: ad8f7794 \"trxcon/l1sched: remove redundant TCH/[FH] prim length checks\"\u000a", "date" : "2023-05-30 17:14:30 +0700", "id" : "f97238f766d87d3e1e4466559164f2362c2f454f", "msg" : "trxcon/l1sched: fix UL FACCH regression in tx_tchh_fn()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "6f26f0060381bf5bf88f4b7204aa03db6d146d77", "timestamp" : 1685441893000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: cosmetic: use variable names like in osmo-bts-trx\u000a\u000aThis way it's easier to keep trxcon in sync with osmo-bts-trx.\u000a\u000aChange-Id: I8138a45cca4e9063bf7d36ebc920b20b755138dd\u000aRelated: OS#4396\u000a", "date" : "2023-05-30 17:18:13 +0700", "id" : "6f26f0060381bf5bf88f4b7204aa03db6d146d77", "msg" : "trxcon/l1sched: cosmetic: use variable names like in osmo-bts-trx", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "af81e3ae596f2abc852848b602d77476c4f37967", "timestamp" : 1685441893000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: do not align Tx burst transmission\u000a\u000aThis is no longer needed thanks to recent patch b0be904b.\u000a\u000aChange-Id: Ia397cbe16f719729a814b7ef0b7035c7fe8ba165\u000aRelated: b0be904b \"trxcon: do not call l1sched_prim_dequeue() at ul_bid != 0\"\u000a", "date" : "2023-05-30 17:18:13 +0700", "id" : "af81e3ae596f2abc852848b602d77476c4f37967", "msg" : "trxcon/l1sched: do not align Tx burst transmission", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "d400126d0fe60783c10d99c96fcf42ddf3a8ee5f", "timestamp" : 1685464269000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Forward Paging Request Type 1/2 to rlcmac layer\u000a\u000aThe RLCMAC layer in libosmo-gprs-rlcmac will decode the messages and if\u000amatching the MS, forward it to GMM, who will see if it requires initiating\u000aa packet access procedure.\u000a\u000aChange-Id: Iee4b5ee5e1e5874b550dd8536b095bf0b5eeb8f4\u000a", "date" : "2023-05-30 16:31:09 +0000", "id" : "d400126d0fe60783c10d99c96fcf42ddf3a8ee5f", "msg" : "layer23: modem: Forward Paging Request Type 1/2 to rlcmac layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "0ee32177a28e7191bb1ddba9c4115352b1d366d7", "timestamp" : 1685475329000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: rework burst buffer shifting for TCH/[FH]\u000a\u000aThis is how the buffer shifting is implemented in osmo-bts-trx. Keep\u000atrxcon's l1sched implementation as close to osmo-bts-trx as possible\u000ain order to simplify the integration of CSD support.\u000a\u000aChange-Id: Idb6e415f37f41b8ab92a3864962dac0a40c2fbaa\u000aRelated: OS#4396\u000a", "date" : "2023-05-30 19:35:29 +0000", "id" : "0ee32177a28e7191bb1ddba9c4115352b1d366d7", "msg" : "trxcon/l1sched: rework burst buffer shifting for TCH/[FH]", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/rlcmac.c" ], "commitId" : "81b3237c884d348fe360bb31efc0c06946b29e3a", "timestamp" : 1686059778000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM\u000a\u000aChange-Id: Ife91ad87fed78daf86e9f28ceed981d61799758e\u000a", "date" : "2023-06-06 15:56:18 +0200", "id" : "81b3237c884d348fe360bb31efc0c06946b29e3a", "msg" : "layer23: modem: Forward LLC-TRANSMITTED.ind RLCMAC->GMM", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "dae9add949e6a288632da33ed73ac1c263201e43", "timestamp" : 1686059821000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Add helper function to get FN from gsm48_req_ref\u000a\u000aChange-Id: I1265a580f55473f52e77af6c5f53c1573f8f3e70\u000a", "date" : "2023-06-06 15:57:01 +0200", "id" : "dae9add949e6a288632da33ed73ac1c263201e43", "msg" : "layer23: modem: Add helper function to get FN from gsm48_req_ref", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c" ], "commitId" : "21541a748e7a55826ab58a9d810ec7b3c1732da5", "timestamp" : 1686153234000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "l1gprs: properly handle (forward) PTCCH/D blocks\u000a\u000aUnconditionally forward PTCCH/D blocks towards the upper layers.\u000aCalling l1gprs_pdch_filter_dl_block() on them makes no sense.\u000a\u000aChange-Id: Ifcc53d442426c8bfdacd3d179e20bb45c43f4644\u000aFixes: BTS_Tests.TC_pcu_ptcch (DL part)\u000aRelated: OS#5500, OS#5955\u000a", "date" : "2023-06-07 15:53:54 +0000", "id" : "21541a748e7a55826ab58a9d810ec7b3c1732da5", "msg" : "l1gprs: properly handle (forward) PTCCH/D blocks", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_prim.c" ], "commitId" : "a49696bc981ffe5acda576f6a076572255c38b54", "timestamp" : 1686153234000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: do not check TDMA Fn of PTCCH/U prims\u000a\u000aThe PTCCH/U primitives are basically Access Bursts. The TDMA Fn in\u000asuch primitives is always 0, because there's currently no way to\u000aindicate TDMA Fn in L1CTL_RACH_REQ (only the offset).\u000a\u000aChange-Id: I54ba9b5d9c3eba4aeabf9ed6fcf1e8d09f21cce1\u000aFixes: BTS_Tests.TC_pcu_ptcch (UL part)\u000aRelated: OS#5500, OS#5955\u000a", "date" : "2023-06-07 15:53:54 +0000", "id" : "a49696bc981ffe5acda576f6a076572255c38b54", "msg" : "trxcon/l1sched: do not check TDMA Fn of PTCCH/U prims", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/rlcmac.c" ], "commitId" : "b1e3742a94f5db2f396f4af1c04cf008e052e58e", "timestamp" : 1686153405000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: do not send RTS.ind if we got PTCCH/D\u000a\u000aChange-Id: Idcdf56de7fc6279d8b942f3670ecdc6f88c3dfd1\u000aRelated: OS#5500\u000a", "date" : "2023-06-07 15:56:45 +0000", "id" : "b1e3742a94f5db2f396f4af1c04cf008e052e58e", "msg" : "modem: do not send RTS.ind if we got PTCCH/D", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py", "src/target/trx_toolkit/burst_fwd.py", "src/target/trx_toolkit/ctrl_if_trx.py" ], "commitId" : "f5959f78cd19d20c2fd13607a19b1b1d6b085835", "timestamp" : 1686511531000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "fake_trx.py: remove SETSLOT based burst filtering\u000a\u000aFor the sake of simplicity and due to some performance limitations,\u000afake_trx.py does not generate TRXD NOPE indications for osmo-bts-trx\u000aon its own. It's actually trxcon sending NOPE.req (empty Tx PDUs)\u000awhen it has nothing to send, and fake_trx.py simply converting them.\u000a\u000aIn a follow-up change [1] we remove trxcon's internal clock module,\u000amaking the Uplink burst scheduling being driven by Downlink bursts\u000awith the respective TDMA Fn/Tn values. Given that fake_trx.py is\u000acurrently dropping bursts received for inactive timeslots, we would\u000aget NOPE.req only for a single timeslot, the one being currently\u000aactive. This would break several testcases in ttcn3-bts-test.\u000a\u000aRemove SETSLOT based burst filtering, so that trxcon would still be\u000aable to generate NOPE.req for all, active and inactive timeslots.\u000aDownlink bursts for inactive timeslots are discarded anyway.\u000a\u000aChange-Id: Ia42550d5c2d8b49efbdf8ef0ce46b26afd1c464e\u000aRelated: [1] Ic8a5b6277c6b16392026e0557376257d71c9d230\u000aRelated: OS#5500\u000a", "date" : "2023-06-11 19:25:31 +0000", "id" : "f5959f78cd19d20c2fd13607a19b1b1d6b085835", "msg" : "fake_trx.py: remove SETSLOT based burst filtering", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/ctrl_if_trx.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/burst_fwd.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h", "src/host/trxcon/src/trxcon_inst.c", "src/host/trxcon/src/Makefile.am", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/src/sched_clck.c", "src/host/trxcon/src/trxcon_shim.c", "src/host/trxcon/src/trxcon_main.c", "src/host/trxcon/src/sched_trx.c", "src/host/trxcon/include/osmocom/bb/trxcon/phyif.h", "src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h", "src/host/trxcon/src/trx_if.c" ], "commitId" : "45c821aee08e5f91273b0e203a1a04cff60114c8", "timestamp" : 1686511531000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "trxcon: get rid of the timer driven clock module\u000a\u000atrxcon was heavily inspired by osmo-bts-trx, and among with many other\u000ascheduling related parts also inherited the timer driven clock module.\u000a\u000aThis clock module is driving the Uplink burst scheduling, just like it\u000adoes drive the Downlink burst scheduling in osmo-bts-trx. Just like\u000ain osmo-bts-trx, the clock module relies on periodic CLCK indications\u000afrom the PHY, which are needed to compensate for the clock drifting.\u000a\u000aThe key difference is that trxcon is using Downlink bursts as the CLCK\u000aindications, see 'bi.fn % 51' in trx_data_rx_cb(). This is possible\u000abecause the MS is a clock slave of the BTS: the MS PHY needs to sync\u000aits freq. and clock first, and only after that it can Rx and Tx.\u000a\u000aSo far we've had no problems with the clock module in trxcon until we\u000astarted adding GPRS support and integrated the l1gprs. While the CS\u000adomain is quite flexible in terms of timings and delays, the PS domain\u000ais a lot more sensetive to the timing issues.\u000a\u000aSometimes it happens that the trxcon's clock module is ticking quicker\u000athan it should, resulting in Uplink PDCH blocks being scheduled earlier\u000athan the respective Downlink PDCH blocks are received:\u000a\u000a20230502021957724 l1sched_pull_burst(): PDTCH/U Tx time (fn=56103)\u000a20230502021957744 (PDCH-7) Rx DL BLOCK.ind (fn=56103, len=23): ...\u000a20230502021957747 l1sched_pull_burst(): PDTCH/U Tx time (fn=56108)\u000a20230502021957765 l1sched_pull_burst(): PDTCH/U Tx time (fn=56112)\u000a20230502021957767 (PDCH-7) Rx DL BLOCK.ind (fn=56108, len=23): ...\u000a20230502021957768 (PDCH-7) Rx UL BLOCK.req (fn=56112, len=54): ...\u000a20230502021957784 l1sched_pull_burst(): PDTCH/U Tx time (fn=56116)\u000a20230502021957784 TS7-PDTCH dropping Tx primitive (current Fn=56116, prim Fn=56112)\u000a\u000aThis is impossible in reality, because Uplink is intentionally lagging\u000abehind Downlink by 3 TDMA timeslot periods. In a virtual setup this\u000acauses sporadic dropping of Uplink PDCH blocks, as can be seen from\u000athe logging snippet above, and significantly degrades the RLC/MAC\u000aperformance for GPRS.\u000a\u000aLet's remove the internal clock module and trigger the Uplink burst\u000atransmission each time we receive a Downlink burst. This helps to\u000aovercome the GPRS scheduling issues and replicates the approach of\u000aosmo-trx-ms more closely.\u000a\u000aChange-Id: Ic8a5b6277c6b16392026e0557376257d71c9d230\u000aRelated: OS#5500\u000a", "date" : "2023-06-11 19:25:31 +0000", "id" : "45c821aee08e5f91273b0e203a1a04cff60114c8", "msg" : "trxcon: get rid of the timer driven clock module", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/phyif.h" }, { "editType" : "delete", "file" : "src/host/trxcon/src/sched_clck.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/Makefile.am" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_inst.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_shim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trx_if.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trxcon_main.c" ], "commitId" : "923e9b0b90622a7977c73ddd264d7cc48439098f", "timestamp" : 1686511531000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "trxcon: do not advance Uplink TDMA Fn by default\u000a\u000aThe idea behind advancing Uplink TDMA Fn is to give the transceiver,\u000awhich is usually a separate process, some additional time to receive\u000aand prepare Uplink bursts for transmission. This comes at a price\u000aof having an additional delay between Uplink and Downlink.\u000a\u000aGiven that trxcon, as a standalone application, is primarily used in\u000aconjunction with fake_trx.py for running ttcn3-bts-test against\u000aosmo-bts-trx, there is no reason to advance the Uplink TDMA Fn.\u000a\u000aChange-Id: I838b1ebc54e4c5d116f8af2155d97215a6133ba4\u000aRelated: OS#5500\u000a", "date" : "2023-06-11 19:25:31 +0000", "id" : "923e9b0b90622a7977c73ddd264d7cc48439098f", "msg" : "trxcon: do not advance Uplink TDMA Fn by default", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "96fec1646d714ab1880bf69106c0c556fd849ba3", "timestamp" : 1686750821000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix -Wlogical-not-parentheses in gsm48_cc_init()\u000a\u000aFound by clang:\u000a\u000a gsm48_cc.c:54:6: warning: logical not is only applied to the left\u000a hand side of this comparison [-Wlogical-not-parentheses]\u000a if (!cc->mncc_upqueue.next == 0)\u000a ^ ~~\u000a\u000aChange-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858\u000a", "date" : "2023-06-14 20:53:41 +0700", "id" : "96fec1646d714ab1880bf69106c0c556fd849ba3", "msg" : "mobile: fix -Wlogical-not-parentheses in gsm48_cc_init()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/subscriber.c" ], "commitId" : "df900478de4f3931539c9f2b0387f9800a785f9f", "timestamp" : 1686821025000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "layer23: Update to libosmocore osmo_auth_gen_vec2\u000a\u000alibosmogsm has recently deprecated the use of osmo_auth_gen_vec\u000aand the osmo_sub_auth_data structure in favor of newer versions\u000aof this API. Let's migrate to it\u000a\u000aChange-Id: I1d9751c5f74a59e7310d07d54a3fdbac213324bd\u000aDepends: libosmocore.git Ie775fedba4a3fa12314c0f7c8a369662ef6a40df\u000a", "date" : "2023-06-15 09:23:45 +0000", "id" : "df900478de4f3931539c9f2b0387f9800a785f9f", "msg" : "layer23: Update to libosmocore osmo_auth_gen_vec2", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/subscriber.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/main.c", "src/host/layer23/src/common/main.c" ], "commitId" : "749f0a461cc78b0fbd17f3eeee36dace4ba9c8be", "timestamp" : 1686873119000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: fix handling of logging category mask (-d option)\u000a\u000aIn change 67943df4 I broke handling of the logging category mask in\u000athe mobile app. Adding this option results in a segfault:\u000a\u000a ERROR: osmo_log_info == NULL! You must call log_init() before\u000a using logging in log_parse_category_mask()!\u000a Assert failed osmo_log_info src/libosmocore/src/core/logging.c:329\u000a\u000aAs can be seen, the problem is that we are calling\u000alog_parse_category_mask() before initializing the logging.\u000a\u000aAs possible solution, I could rearrange the code to parse command\u000aline options after calling osmo_init_logging2(). This would fix\u000athe segfault, but would not fully solve the problem.\u000a\u000aIf we call log_parse_category_mask() before parsing the config file,\u000athen logging configuration in the config file overwrites the logging\u000aconfiguration specified via the command line. But we want the\u000aopposite: the command line setting should overwrite the config file\u000aparameters. This is handy because there is no need to edit the\u000aconfig file if you quickly need to test something.\u000a\u000aSo let's call log_parse_category_mask() after parsing the config file.\u000a\u000aChange-Id: I1b2b7804bf99b71f96e9197f7824cfd20431e8a1\u000aFixes: 67943df4 \"layer23: fix parsing of command line options\"\u000a", "date" : "2023-06-16 06:51:59 +0700", "id" : "749f0a461cc78b0fbd17f3eeee36dace4ba9c8be", "msg" : "layer23: fix handling of logging category mask (-d option)", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/main.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "321148964906c1f83727c2ad0e5dc4de0ff20f89", "timestamp" : 1686940839000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: cosmetic: fix formatting in modem_gmm_prim_up_cb()\u000a\u000aChange-Id: I1498b92f2dc3d056ca69072dfb077cba65b86b6e\u000a", "date" : "2023-06-17 01:40:39 +0700", "id" : "321148964906c1f83727c2ad0e5dc4de0ff20f89", "msg" : "modem: cosmetic: fix formatting in modem_gmm_prim_up_cb()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "bc04784b1412834c86a6ff8635df0c7b805bd55b", "timestamp" : 1687451555000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: cosmetic: move to other libosmo* imports\u000a\u000aChange-Id: Id4d8df3f230729dc2c65e1bedea705e28feaa029\u000a", "date" : "2023-06-22 23:32:35 +0700", "id" : "bc04784b1412834c86a6ff8635df0c7b805bd55b", "msg" : "layer23: cosmetic: move to other libosmo* imports", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "9f61426a15cfde452a15c338238c35df76d09d56", "timestamp" : 1687453284000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: use gsm0502_fn2ccch_block() from libosmogsm\u000a\u000aChange-Id: I652a2ab9ddb3cb5082cce911a5cdb4cf8abcf552\u000aDepends: libosmocore.git I8cbd31226754e95887358ed83a928e2f567f4cf3\u000a", "date" : "2023-06-23 00:01:24 +0700", "id" : "9f61426a15cfde452a15c338238c35df76d09d56", "msg" : "layer23: use gsm0502_fn2ccch_block() from libosmogsm", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "60215bc051c96d87c552ece42d594be7f7388c4f", "timestamp" : 1688409813000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: properly handle Dedicated mode or TBF IE\u000a\u000aWe need to distinguish between Uplink and Downlink TBF assignment in\u000agrr_rx_imm_ass(), because matching the Request Reference IE makes\u000asense only for the Uplink TBF assignment.\u000a\u000aUplink TBFs are requested by the UEs by sending RACH, while Downlink\u000aTBFs are assigned by the network itself. The Request Reference IE\u000ais only valid for Uplink assignments and shall be ignored in messages\u000aassigning Downlink TBFs.\u000a\u000aChange-Id: Idb9b3203147be3b42256c0bcab3ecdabcf2d2fa9\u000aRelated: OS#5500\u000a", "date" : "2023-07-04 01:43:33 +0700", "id" : "60215bc051c96d87c552ece42d594be7f7388c4f", "msg" : "modem: properly handle Dedicated mode or TBF IE", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_lchan_common.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" ], "commitId" : "d84b2ed6eda89d8e055d0073b50e3cc6e2b31a95", "timestamp" : 1689108591000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: fix handling of UL FACCH on TCH/A[FH]S\u000a\u000aIn ad8f7794 I changed both tx_tch[fh]_fn() to use a switch statement\u000aand introduced a regression by removing special treatment of FACCH:\u000a\u000a@@ -238,10 +237,16 @@ int tx_tchf_fn(struct l1sched_lchan_state *lchan,\u000a- if (msgb_l2len(lchan->prim) == GSM_MACBLOCK_LEN) {\u000a- /* Encode payload */\u000a- rc = gsm0503_tch_fr_encode(buffer, msgb_l2(lchan->prim), GSM_MACBLOCK_LEN, 1);\u000a- } else if (lchan->tch_mode == GSM48_CMODE_SPEECH_AMR) {\u000a@@ -459,10 +458,15 @@ int tx_tchh_fn(struct l1sched_lchan_state *lchan,\u000a- if (msgb_l2len(lchan->prim) == GSM_MACBLOCK_LEN) {\u000a- rc = gsm0503_tch_hr_encode(buffer, msgb_l2(lchan->prim), GSM_MACBLOCK_LEN);\u000a- lchan->ul_facch_blocks = 6;\u000a- } else if (lchan->tch_mode == GSM48_CMODE_SPEECH_AMR) {\u000a\u000aNow if the channel mode is GSM48_CMODE_SPEECH_AMR, UL FACCH/[FH] frames\u000awill be fed to osmo_amr_rtp_dec(), which is definitely wrong. Fix this\u000aby doing all AMR specific checks in a separate function, which is\u000acalled only for speech frames.\u000a\u000aChange-Id: Ie217bbb389b5abb95d241781ffe3f5c7b1c188c0\u000aFixes: ad8f7794 \"trxcon/l1sched: remove redundant TCH/[FH] prim length checks\"\u000aRelated: OS#4396\u000a", "date" : "2023-07-12 03:49:51 +0700", "id" : "d84b2ed6eda89d8e055d0073b50e3cc6e2b31a95", "msg" : "trxcon/l1sched: fix handling of UL FACCH on TCH/A[FH]S", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_common.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_common.c" ], "commitId" : "58bd4e712a98d10e3c5104c83ea095553c8bae19", "timestamp" : 1689108591000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: remove unused vars in l1sched_lchan_amr_prim_is_valid()\u000a\u000aChange-Id: I57e18866addc2245c017e354eab218f56583026c\u000aRelated: OS#4396\u000a", "date" : "2023-07-12 03:49:51 +0700", "id" : "58bd4e712a98d10e3c5104c83ea095553c8bae19", "msg" : "trxcon/l1sched: remove unused vars in l1sched_lchan_amr_prim_is_valid()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_common.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/src/sched_lchan_desc.c", "src/host/trxcon/include/osmocom/bb/l1sched/prim.h", "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_rach.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_trx.c", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "a22acea3a9db44d891080caaed8619114386afff", "timestamp" : 1689108754000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: rework dequeueing of Tx prims\u000a\u000aCentralized dequeueing of Tx prims in l1sched_pull_burst() is a working\u000aapproach, but doing this in each logical channel handler individually\u000ais a lot more flexible. This is how it's done in osmo-bts-trx, and\u000athis allows implementing FACCH support for CSD channels.\u000a\u000aChange-Id: I3d6c2136ff1855ab0aa9062b20b2a64fd0e5fe28\u000aRelated: OS#4396, OS#1572\u000a", "date" : "2023-07-12 03:52:34 +0700", "id" : "a22acea3a9db44d891080caaed8619114386afff", "msg" : "trxcon/l1sched: rework dequeueing of Tx prims", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_desc.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_rach.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/prim.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c" ], "commitId" : "21aacfe7096ef27fe40c22d20a86d2303f9cba91", "timestamp" : 1689108754000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: peoperly prioritize FACCH/H over TCH\u000a\u000aUnlike FACCH/F, which steals one TCH frame, FACCH/H steals two TCH\u000aframes. This is what prim_dequeue_tchh() aims to implement, but\u000athe current implementation is not 100% correct.\u000a\u000aThe problem is that we're attempting to dequeue and drop two TCH frames\u000ain one go, whenever we get a FACCH/H frame. Most likely, there will be\u000ano 2nd TCH frame in the Tx queue at that time, so it will never be\u000adropped and will clog the queue.\u000a\u000aLet's replicate what osmo-bts-trx does:\u000a\u000a* dequeue and drop the 1st TCH frame when sending 1st/6 burst of FACCH,\u000a* dequeue and drop the 2nd TCH frame when sending 3rd/6 burst of FACCH.\u000a\u000aChange-Id: I513d6805ddf97783c002be285fb3ca7893e42377\u000aRelated: OS#4396, OS#1572\u000a", "date" : "2023-07-12 03:52:34 +0700", "id" : "21aacfe7096ef27fe40c22d20a86d2303f9cba91", "msg" : "trxcon/l1sched: peoperly prioritize FACCH/H over TCH", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "44282c0fe8957ef43853ab982e9bf4a30e54efde", "timestamp" : 1689108754000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: simplify and unify prim_dequeue_tchf()\u000a\u000aMake it easier to read and more similar to prim_dequeue_tchh().\u000a\u000aChange-Id: Ie79069e5cc8acd193a326ac9d334fe070552e320\u000a", "date" : "2023-07-12 03:52:34 +0700", "id" : "44282c0fe8957ef43853ab982e9bf4a30e54efde", "msg" : "trxcon/l1sched: simplify and unify prim_dequeue_tchf()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_common.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/include/osmocom/bb/l1sched/prim.h", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "fd8962e89144fb0af4b99199589d9f9768804640", "timestamp" : 1689108754000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: do not craft artificial BFI frames on TCH\u000a\u000aWhenever decoding fails or a FACCH setaling happens, simply send an\u000aempty DATA.ind to the upper layers. On the Uplink path, use a dummy\u000aLAPDm func=UI frame (with random padding) whenever possible.\u000a\u000aCrafting TCH frames with zeroes is not really needed and moreover makes\u000ait hard to distinguish between valid speech frames and BFIs. This also\u000aused to be the case for osmo-bts-trx, but not anymore (see the related\u000apatch).\u000a\u000aChange-Id: I20391b860fbc2ce8f0f03d7ba95ef7a098c0f9db\u000aRelated: osmo-bts.git I8f9fb5b8c5b2cad4b92ac693c0040779f811981a\u000a", "date" : "2023-07-12 03:52:34 +0700", "id" : "fd8962e89144fb0af4b99199589d9f9768804640", "msg" : "trxcon/l1sched: do not craft artificial BFI frames on TCH", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_common.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/prim.h" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "0cfd0bbe801d86e1a3cbc08b228f9ad2521ebd08", "timestamp" : 1689108754000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: transmit dummy speech blocks with inverted CRC3\u000a\u000aIn case when an Uplink TCH/[FH]S frame needs to be transmitted, but\u000athere is no frame available in the Tx queue, transmit an intentionally\u000ainvalid block with inverted CRC3. This will induce a BFI condition in\u000athe BTS side receiver. See also the related osmo-bts-trx patch.\u000a\u000aChange-Id: I16ff09a220da13c2c76538bc43354afc4e688794\u000aDepends: libosmocore.git Iade3310e16b906efb6892d28f474a0d15204e861\u000aRelated: osmo-bts.git I78106802a0aa4af39859c75d29fe0e77037899fe\u000a", "date" : "2023-07-12 03:52:34 +0700", "id" : "0cfd0bbe801d86e1a3cbc08b228f9ad2521ebd08", "msg" : "trxcon/l1sched: transmit dummy speech blocks with inverted CRC3", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "7e262322d1d376bcb1117f4b0ca213e2f8fd8855", "timestamp" : 1689847769000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: gmm: Forward GMMSM-Modify.ind to SM layer\u000a\u000aDepends: libosmo-gprs.git Change-Id Ic765b7a565cac4abcf34d8c6868e103971d17822\u000aChange-Id: I3cd90ad85fb77b09c3300e87e454c4fe641edc88\u000a", "date" : "2023-07-20 12:09:29 +0200", "id" : "7e262322d1d376bcb1117f4b0ca213e2f8fd8855", "msg" : "layer23: modem: gmm: Forward GMMSM-Modify.ind to SM layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/llc.c" ], "commitId" : "3a031345e16d807e8c48ef2bb4e9fe6ee893556b", "timestamp" : 1689847777000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: llc: Forward LL-Assign.req to SNDCP\u000a\u000aDepends: libosmo-gprs.git Change-Id I924dcf3ac9cbb15e26a5e9376f89ca098ab49e0b\u000aChange-Id: I0b0f025a0cd356c997fc4620f2d6be4792fc1d29\u000a", "date" : "2023-07-20 12:09:37 +0200", "id" : "3a031345e16d807e8c48ef2bb4e9fe6ee893556b", "msg" : "layer23: modem: llc: Forward LL-Assign.req to SNDCP", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/llc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "19450eb435e07649b1f48201526ffda17f1e0219", "timestamp" : 1689849381000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: gmm: Update own TLLI copy though GMMRR-Assign.req hook\u000a\u000aThis is needed in order to provide updated TLLI when submitting new user\u000adata from the tundev to the SNDCP layer.\u000a\u000aChange-Id: I5c6a2c371ae6d65bf4fe23e665ec939da37112be\u000a", "date" : "2023-07-20 12:36:21 +0200", "id" : "19450eb435e07649b1f48201526ffda17f1e0219", "msg" : "layer23: modem: gmm: Update own TLLI copy though GMMRR-Assign.req hook", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/modem/rlcmac.c", "src/host/layer23/include/osmocom/bb/common/ms.h", "src/host/layer23/include/osmocom/bb/modem/grr.h" ], "commitId" : "3f0f1a421497657589268e5f4a37811232b05474", "timestamp" : 1690200041000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: implement GPRS-RR FSM\u000a\u000aChange-Id: I8a7d85df7b07d85ac86e0b7e340f6bbacc65e1bc\u000a", "date" : "2023-07-24 14:00:41 +0200", "id" : "3f0f1a421497657589268e5f4a37811232b05474", "msg" : "layer23: modem: implement GPRS-RR FSM", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/grr.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/rlcmac.c" ], "commitId" : "5462ad040cd75353f8d53f68a0370bf82784a39b", "timestamp" : 1690200047000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "modem: handle OSMO_GPRS_RLCMAC_L1CTL_PDCH_{ESTABLISH,RELEASE}\u000a\u000aChange-Id: Ic39ce696834943dc661c85cbf3d54ccd598b60ce\u000aDepends: libosmo-gprs.git I2568c58646ce7511367275ac96cd55e7fdd7ec18\u000a", "date" : "2023-07-24 14:00:47 +0200", "id" : "5462ad040cd75353f8d53f68a0370bf82784a39b", "msg" : "modem: handle OSMO_GPRS_RLCMAC_L1CTL_PDCH_{ESTABLISH,RELEASE}", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trx_if.c" ], "commitId" : "e9bfff30ac73dd13f9114904f44ea7c8d0c5c101", "timestamp" : 1690200047000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "trxcon: trx_if_cmd_poweron(): send CMD POWERON unconditionally\u000a\u000aThis works-around a race condition happening when the upper layers\u000aare sending L1CTL RESET.req immediately followed by L1CTL FBSB.req.\u000aThe problem is that the TRXC logic is considering the transceiver\u000apowered on until a response to CMD POWEROFF is received.\u000a\u000aChange-Id: I967ce047eb198f1eaf8446bb4c1f87a98d3de264\u000aRelated: OS#5500\u000a", "date" : "2023-07-24 14:00:47 +0200", "id" : "e9bfff30ac73dd13f9114904f44ea7c8d0c5c101", "msg" : "trxcon: trx_if_cmd_poweron(): send CMD POWERON unconditionally", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trx_if.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "0a6ad6bbf882cddc7a3b6634879baad3ca085c28", "timestamp" : 1690200047000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Submit L1CTL-CCCH_READY.ind\u000a\u000aSignal RLC/MAC layer that the lower layers is in packet idle mode ready\u000ato use CCCH (such as packet-access-procedure).\u000a\u000aChange-Id: I05050e840a3b267b3b3a278588ee113b45bfbd4c\u000a", "date" : "2023-07-24 14:00:47 +0200", "id" : "0a6ad6bbf882cddc7a3b6634879baad3ca085c28", "msg" : "layer23: modem: Submit L1CTL-CCCH_READY.ind", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/include/osmocom/bb/modem/modem.h" ], "commitId" : "345d03a6f6eb4c2d9511774b1eda33f0a886742a", "timestamp" : 1690200047000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Delay using cell until fully synced to it\u000a\u000aChange-Id: If306d82879281bb540c5cdee2eaf354858c8d24b\u000a", "date" : "2023-07-24 14:00:47 +0200", "id" : "345d03a6f6eb4c2d9511774b1eda33f0a886742a", "msg" : "layer23: modem: Delay using cell until fully synced to it", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/modem.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "89ef574fe2257f65ae4140b71620589e8c0726e9", "timestamp" : 1690200047000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Avoid direct transition ST_PACKET_TRANSFER->ST_PACKET_IDLE\u000a\u000aRight now the existing code is switching to state IDLE and hence running\u000agrr_st_packet_idle_onenter() which attempts stuff like starting an attach.\u000aThis is all done while the L1CTL RESET + FBSB is still in progress. We\u000ashould instead wait to receive confirmation from those.\u000aAs an easy implementation for now, simply switch to the\u000aGRR_ST_PACKET_NOT_READY state, which will move to GRR_ST_PACKET_IDLE\u000aonce it starts receiving CCCH blocks (aka it will already have gone\u000athrough L1CTL RESET + FBSB completely).\u000a\u000aChange-Id: Ie797b36701d10c6052500c637a08b061bb1e4bd7\u000a", "date" : "2023-07-24 14:00:47 +0200", "id" : "89ef574fe2257f65ae4140b71620589e8c0726e9", "msg" : "layer23: modem: Avoid direct transition", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_common.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/include/osmocom/bb/l1sched/prim.h", "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_rach.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/src/sched_trx.c", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "3f409eb94eac9ffa67a7528f29f58275f0b836b8", "timestamp" : 1690490077000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: emit DATA.cnf early (on bid=0)\u000a\u000atrxcon's scheduler is currently emitting DATA.cnf whenever the last\u000aburst of a DATA.req has been transmitted. This sounds logical, but\u000amakes the implementation quite complex. It's even harder to implement\u000asending of DATA.cnf properly for CSD specific channel modes, which are\u000ato be implemented in a follow-up patch.\u000a\u000aThe DATA.cnf prims trigger sending of L1CTL DATA.cnf/TRAFFIC.cnf,\u000awhich are interpreted as Ready-to-Send by the upper layers (layer23).\u000aAdditionally DATA.cnf prims trigger sending of GSMTAP PDUs containing\u000athe respective Uplink frames.\u000a\u000aThis patch changes the l1sched logic, so that a DATA.cnf primitive\u000ais emitted whenever the respective DATA.req is dequeued and encoded\u000ausing the lchan specific channel coding function. This simplifies\u000athe code a lot and prepares for the upcoming CSD support.\u000a\u000aAs a bonus, this patch fixes an inconsistency between TDMA FNs reported\u000ain Uplink and Downlink GSMTAP PDUs. Now we're indicating the first Fn\u000ain both cases, so Uplink is consistent with Downlink.\u000a\u000aChange-Id: Ie09a24cd950a93edd871a9fbc5b47ec96c24cceb\u000aRelated: OS#4396, OS#1572\u000a", "date" : "2023-07-27 20:34:37 +0000", "id" : "3f409eb94eac9ffa67a7528f29f58275f0b836b8", "msg" : "trxcon/l1sched: emit DATA.cnf early (on bid=0)", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_common.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/prim.h" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_rach.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/app_modem.c", "src/host/layer23/src/modem/sm.c", "src/host/layer23/include/osmocom/bb/common/apn.h" ], "commitId" : "33dd069aa801d84e0360dcb4079230462aea8ec1", "timestamp" : 1690493132000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Validate IP version of UL data packets from tun match PDP context setup\u000a\u000aChange-Id: I3fe56fcbdbb6be3366829a14a433b735f7f9d43c\u000a", "date" : "2023-07-27 21:25:32 +0000", "id" : "33dd069aa801d84e0360dcb4079230462aea8ec1", "msg" : "layer23: modem: Validate IP version of UL data packets from tun match", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/apn.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/app_modem.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/sm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "c8b951e276953e6a6f5420df4b111b25c5ad5822", "timestamp" : 1690818375000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Fix newline character typo in log line\u000a\u000aChange-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c\u000a", "date" : "2023-07-31 17:46:15 +0200", "id" : "c8b951e276953e6a6f5420df4b111b25c5ad5822", "msg" : "layer23: modem: Fix newline character typo in log line", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "e2fd48e7d783a92e862527d5d5b88e6c14dc06d2", "timestamp" : 1690819399000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: gmm: Log allocated TLLI on Attach Success\u000a\u000aChange-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a\u000a", "date" : "2023-07-31 18:03:19 +0200", "id" : "e2fd48e7d783a92e862527d5d5b88e6c14dc06d2", "msg" : "layer23: modem: gmm: Log allocated TLLI on Attach Success", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/gmm.c" ], "commitId" : "171ba463828af143911d38e8a4885759f9d2e389", "timestamp" : 1690819977000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: gmm: Adapt log string about no TLLI found\u000a\u000aDuring initial GMM Attach, the GMM layer generates an internal\u000alocal TLLI and uses it to do the GMM Attach. Only at the time it\u000areceives the GMM Attach Accept with the assigned TLLI from the network\u000athen explicitly informs other layers about the TLLI update.\u000aHence, the GMMREG user doesn't really know about the TLLI in use until\u000athe GMM Attach success happens (gmmreg-attach.cnf).\u000aDuring that time, the TLLI at the app is basically unassigned\u000a(0xffffffff). Hence, during that same time a TLLI update hook in\u000aGMMRR-Assign.req will not work since the app is unaware of the remporary\u000alocal TLLI, so no match can be done.\u000aIn that specific scenario, that's fine, since anyway it is waiting to\u000areceive the GMMREG-Attach.cnf, which will indicate the assigned TLLI to\u000ait.\u000aIn summary, not being able to match the TLLI in GMMRR-Assign.req is not\u000abad per se, so soften the log error there.\u000a\u000aChange-Id: I31c04288789393391084000fbdbcdcedb11d0b68\u000a", "date" : "2023-07-31 18:12:57 +0200", "id" : "171ba463828af143911d38e8a4885759f9d2e389", "msg" : "layer23: modem: gmm: Adapt log string about no TLLI found", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/gmm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/vty.c" ], "commitId" : "845ad38328db3134f271ae696d14f7ece88315d8", "timestamp" : 1691469033000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "Fix VTY command to set IMEISV.\u000a\u000aThe pointer and size must given for the SV portion of the character\u000aarray only.\u000a\u000aFixes: CID#314049, CID#314048\u000aChange-Id: Ieff4ca886dec71aae1b6ecf2b623d600426580da\u000a", "date" : "2023-08-08 04:30:33 +0000", "id" : "845ad38328db3134f271ae696d14f7ece88315d8", "msg" : "Fix VTY command to set IMEISV.", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "d524c17d907b39189c1c7b465b8f40db2d79f55b", "timestamp" : 1691591886000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1ctl: Fill ph_data_param fn field\u000a\u000aRelated: OS#3626\u000aChange-Id: I3317296b2bda1088a2af81ba9b135714f8393afd\u000a", "date" : "2023-08-09 16:38:06 +0200", "id" : "d524c17d907b39189c1c7b465b8f40db2d79f55b", "msg" : "l1ctl: Fill ph_data_param fn field", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "8bbd0d173fad3708fac3207d56dd04c14912351e", "timestamp" : 1691670486000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1ctl: Fix fill ph_data_param fn field\u000a\u000aThis commit fixes recent previous commit filling in the fn field. The\u000adl->frame_nr is network order, and we want to pass a host order integer\u000ain the primitive. Use the tm.fn which already includes the proper value\u000acalculated from dl->frame_nr.\u000a\u000aFixes: d524c17d907b39189c1c7b465b8f40db2d79f55b\u000aRelated: OS#3626\u000aChange-Id: Id96015c8b419932abb8095c6cb85aceef34e366f\u000a", "date" : "2023-08-10 14:28:06 +0200", "id" : "8bbd0d173fad3708fac3207d56dd04c14912351e", "msg" : "l1ctl: Fix fill ph_data_param fn field", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c", "src/host/layer23/include/osmocom/bb/common/l1ctl.h", "include/l1ctl_proto.h", "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "8b4640ec19d95735363c635b84ca814d9c35ab76", "timestamp" : 1691673409000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1ctl_proto: add 'start_fn' field to UL/DL TBF CFG.req messages\u000a\u000aChange-Id: Ibb6a05165fe1c81268fb0e3674adae4065e78171\u000aRelated: OS#5500\u000a", "date" : "2023-08-10 15:16:49 +0200", "id" : "8b4640ec19d95735363c635b84ca814d9c35ab76", "msg" : "l1ctl_proto: add 'start_fn' field to UL/DL TBF CFG.req messages", "paths" : [ { "editType" : "edit", "file" : "include/l1ctl_proto.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/l1ctl.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c" ], "commitId" : "3ac817108eeb94ead29b0644c872d0a67abf2943", "timestamp" : 1691769858000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1gprs: Fix slotmask update on already registered tbf\u000a\u000aChange-Id: I5d64488d2aa740e91e01fad17f2af3ded24b12ef\u000a", "date" : "2023-08-11 18:04:18 +0200", "id" : "3ac817108eeb94ead29b0644c872d0a67abf2943", "msg" : "l1gprs: Fix slotmask update on already registered tbf", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c", "src/host/trxcon/src/trxcon_fsm.c", "include/l1gprs.h" ], "commitId" : "fb384998fbddcc545eec76da41db1aa41b583aa9", "timestamp" : 1691776052000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req\u000a\u000aChange-Id: I4c2ff25217fba0b6b4704f023071b86ed9afb55c\u000aRelated: OS#5500\u000a", "date" : "2023-08-11 19:47:32 +0200", "id" : "fb384998fbddcc545eec76da41db1aa41b583aa9", "msg" : "trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req", "paths" : [ { "editType" : "edit", "file" : "include/l1gprs.h" }, { "editType" : "edit", "file" : "src/shared/l1gprs.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "13b1946fa7888f033fdffd2229f73eea52702a08", "timestamp" : 1692884871000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: Pass fn from lapdm to L1CTL-CCCH_DATA.ind\u000a\u000aChange-Id: I7a9f31ae363fe7de019ff1a906f3978ff3074036\u000a", "date" : "2023-08-24 15:47:51 +0200", "id" : "13b1946fa7888f033fdffd2229f73eea52702a08", "msg" : "layer23: modem: Pass fn from lapdm to L1CTL-CCCH_DATA.ind", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c", "include/l1gprs.h" ], "commitId" : "71e39bccf1e509bde86fd1f2cd0c7fc5e5675342", "timestamp" : 1692884874000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1gprs: implement TBF starting time support\u000a\u000aChange-Id: I174e3c43d2f4c828a528710b284e62c9bb794122\u000aRelated: OS#5500\u000a", "date" : "2023-08-24 15:47:54 +0200", "id" : "71e39bccf1e509bde86fd1f2cd0c7fc5e5675342", "msg" : "l1gprs: implement TBF starting time support", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" }, { "editType" : "edit", "file" : "include/l1gprs.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c" ], "commitId" : "9fcf7a45b2dd07ef1e5c956ea05ad2631b7d372d", "timestamp" : 1692884874000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1gprs: Improve logging fn and tn in BLOCK.req\u000a\u000aChange-Id: Iba29d88770e79fee0e4ac3c8f4e833907afa5b52\u000a", "date" : "2023-08-24 15:47:54 +0200", "id" : "9fcf7a45b2dd07ef1e5c956ea05ad2631b7d372d", "msg" : "l1gprs: Improve logging fn and tn in BLOCK.req", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c" ], "commitId" : "a98f0bd93065fef09d7a43b7bc55a35637201c0d", "timestamp" : 1692884874000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1gprs: Log slotmask when logging TBF\u000a\u000aChange-Id: Ib96b01c591dbcc6aa9e0527e0be499ef8aee2863\u000a", "date" : "2023-08-24 15:47:54 +0200", "id" : "a98f0bd93065fef09d7a43b7bc55a35637201c0d", "msg" : "l1gprs: Log slotmask when logging TBF", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "d130d9d7b1b424a43c8f90b3b6bab45fbb431176", "timestamp" : 1692884874000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "layer23: modem: pass TBF starting time from CFG UL/DL TBF Req\u000a\u000aChange-Id: Iae53c6e704a5b868a265216d4cb48b1edc2d7e61\u000aDepends: libosmo-gprs.git I27a7a896fe3839fa4f9b8cd9500c4ab7867bbaa0\u000aRelated: OS#5500\u000a", "date" : "2023-08-24 15:47:54 +0200", "id" : "d130d9d7b1b424a43c8f90b3b6bab45fbb431176", "msg" : "layer23: modem: pass TBF starting time from CFG UL/DL TBF Req", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_common.c", "src/host/trxcon/src/l1ctl.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h", "src/host/trxcon/src/sched_lchan_desc.c", "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_prim.c", "src/host/trxcon/src/sched_lchan_tchf.c", "src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h", "src/host/trxcon/src/sched_lchan_xcch.c" ], "commitId" : "a93785bf437c45131aad0bac52b7c3f3db9ecee3", "timestamp" : 1693120494000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: implement CSD scheduling support\u000a\u000aThis patch adds support for TCH/[FH]2.4, TCH/[FH]4.8, TCH/F9.6 and\u000aTCH/F14.4 (including FACCH). Additional changes made:\u000a\u000a* enlarge the maximum TCH burst buffer size to 24 * (2 * 58) bytes;\u000a* enlarge per-l1cs UL/DL burst masks to hold up to 32 bits;\u000a* enlarge per-l1cs DL meas ring buffer to 24 entries;\u000a* enlarge L1SCHED_PRIM_TAILROOM from 256 to 512 bytes;\u000a* enlarge L1CTL_LENGTH from 256 to 512 bytes;\u000a\u000aChange-Id: I0d7389a9a5f7019b9316ab1c0115797ff54a0e41\u000aDepends: libosmocore.git Ib482817b5f6a4e3c7299f6e0b3841143b60fc93d\u000aDepends: libosmocore.git I0c7a9c180dcafe64e6aebe53518d3d11e1f29886\u000aDepends: libosmocore.git I4685376c8deb04db670684c9ebf685ad6fc989fa\u000aRelated: OS#4396, OS#1572\u000a", "date" : "2023-08-27 07:14:54 +0000", "id" : "a93785bf437c45131aad0bac52b7c3f3db9ecee3", "msg" : "trxcon/l1sched: implement CSD scheduling support", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_common.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_desc.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/l1ctl.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_xcch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_mframe.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" ], "commitId" : "096a3cc6f3e982df09836b70a5adcd57a4b93ab9", "timestamp" : 1693152638000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: refactor l1sched_mframe_layout()\u000a\u000aChange-Id: Ie1c3679879ef97d42237d6723d1619ac0ef97f6b\u000a", "date" : "2023-08-27 16:10:38 +0000", "id" : "096a3cc6f3e982df09836b70a5adcd57a4b93ab9", "msg" : "trxcon/l1sched: refactor l1sched_mframe_layout()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_mframe.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_prim.c" ], "commitId" : "c20f3f3f19dca217392c1e613aa1dbe8b6d37865", "timestamp" : 1693839535000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "trxcon: Print fn in prim_enqueue()\u000a\u000aChange-Id: I3725a77cbfb116697c1287edbac9068e64768a19\u000a", "date" : "2023-09-04 16:58:55 +0200", "id" : "c20f3f3f19dca217392c1e613aa1dbe8b6d37865", "msg" : "trxcon: Print fn in prim_enqueue()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/Makefile", "src/target/firmware/board/tr800/afcparams.c", "src/target/firmware/board/tr800/init.c", "src/target/firmware/board/tr800/rffe_leo_quadband.c", "src/target/firmware/board/tr800/keymap.h" ], "commitId" : "59e649dbf1e1e71d38ab6fc40d2feb6fe6195f54", "timestamp" : 1693858752000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "firmware: board: add support for TR-800 target\u000a\u000aiWOW TR-800 is a packaged GSM modem module based on Calypso+Iota+Rita\u000achipset; it is fully quadband, and reverse engineering of its PCB\u000aconfirms that this module is nothing but a mass-produced version of\u000athe core of TI's legendary Leonardo+ reference platform. The same\u000amodule is also known as FreeCalypso Tango - a rebranded version of\u000athe same hardware module with different firmware and a different\u000aResponsible Party for official support.\u000a\u000aFreeCalypso HQ is contributing OsmocomBB support for this Calypso\u000amodem module for two reasons:\u000a\u000a1) Harm reduction - sooner or later someone in Osmocom universe is\u000a going to run OBB firmware on TR-800 once they lay their hands on\u000a this hardware, and the resulting operation will be less harmful /\u000a closer to correct if we provide the basic board support patch.\u000a\u000a2) There exists a large surplus of FreeCalypso Caramel2 development\u000a boards that are based around FC Tango modules. Having this hw\u000a supported by both firmwares will hopefully increase the chances\u000a that these boards will find loving homes, as opposed to continuing\u000a to gather dust in a cardboard box.\u000a\u000aLegal and ethical disclaimer: OsmocomBB firmware running on ANY\u000aCalypso+Iota+Rita target is *known*, through confirmed observations\u000awith a measuring instrument (R&S CMU200), to put out radio transmissions\u000athat are *severely out of spec*, and this defect does NOT go away\u000awith the present patch which merely adds support for a different C+I+R\u000aboard target. The present patch has been produced as a harm reduction\u000ameasure, to reduce (but not to zero) the harm that will be caused\u000aby parties who run OsmocomBB firmware on C+I+R hardware despite having\u000abeen advised not to. As the party seeking to reduce rather than cause\u000athat harm, Mother Mychaela and her related business entities explicitly\u000adisclaim all liability for damage that will be caused by parties who\u000acontinue running OsmocomBB firmware despite having been repeatedly\u000aadvised to switch to manufacturer-approved published-source firmware\u000ainstead.\u000a\u000aChange-Id: I84d564f052f12a25ea3bfb9c78860e9dc6262be8\u000a", "date" : "2023-09-04 20:19:12 +0000", "id" : "59e649dbf1e1e71d38ab6fc40d2feb6fe6195f54", "msg" : "firmware: board: add support for TR-800 target", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/Makefile" }, { "editType" : "add", "file" : "src/target/firmware/board/tr800/keymap.h" }, { "editType" : "add", "file" : "src/target/firmware/board/tr800/rffe_leo_quadband.c" }, { "editType" : "add", "file" : "src/target/firmware/board/tr800/init.c" }, { "editType" : "add", "file" : "src/target/firmware/board/tr800/afcparams.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c", "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/common/l1ctl.c", "src/host/trxcon/src/trxcon_fsm.c", "src/host/layer23/src/modem/rlcmac.c", "include/l1gprs.h", "src/host/layer23/include/osmocom/bb/common/ms.h", "include/l1ctl_proto.h", "src/host/layer23/include/osmocom/bb/modem/grr.h", "src/host/virt_phy/src/virt_prim_pdch.c" ], "commitId" : "fa833e40956a72334174eea220e4b5a20bf7864a", "timestamp" : 1693866848000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "l1gprs/l1ctl: Decouple RTS.ind from DL_BLOCK.ind\u000a\u000aBefore this patch, the RTS:ind was crafted up in the stack when\u000areceiving the DL_BLOCK.ind. This created some problems since the\u000ainternal low level state has to be updated in between signalling\u000aDL_BLOCK.ind and RTS.ind, as there's a fn-advnace of one block between\u000athose 2 signals (hence the timeslot allocation has to be applied at the\u000atime when the fn-advance is applied).\u000aThis is actually not fixing the whole issue, since there's several\u000atimeslots and hence the following events will have the internal timeslot updated\u000aduring the event in the middle, hence potentially causing problems in the\u000aremaining TS:\u000aDL_BLOCK.ind(FN=N, TS=1), RTS.ind(FN=N+4, TS=1), DL_BLOCK.ind(FN=N, TS=2)\u000a\u000aIn any case, this decoupling already improves the situation and is step\u000aneeded anyway towards fully fixing the problem (by, for instance,\u000amaintaining a timeslot state duplicated both for DL and Ul directions,\u000asince they drive based on differnet FN time (1 PDCH block).\u000a\u000aChange-Id: I1494e0aac7555f6e01b4b435b77140afc42c098e\u000a", "date" : "2023-09-04 22:34:08 +0000", "id" : "fa833e40956a72334174eea220e4b5a20bf7864a", "msg" : "l1gprs/l1ctl: Decouple RTS.ind from DL_BLOCK.ind", "paths" : [ { "editType" : "edit", "file" : "include/l1ctl_proto.h" }, { "editType" : "edit", "file" : "include/l1gprs.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" }, { "editType" : "edit", "file" : "src/shared/l1gprs.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/grr.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_pdch.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/virt_prim_pdch.c" ], "commitId" : "9a71f0a18b5563844ec2cf4cd3d63549c5ffd9a4", "timestamp" : 1693937312000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: fix wrong pointer being checked\u000a\u000aChange-Id: I2f845b0335d2d9818aa15c30f8621acd120e82d4\u000aFixes: fa833e40 \"l1gprs/l1ctl: Decouple RTS.ind from DL_BLOCK.ind\"\u000aFixes: CID#323121\u000a", "date" : "2023-09-06 01:08:32 +0700", "id" : "9a71f0a18b5563844ec2cf4cd3d63549c5ffd9a4", "msg" : "virt_phy: fix wrong pointer being checked", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virt_prim_pdch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h", "src/host/trxcon/src/trxcon_fsm.c" ], "commitId" : "05ddc05233100236d93c1268a1d851b14efc6fca", "timestamp" : 1693939349000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "trxcon: handle_tbf_cfg_req(): properly set TSC for lchans\u000a\u000aBefore this patch all Uplink PDCH bursts were using TSC=0.\u000a\u000aChange-Id: I58b2da0d285b9a3e444374a30276fbaab3b784ac\u000aRelated: OS#5500\u000a", "date" : "2023-09-05 18:42:29 +0000", "id" : "05ddc05233100236d93c1268a1d851b14efc6fca", "msg" : "trxcon: handle_tbf_cfg_req(): properly set TSC for lchans", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "57b0908a7156c97aaf97092312cca8e2ce4089aa", "timestamp" : 1695408728000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: grr: clarify a comment in forward_to_rlcmac()\u000a\u000aChange-Id: I11286777c70c776c9f6990be988401ebd5b84f0f\u000a", "date" : "2023-09-23 01:52:08 +0700", "id" : "57b0908a7156c97aaf97092312cca8e2ce4089aa", "msg" : "modem: grr: clarify a comment in forward_to_rlcmac()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/vty.c", "src/host/layer23/src/modem/rlcmac.c", "src/host/layer23/include/osmocom/bb/modem/grr.h" ], "commitId" : "9978b00ea0357be5a5d071562f5695c3165a3e82", "timestamp" : 1695414132000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: grr: implement RACH.req retransmission\u000a\u000aSometimes sending one Access Burst is not enough, so we need to repeat\u000asending it a few more more times changing the 3 LSBs randomly. This\u000ais what we already do in the mobile app, but not in the modem app.\u000a\u000a* Rename GRR_EV_RACH_{REQ,CNF} to GRR_EV_CHAN_ACCESS_{REQ,CNF}.\u000a* Rename VTY command 'grr tx-chan-req' to 'grr start-chan-access'.\u000a* Add an intermediate state GRR_ST_PACKET_ACCESS.\u000a** The GRR_EV_CHAN_ACCESS_REQ transitions to this state.\u000a** One RACH.req gets transmitted when entering this state.\u000a** The GRR_EV_CHAN_ACCESS_CNF confirms transmission of a RACH.req.\u000a** Upon the timeout (300 ms) expiry, a loop state transition happens.\u000a** After 3 loop-transitions, transition to GRR_ST_PACKET_NOT_READY.\u000a\u000aChange-Id: Iab6d9147f6e0aeb99239affacf318a3897fd6ffe\u000aRelated: libosmo-gprs.git If0de3ed86b1e2897d70183f3b0f4fbfd7d2bda80\u000aRelated: OS#5500, OS#6131\u000a", "date" : "2023-09-23 03:22:12 +0700", "id" : "9978b00ea0357be5a5d071562f5695c3165a3e82", "msg" : "modem: grr: implement RACH.req retransmission", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/grr.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/vty.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c" ], "commitId" : "45a8db2a918d9fe5e94a35ecf9fe80973d9de88d", "timestamp" : 1695726687000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "l1gprs: migrate to gsm0502_fncmp() from libosmogsm\u000a\u000aChange-Id: I10261aa114b5dce3efee26ea84a1caa50c49a1d2\u000aDepends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d\u000aDepends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186\u000aRelated: OS#5500\u000a", "date" : "2023-09-26 18:11:27 +0700", "id" : "45a8db2a918d9fe5e94a35ecf9fe80973d9de88d", "msg" : "l1gprs: migrate to gsm0502_fncmp() from libosmogsm", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_pdtch.c" ], "commitId" : "a41ca4bbc42bc66557cdc7c646c539d1a4c1e30f", "timestamp" : 1695730454000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: rework dequeueing of PDCH Tx prims\u000a\u000aWhen an UL BLOCK.req is received late, i.e. after the first Tx burst\u000aof the respective TDMA Fn was requested by the PHY, a domino effect\u000acan be observed: the stale Tx primitive remains in the queue and\u000aprevents transmission of the next primitive, even if the later was\u000areceived in time. This breaks transmission of consecutive UL blocks.\u000a\u000aDon't let stale primitives poison the Tx queue: drop them like before,\u000abut keep looking for a primitive with the matching TDMA Fn. If found\u000aa primitive with TDMA Fn past the current one, stop the iteration.\u000a\u000aChange-Id: I439615639b8e840b9fd4f3af6934d9f298f32216\u000aDepends: libosmocore.git I9590f2e836fc48650decf1564b6ab46306c4fe2d\u000aDepends: libosmocore.git Ie8bb9c49c6f81b8f4a1766547d6943f9880d1186\u000aRelated: OS#5500\u000a", "date" : "2023-09-26 19:14:14 +0700", "id" : "a41ca4bbc42bc66557cdc7c646c539d1a4c1e30f", "msg" : "trxcon/l1sched: rework dequeueing of PDCH Tx prims", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "3f36843b9070ef4ba32884be71d15b02cf10ddd4", "timestamp" : 1695738177000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly\u000a\u000aPass size in bytes to memcpy(), not number of elements!\u000a\u000aChange-Id: I687435f5458e766d9d61143d6e4255f089fe1caf\u000aFixes: 6db5f8b9c \"modem: get rid of app_data.chan_req, use ms->rrlayer\"\u000aRelated: OS#5500, OS#6131\u000a", "date" : "2023-09-26 21:22:57 +0700", "id" : "3f36843b9070ef4ba32884be71d15b02cf10ddd4", "msg" : "modem: fix grr_st_packet_access_action(): shift rr->cr_hist properly", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" ], "commitId" : "975351e2508683c7c7b18958b8248cd157400fb0", "timestamp" : 1695823361000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "ASCI: Add GCC/BCC (call control) to mobility management\u000a\u000aGCC is the call control for voice group calls, BCC is the call control\u000afor voice broadcast calls.\u000a\u000aThis patch includes the new message primitives between MM layer and the\u000aGCC/BCC layers.\u000a\u000aRelated: OS#5364\u000aChange-Id: If6f3cea4b2ca839559596a6ee5a3d169c6d85dbe\u000a", "date" : "2023-09-27 14:02:41 +0000", "id" : "975351e2508683c7c7b18958b8248cd157400fb0", "msg" : "ASCI: Add GCC/BCC (call control) to mobility management", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "245b4b92389a7fd417cfc784d13adeb0da94be03", "timestamp" : 1695823361000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "ASCI: Get timing advance and TX power only when included\u000a\u000aInstead of assuming that there are TX power and timing advance IEs\u000aincluded in RSL message, check for existence.\u000a\u000agsm48_rr_rx_acch() may receive frames from FACCH that do not have these\u000aIEs included in the message. These frames are UI frames on DCCH and Bter\u000aframes. E.g. these frames are used on voice group channel to control\u000auplink.\u000a\u000aRelated: OS#5364\u000aChange-Id: I87fcd44bba221ab4c5fbd2c79557db2444a10b88\u000a", "date" : "2023-09-27 14:02:41 +0000", "id" : "245b4b92389a7fd417cfc784d13adeb0da94be03", "msg" : "ASCI: Get timing advance and TX power only when included", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" ], "commitId" : "b7663882c0ad86b7fb709a4e5b136e7c0230a399", "timestamp" : 1695823361000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "ASCI: MM connections are defined by 'ref' and 'protocol' tuple\u000a\u000aVGCS and VBS calls may share the same (call) ref or share with other\u000aprotocols. Therefore the MM connection is defined by the reference and\u000athe prococol discriminator.\u000a\u000aRelated: OS#5364\u000aChange-Id: Ic280cd8c666660077bb2c2ef641f4cddd3b36eee\u000a", "date" : "2023-09-27 14:02:41 +0000", "id" : "b7663882c0ad86b7fb709a4e5b136e7c0230a399", "msg" : "ASCI: MM connections are defined by 'ref' and 'protocol' tuple", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/misc/app_cbch_sniff.c", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h", "src/target/firmware/include/layer1/sync.h", "src/host/layer23/src/mobile/gsm414.c", "src/host/layer23/src/common/l1ctl.c", "src/target/firmware/layer1/prim_tch.c", "src/target/firmware/layer1/l23_api.c", "src/host/layer23/include/osmocom/bb/common/l1ctl.h", "src/target/firmware/include/layer1/async.h", "include/l1ctl_proto.h", "src/host/layer23/src/modem/grr.c", "src/host/layer23/include/osmocom/bb/common/osmocom_data.h", "src/target/firmware/layer1/async.c" ], "commitId" : "28d9a4880cdbc18195d759e182af3a23e9cfa236", "timestamp" : 1695823361000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "ASCI: Add a flag to turn transmitter off or on\u000a\u000aThis flag can be used to turn transmitter off for \"group receive mode\"\u000aor for handover procedure. The flag is stored in the channel description\u000aof the mobile application. It is sent to layer 1 when switching to\u000adedicated channel or when changing TCH mode.\u000a\u000aAt the layer 1 the transmitter is turned off while the receiver is still\u000aactive. This is done by:\u000a\u000a * scheduling a TX dummy task for TCH bursts\u000a * scheduling no TX task for SACCH bursts\u000a * not enabling the transmit window\u000a\u000aRelated: OS#5364\u000aChange-Id: I20133523adc3b204cd2181bfe664fe66020a10e3\u000a", "date" : "2023-09-27 14:02:41 +0000", "id" : "28d9a4880cdbc18195d759e182af3a23e9cfa236", "msg" : "ASCI: Add a flag to turn transmitter off or on", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/include/layer1/sync.h" }, { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/osmocom_data.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/target/firmware/layer1/l23_api.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" }, { "editType" : "edit", "file" : "src/target/firmware/include/layer1/async.h" }, { "editType" : "edit", "file" : "src/target/firmware/layer1/async.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/l1ctl.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/misc/app_cbch_sniff.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm414.c" }, { "editType" : "edit", "file" : "include/l1ctl_proto.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/logging.h", "src/host/layer23/src/common/logging.c" ], "commitId" : "e51391166896ff16a2555ad2154d2225fe09e2e7", "timestamp" : 1695823361000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "ASCI: Add two logging categories for group and broadcast call control\u000a\u000aRelated: OS#5364\u000aChange-Id: I77f634c7098137a5412ea56ddc0e794e629d1982\u000a", "date" : "2023-09-27 14:02:41 +0000", "id" : "e51391166896ff16a2555ad2154d2225fe09e2e7", "msg" : "ASCI: Add two logging categories for group and broadcast call control", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/logging.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/logging.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_rach.c" ], "commitId" : "d95c8f4fa693c4e34bbbdde171fe1ba096e23825", "timestamp" : 1695823361000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "Transmit access bursts on DCCH of TCH channels\u000a\u000aThis is required to access a TCH during handover or to access the uplink\u000aof a VGCS channel.\u000a\u000aThe patch is taken from the handover branch.\u000a\u000aChange-Id: I1a972d9bac5749c67c1b139825400854f7cf1490\u000a", "date" : "2023-09-27 14:02:41 +0000", "id" : "d95c8f4fa693c4e34bbbdde171fe1ba096e23825", "msg" : "Transmit access bursts on DCCH of TCH channels", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_rach.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/common/l1ctl.c", "src/target/firmware/include/layer1/sync.h", "src/host/layer23/include/osmocom/bb/common/l1ctl.h", "src/target/firmware/layer1/l23_api.c", "src/host/layer23/src/common/l1ctl_lapdm_glue.c", "src/target/firmware/layer1/prim_rach.c", "include/l1ctl_proto.h", "src/target/firmware/include/layer1/prim.h" ], "commitId" : "23d46f003f7cbb8d2c39b6285c1e22fd692f9631", "timestamp" : 1695890558000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add UIC support to random access burst\u000a\u000aA different identity code can be used on uplink access bursts on voice\u000agroup channel. This is optional for the network, but mandatory for the\u000aMS side. If the network does not define a UIC, the BSIC is used instead.\u000aBSIC is used for RACH channel and handover.\u000a\u000aRelated: OS#5364\u000aChange-Id: I4039734676949aefa5be4b5298764b8ba7e1b8ed\u000a", "date" : "2023-09-28 10:42:38 +0200", "id" : "23d46f003f7cbb8d2c39b6285c1e22fd692f9631", "msg" : "ASCI: Add UIC support to random access burst", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" }, { "editType" : "edit", "file" : "src/target/firmware/include/layer1/sync.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/l1ctl.h" }, { "editType" : "edit", "file" : "src/target/firmware/include/layer1/prim.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl_lapdm_glue.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_rach.c" }, { "editType" : "edit", "file" : "include/l1ctl_proto.h" }, { "editType" : "edit", "file" : "src/target/firmware/layer1/l23_api.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/support.c" ], "commitId" : "32423ccf5d1c55daef057ec445ecd65ea2a539b3", "timestamp" : 1695890562000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add support flags to mobile (and VTY) for VGCS/VBS\u000a\u000aThese support flags can be enabled or disabled and are sent in the\u000aclass mark IE. Also they allow or disallow making VGCS/VBS calls.\u000a\u000aRelated: OS#5364\u000aChange-Id: Ia23eb190e533660cce4ba4c856a83b5f3d534202\u000a", "date" : "2023-09-28 10:42:42 +0200", "id" : "32423ccf5d1c55daef057ec445ecd65ea2a539b3", "msg" : "ASCI: Add support flags to mobile (and VTY) for VGCS/VBS", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/support.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h", "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "dd60a527be07ad3530828dd4e42b2628846ff689", "timestamp" : 1695890563000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Refactoring encoding of mobile identity at mobile application\u000a\u000aDeprecated functions gsm48_generate_mid_from_*() are replaced by\u000aosmo_mobile_identity_encode_msgb(). Clean up code.\u000a\u000aChange-Id: I9ff429bd50d718530fdad64a276053a35c8928f2\u000a", "date" : "2023-09-28 10:42:43 +0200", "id" : "dd60a527be07ad3530828dd4e42b2628846ff689", "msg" : "Refactoring encoding of mobile identity at mobile application", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" ], "commitId" : "bb32882adc170890dbf2e937181e6d6ee3c55b17", "timestamp" : 1695890567000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Increase channel request history to 5 entries\u000a\u000a3 entries are enough for random access on CCCH. 5 are required for\u000auplink request on VGCS channel.\u000a\u000aThe history is used to remember when the random access bursts were send.\u000aThe RR layer can check if the IMMEDIATE ASSIGNMENT or VGCS UPLINK GRANT\u000amessage has matching frame number and random value of up to 5 random\u000aaccess bursts previously sent.\u000a\u000aRelated: OS#5364\u000aChange-Id: I62f18685bf05663f3ee6e94f6884ffb9a6b07ea4\u000a", "date" : "2023-09-28 10:42:47 +0200", "id" : "bb32882adc170890dbf2e937181e6d6ee3c55b17", "msg" : "ASCI: Increase channel request history to 5 entries", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "c9f90c4d5aa236f0cf1922d32d296292d1b30506", "timestamp" : 1695890568000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix request reference value in gsm48_match_ra()\u000a\u000aDo not overwrite the given request reference pointer with the history\u000abuffer's reference. This makes no sense.\u000a\u000aWithout this fix only the response to the first access burst could be\u000amatched correctly.\u000a\u000aChange-Id: Iec636d368e20030beac2861bff61b1a06e7b4821\u000a", "date" : "2023-09-28 10:42:48 +0200", "id" : "c9f90c4d5aa236f0cf1922d32d296292d1b30506", "msg" : "Fix request reference value in gsm48_match_ra()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "699a3a397862ae68054c7d1cbffcb6ce80842db5", "timestamp" : 1695890571000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix unset sapi in gsm48_rr_data_ind()\u000a\u000aThe gsm48_rr_hdr is pushed into the message before sending data to\u000aMM layer. SAPI was not set in this header.\u000a\u000aChange-Id: I8345a562050d52d491f3b7192c979d455a63931c\u000a", "date" : "2023-09-28 10:42:51 +0200", "id" : "699a3a397862ae68054c7d1cbffcb6ce80842db5", "msg" : "Fix unset sapi in gsm48_rr_data_ind()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h", "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "c3467236a363ad51ee7d8ef0e274d05d9e759389", "timestamp" : 1695890573000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add channel notification event to MM events\u000a\u000aThis is required to notify MM layer about new and ceased group and\u000abroadcast calls.\u000a\u000aRelated: OS#5364\u000aChange-Id: Ifee286ba4628356cc19b5dc75f1843287c5d2342\u000a", "date" : "2023-09-28 10:42:53 +0200", "id" : "c3467236a363ad51ee7d8ef0e274d05d9e759389", "msg" : "ASCI: Add channel notification event to MM events", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" ], "commitId" : "1dc887a78dcd44d80db72e648f5f6568ce20ad8a", "timestamp" : 1695890576000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add uplink free/busy event to MM events\u000a\u000aRelated: OS#5364\u000aChange-Id: I3f8d97a0359ea9560d6d6bfd8238ddc6492c56e8\u000a", "date" : "2023-09-28 10:42:56 +0200", "id" : "1dc887a78dcd44d80db72e648f5f6568ce20ad8a", "msg" : "ASCI: Add uplink free/busy event to MM events", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" ], "commitId" : "2d9c447c3f63ea73f7f9d8dd93bbbf99dfd7f0b9", "timestamp" : 1695890578000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add interface for group receive/transmit mode support to RR layer\u000a\u000aThis patch includes new messages and description. The are used to bring\u000aRR layer into group receive mode and from there in group transmit mode\u000aand back.\u000a\u000aRelated: OS#5364\u000aChange-Id: I1abd56c63d15af1cff8bde7589a571cb5bb5506f\u000a", "date" : "2023-09-28 10:42:58 +0200", "id" : "2d9c447c3f63ea73f7f9d8dd93bbbf99dfd7f0b9", "msg" : "ASCI: Add interface for group receive/transmit mode support to RR layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "615a88f69b52e786abab2001cb442329439711dc", "timestamp" : 1695902029000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix reception of MM messages at gsm48_mm_data_ind()\u000a\u000aThe patch \"ASCI: Add GCC/BCC (call control) to mobility management\"\u000abreaks reception of MM messages. No MM connection setup is possible.\u000a\u000aThis patch fixes the issue.\u000a\u000aChange-Id: I263739bb0220d19f14114714fe9d82505bdbd267\u000a", "date" : "2023-09-28 13:53:49 +0200", "id" : "615a88f69b52e786abab2001cb442329439711dc", "msg" : "Fix reception of MM messages at gsm48_mm_data_ind()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "d575e5bf6ee69adff6c7203b178ca981266ab933", "timestamp" : 1695902032000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Add header length check to received CCCH messages\u000a\u000aChange-Id: I3bc6b0b997e6ea1048c3357d276adfcc1638b02b\u000a", "date" : "2023-09-28 13:53:52 +0200", "id" : "d575e5bf6ee69adff6c7203b178ca981266ab933", "msg" : "Add header length check to received CCCH messages", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "e676cf83eefaba5eb42eeef8e28ec01ed6655c14", "timestamp" : 1695902033000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Prepare gsm48_rr_rx_acch for voice group channel\u000a\u000aThe gsm48_rr_rx_acch function receives FACCH/SACCH. This is not only\u000aused for system information on SACCH, but also for short header messages\u000aand regular UI messages on TCH.\u000a\u000aRelated: OS#5364\u000aChange-Id: I39b27396a31137b3c4bdcb40dccdf3de60458fe2\u000a", "date" : "2023-09-28 13:53:53 +0200", "id" : "e676cf83eefaba5eb42eeef8e28ec01ed6655c14", "msg" : "ASCI: Prepare gsm48_rr_rx_acch for voice group channel", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h", "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "91d862c25187a5ef2cc9e265f52d5b7fe4a6ed6d", "timestamp" : 1695902034000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add ASCI notification support to RR layer\u000a\u000aThe notifications are received on NCH, as well as on FACCH.\u000a\u000aRelated: OS#5364\u000aChange-Id: I49df02cb4d99d9aab1ea3ca13beb2ea00ae4c9f4\u000a", "date" : "2023-09-28 13:53:54 +0200", "id" : "91d862c25187a5ef2cc9e265f52d5b7fe4a6ed6d", "msg" : "ASCI: Add ASCI notification support to RR layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h", "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "253e5cd1ebefcdd99c08ea7ab32dd93b67379ebe", "timestamp" : 1695902037000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add group receive mode support to RR layer\u000a\u000aThis allows reception of VGCS and VBS calls. A special sub-state is used\u000ato differentiate between IDLE mode and group receive mode. Later it can\u000abe used to differentiate between dedicated and group transmit mode.\u000a\u000aRelated: OS#5364\u000aChange-Id: Ia7d806b354fb3be5729bff8ac9aa1c7ad7a8b539\u000a", "date" : "2023-09-28 13:53:57 +0200", "id" : "253e5cd1ebefcdd99c08ea7ab32dd93b67379ebe", "msg" : "ASCI: Add group receive mode support to RR layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" ], "commitId" : "17115c70b157de020ab2b4fd16ffb93745e8ef4b", "timestamp" : 1696268221000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add group transmit mode support to RR layer\u000a\u000aThis allows the upper layer to estabish and release connection on the\u000auplink of a voice group call.\u000a\u000aRelated: OS#5364\u000aChange-Id: I9b62eef5d877e5d9dcf349717efd2cce28862c58\u000a", "date" : "2023-10-02 19:37:01 +0200", "id" : "17115c70b157de020ab2b4fd16ffb93745e8ef4b", "msg" : "ASCI: Add group transmit mode support to RR layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" ], "commitId" : "1678f53f99edd3ec601a69484ce9f42536ff9d2d", "timestamp" : 1696268225000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add group receive and transmit mode support to MM layer\u000a\u000aRelated: OS#5364\u000aChange-Id: I05957182a57423ad947ab200b52f65fde859e110\u000a", "date" : "2023-10-02 19:37:05 +0200", "id" : "1678f53f99edd3ec601a69484ce9f42536ff9d2d", "msg" : "ASCI: Add group receive and transmit mode support to MM layer", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/transaction.h", "src/host/layer23/src/mobile/transaction.c", "src/host/layer23/src/mobile/gsm411_sms.c", "src/host/layer23/src/mobile/gsm480_ss.c", "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "32399095be88bc05c6c4873876cc005a0b38f0ae", "timestamp" : 1696268229000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add protocol type to trans_find_by_callref() function\u000a\u000aThis is required, because different protocols may share the same\u000acallref, but use different protocols. E.g. a voice group call can share\u000athe same callref with a voice broadcast call, but these calls are\u000adifferent transactions.\u000a\u000aRelated: OS#5364\u000aChange-Id: Ifea3a81aae3b4ae897851f867b13fa987c8cbe11\u000a", "date" : "2023-10-02 19:37:09 +0200", "id" : "32399095be88bc05c6c4873876cc005a0b38f0ae", "msg" : "ASCI: Add protocol type to trans_find_by_callref() function", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/transaction.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/transaction.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm411_sms.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm480_ss.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/transaction.c", "src/host/layer23/src/mobile/gsm411_sms.c", "src/host/layer23/include/osmocom/bb/mobile/Makefile.am", "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/mobile/gsm480_ss.c", "src/host/layer23/include/osmocom/bb/mobile/transaction.h", "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c", "src/host/layer23/src/mobile/Makefile.am", "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "666ec1d7619288df7f91868a8aebdafe9220a020", "timestamp" : 1696268233000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add GCC/BCC layer to support voice group/broadcast calls\u000a\u000aRelated: OS#5364\u000aChange-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d\u000a", "date" : "2023-10-02 19:37:13 +0200", "id" : "666ec1d7619288df7f91868a8aebdafe9220a020", "msg" : "ASCI: Add GCC/BCC layer to support voice group/broadcast calls", "paths" : [ { "editType" : "add", "file" : "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/transaction.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/Makefile.am" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" }, { "editType" : "add", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm480_ss.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/Makefile.am" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/transaction.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm411_sms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/vty.h", "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "17f494189f793ad47166a9a960853899a3df55f0", "timestamp" : 1696268238000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add VTY commands to control voice group/broadcast calls\u000a\u000aRelated: OS#5364\u000aChange-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6\u000a", "date" : "2023-10-02 19:37:18 +0200", "id" : "17f494189f793ad47166a9a960853899a3df55f0", "msg" : "ASCI: Add VTY commands to control voice group/broadcast calls", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/vty.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sysinfo.c" ], "commitId" : "06b4885b18b1ad4bcb429b8314f64ea23d2f90a5", "timestamp" : 1696268240000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Show NCH position in VTY together with system information\u000a\u000aRelated: OS#5364\u000aChange-Id: I5e0a9d469eb70608502dca881808621fa153b666\u000a", "date" : "2023-10-02 19:37:20 +0200", "id" : "06b4885b18b1ad4bcb429b8314f64ea23d2f90a5", "msg" : "ASCI: Show NCH position in VTY together with system information", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "00507bdc139430be9ea0ec5d2615907e137c5b30", "timestamp" : 1696268244000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Cleaning gsm48_mm_data_ind()\u000a\u000aGet rid of goto and double switch/case by putting connection handling\u000acode into a separate function.\u000a\u000aChange-Id: I12454cab06c105ccd9e2495e3a6f0640f2884885\u000a", "date" : "2023-10-02 19:37:24 +0200", "id" : "00507bdc139430be9ea0ec5d2615907e137c5b30", "msg" : "Cleaning gsm48_mm_data_ind()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sysinfo.c" ], "commitId" : "a67c8b32fb0438490b388ccc07ce335f43d5159f", "timestamp" : 1696268245000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Correctly extract bits from SI2*/SI5*\u000a\u000aThese bits are:\u000a * EXT-IND\u000a * BA-IND\u000a * Multiband reporting\u000a\u000aChange-Id: Ie5349464fed0a4276955235c7c87b5bcb299f20d\u000a", "date" : "2023-10-02 19:37:25 +0200", "id" : "a67c8b32fb0438490b388ccc07ce335f43d5159f", "msg" : "Correctly extract bits from SI2*/SI5*", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sysinfo.c" ], "commitId" : "3fb118bd91eb73274850c83f2ddbf18eadd9b7ec", "timestamp" : 1696268248000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix typo in sysinfo.c\u000a\u000aChange-Id: I12405bef9f7910a354d9ac5153f4adc55095d747\u000a", "date" : "2023-10-02 19:37:28 +0200", "id" : "3fb118bd91eb73274850c83f2ddbf18eadd9b7ec", "msg" : "Fix typo in sysinfo.c", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "d6b2a4d6851d5d1615190e3f810500668bd83b50", "timestamp" : 1696268250000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Correctly use SUP_WRITE() macro for GSM 850\u000a\u000aChange-Id: I52c99c63e38934fb26c26dba5bf2551ea311228b\u000a", "date" : "2023-10-02 19:37:30 +0200", "id" : "d6b2a4d6851d5d1615190e3f810500668bd83b50", "msg" : "Correctly use SUP_WRITE() macro for GSM 850", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "1cc4c0f487a1c7b412c4ad46b386847fcba0512d", "timestamp" : 1696416903000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix potential NULL pointer dereferences, discovered by Coverity Scan\u000a\u000aSee: CID 323362 + CID 323363\u000aChange-Id: I47aa506014d8bddb8c8ce9b506c1c5c7b8056d30\u000a", "date" : "2023-10-04 12:55:03 +0200", "id" : "1cc4c0f487a1c7b412c4ad46b386847fcba0512d", "msg" : "Fix potential NULL pointer dereferences, discovered by Coverity Scan", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sysinfo.c", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/common/sysinfo.h" ], "commitId" : "61ea0ac0abc42b858126eb3efe25b51a9dc58ad6", "timestamp" : 1696416926000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$\u000a\u000aRelated: OS#5782\u000aChange-Id: I81c7929f6d951d8eef7d08624f0b72830370c448\u000a", "date" : "2023-10-04 12:55:26 +0200", "id" : "61ea0ac0abc42b858126eb3efe25b51a9dc58ad6", "msg" : "ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sysinfo.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/common/sysinfo.c", "src/host/layer23/include/osmocom/bb/common/sysinfo.h" ], "commitId" : "c8fed7fba78d553d0dd9f106ae0f8bf7959d319e", "timestamp" : 1696416929000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add VTY command to display group call neighbor cells\u000a\u000aRelated: OS#5782\u000aChange-Id: Ie84221507bdf247c1563b829d6cf0adb53ce161f\u000a", "date" : "2023-10-04 12:55:29 +0200", "id" : "c8fed7fba78d553d0dd9f106ae0f8bf7959d319e", "msg" : "ASCI: Add VTY command to display group call neighbor cells", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sysinfo.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/settings.c" ], "commitId" : "0cee735aca1f0c32d10d1b31b5c32eee852097c2", "timestamp" : 1696416930000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix settings for VGCS/VBS\u000a\u000aThe \"support\" flags must be copied to the settings, because they are\u000aenabled by default and may be omitted in the VTY config.\u000a\u000aRelated: OS#5364\u000aChange-Id: I81575dd3f2ade70101df32935a1c3d5469327577\u000a", "date" : "2023-10-04 12:55:30 +0200", "id" : "0cee735aca1f0c32d10d1b31b5c32eee852097c2", "msg" : "Fix settings for VGCS/VBS", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c" ], "commitId" : "a397330e105772d6a7b6367dc3a46a55bd0a29f7", "timestamp" : 1696511792000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS\u000a\u000aI forgot to permit the loop state transmission, so the modem app\u000agets stuck in GRR_ST_PACKET_ACCESS is no IMM ASS is received...\u000a\u000aChange-Id: I059d2929f7f724cfe26935bf35c167e60157451f\u000aFixes: 9978b00e \"modem: grr: implement RACH.req retransmission\"\u000a", "date" : "2023-10-05 20:16:32 +0700", "id" : "a397330e105772d6a7b6367dc3a46a55bd0a29f7", "msg" : "modem: grr_fsm: permit loop transition for GRR_ST_PACKET_ACCESS", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" ], "commitId" : "22e79a87faaa8137e559908d4f90037603fb377a", "timestamp" : 1696513302000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "ASCI: Fix false return value checks, discovered by Coverity Scan\u000a\u000aSee: CID 32637 - 323644\u000a\u000aRelated: OS#5364\u000aChange-Id: If72590bb94597e434386bbcd312919a71abf0aae\u000a", "date" : "2023-10-05 13:41:42 +0000", "id" : "22e79a87faaa8137e559908d4f90037603fb377a", "msg" : "ASCI: Fix false return value checks, discovered by Coverity Scan", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sysinfo.c" ], "commitId" : "beed281a0a85a1242be52b9fa45d8b880f2508bc", "timestamp" : 1696515897000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix selection of correct ARFCN at arfcn_from_freq_index()\u000a\u000aThe selection of ARFCN is described in TS 44.018 §10.5.2.20.\u000a\u000aThe frequencies found in SI5 and SI5bis are counted first, in the\u000afollowing order: ARFCN 1..1023,0.\u000a\u000aThe frequencies found in SI5ter are counted afterwards, in the following\u000aorder: ARFCN 1..1023,0.\u000a\u000aRelated: OS#5782\u000aChange-Id: I090d84a5550d89743e8f5a886f400df6483f50d7\u000a", "date" : "2023-10-05 16:24:57 +0200", "id" : "beed281a0a85a1242be52b9fa45d8b880f2508bc", "msg" : "Fix selection of correct ARFCN at arfcn_from_freq_index()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/common/sysinfo.h" ], "commitId" : "203014d74468fd401900e2ab1b20fc14752c3c76", "timestamp" : 1696515900000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Fix indices of ARFCNs for measurement report\u000a\u000aThe order of ARFCNs are described in TS 44.018 §10.5.2.20.\u000a\u000aThe function arfcn_from_freq_index() is re-used to get the ARFCNs in\u000acorrect order for the report.\u000a\u000aChange-Id: I0674467eb5a38a341cf65f95a25aa5f7232df069\u000a", "date" : "2023-10-05 16:25:00 +0200", "id" : "203014d74468fd401900e2ab1b20fc14752c3c76", "msg" : "Fix indices of ARFCNs for measurement report", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sysinfo.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "6708699b224a1e09cedc9caec79ee511f8bfbc45", "timestamp" : 1696887541000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Correctly detect the follow-on proceed information element\u000a\u000aEven if follow-on proceed is not supported, the warning message about\u000anot beeing supported should only show when the follow-on proceed\u000ainformation element is included in the location update accept messages.\u000a\u000aChange-Id: I2b1aceb8b85bdd9faabe354501f9036f1fc6fe33\u000a", "date" : "2023-10-09 23:39:01 +0200", "id" : "6708699b224a1e09cedc9caec79ee511f8bfbc45", "msg" : "Correctly detect the follow-on proceed information element", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "bcc047e5e12b714c1be42c98beedf428b86bab0e", "timestamp" : 1696941086000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "Provide create_conn_and_push_mm_hdr() with correct SAPI\u000a\u000aChange-Id: I454178f45aed49417f8cd7744155be66b9ac509f\u000aFixes: 00507bdc \"Cleaning gsm48_mm_data_ind()\"\u000aRelated: OS#6216\u000a", "date" : "2023-10-10 19:31:26 +0700", "id" : "bcc047e5e12b714c1be42c98beedf428b86bab0e", "msg" : "Provide create_conn_and_push_mm_hdr() with correct SAPI", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "de630abfc83a88091072fb3c93e958041c3d99f0", "timestamp" : 1697195344000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: send UL/DL GPRS blocks over GSMTAP\u000a\u000aNote that despite the VTY interface offers various channel type\u000afiltering facilities, the actual filtering is not implemented.\u000a\u000aThis patch simply brings PS domain in consistency with CS domain:\u000athe UL and DL GPRS blocks are now being sent over GSMTAP without\u000aany filtering, just like GSM MAC blocks.\u000a\u000aChange-Id: I338205bee44fe182233efc5619a3d528cd07d932\u000aRelated: OS#5500, OS#6209\u000a", "date" : "2023-10-13 18:09:04 +0700", "id" : "de630abfc83a88091072fb3c93e958041c3d99f0", "msg" : "layer23: send UL/DL GPRS blocks over GSMTAP", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c", "src/target/firmware/include/calypso/l1_environment.h" ], "commitId" : "79baca14d41663b1282655620328452944a13f4d", "timestamp" : 1697433700000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: mute UL/DL vocodec if it's not needed\u000a\u000aThe upper layers usually request either of the two configurations:\u000a\u000a* (AUDIO_TX_MICROPHONE | AUDIO_RX_SPEAKER) - in this configuration\u000a the phone (PHY) is both the origin and the destination of the TCH\u000a frames. DL frames are played via the built-in speaker; UL frames\u000a recorded using the built-in microphone.\u000a\u000a* (AUDIO_TX_TRAFFIC_REQ | AUDIO_RX_TRAFFIC_IND) - in this case\u000a the upper layers (host side) become the origin and the destination\u000a of the TCH frames. The built-in speaker and microphone are\u000a expected to be disabled.\u000a\u000aHowever, when using the second configuration, one can still hear\u000aDL TCH frames being played by the built-in speaker. The built-in\u000amicrophone does not seem to be causing any issues, but still we\u000adefinitely don't want the vocoder to interfere with the host.\u000a\u000aChange-Id: I390db1889f079dea8112794c3e039a9136b897df\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 12:21:40 +0700", "id" : "79baca14d41663b1282655620328452944a13f4d", "msg" : "firmware/layer1: mute UL/DL vocodec if it's not needed", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/include/calypso/l1_environment.h" }, { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c" ], "commitId" : "8a2422db1fcf5992146ca570ea69484226a141ff", "timestamp" : 1697433700000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: clean up l1s_tch_cmd(): reduce nesting\u000a\u000aChange-Id: If4f0bb37cb3e12e09078027461cd5040524e43b2\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 12:21:40 +0700", "id" : "8a2422db1fcf5992146ca570ea69484226a141ff", "msg" : "firmware/layer1: clean up l1s_tch_cmd(): reduce nesting", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c" ], "commitId" : "c6c392aafdd2134adbea72bf6321a87eb8d69421", "timestamp" : 1697440016000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: cosmetic: labels should not be indented\u000a\u000aChange-Id: Ie32501df19cc2eedd1042c9917583d7386a665bc\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:06:56 +0700", "id" : "c6c392aafdd2134adbea72bf6321a87eb8d69421", "msg" : "firmware/layer1: cosmetic: labels should not be indented", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c" ], "commitId" : "f492a99d3639b067ed7d7f98a2e95f98b1c185a4", "timestamp" : 1697440219000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: clean up l1s_tch_resp()\u000a\u000a* Reset both A_DD_0 and A_DD_1 headers, like in the case of FACCH.\u000a* Reduce nesting, fix minor coding style issues.\u000a* Add a FIXME for proper B_BFI checking.\u000a\u000aChange-Id: Ie4faf386f54720888e73171bee26f93dfa0562d5\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:10:19 +0700", "id" : "f492a99d3639b067ed7d7f98a2e95f98b1c185a4", "msg" : "firmware/layer1: clean up l1s_tch_resp()", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c" ], "commitId" : "5523c0084dcf3e57422f31449551d9b9aad40107", "timestamp" : 1697440221000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: fix l1s_tch_resp(): use the right A_DD header\u000a\u000aChange-Id: Idd48438e47ac3ef1172621e77688d094cdcdbf34\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:10:21 +0700", "id" : "5523c0084dcf3e57422f31449551d9b9aad40107", "msg" : "firmware/layer1: fix l1s_tch_resp(): use the right A_DD header", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c" ], "commitId" : "7286560a33a8614dc09cd1a3afd3bd2144167921", "timestamp" : 1697440221000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: fill-in DL info for L1CTL TRAFFIC.ind\u000a\u000aChange-Id: I1c9727b183214f3d1a4f9a48489479f8435a4c5a\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:10:21 +0700", "id" : "7286560a33a8614dc09cd1a3afd3bd2144167921", "msg" : "firmware/layer1: fill-in DL info for L1CTL TRAFFIC.ind", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c" ], "commitId" : "a6d0a3e17002598d973c2a887b8f5d219b252943", "timestamp" : 1697440221000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: emit TRAFFIC.ind even if B_BFI is set\u000a\u000aEven if the DSP marks a traffic frame as bad (B_BFI), we still want\u000ato deliver something to the upper layers, just like we do for FACCH.\u000a\u000aChange-Id: I559793a3506089b1c1758ee7022cceb7753afb30\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:10:21 +0700", "id" : "a6d0a3e17002598d973c2a887b8f5d219b252943", "msg" : "firmware/layer1: emit TRAFFIC.ind even if B_BFI is set", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c", "src/target/firmware/layer1/async.c" ], "commitId" : "069b627abecad7efb4de43e3bad7ceb685d65e89", "timestamp" : 1697440221000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: handle CSD related channel modes\u000a\u000aChange-Id: Ib73210b273826ded56d42c41ffeb835eef96dd2b\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:10:21 +0700", "id" : "069b627abecad7efb4de43e3bad7ceb685d65e89", "msg" : "firmware/layer1: handle CSD related channel modes", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" }, { "editType" : "edit", "file" : "src/target/firmware/layer1/async.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/voice.c" ], "commitId" : "ed9e949dd991dd36bb8aa1f172457f5cb1b07c77", "timestamp" : 1697440221000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix AUDIO_IOH_LOOPBACK mode: pull DL info header\u000a\u000aThe loopback mode is currently broken because the DL info header\u000aremains present, thus becoming a bogus \"part\" of the speech frame.\u000a\u000aChange-Id: I1af187b4bc5f5a99bc7f7634d90bf14ad3db0e49\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:10:21 +0700", "id" : "ed9e949dd991dd36bb8aa1f172457f5cb1b07c77", "msg" : "mobile: fix AUDIO_IOH_LOOPBACK mode: pull DL info header", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/voice.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "8d18e106a9058abcc2719fd3d3ecec10233c3713", "timestamp" : 1697440465000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: mncc_recv_internal(): make struct gsm_mncc ptr const\u000a\u000aChange-Id: I0a5522b7df112bfaefc684c872a618c1e9118e61\u000a", "date" : "2023-10-16 14:14:25 +0700", "id" : "8d18e106a9058abcc2719fd3d3ecec10233c3713", "msg" : "mobile: mncc_recv_internal(): make struct gsm_mncc ptr const", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h" ], "commitId" : "b525577a5e4ad19704cbd122822b206c21b67774", "timestamp" : 1697440468000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: mncc_call(): make *number argument const\u000a\u000aChange-Id: I4558ce1313b8e9aadd73474a6514c136aa512de3\u000a", "date" : "2023-10-16 14:14:28 +0700", "id" : "b525577a5e4ad19704cbd122822b206c21b67774", "msg" : "mobile: mncc_call(): make *number argument const", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "8f1091ee4be4d1e7bd2364143fa7373bb76a5666", "timestamp" : 1697440468000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: separate 'call MS_NAME NUMBER' command\u000a\u000aThis will allow us adding an optional switch for data calls.\u000a\u000aChange-Id: I5d2332df09a81cb0747ecd9d95351ab59f99358e\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:14:28 +0700", "id" : "8f1091ee4be4d1e7bd2364143fa7373bb76a5666", "msg" : "mobile: separate 'call MS_NAME NUMBER' command", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "026f11328073b83769ffac83f19567e44a5547cd", "timestamp" : 1697440468000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: clean up call related VTY commands\u000a\u000aChange-Id: I8bccdf776ad541932ad4a6d6a68426a6ab856e08\u000aRelated: OS#4396\u000a", "date" : "2023-10-16 14:14:28 +0700", "id" : "026f11328073b83769ffac83f19567e44a5547cd", "msg" : "mobile: clean up call related VTY commands", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "2c0f71ac43d2f7fb20e4b9ac610aab706e2f00ac", "timestamp" : 1697609290000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Join a group/bcast call in correct MM states only\u000a\u000aThese states are:\u000a\u0009GSM48_MM_SST_NORMAL_SERVICE\u000a\u0009GSM48_MM_SST_ATTEMPT_UPDATE\u000a\u0009GSM48_MM_SST_LIMITED_SERVICE\u000a\u0009GSM48_MM_SST_LOC_UPD_NEEDED\u000a\u0009GSM48_MM_SST_PLMN_SEARCH (limited service)\u000a\u0009GSM48_MM_SST_PLMN_SEARCH_NORMAL\u000a\u000aIf the service is limited, group/bcast calls can be joined, but uplink\u000aaccess is not allowed.\u000a\u000aRelated: OS#5364\u000aChange-Id: I2f8ff65f6e101972f9b1760013983d00ae6e7760\u000a", "date" : "2023-10-18 08:08:10 +0200", "id" : "2c0f71ac43d2f7fb20e4b9ac610aab706e2f00ac", "msg" : "ASCI: Join a group/bcast call in correct MM states only", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "e45abc96ec016451d99b9daf7eff3ad11080fbc3", "timestamp" : 1697609294000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Ignore cell selection event during group receive mode\u000a\u000aCell selection is not supported during group receive mode. If it\u000ahappens anyway, give an error message and select correct sub-state.\u000a\u000aThis fixes I05957182a57423ad947ab200b52f65fde859e110.\u000a\u000aRelated: OS#5364 and OS#6214\u000aChange-Id: Iea6fe623956003130000c59ec0e1b24b3177052d\u000a", "date" : "2023-10-18 08:08:14 +0200", "id" : "e45abc96ec016451d99b9daf7eff3ad11080fbc3", "msg" : "ASCI: Ignore cell selection event during group receive mode", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "86fed8fc97a68297658463f080c9f9b1ff5c20e5", "timestamp" : 1697609298000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Select correct state when returning to idle or group receive mode\u000a\u000aThis fixes I05957182a57423ad947ab200b52f65fde859e110.\u000a\u000aRelated: OS#5364 and OS#6214\u000aChange-Id: I626195161b987f1ba0065134afcf3936c9c090eb\u000a", "date" : "2023-10-18 08:08:18 +0200", "id" : "86fed8fc97a68297658463f080c9f9b1ff5c20e5", "msg" : "ASCI: Select correct state when returning to idle or group receive mode", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "014646fc66032a8ef1961fdb129509174a9589a0", "timestamp" : 1697609304000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Change state correctly when leaving group mode\u000a\u000aUse new_mm_state() to leave group mode. This will trigger IMSI detach\u000awhen returning to IDLE mode, if it has been delayed.\u000a\u000aRelated: OS#5364\u000aChange-Id: I3c83c9e0fe10b35d60d125df6929fcb5ddc35f1a\u000a", "date" : "2023-10-18 08:08:24 +0200", "id" : "014646fc66032a8ef1961fdb129509174a9589a0", "msg" : "ASCI: Change state correctly when leaving group mode", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" ], "commitId" : "162398a0d95afd642ceb4387d59f83277485e6e1", "timestamp" : 1697609305000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Register state machines only once, when the application starts\u000a\u000aRelated: OS#5364\u000aChange-Id: I46d68e31e0bfd6a64c190e439f45b24502dd1f30\u000a", "date" : "2023-10-18 08:08:25 +0200", "id" : "162398a0d95afd642ceb4387d59f83277485e6e1", "msg" : "ASCI: Register state machines only once, when the application starts", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "7a413ffb266aed91f72f462320b8efa7c86f07c7", "timestamp" : 1697636795000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: mnccms: use constants from libosmogsm (gsm_04_08.h)\u000a\u000aChange-Id: I5ce59db39ad865620aaed2d778bc3710cf37bc3b\u000aRelated: OS#4396\u000a", "date" : "2023-10-18 20:46:35 +0700", "id" : "7a413ffb266aed91f72f462320b8efa7c86f07c7", "msg" : "mobile: mnccms: use constants from libosmogsm (gsm_04_08.h)", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "9130b2d8f5a18a605399f3fd1493783cc15ab4c2", "timestamp" : 1697636795000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: cosmetic: improve mncc_{get,set}_bearer()\u000a\u000aChange-Id: I5647bdf58cbf58065dbe8eebe16f330d98fd0d22\u000aRelated: OS#4396\u000a", "date" : "2023-10-18 20:46:35 +0700", "id" : "9130b2d8f5a18a605399f3fd1493783cc15ab4c2", "msg" : "mobile: cosmetic: improve mncc_{get,set}_bearer()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "292f39900c6837c093b54b2b4353a79b7ce26427", "timestamp" : 1697636795000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix mncc_get_bearer(): return -1 straightaway\u000a\u000aEven though the function works as expected and *can* return -1,\u000awhich is first casted to unsigned and then back to signed, let's\u000amake the code less confusing by returning -1 straightaway.\u000a\u000aChange-Id: I3206fcfa9ab4cac85a1f0f2a4de3250b25f9058f\u000aRelated: OS#4396\u000a", "date" : "2023-10-18 20:46:35 +0700", "id" : "292f39900c6837c093b54b2b4353a79b7ce26427", "msg" : "mobile: fix mncc_get_bearer(): return -1 straightaway", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "40609ca94b2fb055ea0a405850e5e4894819d74b", "timestamp" : 1697636795000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: improve handling of Bearer Capability IE for MT calls\u000a\u000aThis patch prepares for adding MT data call support:\u000a\u000a* Move handling of the Bearer Capability IE into a function.\u000a* Check transfer mode and coding standard in the received BCap.\u000a\u000aChange-Id: I3a5cac8c35ba6b7bdc5fcb077690b32848747756\u000aRelated: OS#4396\u000a", "date" : "2023-10-18 20:46:35 +0700", "id" : "40609ca94b2fb055ea0a405850e5e4894819d74b", "msg" : "mobile: improve handling of Bearer Capability IE for MT calls", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "1c7c71376024aa9cbfb415cf712ff2f83062acea", "timestamp" : 1697636795000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: vty: rework support enable/disable commands\u000a\u000aChange-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2\u000aRelated: OS#4396\u000a", "date" : "2023-10-18 20:46:35 +0700", "id" : "1c7c71376024aa9cbfb415cf712ff2f83062acea", "msg" : "mobile: vty: rework support enable/disable commands", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" ], "commitId" : "8c190e6f927a34e5967fe0abd189604f6024f51b", "timestamp" : 1698390736000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Handle rejection of voice group/broadcast call correctly\u000a\u000aIf joining a call gets rejected, the call must not be released, instead\u000ait must return to U3 state (incoming call), because the call still\u000aexists in the cell and it might possible to join it later.\u000a\u000aIf a call notification is gone, a new event is used in the state machine\u000ato release incoming call.\u000a\u000aChange-Id: I605387c6be409ef0e67caf7b9e2a83e1032b45f1\u000aRelated: OS#5364\u000a", "date" : "2023-10-27 09:12:16 +0200", "id" : "8c190e6f927a34e5967fe0abd189604f6024f51b", "msg" : "ASCI: Handle rejection of voice group/broadcast call correctly", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "bfebc813842650e1d5191d561ef4a18b3c9b7eb6", "timestamp" : 1698390742000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Use correct mobile identiy in TALKER INDICATION message\u000a\u000aUse TMSI only if valid in the current location area. If the MS moves to\u000aa different location area and joins a group call before location update,\u000aTMSI is not valid. Then use IMSI instead. If no IMSI/TSMI is available,\u000asend mobile identity without IMSI/TMSI.\u000a\u000aChange-Id: I299604a0e12d91e9133b70757826ac9637da0e3e\u000aRelated: OS#5364\u000a", "date" : "2023-10-27 09:12:22 +0200", "id" : "bfebc813842650e1d5191d561ef4a18b3c9b7eb6", "msg" : "ASCI: Use correct mobile identiy in TALKER INDICATION message", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/include/osmocom/bb/common/settings.h" ], "commitId" : "d7e611472a923f0f3d6f53c8777df7f5e8114656", "timestamp" : 1698390746000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Add option to join voice group/broadcast calls without valid SIM\u000a\u000aThis option must be enabled in the VTY and is disabled by default.\u000a\u000aCalls can be joined when service is limited or normal. With that option\u000aenabled, calls can be joined even with invalid SIM.\u000a\u000aTalking is allowed when service is normal. With that option enabled,\u000atalking is always allowed. It depends on the network, if it accepts the\u000atalker.\u000a\u000aChange-Id: I6ea851a8cb015ff685b985335968c6184beca816\u000aRelated: OS#5364\u000a", "date" : "2023-10-27 09:12:26 +0200", "id" : "d7e611472a923f0f3d6f53c8777df7f5e8114656", "msg" : "ASCI: Add option to join voice group/broadcast calls without valid SIM", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/common/settings.c" ], "commitId" : "9d765a66fc49eef53d8ab601185b11b6e6d7720a", "timestamp" : 1698390748000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "ASCI: Correctly set and store 'uplink-release-local' flag\u000a\u000aAlso this option is enabled by default and show in the VTY if it is\u000adisabled.\u000a\u000aChange-Id: I6af44f0dd7ff842de633587fb0dcbe78126d30e1\u000aRelated: OS#5364\u000a", "date" : "2023-10-27 09:12:28 +0200", "id" : "9d765a66fc49eef53d8ab601185b11b6e6d7720a", "msg" : "ASCI: Correctly set and store 'uplink-release-local' flag", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "df8801bed6b232ab4f16efa457b430f96e49c4ba", "timestamp" : 1698653158000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: rework L1CTL TRAFFIC.{ind,req} related logging\u000a\u000aMake these Rx/Tx messages more informative.\u000a\u000aChange-Id: I9c73db3c3650547030b8c354016e65195daebb62\u000aRelated: OS#4396\u000a", "date" : "2023-10-30 15:05:58 +0700", "id" : "df8801bed6b232ab4f16efa457b430f96e49c4ba", "msg" : "layer23: rework L1CTL TRAFFIC.{ind,req} related logging", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/mncc.h" ], "commitId" : "e1bcc5af889aeb3a7144e478f14bb770bf99bc56", "timestamp" : 1698653158000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: cosmetic: use '#pragma once' in mncc.h\u000a\u000aChange-Id: I2f350c5b67e57097b71b12ba42c90ce0941b8fea\u000a", "date" : "2023-10-30 15:05:58 +0700", "id" : "e1bcc5af889aeb3a7144e478f14bb770bf99bc56", "msg" : "mobile: cosmetic: use '#pragma once' in mncc.h", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/mncc.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/mncc.h", "src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h" ], "commitId" : "011308cbcc1cb4f0b93bf6b9c04513f59c3b2d93", "timestamp" : 1698653158000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: move 'struct gsm_call' from to \u000a\u000aThe only file using this structure is mnccms.c.\u000a\u000aChange-Id: Iaa43609849ac3c755d47258d3aca4bfe7a6b3a49\u000aRelated: OS#4396\u000a", "date" : "2023-10-30 15:05:58 +0700", "id" : "011308cbcc1cb4f0b93bf6b9c04513f59c3b2d93", "msg" : "mobile: move 'struct gsm_call' from to ", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/mncc.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/common/support.h", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/settings.c", "src/host/layer23/src/mobile/mnccms.c", "src/host/layer23/src/common/support.c" ], "commitId" : "e73a604de0ed5af7b7ef4c61ad3a92ec7a062ee8", "timestamp" : 1698910883000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: add support for Circuit Switched Data calls\u000a\u000aThis patch implements the signalling part for mobile originating\u000aand mobile terminating CSD calls. The user plane interface is\u000ato be implemented in follow-up patches.\u000a\u000aChange-Id: I1995fa0a7a68d9b980852b664d472d4633777ac6\u000aRelated: OS#4396\u000a", "date" : "2023-11-02 14:41:23 +0700", "id" : "e73a604de0ed5af7b7ef4c61ad3a92ec7a062ee8", "msg" : "mobile: add support for Circuit Switched Data calls", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/support.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/support.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/vty.h", "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "5bdebfaae347d7c2b925b9f7c79d32a8beb1b5df", "timestamp" : 1698912945000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: rename 'audio' node to 'tch-voice' node\u000a\u000aChange-Id: I2cab597c5de92ecb343cad7aaaa48035ca5f8365\u000aRelated: OS#4396\u000a", "date" : "2023-11-02 15:15:45 +0700", "id" : "5bdebfaae347d7c2b925b9f7c79d32a8beb1b5df", "msg" : "mobile: rename 'audio' node to 'tch-voice' node", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/vty.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gapk_io.c", "src/host/layer23/src/mobile/voice.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/common/settings.c", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/include/osmocom/bb/common/settings.h" ], "commitId" : "e80d30225565d4b352a1451c441d9b4a1b409c4a", "timestamp" : 1698992586000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: clarify TCH I/O {handler,format} naming\u000a\u000aBefore we add handling of TCH I/O for data calls, let's rename the\u000aexisting voice related symbols and struct fields to have 'voice'\u000ain their names.\u000a\u000aChange-Id: If6c799d11e225ad00ca5da5ae63dca20568a0ce0\u000aRelated: OS#4396\u000a", "date" : "2023-11-03 13:23:06 +0700", "id" : "e80d30225565d4b352a1451c441d9b4a1b409c4a", "msg" : "mobile: clarify TCH I/O {handler,format} naming", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gapk_io.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/voice.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/settings.c" ], "commitId" : "1c4a77adbfd91fcf5a5ee3348aef4e81662ab7dd", "timestamp" : 1698992755000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: gsm_settings_init(): set TCH frame format explicitly\u000a\u000aChange-Id: I4660b07977b6701ad5dc4bf25f12cba374101f8b\u000aRelated: OS#4396\u000a", "date" : "2023-11-03 13:25:55 +0700", "id" : "1c4a77adbfd91fcf5a5ee3348aef4e81662ab7dd", "msg" : "mobile: gsm_settings_init(): set TCH frame format explicitly", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/mobile/vty.h", "src/host/layer23/src/common/settings.c", "src/host/layer23/include/osmocom/bb/common/settings.h" ], "commitId" : "21708873998d4875404e071f1084971cbc3bc2e2", "timestamp" : 1698993178000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: add params and VTY commands for data calls\u000a\u000aChange-Id: If52fa70cb202f0736a17fe8eb63d226186637f62\u000aRelated: OS#4396\u000a", "date" : "2023-11-03 13:32:58 +0700", "id" : "21708873998d4875404e071f1084971cbc3bc2e2", "msg" : "mobile: add params and VTY commands for data calls", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/vty.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h", "src/host/layer23/src/mobile/voice.c", "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "b6083dcd13655f3826ceae5022b2253a352d55a0", "timestamp" : 1698993242000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: cosmetic: rename gsm48_rr_tx_{voice->traffic}()\u000a\u000aNot only this function can be used to transmit a voice frame,\u000abut also a data frame during a CSD call.\u000a\u000aChange-Id: I920300ae477e3c3d7c413cd1a35f2bc385266960\u000aRelated: OS#4396\u000a", "date" : "2023-11-03 13:34:02 +0700", "id" : "b6083dcd13655f3826ceae5022b2253a352d55a0", "msg" : "mobile: cosmetic: rename gsm48_rr_tx_{voice->traffic}()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gsm48_rr.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/voice.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch.c", "src/host/layer23/include/osmocom/bb/mobile/Makefile.am", "src/host/layer23/src/mobile/gapk_io.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c", "src/host/layer23/src/mobile/voice.c", "src/host/layer23/include/osmocom/bb/mobile/tch.h", "src/host/layer23/include/osmocom/bb/mobile/voice.h", "src/host/layer23/src/mobile/Makefile.am", "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "efe2c7b7bd12729335a795ddb255c87e4d6722f7", "timestamp" : 1698993242000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: rename voice.[ch] to tch.[ch]\u000a\u000aAlso take a chance to change the 'tch_' prefix for all functions.\u000a\u000aChange-Id: I05e1ae777add73672db61565c77c68d8ab2b08f0\u000aRelated: OS#4396\u000a", "date" : "2023-11-03 13:34:02 +0700", "id" : "efe2c7b7bd12729335a795ddb255c87e4d6722f7", "msg" : "mobile: rename voice.[ch] to tch.[ch]", "paths" : [ { "editType" : "delete", "file" : "src/host/layer23/include/osmocom/bb/mobile/voice.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gapk_io.c" }, { "editType" : "add", "file" : "src/host/layer23/src/mobile/tch.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/Makefile.am" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/Makefile.am" }, { "editType" : "delete", "file" : "src/host/layer23/src/mobile/voice.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" }, { "editType" : "add", "file" : "src/host/layer23/include/osmocom/bb/mobile/tch.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" ], "commitId" : "3aa20b9959abad8ce6e31f09d1344ddfd70c9208", "timestamp" : 1699618453000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, "authorEmail" : "andreas@eversberg.eu", "comment" : "ASCI: Notify talker in the VTY that he cannot leave the call while talking\u000a\u000aRelated: OS#5364\u000aChange-Id: I497efc5bddc122cd5744de531917aad415ac1654\u000a", "date" : "2023-11-10 12:14:13 +0000", "id" : "3aa20b9959abad8ce6e31f09d1344ddfd70c9208", "msg" : "ASCI: Notify talker in the VTY that he cannot leave the call while", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm44068_gcc_bcc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "c56247071cc6faf8bcbbb511795d1e39aa87a0de", "timestamp" : 1699994678000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "trxcon/l1sched: tx_tch[fh]_fn(): fix sending idle CSD frames\u000a\u000aIn accordance with 3GPP TS 44.021, sections 8.1.6 and 10.2.3, the\u000atransmission of idle frames to the DTE is mandated when no data is\u000areceived from the radio interface. An idle frame has all data,\u000astatus, and E-bits to binary '1' (excluding the alignment pattern).\u000a\u000aThis requirement is currently implemented by osmo-bts for the Uplink,\u000aand is going to be adopted for the Downlink (see the related patch).\u000a\u000aThis patch brings trxcon/l1sched in sync with osmo-bts-trx.\u000a\u000aChange-Id: I7dea3dde46bc02814e99c3e873298cc7ed045a51\u000aRelated: osmo-bts.git I0b25cfac41b6d8dcf3bfd9d46d51a9665f1b047a\u000aRelated: OS#1572, OS#4396\u000a", "date" : "2023-11-14 20:44:38 +0000", "id" : "c56247071cc6faf8bcbbb511795d1e39aa87a0de", "msg" : "trxcon/l1sched: tx_tch[fh]_fn(): fix sending idle CSD frames", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/layer1/prim_tch.c" ], "commitId" : "7c60c5d6d95a059a50c85b68a5128c5cfd55f04c", "timestamp" : 1700561050000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware/layer1: avoid 'for' loop initial declarations\u000a\u000aAs was reported by roox, osmocom-bb currently fails to build on OBS:\u000a\u000ahttps://build.opensuse.org/build/home:mnhauke:osmocom:nightly/openSUSE_Tumbleweed/x86_64/osmocom-bb/_log\u000a\u000a[ 24s] layer1/prim_tch.c: In function 'l1s_tch_meas_avg':\u000a[ 24s] layer1/prim_tch.c:183:2: error: 'for' loop initial declarations are only allowed in C99 mode\u000a[ 24s] layer1/prim_tch.c:183:2: note: use option -std=c99 or -std=gnu99 to compile your code\u000a\u000aWe don't specify the C standard explicitly, so let's move the variable\u000adeclaration out of the for-loop in l1s_tch_meas_avg().\u000a\u000aChange-Id: I6c65fbead4e612c81728e9c6601d5f2107616ee6\u000aFixes: 7286560a3 \"firmware/layer1: fill-in DL info for L1CTL TRAFFIC.ind\"\u000a", "date" : "2023-11-21 17:04:10 +0700", "id" : "7c60c5d6d95a059a50c85b68a5128c5cfd55f04c", "msg" : "firmware/layer1: avoid 'for' loop initial declarations", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/layer1/prim_tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/Makefile.inc" ], "commitId" : "818133cd23b493da472daff2cda9a8e97d0c9637", "timestamp" : 1700658746000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "firmware: -nostartfiles -nodefaultlibs are not flags of LD but flags of GCC\u000a\u000aIt seems that those flags have always been gcc flags, and not ld flags.\u000a\u000aAfter decades of tolerating this, binutils 2.36.x no longer tolerates\u000athose flags but prints an error:\u000a\u000aarm-none-eabi-ld: Error: unable to disambiguate: -nostartfiles (did you mean --nostartfiles ?)\u000a\u000aSee also https://github.com/apache/nuttx/issues/3826 and the related\u000ahttps://github.com/apache/nuttx/pull/3836 how this was solved in another\u000aproject - I adopted that solution here 1:1\u000a\u000aChange-Id: Id199e4d03d5aae07a347c98f47791f42c12008c6\u000a", "date" : "2023-11-22 14:12:26 +0100", "id" : "818133cd23b493da472daff2cda9a8e97d0c9637", "msg" : "firmware: -nostartfiles -nodefaultlibs are not flags of LD but flags of", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/Makefile.inc" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/app_mobile.c" ], "commitId" : "520dd66bdb98f6b7e476e1073ed51b1b5aae7972", "timestamp" : 1701078264000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "LAPDm: Enable flag to prevent sending two subsequent REJ frame\u000a\u000aSetting the flag was not required in earlier versions of libosmogsm,\u000abecause this feature was enabled by default.\u000a\u000aThe roundtrip delay for a LAPD link must be less than T200.\u000a\u000aOsmocom-bb runs LAPDm on the host machine via serial interface and USB\u000ainterface that may cause a roundtrip delay that exceeds T200. Also\u000aosmo-bts may have that problem, due to latency between physical\u000ainterface and osmo-bts software.\u000a\u000aWhat may happen:\u000a\u000aAn I frame gets lost.\u000a\u000aThe sending side transmits the next I frame. The receiving side detects\u000athe send-sequence error and responds with a REJ frame.\u000a\u000aDue to the round trip delay, the T200 expires on the sending side and\u000acauses the I frame to be retransmitted with the P bit set, it enters\u000athe timer recovery state. The receiving side detects the send-sequence\u000aerror and responds with a REJ frame with the F bit set.\u000a\u000aThe sending side will then receive two REJ frames. The first REJ frame\u000awill clear the timer recovery state. The second REJ frame (with F bit\u000aset) is received when not in timer recovery state, causing an\u000aMDL-ERROR-INDICATION.\u000a\u000aThe layer 2 connection is broken.\u000a\u000aEarly tests with osmocom-bb in a real network showed exactly this\u000aproblem.\u000a\u000aThe solution is to suppress every second REJ frame at the receiving\u000aside, until the sequence error condition is cleared. If the first REJ\u000aframe gets lost, the sending side would retransmit the I frame again\u000aafter another expiry of T200. Then the receiving side would respond\u000awith a REJ frame again.\u000a\u000aRelates: OS#5969\u000aDepends: libosmocore.git I93994dbbd1fc2c9edb8f3015c6b18ecd0fce0565\u000aChange-Id: Iaa1645fb1970fe513d71bc1b03f7c5eac62f35d7\u000a", "date" : "2023-11-27 10:44:24 +0100", "id" : "520dd66bdb98f6b7e476e1073ed51b1b5aae7972", "msg" : "LAPDm: Enable flag to prevent sending two subsequent REJ frame", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sysinfo.c", "src/host/layer23/include/osmocom/bb/common/sysinfo.h", "src/host/layer23/src/mobile/gsm322.c", "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "046ee64e3dd7bf285d0e965996bde47acae53099", "timestamp" : 1701078566000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810\u000a\u000aWhile it is correct to use the band indicator from SI1 rest octets,\u000ait may only be applied for ARFCN values in the range 512..810.\u000a\u000aThe function gsm_refer_pcs() is used to determine, if the cell (which\u000a'talks' about ARFCNs) refers to them PCS or DCS channels. It returns\u000atrue, if it refers to PCS, but this only means that ARFCNs in the range\u000a512..810 are PCS channels, not all ARFCNs.\u000a\u000aThe new function gsm_arfcn_refer_pcs() is used to add the PCS flag to an\u000aARFCN, if the given cell refers to PCS and the given ARFCN is in the PCS\u000arange 512..810.\u000a\u000aChange-Id: Id99c8534bf853f4f24f99364790c1ac1df6cc007\u000aRelated: OS#6078\u000a", "date" : "2023-11-27 10:49:26 +0100", "id" : "046ee64e3dd7bf285d0e965996bde47acae53099", "msg" : "mobile: Fix PCS ARFCN handling: PCS can only be ARFCN 512..810", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/sysinfo.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm322.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "058a17db207c3a6b6bf5c4b6c00ed67110a5221c", "timestamp" : 1701704081000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Correctly initialize neighbor cell measurement list from SI5*\u000a\u000aA wrong index was used, causing the first neighbor cell to be\u000auninitialized. This uninitialized neighbor cell was reported by\u000aMEASUREMENT REPORT.\u000a\u000aRelated: OS#6280\u000aChange-Id: I192c0777450cbe24abb3c7c8736c678b97725e9f\u000a", "date" : "2023-12-04 16:34:41 +0100", "id" : "058a17db207c3a6b6bf5c4b6c00ed67110a5221c", "msg" : "Correctly initialize neighbor cell measurement list from SI5*", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "1641e07c98a68f3c038b9ee9d490f66914629d24", "timestamp" : 1701704121000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, "authorEmail" : "jolly@eversberg.eu", "comment" : "Correctly assemble measurement result into MEASUREMENT REPORT\u000a\u000aAfter adding the strongest cell to the measurement report, the variables\u000a'strongest' and 'strongest_i' are used to prevent that already added\u000acells are added again.\u000a\u000aPlease note that there are no neighbor cell measurements available,\u000abecause current layer 1 does not report BSIC of neighbor cells. This\u000ameans that there is no neighbor cell reported.\u000a\u000aRelated: OS#6280\u000aChange-Id: Iaeeaf978da31611c47a20af41790bfa6640dcffd\u000a", "date" : "2023-12-04 16:35:21 +0100", "id" : "1641e07c98a68f3c038b9ee9d490f66914629d24", "msg" : "Correctly assemble measurement result into MEASUREMENT REPORT", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/sysinfo.c" ], "commitId" : "08109f5feedd79493383f304e45e8a03cf28ef29", "timestamp" : 1702073265000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: fix incorrect check in gsm_arfcn_refer_pcs()\u000a\u000aChange-Id: I1f4107bdbb0f696ed3bd3cceaa94353ebe69f78f\u000aFixes: 046ee64e3dd7bf285d0e965996bde47acae53099\u000aFixes: CID#336542\u000a", "date" : "2023-12-09 05:07:45 +0700", "id" : "08109f5feedd79493383f304e45e8a03cf28ef29", "msg" : "layer23: fix incorrect check in gsm_arfcn_refer_pcs()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/sysinfo.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/src/logging.c" ], "commitId" : "2242dbfcc6f5ed14a9ea5505f769ab49a7c5f68f", "timestamp" : 1702207077000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: fix checking stderr_target in ms_log_init()\u000a\u000aChecking the stderr makes a little sense, since it's an integer\u000avalue (usually equal to 2). The actual intention, most likely,\u000awas to check 'stderr_target' against NULL.\u000a\u000aChange-Id: Id597f766142f928135f9fd2b7cf4d69de7bc72f0\u000aRelated: OS#6299\u000a", "date" : "2023-12-10 18:17:57 +0700", "id" : "2242dbfcc6f5ed14a9ea5505f769ab49a7c5f68f", "msg" : "virt_phy: fix checking stderr_target in ms_log_init()", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/logging.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/virt_phy/include/osmocom/bb/virtphy/logging.h", "src/host/virt_phy/src/logging.c", "src/host/virt_phy/src/virtphy.c" ], "commitId" : "22b8076619d1543377456a2edd68c16ea3bcb84b", "timestamp" : 1702207092000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "virt_phy: use osmo_init_logging2() to init logging\u000a\u000aChange-Id: Iaaaa3b0c1aaea8d96b760938a4638eaa0dd65bc7\u000aRelated: OS#6299\u000a", "date" : "2023-12-10 18:18:12 +0700", "id" : "22b8076619d1543377456a2edd68c16ea3bcb84b", "msg" : "virt_phy: use osmo_init_logging2() to init logging", "paths" : [ { "editType" : "edit", "file" : "src/host/virt_phy/src/virtphy.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/src/logging.c" }, { "editType" : "edit", "file" : "src/host/virt_phy/include/osmocom/bb/virtphy/logging.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "49d5ffb120f73dc071d1319b77fbc55240d398ef", "timestamp" : 1704728075000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23/mobile: use osmo_mobile_identity API\u000a\u000aMigrate from deprecated gsm48_mi_to_string() API.\u000a\u000aChange-Id: Ib0d7f76cd635e8d1092ffc1d07ecb29ec0435dda\u000aDepends: libosmocore.git If4f7be606e54cfa1c59084cf169785b1cbda5cf5\u000a", "date" : "2024-01-08 22:34:35 +0700", "id" : "49d5ffb120f73dc071d1319b77fbc55240d398ef", "msg" : "layer23/mobile: use osmo_mobile_identity API", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/misc/app_ccch_scan.c" ], "commitId" : "2a688ec5e97a80ee3878bbf951c0acc2b17dbf7a", "timestamp" : 1704729105000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23/ccch_scan: use osmo_mobile_identity API\u000a\u000a* Migrate from deprecated gsm48_mi_to_string() API.\u000a* Take a chance to unfify printing of mobile identity.\u000a* Use osmo_load32be() for printing TMSI - this is what\u000a the osmo_mobile_identity API does internally.\u000a\u000aChange-Id: Ida67adaa61689c55505a89e1a1bebde041c91139\u000aDepends: libosmocore.git If4f7be606e54cfa1c59084cf169785b1cbda5cf5\u000a", "date" : "2024-01-08 22:51:45 +0700", "id" : "2a688ec5e97a80ee3878bbf951c0acc2b17dbf7a", "msg" : "layer23/ccch_scan: use osmo_mobile_identity API", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/misc/app_ccch_scan.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/solve_envs.py" ], "commitId" : "697e259dc463bf744253ed27475727238a664941", "timestamp" : 1704902516000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware: fix shebang in solve_envs.py: s/python/python3/\u000a\u000aThis patch fixes [currently missing] Jenkins build verification.\u000aCurrently it's just skipping the firmware due to errors:\u000a\u000amake -C target/firmware CROSS_COMPILE=arm-none-eabi-\u000amake[1]: Entering directory '/build/src/target/firmware'\u000a/usr/bin/env: 'python': No such file or directory\u000a/usr/bin/env: 'python': No such file or directory\u000a/usr/bin/env: 'python': No such file or directory\u000a/usr/bin/env: 'python': No such file or directory\u000a/usr/bin/env: 'python': No such file or directory\u000a/usr/bin/env: 'python': No such file or directory\u000a...\u000a\u000aChange-Id: Ibfcc17ca2736da82d60db3b0e350b74e788031b0\u000a", "date" : "2024-01-10 23:01:56 +0700", "id" : "697e259dc463bf744253ed27475727238a664941", "msg" : "firmware: fix shebang in solve_envs.py: s/python/python3/", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/solve_envs.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gapk_io.c" ], "commitId" : "ca183f79d8aef31f9cff5670a06ffbc8c50f90ea", "timestamp" : 1705343804000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix segfault on empty TRAFFIC.ind\u000a\u000aThe L1 PHY may emit empty TRAFFIC.ind in case of decoding errors.\u000aAbort execution of pq_audio_sink early, otherwise we hit an assert.\u000a\u000aChange-Id: Ice11b72ddfd51fbfb17a4c609c664b86a8f69591\u000a", "date" : "2024-01-16 01:36:44 +0700", "id" : "ca183f79d8aef31f9cff5670a06ffbc8c50f90ea", "msg" : "mobile: fix segfault on empty TRAFFIC.ind", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gapk_io.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/common/osmocom_data.h" ], "commitId" : "83e36c0caf3082b194f5c3995ab299675c4893c1", "timestamp" : 1705343822000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: drop unneeded forward declaration\u000a\u000aChange-Id: I75bd08c1a88ad75d93a519422dfb7922c37a27a3\u000a", "date" : "2024-01-16 01:37:02 +0700", "id" : "83e36c0caf3082b194f5c3995ab299675c4893c1", "msg" : "layer23: drop unneeded forward declaration", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/osmocom_data.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm480_ss.c", "src/host/layer23/src/mobile/gsm48_mm.c", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "bb0ac02ecff37cc76d91b14c73bd07ef198ef142", "timestamp" : 1705343822000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: always check return value of tlv_parse()\u000a\u000aChange-Id: Id02fc0b1af6da939cb72f327c7d2ddca484ca063\u000a", "date" : "2024-01-16 01:37:02 +0700", "id" : "bb0ac02ecff37cc76d91b14c73bd07ef198ef142", "msg" : "mobile: always check return value of tlv_parse()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm480_ss.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "273d412ad7a35edf323e9627a0512ebd0251bf63", "timestamp" : 1705348969000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: gsm48_cc_data_ind(): check if struct gsm48_hdr fits\u000a\u000aChange-Id: I06c1877f603d3de0210dee7033ef163637c22054\u000aRelated: OS#4396\u000a", "date" : "2024-01-16 03:02:49 +0700", "id" : "273d412ad7a35edf323e9627a0512ebd0251bf63", "msg" : "mobile: gsm48_cc_data_ind(): check if struct gsm48_hdr fits", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "8d4c4d649da07a355edeae43cf8b58d4791abd0a", "timestamp" : 1705349016000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: mncc_recvmsg(): fix 'msg_type' param type\u000a\u000aChange-Id: I5146637f1c45044d0df258aa3d82fa9454898c92\u000aRelated: OS#4396\u000a", "date" : "2024-01-16 03:03:36 +0700", "id" : "8d4c4d649da07a355edeae43cf8b58d4791abd0a", "msg" : "mobile: mncc_recvmsg(): fix 'msg_type' param type", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "5a1d79e58750f86c1e7530cb9526aae20edf2135", "timestamp" : 1705442532000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: gsm48_mm_data_ind(): check if struct gsm48_hdr fits\u000a\u000aA similar check was recently added to gsm48_cc_data_ind().\u000a\u000aChange-Id: Ibc5153df41e2c6365a3c65b1906d440a1074514b\u000aRelated: 273d412a \"mobile: gsm48_cc_data_ind(): check if struct gsm48_hdr fits\"\u000a", "date" : "2024-01-17 05:02:12 +0700", "id" : "5a1d79e58750f86c1e7530cb9526aae20edf2135", "msg" : "mobile: gsm48_mm_data_ind(): check if struct gsm48_hdr fits", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_mm.c" ], "commitId" : "1f0ce9c9ab8435a102f02502f45559183978b150", "timestamp" : 1705442532000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "fixup: mobile: always check return value of tlv_parse()\u000a\u000aFix a regression: check if Location Area Information IE fits.\u000a\u000aChange-Id: I51e2ae1be1c51a6359f8b0faad56f654251f1413\u000aFixes: bb0ac02e \"mobile: always check return value of tlv_parse()\"\u000aFixes: CID#341618\u000a", "date" : "2024-01-17 05:02:12 +0700", "id" : "1f0ce9c9ab8435a102f02502f45559183978b150", "msg" : "fixup: mobile: always check return value of tlv_parse()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_mm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm480_ss.c", "src/host/layer23/src/mobile/transaction.c", "src/host/layer23/include/osmocom/bb/common/osmocom_data.h", "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "c3a1f4a39b180432e2120970bb6d4eccad4501af", "timestamp" : 1705506761000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: add generic signals for CC/SS/SM transactions\u000a\u000aThis allows driving logic in other modules based on transaction\u000arelated events, such as allocation, deallocation, or a state change.\u000aThese new signals will be used in the upcoming CSD implementation.\u000a\u000aChange-Id: Idae5da24cb517878a26cc14b2ba6976e60f0b31b\u000aRelated: OS#4396\u000a", "date" : "2024-01-17 22:52:41 +0700", "id" : "c3a1f4a39b180432e2120970bb6d4eccad4501af", "msg" : "mobile: add generic signals for CC/SS/SM transactions", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/osmocom_data.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm480_ss.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/transaction.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/transaction.h", "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "a8c3e6eb0e930f9a9e52036018eee5ad6953c473", "timestamp" : 1705506761000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: store MNCC Bearer Capability in CC transaction\u000a\u000aWe will need to know the current Bearer Capability of a CC\u000atransaction in the upcoming patches adding CSD support.\u000a\u000aChange-Id: Ifc3ecf832a552c65444f49711ac836b6cd984715\u000aRelated: OS#4396\u000a", "date" : "2024-01-17 22:52:41 +0700", "id" : "a8c3e6eb0e930f9a9e52036018eee5ad6953c473", "msg" : "mobile: store MNCC Bearer Capability in CC transaction", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/transaction.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gapk_io.c" ], "commitId" : "4038d3e42f6a9e0e92e3deeb675d6586b4d132db", "timestamp" : 1705506761000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: cosmetic: use consistent naming for gapk_io_state\u000a\u000aChange-Id: I96a995bdf20c95a15271de68fbf434e101047313\u000aRelated: OS#4396\u000a", "date" : "2024-01-17 22:52:41 +0700", "id" : "4038d3e42f6a9e0e92e3deeb675d6586b4d132db", "msg" : "mobile: cosmetic: use consistent naming for gapk_io_state", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gapk_io.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/gapk_io.h", "src/host/layer23/src/mobile/tch.c", "src/host/layer23/src/mobile/gsm48_rr.c", "src/host/layer23/src/mobile/gapk_io.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/include/osmocom/bb/mobile/tch.h", "src/host/layer23/include/osmocom/bb/common/ms.h" ], "commitId" : "129d0ea8024817193a0180c487e3394fbb6c7c3d", "timestamp" : 1705524695000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: init/deinit GAPK I/O based on CC transaction events\u000a\u000aChange-Id: I28f87f6a6de673611aa02a24e8985aee23d4498b\u000aRelated: OS#4396\u000a", "date" : "2024-01-18 03:51:35 +0700", "id" : "129d0ea8024817193a0180c487e3394fbb6c7c3d", "msg" : "mobile: init/deinit GAPK I/O based on CC transaction events", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gapk_io.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/tch.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gapk_io.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gapk_io.c", "src/host/layer23/include/osmocom/bb/mobile/tch.h", "src/host/layer23/src/mobile/tch.c", "src/host/layer23/src/mobile/gsm48_cc.c" ], "commitId" : "0829246a2219478ece6def0736279d5d828aa7d2", "timestamp" : 1705524855000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: rename tch_send_voice_{msg,frame}() functions\u000a\u000aThese functions can also be used for sending data frames (CSD).\u000a\u000aChange-Id: Ib55b4405847f2efb583f3a379ff4b6929d6d6c5b\u000aRelated: OS#4396\u000a", "date" : "2024-01-18 03:54:15 +0700", "id" : "0829246a2219478ece6def0736279d5d828aa7d2", "msg" : "mobile: rename tch_send_voice_{msg,frame}() functions", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/tch.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gapk_io.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_cc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_voice.c", "src/host/layer23/src/mobile/tch.c", "src/host/layer23/src/mobile/Makefile.am" ], "commitId" : "f147776e47cdf3e0a47f10805e5374c56c5da928", "timestamp" : 1705705683000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: split voice specific TCH handling into its own file\u000a\u000aChange-Id: Ib917d95fe77da3e60bc932cce56714d81095c7d4\u000aRelated: OS#4396\u000a", "date" : "2024-01-20 06:08:03 +0700", "id" : "f147776e47cdf3e0a47f10805e5374c56c5da928", "msg" : "mobile: split voice specific TCH handling into its own file", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch.c" }, { "editType" : "add", "file" : "src/host/layer23/src/mobile/tch_voice.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/Makefile.am" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/tch.h", "src/host/layer23/src/mobile/tch.c", "src/host/layer23/src/mobile/tch_data.c", "src/host/layer23/configure.ac", "src/host/layer23/src/mobile/Makefile.am" ], "commitId" : "caa00658246f8d7b22735ecdedd5fee7baa6e76e", "timestamp" : 1705705686000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: integrate V.110 TA & soft-UART from libosmocore\u000a\u000aChange-Id: I7ac9c0e5010730fa4d8bc7a7a3c7ff85e11731c0\u000aDepends: libosmocore.git I6d2f8e250df31c233a2741163113dc07515409ae\u000aDepends: libosmocore.git I5716bd6fd0201ee7a7a29e72f775972cd374082f\u000aDepends: libosmocore.git I2ca95963fd5852ddb89bdd35b86b31489127fe84\u000aRelated: OS#4396\u000a", "date" : "2024-01-20 06:08:06 +0700", "id" : "caa00658246f8d7b22735ecdedd5fee7baa6e76e", "msg" : "mobile: integrate V.110 TA & soft-UART from libosmocore", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/configure.ac" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/Makefile.am" }, { "editType" : "add", "file" : "src/host/layer23/src/mobile/tch_data.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/tch.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/tch.h", "src/host/layer23/src/mobile/tch_data.c", "src/host/layer23/src/mobile/tch_data_sock.c", "src/host/layer23/src/mobile/Makefile.am" ], "commitId" : "437118145670eed3c8d36e9226681471c666530d", "timestamp" : 1705710975000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: implement sending CSD data over UNIX socket\u000a\u000aChange-Id: Id054af7b3d9d0a41715f7981deb420f6e09bf30c\u000aRelated: OS#4396\u000a", "date" : "2024-01-20 07:36:15 +0700", "id" : "437118145670eed3c8d36e9226681471c666530d", "msg" : "mobile: implement sending CSD data over UNIX socket", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" }, { "editType" : "add", "file" : "src/host/layer23/src/mobile/tch_data_sock.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/Makefile.am" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/tch.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_data.c", "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "088ddb23c417aac49f92792e31674618e4421c0c", "timestamp" : 1705710993000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix unsupported data rate (UR/IR) messages\u000a\u000aChange-Id: I4f68cc999cb7bf9c5a17c8650de0411248420c1e\u000aRelated: OS#4396\u000a", "date" : "2024-01-20 07:36:33 +0700", "id" : "088ddb23c417aac49f92792e31674618e4421c0c", "msg" : "mobile: fix unsupported data rate (UR/IR) messages", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_04_08.h" ], "commitId" : "149da511d413d5aa19aef2101aa4299aa7b50a64", "timestamp" : 1706054510000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware (libosmocore): fix gsm48_chan_mode for TCH/[FH]2.4\u000a\u000aThis is basically a back-port of the fix that was merged to\u000alibosmocore.git back in 2013. Our ancient copy of libosmocore,\u000awhich is used for building the firmware, predates this commit.\u000a\u000aIdeally, we should rip off this ancient copy and build the firmware\u000aagainst recent master (see OS#2378). But for now, let's just fix\u000aour local copy. Otherwise TCH/[FH]2.4 support is broken.\u000a\u000aChange-Id: I99f528f3e1cd4c04ebb9d8becf1572688dd531ae\u000aRelated: libosmocore.git 31e844bfe2756e36dd50f8bed9fa8b087ee6a1d9\u000aRelated: OS#4396\u000a", "date" : "2024-01-24 00:01:50 +0000", "id" : "149da511d413d5aa19aef2101aa4299aa7b50a64", "msg" : "firmware (libosmocore): fix gsm48_chan_mode for TCH/[FH]2.4", "paths" : [ { "editType" : "edit", "file" : "src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_04_08.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "doc/examples/mobile/multi_ms.cfg", "doc/examples/mobile/default.cfg" ], "commitId" : "17ea9530b9731df6a7962cdd97020842657ea296", "timestamp" : 1706054676000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "doc/examples/mobile: add tch-{data,voice} sections\u000a\u000aChange-Id: I9e53d4c429445ded07d77b27b6a31aa404b00e27\u000aRelated: OS#4396\u000a", "date" : "2024-01-24 00:04:36 +0000", "id" : "17ea9530b9731df6a7962cdd97020842657ea296", "msg" : "doc/examples/mobile: add tch-{data,voice} sections", "paths" : [ { "editType" : "edit", "file" : "doc/examples/mobile/default.cfg" }, { "editType" : "edit", "file" : "doc/examples/mobile/multi_ms.cfg" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/logging.c", "src/host/layer23/src/mobile/tch_data.c", "src/host/layer23/include/osmocom/bb/common/logging.h", "src/host/layer23/src/mobile/tch_data_sock.c" ], "commitId" : "f35414b75e26286a07c36588e744ecfdda40239d", "timestamp" : 1706054697000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: add a separate logging category for CSD\u000a\u000aChange-Id: If9db0759aeb4324ace9ae258c852787f37897d83\u000aRelated: OS#4396\u000a", "date" : "2024-01-24 07:04:57 +0700", "id" : "f35414b75e26286a07c36588e744ecfdda40239d", "msg" : "mobile: add a separate logging category for CSD", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data_sock.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/logging.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/logging.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_data.c" ], "commitId" : "8ebaeca991ab96badd69ff0faca9d5449d7f6416", "timestamp" : 1706114513000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: handle V.24 line status updates from V.110 TA\u000a\u000aChange-Id: I05ba2e10fefe3cae687831b5ced971aa244ad336\u000aRelated: OS#4396\u000a", "date" : "2024-01-24 23:41:53 +0700", "id" : "8ebaeca991ab96badd69ff0faca9d5449d7f6416", "msg" : "mobile: handle V.24 line status updates from V.110 TA", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/settings.c" ], "commitId" : "3c54d77b12e9f9446fcfecbe9e3821ca2506dd77", "timestamp" : 1706114516000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: VTY: use 'enum gsm48_bcap_transp' from libosmogsm\u000a\u000aChange-Id: Iebc0692f17a5a5d04e57d74a720db52775937bdd\u000aRelated: OS#4396\u000a", "date" : "2024-01-24 23:41:56 +0700", "id" : "3c54d77b12e9f9446fcfecbe9e3821ca2506dd77", "msg" : "mobile: VTY: use 'enum gsm48_bcap_transp' from libosmogsm", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/common/settings.c", "src/host/layer23/include/osmocom/bb/common/settings.h" ], "commitId" : "aae93c2163538de6e5ebbc2c46d3bde48ae45303", "timestamp" : 1706114516000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: VTY: make soft-UART parameters configurable\u000a\u000aChange-Id: I48bb58aaf1101fbc0e58db3fb1100927e506ede2\u000aRelated: OS#4396\u000a", "date" : "2024-01-24 23:41:56 +0700", "id" : "aae93c2163538de6e5ebbc2c46d3bde48ae45303", "msg" : "mobile: VTY: make soft-UART parameters configurable", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/mnccms.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/include/osmocom/bb/common/settings.h", "src/host/layer23/src/common/settings.c" ], "commitId" : "2cb3b7adbbd2febe9438065bcea64d5f9d59beb7", "timestamp" : 1706114516000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: VTY: rework data type/rate configuration commands\u000a\u000aChange-Id: I7393fce82613a57275033f5c47e16bbf708a3bfb\u000aRelated: OS#4396\u000a", "date" : "2024-01-24 23:41:56 +0700", "id" : "2cb3b7adbbd2febe9438065bcea64d5f9d59beb7", "msg" : "mobile: VTY: rework data type/rate configuration commands", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/settings.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/common/settings.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/apn_fsm.c" ], "commitId" : "b4cb78a9d9ff5b9d52b51943d0fe19e8c936ff26", "timestamp" : 1706206942000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "modem: fix assigning .timer_cb twice (-Winitializer-overrides)\u000a\u000aChange-Id: Id2d565a5035c47053c0dfa5ad9be3378471b6e14\u000a", "date" : "2024-01-26 01:22:22 +0700", "id" : "b4cb78a9d9ff5b9d52b51943d0fe19e8c936ff26", "msg" : "modem: fix assigning .timer_cb twice (-Winitializer-overrides)", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/apn_fsm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "17c3cbdb097188c14e01dc65d2432f39d714a405", "timestamp" : 1706279384000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: VTY: disable DATA_CALL_TR_V34_9600 (not supported)\u000a\u000aWe cannot initiate V.34 data calls because gsm48_encode_bearer_cap()\u000adoes not support octet 6d. This variant should not be selectable.\u000a\u000aChange-Id: Ibafb9a693654672fb9a6abf665c500a27c87bf22\u000aRelated: OS#4396, OS#6344\u000a", "date" : "2024-01-26 14:29:44 +0000", "id" : "17c3cbdb097188c14e01dc65d2432f39d714a405", "msg" : "mobile: VTY: disable DATA_CALL_TR_V34_9600 (not supported)", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_data.c" ], "commitId" : "8fa524c39703d0e4a0810eb7918d6938296737d7", "timestamp" : 1706279384000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: properly handle different TRAFFIC.{ind,req} formats for CSD\u000a\u000aSo far we supported the Texas Instruments format (TCH_DATA_IOF_TI),\u000awhich is used by Calypso based phones (e.g. Motorola C1xx), but not\u000athe format that trxcon speaks/understands (TCH_DATA_IOF_OSMO).\u000a\u000aChange-Id: Ib17e800e91ad536db53aa55661076089f0ce34b0\u000aRelated: OS#4396\u000a", "date" : "2024-01-26 14:29:44 +0000", "id" : "8fa524c39703d0e4a0810eb7918d6938296737d7", "msg" : "mobile: properly handle different TRAFFIC.{ind,req} formats for CSD", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_data.c", "src/host/layer23/src/mobile/mnccms.c" ], "commitId" : "4b496a8c1c2717ea529ea5adf7f0d6447fa19f3a", "timestamp" : 1706279384000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix rate adaption checking for MO/MT CSD calls\u000a\u000aCurrently we unconditionally expect the rate adaption (octet 5) in\u000athe Bearer Capability IE to be GSM48_BCAP_RA_V110_X30. This is\u000acorrect for UDI (GSM48_BCAP_ITCAP_UNR_DIG_INF), but not for 3.1 kHz\u000aaudio (GSM48_BCAP_ITCAP_3k1_AUDIO) and fax (GSM48_BCAP_ITCAP_FAX_G3)\u000acalls. For the later two it should be GSM48_BCAP_RA_NONE.\u000a\u000aChange-Id: I70d36b3540ed2469068e050809a17ed07b434ad7\u000aRelated: OS#4396\u000a", "date" : "2024-01-26 14:29:44 +0000", "id" : "4b496a8c1c2717ea529ea5adf7f0d6447fa19f3a", "msg" : "mobile: fix rate adaption checking for MO/MT CSD calls", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/mnccms.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c", "doc/examples/mobile/default.cfg" ], "commitId" : "57ef3dea1b60fa8c2e10c2589240c433cd95ce97", "timestamp" : 1706279384000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: VTY: store/read data call params to/from config file\u000a\u000aWe already have VTY commands to configure data call parameters at\u000arun-time, but so far there was no way to save and restore them.\u000aThis commit adds the respective commands to TCH_DATA_NODE.\u000a\u000aChange-Id: I4453f2e7e048b3f3ebb1727f6d26f018c792c92d\u000aRelated: OS#4396\u000a", "date" : "2024-01-26 14:29:44 +0000", "id" : "57ef3dea1b60fa8c2e10c2589240c433cd95ce97", "msg" : "mobile: VTY: store/read data call params to/from config file", "paths" : [ { "editType" : "edit", "file" : "doc/examples/mobile/default.cfg" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_trx.c" ], "commitId" : "006bfe5c3ab39ae3f7765e7b90bf742e71b7c9ac", "timestamp" : 1706807364000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1gprs: print dropped prims in l1sched_reset_lchan()\u000a\u000aChange-Id: Iaa11b5cee16dc43ef01c38be756864c2b3b57835\u000a", "date" : "2024-02-02 00:09:24 +0700", "id" : "006bfe5c3ab39ae3f7765e7b90bf742e71b7c9ac", "msg" : "trxcon/l1gprs: print dropped prims in l1sched_reset_lchan()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_trx.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_pdtch.c" ], "commitId" : "ff0e47de6b98f926f54c148996eeaded6f22f9e8", "timestamp" : 1706807368000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1gprs: print msgb hexdump in prim_dequeue_pdtch()\u000a\u000aChange-Id: I1f82d53a46017c805c70b9dcccad058048549220\u000a", "date" : "2024-02-02 00:09:28 +0700", "id" : "ff0e47de6b98f926f54c148996eeaded6f22f9e8", "msg" : "trxcon/l1gprs: print msgb hexdump in prim_dequeue_pdtch()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_data.c" ], "commitId" : "e2529ea58fa6c1ebbbfc8455ebfcd43ef72820dc", "timestamp" : 1706902704000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()\u000a\u000aIt's unlikely to happen as long as all TCH_DATA_IOF_* variants are\u000ahandled in the switch statements, but still gcc does complain.\u000a\u000aChange-Id: I0a81d5c4f11feb7cf73771c23848dee9ce6ec620\u000a", "date" : "2024-02-03 02:38:24 +0700", "id" : "e2529ea58fa6c1ebbbfc8455ebfcd43ef72820dc", "msg" : "mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c" ], "commitId" : "e344d6b7c29b2ea5a4e0ef244695bbe52b01ac66", "timestamp" : 1707137731000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "l1gprs: minor changes to l1gprs_handle_rts_ind()\u000a\u000a* assert() the given TDMA Tn before accessing gprs->pdch[]\u000a* do not check TDMA Fn, as there can be no RTS.ind for PTCCH/U\u000a** unlike PTCCH/D, we send Access Bursts on PTCCH/U\u000a\u000aChange-Id: Ie74d1c4123715d61875c4c956eb4a1ce97ed5f24\u000a", "date" : "2024-02-05 12:55:31 +0000", "id" : "e344d6b7c29b2ea5a4e0ef244695bbe52b01ac66", "msg" : "l1gprs: minor changes to l1gprs_handle_rts_ind()", "paths" : [ { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/apn_fsm.c" ], "commitId" : "1df9fecf168db9efb19a98cd6154c974a39bcfc5", "timestamp" : 1707146845000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "apn_fsm: Set default timeout for APN activation to 65s\u000a\u000aThe current timeout is too low, taking into account that SM PDP\u000aActivation timeout is already 30. When SM fails, it will retry sending\u000aPDP Context Activation Req. Hence, give it enough time to at least retry\u000aonce, plus some extra buffer time (eg to go through GMM attach once).\u000a\u000aChange-Id: I34f9b0a5ad5767155dc3e4c0ac1c4bf1521be596\u000a", "date" : "2024-02-05 15:27:25 +0000", "id" : "1df9fecf168db9efb19a98cd6154c974a39bcfc5", "msg" : "apn_fsm: Set default timeout for APN activation to 65s", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/apn_fsm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/llc.c" ], "commitId" : "cf32f3429270516828b560b6b5566f6522466bfb", "timestamp" : 1707146845000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "modem: Improve logging when forwarding data to GRR\u000a\u000aChange-Id: Idf80c0fa1c8293afbe354442a72f5b1c5a84f9e1\u000a", "date" : "2024-02-05 15:27:25 +0000", "id" : "cf32f3429270516828b560b6b5566f6522466bfb", "msg" : "modem: Improve logging when forwarding data to GRR", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/modem/llc.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/l1gprs.c", "include/l1ctl_proto.h", "include/l1gprs.h" ], "commitId" : "a6c837cd982dcd7075ff022ae58f71520b148b75", "timestamp" : 1707147234000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "l1gprs: implement UL BLOCK.cnf (L1CTL_GPRS_UL_BLOCK_CNF)\u000a\u000aChange-Id: I56e0b5631c7446390adbfc5664e56f56ebb88cc1\u000a", "date" : "2024-02-05 15:33:54 +0000", "id" : "a6c837cd982dcd7075ff022ae58f71520b148b75", "msg" : "l1gprs: implement UL BLOCK.cnf (L1CTL_GPRS_UL_BLOCK_CNF)", "paths" : [ { "editType" : "edit", "file" : "include/l1ctl_proto.h" }, { "editType" : "edit", "file" : "include/l1gprs.h" }, { "editType" : "edit", "file" : "src/shared/l1gprs.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_pdtch.c", "src/host/trxcon/src/trxcon_fsm.c", "src/host/trxcon/src/trxcon_shim.c", "src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" ], "commitId" : "fc02727700623fbc6f30404919c22b8a1d4bab32", "timestamp" : 1707147234000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH\u000a\u000aIn tx_pdtch_fn(), delay sending DATA.cnf until bid=3. Otherwise we\u000asend it too early (at bid=0) and trick the upper layers (RLC/MAC)\u000ato believe that the whole block (all bursts) has been transmitted.\u000a\u000aChange-Id: If32fafeef0ea347ed3800e6b67349bf12e66047f\u000a", "date" : "2024-02-05 15:33:54 +0000", "id" : "fc02727700623fbc6f30404919c22b8a1d4bab32", "msg" : "trxcon/l1sched: trigger sending UL BLOCK.cnf for PDTCH", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_shim.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_pdtch.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h" }, { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_fsm.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "bec5f4c4f8c475de5234335f6fc701996af50da4", "timestamp" : 1707147234000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23: cosmetic: clarify GPRS related L1CTL logging\u000a\u000aChange-Id: Idcde85c132a52b7bc6c3f2f58c2eac0a509b7b43\u000a", "date" : "2024-02-05 15:33:54 +0000", "id" : "bec5f4c4f8c475de5234335f6fc701996af50da4", "msg" : "layer23: cosmetic: clarify GPRS related L1CTL logging", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/modem/grr.c", "src/host/layer23/src/modem/rlcmac.c", "src/host/layer23/include/osmocom/bb/common/ms.h", "src/host/layer23/include/osmocom/bb/modem/grr.h", "src/host/layer23/src/common/l1ctl.c" ], "commitId" : "aab5d12bdd966ce4ad7cd10fa8d661dff9f23453", "timestamp" : 1707147268000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "layer23/modem: handle and forward L1CTL UL BLOCK.cnf\u000a\u000aChange-Id: I9255ac17529b5ac260f9a0f141f3af6b3b72a802\u000aDepends: libosmo-gprs.git I145b9586f83ae0235b4648916bd44996e8dc57f0\u000a", "date" : "2024-02-05 15:34:28 +0000", "id" : "aab5d12bdd966ce4ad7cd10fa8d661dff9f23453", "msg" : "layer23/modem: handle and forward L1CTL UL BLOCK.cnf", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/l1ctl.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/grr.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/common/ms.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/modem/rlcmac.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/modem/grr.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "e67a21049adfd30c67174c5a30528b12d3daea57", "timestamp" : 1707159579000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo'\u000a\u000aChange-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d\u000a", "date" : "2024-02-06 01:59:39 +0700", "id" : "e67a21049adfd30c67174c5a30528b12d3daea57", "msg" : "mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo'", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/vty_interface.c" ], "commitId" : "21d63cd6c51682e07d32682eac7330ad8beff570", "timestamp" : 1707159579000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: assert() values returned by get_string_value()\u000a\u000aChange-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e\u000a", "date" : "2024-02-06 01:59:39 +0700", "id" : "21d63cd6c51682e07d32682eac7330ad8beff570", "msg" : "mobile: assert() values returned by get_string_value()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "doc/examples/mobile/default.cfg", "src/host/layer23/src/common/support.c" ], "commitId" : "45a11442e630f764344d5086e0043949d6a0d916", "timestamp" : 1707159579000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: disable TCH/F14.4 (not implemented)\u000a\u000aChange-Id: Ia8dff81d4b56c9d6599059f3a5a2964d3cd95829\u000aRelated: OS#4396, OS#6346\u000a", "date" : "2024-02-06 01:59:39 +0700", "id" : "45a11442e630f764344d5086e0043949d6a0d916", "msg" : "mobile: disable TCH/F14.4 (not implemented)", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/common/support.c" }, { "editType" : "edit", "file" : "doc/examples/mobile/default.cfg" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_data.c" ], "commitId" : "b512a08a7cfbe6ec829da0c03f61fe3a0e2f0905", "timestamp" : 1707159579000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: use tch_send_msg() in tch_csd_tx_to_l1()\u000a\u000aDo not access the RR API directly, use TCH API for sending UL data.\u000a\u000aChange-Id: Icd5b5fad835feecd96a83fa5c83ed08037826fa6\u000aRelated: OS#4396\u000a", "date" : "2024-02-06 01:59:39 +0700", "id" : "b512a08a7cfbe6ec829da0c03f61fe3a0e2f0905", "msg" : "mobile: use tch_send_msg() in tch_csd_tx_to_l1()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/include/osmocom/bb/mobile/tch.h", "src/host/layer23/src/mobile/tch.c" ], "commitId" : "1b79142f0f1d7aa0e3bd62faf72ba7de7c7ba745", "timestamp" : 1707159579000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: init TCH state earlier (on receipt of CC ALERTING)\u000a\u000aDuring a Mobile Originating voice call, we would normally start\u000areceiving traffic indications with ringback tone (or even some\u000amelody) before the call gets CONNECTed. So in order for the user\u000ato be able to hear that, we need to init the voice call handler\u000aearlier (on receipt of CC ALERTING message).\u000a\u000aWe should not be transmitting voice/data frames before the call\u000agets CONNECTed, so add 'rx_only' flag to the TCH state. In\u000atch_send_msg() drop msgb if this flag is set.\u000a\u000aRx only mode makes no sense for data calls, so in tch_recv_cb() we\u000adiscard received DL frames and thus do not trigger sending UL frames.\u000a\u000aChange-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec\u000aRelated: OS#4396\u000a", "date" : "2024-02-06 01:59:39 +0700", "id" : "1b79142f0f1d7aa0e3bd62faf72ba7de7c7ba745", "msg" : "mobile: init TCH state earlier (on receipt of CC ALERTING)", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/tch.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch.c", "src/host/layer23/src/mobile/vty_interface.c", "src/host/layer23/src/mobile/tch_data.c", "src/host/layer23/src/mobile/tch_voice.c", "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "20107916e504f7238068df8088e785255fc17c81", "timestamp" : 1707159601000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: set TRAFFIC.{ind,req} mode during call establishment\u000a\u000aNow that we support data (CSD) calls in addition to voice calls,\u000awe can no longer initialize the TRAFFIC.{ind,req} routing mode\u000ain gsm48_rr_init(). We need to apply the appropriate TCH routing\u000amode *during call establishment* based on its type and the\u000aconfigured I/O handler type.\u000a\u000aAfter this patch, one can have the following configuration:\u000a\u000atch-voice\u000a io-handler l1phy\u000atch-data\u000a io-handler unix-sock\u000a io-tch-format ti\u000a\u000aso that the io-handler setting for voice would not affect data calls.\u000aBefore this patch, the L1 PHY (specifically, Calypso firmware) would\u000anot route TRAFFIC.{ind,req} during data calls at all.\u000a\u000aThanks to this patch, it's also no longer required to restart the\u000amobile application after changing voice or data I/O handler.\u000a\u000aChange-Id: Iab68cb47c28380a9c1efc149c6196ea54f75fdb8\u000aRelated: OS#4396\u000a", "date" : "2024-02-06 02:00:01 +0700", "id" : "20107916e504f7238068df8088e785255fc17c81", "msg" : "mobile: set TRAFFIC.{ind,req} mode during call establishment", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/vty_interface.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_data.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_voice.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gapk_io.c", "src/host/layer23/src/mobile/app_mobile.c", "src/host/layer23/include/osmocom/bb/mobile/tch.h", "src/host/layer23/include/osmocom/bb/mobile/gapk_io.h", "src/host/layer23/src/mobile/tch.c", "src/host/layer23/src/mobile/tch_voice.c" ], "commitId" : "f12b17dffb782c7428a563620aa83ec047fd99c4", "timestamp" : 1707221709000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix GAPK I/O producing too many UL frames\u000a\u000aGAPK I/O is currently generating too many UL voice frames, causing\u000aTx queue overflow in the L1 PHY. Change the logic to make DL voice\u000aframes drive the Uplink processing chain, like we do for CSD.\u000a\u000aChange-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1\u000a", "date" : "2024-02-06 19:15:09 +0700", "id" : "f12b17dffb782c7428a563620aa83ec047fd99c4", "msg" : "mobile: fix GAPK I/O producing too many UL frames", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gapk_io.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/tch.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch.c" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_voice.c" }, { "editType" : "edit", "file" : "src/host/layer23/include/osmocom/bb/mobile/gapk_io.h" }, { "editType" : "edit", "file" : "src/host/layer23/src/mobile/app_mobile.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_prim.c" ], "commitId" : "fcaaaaf39664fe4496e15bd27c1f0c6da770b21d", "timestamp" : 1710104773000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: fix hex formatting in prim_enqeue()\u000a\u000aChange-Id: I78c310bd9cc5d69bbeca575ebf4a480f16971e93\u000a", "date" : "2024-03-11 04:06:13 +0700", "id" : "fcaaaaf39664fe4496e15bd27c1f0c6da770b21d", "msg" : "trxcon: fix hex formatting in prim_enqeue()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_prim.c" ], "commitId" : "0d1ab4c8d2cbe0ba72662d5b466fb6c60cb8b45f", "timestamp" : 1710104773000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon: fix prim_compose_mr(): indicate proper tn\u000a\u000aChange-Id: I0046f9c103bcb9207f0c2643c6a806bd56553d77\u000a", "date" : "2024-03-11 04:06:13 +0700", "id" : "0d1ab4c8d2cbe0ba72662d5b466fb6c60cb8b45f", "msg" : "trxcon: fix prim_compose_mr(): indicate proper tn", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/rules", "debian/changelog", "debian/compat", "debian/source/format", "debian/copyright", "debian/control", "debian/osmocom-bb.install" ], "commitId" : "78540e447534b37e92091cb3222c13ad7f73acff", "timestamp" : 1710849538000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, "authorEmail" : "osmith@sysmocom.de", "comment" : "debian: initial layer23 packaging\u000a\u000aRelated: OS#6409\u000aChange-Id: I3713201233e13fca5ea4e0b8c4df913c787965f5\u000a", "date" : "2024-03-19 12:58:58 +0100", "id" : "78540e447534b37e92091cb3222c13ad7f73acff", "msg" : "debian: initial layer23 packaging", "paths" : [ { "editType" : "add", "file" : "debian/compat" }, { "editType" : "add", "file" : "debian/source/format" }, { "editType" : "add", "file" : "debian/changelog" }, { "editType" : "add", "file" : "debian/copyright" }, { "editType" : "add", "file" : "debian/control" }, { "editType" : "add", "file" : "debian/osmocom-bb.install" }, { "editType" : "add", "file" : "debian/rules" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ ".github/FUNDING.yml" ], "commitId" : "5250da87adb94479af71783bd5fe7a68d53d1221", "timestamp" : 1711189795000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "Add funding link to github mirror\u000a\u000asee https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository\u000a\u000aChange-Id: I5e0beef247b80ceab6eee207b5c6ce9caa39cd84\u000a", "date" : "2024-03-23 11:29:55 +0100", "id" : "5250da87adb94479af71783bd5fe7a68d53d1221", "msg" : "Add funding link to github mirror", "paths" : [ { "editType" : "add", "file" : ".github/FUNDING.yml" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "7c00190b45205c2f1d2d8e708c1f6e9dd621ff69", "timestamp" : 1716196588000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks\u000a\u000a... in the absence of valid Uplink TCH/A[FH]S or FACCH frames.\u000a\u000aChange-Id: I26205e8672cb2849ea79bd6206c1eff1172bd9d9\u000aRelated: libosmocore.git I82ce2adf995a4b42d1f378c5819f88d773b9104a\u000aRelated: OS#6049\u000a", "date" : "2024-05-20 14:16:28 +0500", "id" : "7c00190b45205c2f1d2d8e708c1f6e9dd621ff69", "msg" : "trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "d70e8a6de72c361870bd9202110dac933d91992f", "timestamp" : 1716429054000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: fix NULL pointer dereference in tx_tch[fh]_fn()\u000a\u000aIf msg is NULL, we're inducing a BFI condition at the BTS side receiver\u000aby sending a TCH/A[FH]S block with invalid CRC6. In this case we need\u000ato skip the rest of the function and jump to send_burst immediately.\u000a\u000aChange-Id: I159b2ed455377c77d8764f9320efd15333129afb\u000aFixes: 7c00190b \"trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks\"\u000aFixes: CID#368538\u000a", "date" : "2024-05-23 08:50:54 +0700", "id" : "d70e8a6de72c361870bd9202110dac933d91992f", "msg" : "trxcon/l1sched: fix NULL pointer dereference in tx_tch[fh]_fn()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_prim.c" ], "commitId" : "ecaa0636426cc3c0142d18a86097f4fbddc9caa2", "timestamp" : 1717688126000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: make l1sched_lchan_emit_data_cnf() NULL-safe\u000a\u000aPassing NULL to l1sched_lchan_emit_data_cnf() is not normal and\u000agenerally not expected, but definitely not fatal enough to abort\u000athe process completely (due to assertion failure).\u000a\u000aChange-Id: Ie64c176265f66a6c1515c66eb465d7e60f6768db\u000a", "date" : "2024-06-06 22:35:26 +0700", "id" : "ecaa0636426cc3c0142d18a86097f4fbddc9caa2", "msg" : "trxcon/l1sched: make l1sched_lchan_emit_data_cnf() NULL-safe", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_prim.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "784993a54a3cadb81410cd8298caa4c179f33fa8", "timestamp" : 1717688522000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: refactor prim management in tx_tch[fh]_fn()\u000a\u000aThe code path below the switch statement in tx_tch[fh]_fn() is no\u000alonger common since we added CSD specific channel coding. This is\u000awhy we had to jump over it in several case statements.\u000a\u000aThis patch significantly reduces the number of goto statements\u000ain these two functions and makes them easier to read/follow at\u000athe price of code duplication, which is tolerable.\u000a\u000aChange-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675\u000a", "date" : "2024-06-06 22:42:02 +0700", "id" : "784993a54a3cadb81410cd8298caa4c179f33fa8", "msg" : "trxcon/l1sched: refactor prim management in tx_tch[fh]_fn()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/tch_voice.c" ], "commitId" : "c310fcfef7f10d026fbfb9569c2a2b46c6984186", "timestamp" : 1718428778000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: cosmetic: fix -Wswitch in tch_voice_state_init()\u000a\u000aNot really critical, just make gcc happy:\u000a\u000atch_voice.c: In function ‘tch_voice_state_init’:\u000atch_voice.c:117:9: warning: enumeration value ‘TCH_VOICE_IOH_GAPK’ not handled in switch [-Wswitch]\u000a 117 | switch (state->handler) {\u000a | ^~~~~~\u000a\u000aChange-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb\u000a", "date" : "2024-06-15 05:19:38 +0000", "id" : "c310fcfef7f10d026fbfb9569c2a2b46c6984186", "msg" : "mobile: cosmetic: fix -Wswitch in tch_voice_state_init()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/tch_voice.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/layer23/src/mobile/gsm48_rr.c" ], "commitId" : "04ea6f9cab3d9d5120c77f88b500bad526564c0a", "timestamp" : 1718428778000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()\u000a\u000aThis is very unlikely to happen, because we set strongest to 127,\u000abut anyway we don't want to see those warnings:\u000a\u000agsm48_rr.c: In function ‘gsm48_rr_tx_meas_rep.isra’:\u000agsm48_rr.c:3714:74: warning: ‘strongest_i’ may be used uninitialized [-Wmaybe-uninitialized]\u000a 3714 | if (rrmeas->nc_rxlev_dbm[i] == strongest && i <= strongest_i)\u000a | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~\u000agsm48_rr.c:3696:31: note: ‘strongest_i’ was declared here\u000a 3696 | int i, index, strongest_i;\u000a | ^~~~~~~~~~~\u000a\u000aChange-Id: I111438633ed48e16f7c43fc1b7a23ae6753a404d\u000a", "date" : "2024-06-15 05:19:38 +0000", "id" : "04ea6f9cab3d9d5120c77f88b500bad526564c0a", "msg" : "mobile: fix -Wmaybe-uninitialized in gsm48_rr_tx_meas_rep()", "paths" : [ { "editType" : "edit", "file" : "src/host/layer23/src/mobile/gsm48_rr.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/board/se_k2x0/rffe_k2x0.c", "src/target/firmware/fb/fb_k2x0.c", "src/target/firmware/Makefile", "src/target/firmware/board/se_k2xx/init.c", "src/target/firmware/fb/fb_k2xx.c", "src/target/firmware/board/se_k2x0/keymap.h", "src/target/firmware/board/se_k2xx/keymap.h", "src/target/firmware/board/se_k2x0/init.c", "src/target/firmware/board/se_k2xx/rffe_k2xx.c" ], "commitId" : "ff8c972b21287fd317d9db7c68467866ede61956", "timestamp" : 1726420774000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware: rename 'se_k2x0' -> 'se_k2xx' (include K205)\u000a\u000aSony Ericsson K205 joins the party!\u000a\u000aThe entire K2xx-series of Sony Ericsson ODM phone models is based on\u000aTI Calypso. The K200, K205, and K220 are identical, except that the\u000aK205 has a different case/housing, and the K220 includes an FM receiver.\u000a\u000aChange-Id: I05a4815c38f9cea7c2c7f2a33b836ebd0c016d0d\u000a", "date" : "2024-09-16 00:19:34 +0700", "id" : "ff8c972b21287fd317d9db7c68467866ede61956", "msg" : "firmware: rename 'se_k2x0' -> 'se_k2xx' (include K205)", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/Makefile" }, { "editType" : "add", "file" : "src/target/firmware/board/se_k2xx/rffe_k2xx.c" }, { "editType" : "delete", "file" : "src/target/firmware/board/se_k2x0/init.c" }, { "editType" : "delete", "file" : "src/target/firmware/board/se_k2x0/keymap.h" }, { "editType" : "add", "file" : "src/target/firmware/board/se_k2xx/init.c" }, { "editType" : "delete", "file" : "src/target/firmware/fb/fb_k2x0.c" }, { "editType" : "add", "file" : "src/target/firmware/fb/fb_k2xx.c" }, { "editType" : "delete", "file" : "src/target/firmware/board/se_k2x0/rffe_k2x0.c" }, { "editType" : "add", "file" : "src/target/firmware/board/se_k2xx/keymap.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/firmware/board/se_k2xx/init.c" ], "commitId" : "cb0a7293e6e9e80b51a81136e88e747858cbd6bc", "timestamp" : 1726424280000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "firmware: k2xx: fix comments about flash organization\u000a\u000aChange-Id: I1b6a50cf7e10b5d71c6aa8d492721a7345ad892a\u000a", "date" : "2024-09-16 01:18:00 +0700", "id" : "cb0a7293e6e9e80b51a81136e88e747858cbd6bc", "msg" : "firmware: k2xx: fix comments about flash organization", "paths" : [ { "editType" : "edit", "file" : "src/target/firmware/board/se_k2xx/init.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c" ], "commitId" : "60bebe94507759c56698abffe7c09bb87c09f2b4", "timestamp" : 1731101156000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: fix decoding of DL FACCH/H for TCH/H4.8 and TCH/H2.4\u000a\u000aThe mapping sched_tchh_dl_csd_map[] is valid for DL TCH/H4.8 and\u000aTCH/H2.4, but not for DL FACCH/H. We need to use a separate\u000alookup table sched_tchh_dl_facch_map[] for DL FACCH/H.\u000a\u000aChange-Id: I17df806185dc620999c4c2b9ed83a18cc8b2e0bf\u000aFixes: a93785bf4 (\"trxcon/l1sched: implement CSD scheduling support\")\u000aRelated: OS#4396, OS#6618\u000a", "date" : "2024-11-09 04:25:56 +0700", "id" : "60bebe94507759c56698abffe7c09bb87c09f2b4", "msg" : "trxcon/l1sched: fix decoding of DL FACCH/H for TCH/H4.8 and TCH/H2.4", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" ], "commitId" : "c344a6a02e7924b5bd69994eddfb38c313f10813", "timestamp" : 1731101174000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: replace old API with sched_tchh_ul_facch_map[]\u000a\u000aThe new UL FACCH/H mapping was the only missing bit that finally\u000aallows us to remove the old API which predates the lookup tables.\u000a\u000aChange-Id: I63ae94bc2edd528b1f9fd2c505b39a43ba1742fd\u000a", "date" : "2024-11-09 04:26:14 +0700", "id" : "c344a6a02e7924b5bd69994eddfb38c313f10813", "msg" : "trxcon/l1sched: replace old API with sched_tchh_ul_facch_map[]", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" }, { "editType" : "edit", "file" : "src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c" ], "commitId" : "8e626aba27c4bc571e2dd35a38f2bcd32cd93b47", "timestamp" : 1731433079000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: fix FACCH/H regression in rx_tchh_fn()\u000a\u000aIn c15084a5 overlooked that in order to ensure alignment to the first\u000aFACCH/H block in rx_tchh_fn() we actually need to check if DL FACCH/H\u000acan start (not end!) at the current TDMA Fn. This means we cannot use\u000athe same mapping as we do below in that function; we need another one.\u000a\u000aThis patch fixes multiple FACCH/H regressions in ttcn3-bts-test.\u000a\u000aChange-Id: Ia4b737cf11d4d9ce9847cabb77189e9cbcbb8840\u000aFixes: c15084a5 (\"trxcon/l1sched: replace old API with sched_tchh_ul_facch_map[]\")\u000a", "date" : "2024-11-13 00:37:59 +0700", "id" : "8e626aba27c4bc571e2dd35a38f2bcd32cd93b47", "msg" : "trxcon/l1sched: fix FACCH/H regression in rx_tchh_fn()", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/doc/l1sched_tch.txt" ], "commitId" : "83bc65bec8f2e88a3efcb3263bafc21dcfdd7e4a", "timestamp" : 1731436205000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: check-in trx_sched_tch.txt from osmo-bts.git\u000a\u000aThis explains burst processing on full-/half-rate traffic channels.\u000a\u000aChange-Id: I3582d6f6e489a345ba8fc6580f6bb29da630fc8e\u000a", "date" : "2024-11-13 01:30:05 +0700", "id" : "83bc65bec8f2e88a3efcb3263bafc21dcfdd7e4a", "msg" : "trxcon/l1sched: check-in trx_sched_tch.txt from osmo-bts.git", "paths" : [ { "editType" : "add", "file" : "src/host/trxcon/doc/l1sched_tch.txt" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/sched_lchan_tchh.c", "src/host/trxcon/src/sched_lchan_tchf.c" ], "commitId" : "efd2110f828e02a696f95addac71f4cdf9a63902", "timestamp" : 1731437513000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "trxcon/l1sched: clarify TDMA Fn (mod 26) maps\u000a\u000a* Clarify comments, fix 3GPP spec. references\u000a* Remove burst tables, refer to doc/l1sched_tch.txt\u000a* Rename mappings: include burst letter\u000a\u000aChange-Id: Ib664ba643073e7673aa86aa860a1649225c19aa1\u000a", "date" : "2024-11-13 01:51:53 +0700", "id" : "efd2110f828e02a696f95addac71f4cdf9a63902", "msg" : "trxcon/l1sched: clarify TDMA Fn (mod 26) maps", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchf.c" }, { "editType" : "edit", "file" : "src/host/trxcon/src/sched_lchan_tchh.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/rules" ], "commitId" : "5af5ee333ae9510b072d644daf33dfdb60e76928", "timestamp" : 1733145966000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, "authorEmail" : "osmith@sysmocom.de", "comment" : "debian: prepare for more subpackages\u000a\u000aPrepare to add these subpackages in follow-up patches:\u000a* osmocom-bb-trx-toolkit\u000a* osmocom-bb-trxcon\u000a* osmocom-bb-virtphy\u000a\u000aWe need these components to run some of the ttnc3 testsuites. By having\u000athem packaged, we can just install them from the binary repositories\u000aalong with the SUT.\u000a\u000atrxcon and virtphy are autootols based, so rework debian/rules to\u000asupport building multiple autotools projects.\u000a\u000aRelated: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/1..2//COMMIT_MSG#b9\u000aChange-Id: I77ad988f5405e6fa9e585eeb646e513ac7d92485\u000a", "date" : "2024-12-02 14:26:06 +0100", "id" : "5af5ee333ae9510b072d644daf33dfdb60e76928", "msg" : "debian: prepare for more subpackages", "paths" : [ { "editType" : "edit", "file" : "debian/rules" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/control", "debian/rules" ], "commitId" : "acb14737e712a588452d4694ef1e3369679538e9", "timestamp" : 1733146497000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, "authorEmail" : "osmith@sysmocom.de", "comment" : "debian: add subpackage osmocom-bb-trxcon\u000a\u000aChange-Id: I548cec7427d70706b1b477c0845234efe6cf825f\u000a", "date" : "2024-12-02 14:34:57 +0100", "id" : "acb14737e712a588452d4694ef1e3369679538e9", "msg" : "debian: add subpackage osmocom-bb-trxcon", "paths" : [ { "editType" : "edit", "file" : "debian/rules" }, { "editType" : "edit", "file" : "debian/control" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/control", "debian/rules" ], "commitId" : "688bab508341b23746c0e0400e2bc79bd0970d21", "timestamp" : 1733146805000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, "authorEmail" : "osmith@sysmocom.de", "comment" : "debian: add subpackage osmocom-bb-virtphy\u000a\u000aI've decided to name the package osmocom-bb-virtphy so there is no\u000aunderscore in it (would look weird in addition to the minus character)\u000aand because it matches the name of the binary \"virtphy\".\u000a\u000aChange-Id: I09d98aba81ab6c76ad46aae36e7369114cef7dd7\u000a", "date" : "2024-12-02 14:40:05 +0100", "id" : "688bab508341b23746c0e0400e2bc79bd0970d21", "msg" : "debian: add subpackage osmocom-bb-virtphy", "paths" : [ { "editType" : "edit", "file" : "debian/rules" }, { "editType" : "edit", "file" : "debian/control" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/osmocom-bb-trx-toolkit.install", "debian/control" ], "commitId" : "f9782c6609ff43635e9e986e011f902a98abea0e", "timestamp" : 1733146870000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, "authorEmail" : "osmith@sysmocom.de", "comment" : "debian: add subpackage osmocom-bb-trx-toolkit\u000a\u000aChange-Id: I3d8140991afaf08b6fff0e80d45dd0310c98ea30\u000a", "date" : "2024-12-02 14:41:10 +0100", "id" : "f9782c6609ff43635e9e986e011f902a98abea0e", "msg" : "debian: add subpackage osmocom-bb-trx-toolkit", "paths" : [ { "editType" : "edit", "file" : "debian/control" }, { "editType" : "add", "file" : "debian/osmocom-bb-trx-toolkit.install" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/changelog" ], "commitId" : "d95af8c46e46207d9a496a6e12a3e502a567db68", "timestamp" : 1733224038000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, "authorEmail" : "osmith@sysmocom.de", "comment" : "Bump version: 0.1.0 → 0.2.0\u000a\u000aPrepare a release tag, so we get binary packages for\u000aosmocom-bb-trx-toolkit, osmocom-bb-trxcon, osmocom-bb-virtphy in the\u000aosmocom:latest repository. Then we can use these packages when running\u000aTTCN-3 testsuites.\u000a\u000aThis is not an official release, as discussed here:\u000ahttps://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/1..2//COMMIT_MSG#b9\u000a\u000aChange-Id: Ifbfaead7ae89d9ac747d1bb495f061c5cbe7a241\u000a", "date" : "2024-12-03 12:07:18 +0100", "id" : "d95af8c46e46207d9a496a6e12a3e502a567db68", "msg" : "Bump version: 0.1.0 → 0.2.0", "paths" : [ { "editType" : "edit", "file" : "debian/changelog" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "contrib/jenkins.sh" ], "commitId" : "8a28cf2e51d1aa5a677ab1ce3645b0b4164e16b5", "timestamp" : 1733846912000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "jenkins.sh: Use --disable-doxygen configure param\u000a\u000aChange-Id: I09eab54587e5d310143faaa57257fe05e4f0e7f6\u000a", "date" : "2024-12-10 17:08:32 +0100", "id" : "8a28cf2e51d1aa5a677ab1ce3645b0b4164e16b5", "msg" : "jenkins.sh: Use --disable-doxygen configure param", "paths" : [ { "editType" : "edit", "file" : "contrib/jenkins.sh" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/clck_gen.py", "src/target/trx_toolkit/test_clck_gen.py" ], "commitId" : "abc63d8d825eb56fdcd7e01bf8824915c8780e18", "timestamp" : 1736940329000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/clck_gen.py: Fix clock generator not to accumulate timing error\u000a\u000aCLCKGen currently works as follows:\u000a\u000a\u0009sleep(ctr_interval)\u000a\u0009some work\u000a\u0009sleep(ctr_interval)\u000a\u0009some work\u000a\u0009sleep(ctr_interval)\u000a\u0009some work\u000a\u0009...\u000a\u000aThe intent here is to do some work at timestamps that are multiple of ctr_interval,\u000ahowever the implementation does not match the intent, because\u000a\u000a1) sleep(ctr_interval) is not guaranteed by the OS to be ideal, so there\u000a will always be some jitter in actually slept time without any\u000a guarantee that the error will fluctuate over zero without accumulating.\u000a\u000a2) \"some work\" takes some time to run and that time adds again and again\u000a to the current time when next sleep(ctr_interval) starts. As the\u000a result even if sleep implementation would be ideal, then n'th sleep\u000a would start not at\u000a\u000a\u0009t₀ + n·ctr_interval\u000a\u000a but instead at\u000a\u000a\u0009t₀ + n·ctr_interval + Σ1..n t(work_i)\u000a\u000a where trailing Σ term adds over and over as the timing error which can\u000a be seen as e.g. increasing trend of received GSM clock jitter in\u000a https://osmocom.org/issues/4658#note-10 .\u000a\u000aThe thinko in the clock generator logic is not so much visible if \"some\u000awork\" takes only a bit of time or is done infrequently. That was\u000aactually the case before fake_trx added tx queueing in 6e1c82d2\u000a(trx_toolkit/transceiver.py: implement the transmit burst queue) because\u000abefore that commit some work was only \"send IND CLOCK data every ~ 100th\u000atick\". However after 6e1c82d2 the work was adjusted to do linear scan of\u000atx queue over and over at every tick which amplified error accumulation\u000aand highlighted the problem.\u000a\u000aWith that tx queuing in fake_trx was disabled in d4ed09df (Revert\u000a\"trx_toolkit/transceiver.py: implement the transmit burst queue\") with\u000athe rationale being most likely, as https://osmocom.org/issues/4658#note-10 says,\u000a\u000a Unfortunately, Python is not fast enough to handle the queues in time.\u000a Despite the relatively low CPU usage, fake_trx.py fails to scheduler\u000a everything during one TDMA frame period. This causes some of our TTCN-3\u000a test cases to fail.\u000a\u000a ...\u000a\u000a Most likely, the problem is that Python's threading.Event is not\u000a accurate enough. Running with SCHED_RR does not change anything.\u000a\u000aHowever with the above analysis we can see that it is the logic in\u000aCLCKgen that needs fixing, not threading.Event . For the reference\u000athreading.Event indeed used dumb timeout implementation on Python2:\u000a\u000a https://github.com/python/cpython/blob/2.7-0-g8d21aa21f2c/Lib/threading.py#L597-L615\u000a https://github.com/python/cpython/blob/2.7-0-g8d21aa21f2c/Lib/threading.py#L343-L369\u000a\u000abut on Python3 it essentially uses plain Lock.acquire(timeout) which,\u000aunder the hood, uses PyThread_acquire_lock_timed - a plain wrapper over\u000asem_timedwait:\u000a\u000a https://github.com/python/cpython/blob/v3.11.9-9-g1b0e63c81b5/Lib/threading.py#L330-L331\u000a https://github.com/python/cpython/blob/v3.11.9-9-g1b0e63c81b5/Modules/_threadmodule.c#L75-L100\u000a https://github.com/python/cpython/blob/v3.11.9-9-g1b0e63c81b5/Python/thread_pthread.h#L480-L491\u000a\u000aso at least with py3 there should be no question about threading.Event .\u000a\u000a-> Fix timing error accumulation by reworking the clock generator loop\u000a to compensate observed jitter, caused by OS noise and the work\u000a taking time, by adjusting to-sleep δt each tick accordingly.\u000a\u000a This is generally good for correctness and will allow us to reinstate\u000a tx queueing in fake_trx.\u000a\u000aWithout the fix added test fails as\u000a\u000a FAIL: test_no_timing_error_accumulated (test_clck_gen.CLCKGen_Test.test_no_timing_error_accumulated)\u000a ----------------------------------------------------------------------\u000a Traceback (most recent call last):\u000a File \"/home/kirr/src/osmocom/bb/src/target/trx_toolkit/test_clck_gen.py\", line 60, in test_no_timing_error_accumulated\u000a self.assertTrue((ntick+1)*clck.ctr_interval > δT, \"tick #%d: time overrun by %dµs total\" %\u000a AssertionError: False is not true : tick #200: time overrun by 572478µs total\u000a\u000aChange-Id: I928801422c9af80c368261f617b91d7ecfedbabf\u000aRelated: OS#4658, OS#6672\u000a", "date" : "2025-01-15 14:25:29 +0300", "id" : "abc63d8d825eb56fdcd7e01bf8824915c8780e18", "msg" : "trx_toolkit/clck_gen.py: Fix clock generator not to accumulate timing", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/clck_gen.py" }, { "editType" : "add", "file" : "src/target/trx_toolkit/test_clck_gen.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/clck_gen.py" ], "commitId" : "008dfba7d8511912e7a1dbc3a32d89bfee007b16", "timestamp" : 1736956891000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/clck_gen: Fix DeprecationWarning about Thread.setDaemon\u000a\u000aThis warning is currently emitted each time trx_toolkit unittests are run:\u000a\u000a (osmo.venv) kirr@deca:~/src/osmocom/bb/src/target/trx_toolkit$ python -m unittest discover\u000a /home/kirr/src/osmocom/bb/src/target/trx_toolkit/clck_gen.py:71: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead\u000a self._thread.setDaemon(True)\u000a ...............................................\u000a ----------------------------------------------------------------------\u000a Ran 47 tests in 0.997s\u000a\u000a OK\u000a\u000a-> Fix it by using Thread.daemon attribute directly as suggested by\u000a https://docs.python.org/3/library/threading.html#threading.Thread.setDaemon\u000a\u000aChange-Id: I6ef70762f671b86342daa35a097532f0b620aaca\u000a", "date" : "2025-01-15 19:01:31 +0300", "id" : "008dfba7d8511912e7a1dbc3a32d89bfee007b16", "msg" : "trx_toolkit/clck_gen: Fix DeprecationWarning about Thread.setDaemon", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/clck_gen.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/clck_gen.py", "src/target/trx_toolkit/test_clck_gen.py" ], "commitId" : "2727bef943d4bac02eef0cb8d18b25ba4a259918", "timestamp" : 1737545599000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/clck_gen: Fix clock generator to emit ticks with exactly GSM frame period\u000a\u000aSince fake_trx beginning in 3187c8e6 (target/fake_trx: initial release\u000aof virtual transceiver) CLCKGen was tuned to emitting ticks with sleep\u000aperiod being time of 1 GSM frame _decreased_ a bit by \"Average loop back\u000adelay\". The idea for this decrease probably was to compensate the time\u000aspent in each tick handler, so that combined sleep + tick work would\u000aoccupy time of 1 GSM frame more or less.\u000a\u000aThe idea of using hardcoded compensation turned out to be not very good,\u000abecause for the overall tick period to be exactly as defined the\u000acompensation should be dynamic and take into account time spent in each\u000atick handler. For example on one machine \"loopback delay\" is one value,\u000awhile on another it will be another value. And if we attach more work to\u000atick handler, like it already happened with adding tx queue, the\u000acompensation needs to take all that into account as well.\u000a\u000aabc63d8d (trx_toolkit/clck_gen.py: Fix clock generator not to accumulate\u000atiming error) explains the problem in detail and adds dynamic\u000acompensation so that the tick period stays as defined instead of\u000adrifting. But it missed to adjust CLCKgen to stop decreasing desired\u000atick period a bit by \"average loop back delay\".\u000a\u000aSo after that patch, because CLCKgen now follows desired period without\u000adrifting, its period was 4.615ms - 0.09ms instead of exact 4.615ms,\u000awhich resulted in e.g. fake_trx and bts-trx clocks to become constantly\u000adissynchronized with the following emitted by bts-trx non-stop:\u000a\u000a 20250122135431420 <0006> scheduler_trx.c:576 GSM clock skew: old fn=0, new fn=102\u000a 20250122135431882 <0006> scheduler_trx.c:604 We were 3 FN slower than TRX, compensated\u000a 20250122135432344 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135432805 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135433267 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135433728 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135434190 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135434651 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135435113 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135435575 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135436036 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135436498 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135436959 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a 20250122135437421 <0006> scheduler_trx.c:604 We were 2 FN slower than TRX, compensated\u000a ...\u000a\u000aWhat happens here is that there are ~ 216 GSM frames every second, and\u000asince fake_trx drifts by 0.09ms every frame, it results in drifting by ~\u000a20ms every second. Which results in \"2 FN slower than TRX\" emitted\u000aapproximately twice per second as above log excerpt confirms.\u000a\u000a-> Fix this by adjusting CLCKgen to emit ticks with exactly GSM frame\u000aperiod by default.\u000a\u000aChange-Id: Ie12fbe8138bac1398805fa270b869e7a333fcba0\u000a", "date" : "2025-01-22 14:33:19 +0300", "id" : "2727bef943d4bac02eef0cb8d18b25ba4a259918", "msg" : "trx_toolkit/clck_gen: Fix clock generator to emit ticks with exactly GSM", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/clck_gen.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/test_clck_gen.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py", "src/target/trx_toolkit/fake_trx.py" ], "commitId" : "0f4714776a9c9b64c4a7268eb8a346f304835565", "timestamp" : 1739362500000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "Revert \"Revert \"trx_toolkit/transceiver.py: implement the transmit burst queue\"\"\u000a\u000aThis reverts commit d4ed09df57b3461470af501e9687ddd80eb78838,\u000areinstating tx queue into fake_trx.\u000a\u000aIt is ok to do so because, as explained in abc63d8d (trx_toolkit/clck_gen.py:\u000aFix clock generator not to accumulate timing error), the\u000areason for GSM clock jitter problem was timing error accumulation in\u000aCLCKgen, not problems with py threading.Event.\u000a\u000aNote: this restores original tx queue implementation basically as-is\u000awith only resolve minor conflicts during the revert. The original tx\u000aqueue implementation wastes CPU cycles though because it linearly scans\u000athe whole tx queue at every TDMA frame. If that CPU usage becomes a real\u000aproblem it should be straightforward to fix by reworking tx queue to use\u000apriority queue instead of unordered array via heapq module from standard\u000alibrary. See https://docs.python.org/3/library/heapq.html for details.\u000a\u000aThe follow-up patches will make necessarry adjastments for tx-queue to\u000afunction properly.\u000a\u000aRelated: OS#4658, OS#6672\u000aChange-Id: I41291708effdd2c767be680fff22ffbd9a56815e\u000a", "date" : "2025-02-12 15:15:00 +0300", "id" : "0f4714776a9c9b64c4a7268eb8a346f304835565", "msg" : "Revert \"Revert \"trx_toolkit/transceiver.py: implement the transmit burst", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/fake_trx.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/host/trxcon/src/trxcon_main.c" ], "commitId" : "c80e193f6d95367e764684a6021ede981f44ebbd", "timestamp" : 1739367153000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trxcon: Advance Uplink TDMA Fn by default again\u000a\u000aThis essentially reverts 923e9b0b (trxcon: do not advance Uplink TDMA Fn\u000aby default; I838b1ebc54e4c5d116f8af2155d97215a6133ba4) for the following\u000areason:\u000a\u000aIn trxcon TRX clock is unused, because the signal from BTS is used as\u000athe master clock source instead (see 45c821ae/Ic8a5b6277c6b16392026e0557376257d71c9d230\u000a\"trxcon: get rid of the timer driven clock module\" for details\".\u000a\u000aBefore restoration of tx-queue in fake_trx this was working ok even with\u000afn-advance=0 on Ms side, but after I41291708effdd2c767be680fff22ffbd9a56815e\u000a(Revert \"Revert \"trx_toolkit/transceiver.py: implement the transmit\u000aburst queue\"\") fake_trx is sending frames having Fn when exactly same Fn\u000ahappens corresponding on fake_trx clock. This results in BTS frames\u000a(that are sent with fn-advance=2 by default (see\u000aI7da3d0948f38e12342fb714b29f8edc5e9d0933d in osmo-bts.git and OS#4487)\u000ato be queued, waited to be sent, and then actually sent to Ms on\u000afn=msg.fn . And then even if Ms replies immediately with that same fn,\u000athat message will be dropped by fake_trx as stalled, because fake_trx\u000athinks that the message is too late since that fn already happened\u000aaccording to fake_trx clock.\u000a\u000aHere is a trace of how that looks like with 1 BTS and 1 MS(*):\u000a\u000a 7.106.927 CLOCK fn=80\u0009\u0009# fake_trx running\u000a 7.111.592 CLOCK fn=81\u000a 7.116.289 CLOCK fn=82\u000a 7.120.949 CLOCK fn=83\u000a 7.125.523 CLOCK fn=84\u000a 7.130.000 CLOCK fn=85\u000a 7.134.575 CLOCK fn=86\u000a\u000a ...\u000a\u000a 7.209.222 CLOCK fn=102\u000a 7.209.897 BTS -> fn=104 tn=0\u0009# BTS starts to emit RF\u000a 7.210.221 BTS -> fn=104 tn=1\u000a 7.210.556 BTS -> fn=104 tn=2\u000a 7.210.796 BTS -> fn=104 tn=3\u000a 7.211.019 BTS -> fn=104 tn=4\u000a 7.211.234 BTS -> fn=104 tn=5\u000a 7.211.479 BTS -> fn=104 tn=6\u000a 7.211.768 BTS -> fn=104 tn=7\u000a 7.213.086 CLOCK fn=103\u000a 7.214.354 BTS -> fn=105 tn=0\u000a 7.214.566 BTS -> fn=105 tn=1\u000a 7.214.685 BTS -> fn=105 tn=2\u000a 7.214.792 BTS -> fn=105 tn=3\u000a 7.214.890 BTS -> fn=105 tn=4\u000a 7.214.985 BTS -> fn=105 tn=5\u000a 7.215.083 BTS -> fn=105 tn=6\u000a 7.215.184 BTS -> fn=105 tn=7\u000a 7.217.823 CLOCK fn=104\u000a 7.218.869 BTS -> fn=106 tn=0\u000a 7.219.092 BTS -> fn=106 tn=1\u000a 7.219.224 BTS -> fn=106 tn=2\u000a 7.219.330 BTS -> fn=106 tn=3\u000a 7.219.431 BTS -> fn=106 tn=4\u000a 7.219.527 BTS -> fn=106 tn=5\u000a 7.219.621 BTS -> fn=106 tn=6\u000a 7.219.718 BTS -> fn=106 tn=7\u000a 7.222.535 CLOCK fn=105\u000a\u000a ...\u000a\u000a 9.995.869 CLOCK fn=706\u0009\u0009# MS will soon connect.\u000a 9.997.138 BTS -> fn=709 tn=0\u0009# Note: BTS is sending fn=709 before CLOCK fn=707\u000a 9.997.338 BTS -> fn=709 tn=1\u0009# so this messages become queued before CLOCK fn=709 happens\u000a 9.997.444 BTS -> fn=709 tn=2\u000a 9.997.535 BTS -> fn=709 tn=3\u000a 9.997.620 BTS -> fn=709 tn=4\u000a 9.997.708 BTS -> fn=709 tn=5\u000a 9.997.789 BTS -> fn=709 tn=6\u000a 9.997.874 BTS -> fn=709 tn=7\u000a 10.000.583 CLOCK fn=707\u000a 10.001.735 BTS -> fn=710 tn=0\u000a 10.001.932 BTS -> fn=710 tn=1\u000a 10.002.041 BTS -> fn=710 tn=2\u000a 10.002.134 BTS -> fn=710 tn=3\u000a 10.002.220 BTS -> fn=710 tn=4\u000a 10.002.373 BTS -> fn=710 tn=5\u000a 10.002.459 BTS -> fn=710 tn=6\u000a 10.002.718 BTS -> fn=710 tn=7\u000a\u000a [DEBUG] ctrl_if_trx.py:115 (MS) Recv POWEROFF cmd\u0009\u0009# MS starts to connect\u000a [INFO] ctrl_if_trx.py:117 (MS) Stopping transceiver...\u000a [DEBUG] ctrl_if_trx.py:229 (MS) Ignore CMD ECHO\u000a 10.005.203 CLOCK fn=708\u000a [DEBUG] ctrl_if_trx.py:229 (MS) Ignore CMD SETSLOT\u000a 10.006.406 BTS -> fn=711 tn=0\u000a [DEBUG] ctrl_if_trx.py:124 (MS) Recv RXTUNE cmd\u000a 10.006.999 BTS -> fn=711 tn=1\u000a 10.007.153 BTS -> fn=711 tn=2\u000a [DEBUG] ctrl_if_trx.py:131 (MS) Recv TXTUNE cmd\u000a 10.007.590 BTS -> fn=711 tn=3\u000a 10.007.728 BTS -> fn=711 tn=4\u000a [DEBUG] ctrl_if_trx.py:97 (MS) Recv POWERON CMD\u0009\u0009# MS connected and activated RF\u000a [INFO] ctrl_if_trx.py:109 (MS) Starting transceiver...\u000a 10.008.344 BTS -> fn=711 tn=5\u000a 10.008.471 BTS -> fn=711 tn=6\u000a 10.008.563 BTS -> fn=711 tn=7\u000a\u000a 10.009.868 CLOCK fn=709\u0009\u0009# CLOCK fn=709 happens\u000a\u000a 10.009.987 MS <- fn=709 tn=0\u0009# messages of BTS queued previously with that fn=709 are forwarded to Ms\u000a 10.010.696 MS <- fn=709 tn=1\u000a 10.010.904 MS -> fn=709 tn=0\u0009# <-- MS sends UL message with that same fn=709 _before_ CLOCK fn=710\u000a 10.011.397 BTS -> fn=712 tn=0\u000a 10.011.507 MS <- fn=709 tn=2\u000a 10.011.770 MS <- fn=709 tn=3\u000a 10.011.968 MS <- fn=709 tn=4\u000a 10.012.156 MS <- fn=709 tn=5\u000a 10.012.342 MS <- fn=709 tn=6\u000a 10.012.527 MS <- fn=709 tn=7\u000a 10.012.914 BTS <- fn=709 tn=0\u000a 10.013.166 BTS -> fn=712 tn=1\u000a 10.013.524 MS -> fn=709 tn=1\u0009# <-- MS sends UL message with that same fn=709 _before_ CLOCK fn=710\u000a 10.013.832 BTS -> fn=712 tn=2\u000a 10.013.949 MS -> fn=709 tn=2\u0009# <-- MS sends UL message with that same fn=709 _before_ CLOCK fn=710\u000a 10.014.081 BTS -> fn=712 tn=3\u000a 10.014.177 MS -> fn=709 tn=3\u0009# <-- MS sends UL message with that same fn=709 _before_ CLOCK fn=710\u000a 10.014.361 BTS -> fn=712 tn=4\u000a\u000a 10.014.475 CLOCK fn=710\u0009\u0009# but most of those messages of MS with fn=709 are not picked up\u000a 10.014.713 MS -> fn=709 tn=4\u0009# instantly and so become dropped as stale on CLOCK fn=710\u000a 10.014.815 MS <- fn=710 tn=0\u000a 10.015.032 BTS -> fn=712 tn=5\u000a 10.015.687 MS <- fn=710 tn=1\u000a 10.016.189 MS <- fn=710 tn=2\u000a 10.016.464 MS <- fn=710 tn=3\u000a 10.016.648 MS <- fn=710 tn=4\u000a 10.016.882 MS <- fn=710 tn=5\u000a 10.017.110 MS <- fn=710 tn=6\u000a 10.017.336 MS <- fn=710 tn=7\u000a [WARNING] transceiver.py:321 (MS) Stale TRXD message (fn=710): fn=709 tn=1 pwr=0\u000a [WARNING] transceiver.py:321 (MS) Stale TRXD message (fn=710): fn=709 tn=2 pwr=0\u000a [WARNING] transceiver.py:321 (MS) Stale TRXD message (fn=710): fn=709 tn=3 pwr=0\u000a [WARNING] transceiver.py:321 (MS) Stale TRXD message (fn=710): fn=709 tn=4 pwr=0\u000a\u000aSo without adding some fn-advance it is practically not possible for Ms\u000ato be on time with tx-queueing on TRX even if Ms sends its uplink frames\u000aright immediately after receiving downlink ones.\u000a\u000aThis way Ms fn-advance has to be 1 at the minimum, so that immediate UL\u000areplies can in principle arrive before fn+1 happens on fake_trx side,\u000aeven for tn=7. And it is also better to increase fn-advance once more by\u000aanother +1, to compensate for possible jitter due to OS scheduling\u000alatencies and similar things. This way default fn-advance=2 on Ms side\u000abecomes symmetric to default fn-advance on BTS side and Ms<->BTS\u000aexchange starts to work ok even with tx-queueing activated on fake_trx.\u000a\u000aIn theory it should be possible to reduce those fn-advances to 1 on both\u000asides, but that will likely require to switch clock granularity from Fn\u000ato Tn increasing precision by an order of magnitude, which will likely\u000aalso result in the need to make architectural change of moving trx to\u000awork inside BTS and MS instead of being separate service processes.\u000aThat's a big task and I'm not delving into that here.\u000a\u000aNote: Uplink Fn advance > 0 is needed for Ms when working with regular\u000aTRX'es as well. The reason is exactly the same as explained above. In\u000a923e9b0b the reason for setting fn-advance=0 by default was that trxcon\u000ais usually being used with fake_trx, and that with fake_trx it is not\u000aneeded. But after reenabling tx-queueing we have to revisit even\u000afake_trx case again.\u000a\u000a(*) the trace was captured with the help of the following debugging patch:\u000a\u000a --- b/src/target/trx_toolkit/burst_fwd.py\u000a +++ a/src/target/trx_toolkit/burst_fwd.py\u000a @@ -22,6 +22,18 @@\u000a\u000a from trx_list import TRXList\u000a\u000a +import sys, time\u000a +\u000a +# trace logs msg to stderr with also marking it with high-resolution timestamp.\u000a +t0 = time.time()\u000a +def trace(msg):\u000a + t = time.time() - t0\u000a + t_ms = int(t * 1e3) / 1e3\u000a + us = int((t - t_ms) * 1e6)\u000a + print(\"%7.3f.%03d %s\" % (t_ms, us, msg), file=sys.stderr)\u000a +\u000a class BurstForwarder(TRXList):\u000a \u0009\"\"\" Performs burst forwarding between transceivers.\u000a\u000a @@ -63,6 +75,7 @@ def forward_msg(self, src_trx, rx_msg):\u000a \u0009\u0009\u0009if trx.get_rx_freq(rx_msg.fn) != tx_freq:\u000a \u0009\u0009\u0009\u0009continue\u000a\u000a +\u0009\u0009\u0009trace(\"%s\\t<- fn=%d\\ttn=%d\" % (trx, rx_msg.fn, rx_msg.tn))\u000a \u0009\u0009\u0009# Transform from TxMsg to RxMsg and forward\u000a \u0009\u0009\u0009tx_msg = rx_msg.trans(ver = trx.data_if._hdr_ver)\u000a \u0009\u0009\u0009trx.handle_data_msg(src_trx, rx_msg, tx_msg)\u000a\u000a --- b/src/target/trx_toolkit/fake_trx.py\u000a +++ a/src/target/trx_toolkit/fake_trx.py\u000a @@ -29,7 +29,7 @@\u000a import re\u000a\u000a from app_common import ApplicationBase\u000a -from burst_fwd import BurstForwarder\u000a +from burst_fwd import BurstForwarder, trace\u000a from transceiver import Transceiver\u000a from data_msg import Modulation\u000a from clck_gen import CLCKGen\u000a @@ -473,6 +473,7 @@ def run(self):\u000a\u000a \u0009# This method will be called by the clock thread\u000a \u0009def clck_handler(self, fn):\u000a +\u0009\u0009trace(\"CLOCK\\tfn=%d\" % fn)\u000a \u0009\u0009# We assume that this list is immutable at run-time\u000a \u0009\u0009for trx in self.trx_list.trx_list:\u000a \u0009\u0009\u0009trx.clck_tick(self.burst_fwd, fn)\u000a\u000a --- b/src/target/trx_toolkit/transceiver.py\u000a +++ a/src/target/trx_toolkit/transceiver.py\u000a @@ -25,6 +25,7 @@\u000a from data_if import DATAInterface\u000a from udp_link import UDPLink\u000a from trx_list import TRXList\u000a +from burst_fwd import trace\u000a\u000a from gsm_shared import HoppingParams\u000a\u000a @@ -198,6 +199,7 @@ def __init__(self, bind_addr, remote_addr, base_port, **kwargs):\u000a \u0009\u0009self._tx_queue = []\u000a\u000a \u0009def __str__(self):\u000a +\u0009\u0009return self.name\u000a \u0009\u0009desc = \"%s:%d\" % (self.remote_addr, self.base_port)\u000a \u0009\u0009if self.child_idx > 0:\u000a \u0009\u0009\u0009desc += \"/%d\" % self.child_idx\u000a @@ -289,6 +291,7 @@ def recv_data_msg(self):\u000a \u0009\u0009\u0009return None\u000a\u000a \u0009\u0009# Enque the message, it will be sent later\u000a +\u0009\u0009trace(\"%s\\t-> fn=%d\\ttn=%d\" % (self, msg.fn, msg.tn))\u000a \u0009\u0009self.tx_queue_append(msg)\u000a \u0009\u0009return msg\u000a\u000aChange-Id: Icf0b4568b44eb75ee0733391d94b0af86f27ee2e\u000a", "date" : "2025-02-12 16:32:33 +0300", "id" : "c80e193f6d95367e764684a6021ede981f44ebbd", "msg" : "trxcon: Advance Uplink TDMA Fn by default again", "paths" : [ { "editType" : "edit", "file" : "src/host/trxcon/src/trxcon_main.c" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py" ], "commitId" : "fc9044895d23393f0fb81843012b83221e6183b7", "timestamp" : 1739370470000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/transceiver: Do not forward nor log from under tx_queue_lock\u000a\u000aEven though for 1 BTS + 1 MS fake_trx works ok with tx-queuing, when I\u000atry to run two ccch_scan's with 1 BTS fake_trx starts occupy ~ 100% of\u000aCPU and emits lots of \"Stale ...\" messages:\u000a\u000a\u0009[WARNING] transceiver.py:317 (M2@127.0.0.1:7700) Stale TRXD message (fn=2793): fn=2791 tn=7 pwr=0\u000a\u0009[WARNING] transceiver.py:317 (M2@127.0.0.1:7700) Stale TRXD message (fn=2793): fn=2792 tn=0 pwr=0\u000a\u0009[WARNING] transceiver.py:317 (M2@127.0.0.1:7700) Stale TRXD message (fn=2793): fn=2792 tn=1 pwr=0\u000a\u0009[WARNING] transceiver.py:317 (M2@127.0.0.1:7700) Stale TRXD message (fn=2793): fn=2792 tn=2 pwr=0\u000a\u0009[WARNING] transceiver.py:317 (M2@127.0.0.1:7700) Stale TRXD message (fn=2793): fn=2792 tn=3 pwr=0\u000a\u0009...\u000a\u000aInspecting a bit with a profiler showed that fake_trx simply cannot keep\u000aup with the load.\u000a\u000aLet's try to fix this with optimizing things a bit where it is easy to\u000anotice and easy to pick up low-hanging fruits.\u000a\u000aThis is the first patch in that optimization series. It moves blocking\u000acalls from out of under tx_queue_lock on transmit path. The reason for\u000athis move is not to block receive path while the transmit path is busy\u000amore than necessary. I originally noticed tx_queue_lock.acquire being\u000avisible in profile of the rx thread which indicates that tx/rx\u000acontention on this lock can really happen if we do non-negligible tasks\u000afrom under this lock. Here, in particular, it was forward_msg that was\u000apreparing and actually sending RxMsg to destination. tx_queue_lock is\u000aneeded only to protect tx_queue itself and synchronize rx and tx threads\u000aaccess to it. Once necessary items are appended or popped, we can do\u000aeverything else out of this lock.\u000a\u000a-> Move everything on the tx codepath, not actually needing access to\u000atx_queue out of this lock:\u000a\u000a- only collect messages to be sent under the lock; actually forward them\u000a after releasing the log;\u000a- same for logging.\u000a\u000aChange-Id: I7d10c972c45b2b5765e7c3a28f8646508b3c8a82\u000a", "date" : "2025-02-12 17:27:50 +0300", "id" : "fc9044895d23393f0fb81843012b83221e6183b7", "msg" : "trx_toolkit/transceiver: Do not forward nor log from under tx_queue_lock", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py" ], "commitId" : "c186b58998dc2340a5f32a90dd100a9cd2e50e47", "timestamp" : 1739370574000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/transceiver: Do not scan tx_queue twice on tx path\u000a\u000aNoticed while moving forwarding out of tx_queue_lock in the previous patch.\u000a\u000aChange-Id: I225c44c4cc327b6786efce96d1278c6ec68fbc25\u000a", "date" : "2025-02-12 17:29:34 +0300", "id" : "c186b58998dc2340a5f32a90dd100a9cd2e50e47", "msg" : "trx_toolkit/transceiver: Do not scan tx_queue twice on tx path", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py" ], "commitId" : "25b61af78e7149bb79837e9d19c5ee2808ba00a1", "timestamp" : 1739370658000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/transceiver: Use with tx_queue_lock instead of manual acquire/release\u000a\u000a- it is a bit faster\u000a- it is a bit more robust as the lock becomes released in case\u000a some exception is raised before reaching release\u000a\u000aNoticed while moving forwarding out of tx_queue_lock in\u000aI7d10c972c45b2b5765e7c3a28f8646508b3c8a82.\u000a\u000aChange-Id: I74b194120bcc518d44796b57e36368bdc8de4aab\u000a", "date" : "2025-02-12 17:30:58 +0300", "id" : "25b61af78e7149bb79837e9d19c5ee2808ba00a1", "msg" : "trx_toolkit/transceiver: Use with tx_queue_lock instead of manual", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/test_data_msg.py", "src/target/trx_toolkit/gsm_shared.py", "src/target/trx_toolkit/rand_burst_gen.py", "src/target/trx_toolkit/data_msg.py" ], "commitId" : "abfd60b3ee7b6763661f59fce76c1e45fb9c0012", "timestamp" : 1739396222000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/*: Represent bursts as arrays instead of lists\u000a\u000aContinuing fake_trx profiling story I noticed that on rx path a\u000anoticeable time is spent in converting from ubits to sbits via list\u000acomprehensions. By changing burst representation from py list, which\u000astores each item as full python object, to an array, which stores each\u000aitem as just byte, and by leveraging bytearray.translate, we can speed\u000aup that conversion by ~ 10x:\u000a\u000abefore:\u000a\u000a In [1]: from data_msg import Msg\u000a\u000a In [2]: burst = [0, 1] * (142//2)\u000a\u000a In [3]: burst\u000a Out[3]:\u000a [0,\u000a 1,\u000a 0,\u000a 1,\u000a 0,\u000a ...\u000a 0,\u000a 1]\u000a\u000a In [4]: Msg.ubit2sbit(burst)\u000a Out[4]:\u000a [127,\u000a -127,\u000a 127,\u000a -127,\u000a ...\u000a 127,\u000a -127]\u000a\u000a In [5]: %timeit Msg.ubit2sbit(burst)\u000a 3.01 µs ± 43.3 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)\u000a\u000aafter:\u000a\u000a In [2]: burst = bytearray([0, 1] * (142//2))\u000a\u000a In [3]: burst\u000a Out[3]: bytearray(b'\\x00\\x01\\x00\\x01...\\x00\\x01')\u000a\u000a In [4]: Msg.ubit2sbit(burst)\u000a Out[4]: array('b', [127, -127, 127, -127, ... 127, -127])\u000a\u000a In [5]: %timeit Msg.ubit2sbit(burst)\u000a 325 ns ± 12.1 ns per loop (mean ± std. dev. of 7 runs, 1,000,000 loops each)\u000a\u000aChange-Id: I7314e9e79752e06fa86b9e346a9beacc5e59579e\u000a", "date" : "2025-02-13 00:37:02 +0300", "id" : "abfd60b3ee7b6763661f59fce76c1e45fb9c0012", "msg" : "trx_toolkit/*: Represent bursts as arrays instead of lists", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/data_msg.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/test_data_msg.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/gsm_shared.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/rand_burst_gen.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/data_msg.py", "src/target/trx_toolkit/data_if.py" ], "commitId" : "06456f118d6fcd6d60a9e50df1d8f07b5fde2c8b", "timestamp" : 1739397354000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/*: Try to avoid copying burst data where possible\u000a\u000aConveying burst data is the primary flow in data place of what fake_trx\u000adoes, so the less copies we do, the less we make CPU loaded.\u000a\u000aAfter this change I can finally run 1 BTS + 2 Mobile + 1 ccch_scan\u000awithout hitting \"Stale message ...\" on fake_trx side. However fake_trx\u000acpu load is close to 100% and there are internal clock overruns often:\u000a\u000a [WARNING] clck_gen.py:97 CLCKGen: time overrun by -1385us; resetting the clock\u000a [WARNING] clck_gen.py:97 CLCKGen: time overrun by -2657us; resetting the clock\u000a [WARNING] clck_gen.py:97 CLCKGen: time overrun by -1264us; resetting the clock\u000a [WARNING] clck_gen.py:97 CLCKGen: time overrun by -2913us; resetting the clock\u000a [WARNING] clck_gen.py:97 CLCKGen: time overrun by -1836us; resetting the clock\u000a ...\u000a\u000aThis suggests that even though fake_trx.py + tx-queue started to work\u000asomehow, the rewrite of fake_trx in C, as explained in OS#6672, is still\u000abetter to do.\u000a\u000aChange-Id: I147da2f110dedc863361059c931f609c28a69e9c\u000a", "date" : "2025-02-13 00:55:54 +0300", "id" : "06456f118d6fcd6d60a9e50df1d8f07b5fde2c8b", "msg" : "trx_toolkit/*: Try to avoid copying burst data where possible", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/data_msg.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/data_if.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py" ], "commitId" : "47af7967f9345a0fb8d80e09579f8aa468e77db1", "timestamp" : 1740488554000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, "authorEmail" : "kirr@nexedi.com", "comment" : "trx_toolkit/transceiver: Spellcheck\u000a\u000aNoticed by Jenkins:\u000a\u000ahttps: //gerrit.osmocom.org/c/osmocom-bb/+/39328/1/src/target/trx_toolkit/transceiver.py#134\u000a\u000aChange-Id: Id2a59d6db53c7f90cd21a056da8b1ac4d85e0373\u000a", "date" : "2025-02-25 16:02:34 +0300", "id" : "47af7967f9345a0fb8d80e09579f8aa468e77db1", "msg" : "trx_toolkit/transceiver: Spellcheck", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py" ], "commitId" : "4a4ce97377030a6ed27c2ec51a0710b373cba262", "timestamp" : 1741186835000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "trx_toolkit: fix typos in Transceiver API doc\u000a\u000aChange-Id: I59c6c75bb2a76fa082d0ad110930a2982ee6728f\u000a", "date" : "2025-03-05 15:00:35 +0000", "id" : "4a4ce97377030a6ed27c2ec51a0710b373cba262", "msg" : "trx_toolkit: fix typos in Transceiver API doc", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/transceiver.py" ], "commitId" : "445c34e7f3a99be41e9ddffc403aa661fe2c9c42", "timestamp" : 1741186835000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" }, "authorEmail" : "laforge@osmocom.org", "comment" : "trx_toolkit: correct Tx burst advance value\u000a\u000aChange-Id: I559e86a15a3a8b4ec725f9d381e7d28628ea9155\u000a", "date" : "2025-03-05 15:00:35 +0000", "id" : "445c34e7f3a99be41e9ddffc403aa661fe2c9c42", "msg" : "trx_toolkit: correct Tx burst advance value", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/transceiver.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/fake_trx.py", "src/target/trx_toolkit/clck_gen.py" ], "commitId" : "867e849010864ecadf1f2e7adb5c70250b6a99fc", "timestamp" : 1742303812000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "fake_trx: Allow setting sched RR priority for clckgen thread\u000a\u000aWith this patch python is still too slow sometimes, with frecuent\u000aoverruns in the range 50-2400 microsecs. Still, with higher prio we\u000ashould hopefully see less cases where the process is being delayed by a\u000amuch higher amount, which may trigger a \"no clock\" error from\u000aosmo-bts-trx.\u000a\u000aChange-Id: I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc\u000a", "date" : "2025-03-18 14:16:52 +0100", "id" : "867e849010864ecadf1f2e7adb5c70250b6a99fc", "msg" : "fake_trx: Allow setting sched RR priority for clckgen thread", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/clck_gen.py" }, { "editType" : "edit", "file" : "src/target/trx_toolkit/fake_trx.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/fake_trx.py" ], "commitId" : "6f45d36e936c9209a18e02b6a8c3a04eb1ff9fd9", "timestamp" : 1742304040000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "Set sched RR Priority on main thread\u000a\u000aSince we are still affected by Python GIL, it makes sense to also set\u000athe main thread (which is actually also expected to be real time) to a\u000areal time priority.\u000a\u000aUse a slightly higher rr prio (prio + 1) to the clckgen thread.\u000a\u000aChange-Id: I6aa22125e7de4f472d691b271639d5bee25762cb\u000a", "date" : "2025-03-18 14:20:40 +0100", "id" : "6f45d36e936c9209a18e02b6a8c3a04eb1ff9fd9", "msg" : "Set sched RR Priority on main thread", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/fake_trx.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/target/trx_toolkit/clck_gen.py" ], "commitId" : "54a0052ab8de1639c306cb3afd1f0ce19b8e2c9c", "timestamp" : 1742338513000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, "authorEmail" : "pespin@sysmocom.de", "comment" : "fake_trx: Remove unneeded field assignment\u000a\u000aThe assignment is not really needed, since worker can already access the\u000afield anyway.\u000a\u000aFixes: 6f45d36e936c9209a18e02b6a8c3a04eb1ff9fd9\u000aChange-Id: Ib8808f8bf8f3ef084334debac47ca48a48aa0cea\u000a", "date" : "2025-03-18 23:55:13 +0100", "id" : "54a0052ab8de1639c306cb3afd1f0ce19b8e2c9c", "msg" : "fake_trx: Remove unneeded field assignment", "paths" : [ { "editType" : "edit", "file" : "src/target/trx_toolkit/clck_gen.py" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "doc/examples/mobile/mobile.cfg", "doc/examples/mobile/default.cfg" ], "commitId" : "04339f502cca934ff09730ee4a8387b091379f03", "timestamp" : 1757335514000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "doc/examples/mobile: rename default.cfg -> mobile.cfg\u000a\u000aLet's be consistent with the modem app and other Osmocom projects.\u000a\u000aChange-Id: I826f31523a941a616a95a3fc1b935fc63d886cc0\u000aRelated: OS#6851\u000a", "date" : "2025-09-08 19:45:14 +0700", "id" : "04339f502cca934ff09730ee4a8387b091379f03", "msg" : "doc/examples/mobile: rename default.cfg -> mobile.cfg", "paths" : [ { "editType" : "delete", "file" : "doc/examples/mobile/default.cfg" }, { "editType" : "add", "file" : "doc/examples/mobile/mobile.cfg" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/osmocom-bb.install" ], "commitId" : "15f23c2e22b5d5a9ba17ce581d66479d96381995", "timestamp" : 1757335589000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "debian: remove osmocom-bb.install\u000a\u000aThere's no such package in `debian/control`, so this file is useless.\u000a\u000aChange-Id: Id7dcc24dfe9697035d67339b9bbe05f468bd25ab\u000aRelated: OS#6851\u000a", "date" : "2025-09-08 19:46:29 +0700", "id" : "15f23c2e22b5d5a9ba17ce581d66479d96381995", "msg" : "debian: remove osmocom-bb.install", "paths" : [ { "editType" : "delete", "file" : "debian/osmocom-bb.install" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/osmocom-bb-layer23.install", "debian/rules", "debian/osmocom-bb-virtphy.install", "debian/osmocom-bb-trxcon.install" ], "commitId" : "2a93a822f88b10e33248762c76e8b4e29ac63832", "timestamp" : 1757337317000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "debian: fix empty osmocom-bb-{trxcon,virtphy} packages\u000a\u000aFor each of layer23, trxcon, and virt_phy:\u000a\u000a* Configure/build using the top-level Makefile.\u000a* Install into its own DESTDIR (`debian/tmp/$PROJ`).\u000a* Add the respective `*.install` file.\u000a\u000aChange-Id: Ieee634f7f643a7599c735a5b77549cf34deb7fb9\u000aRelated: OS#6851\u000a", "date" : "2025-09-08 20:15:17 +0700", "id" : "2a93a822f88b10e33248762c76e8b4e29ac63832", "msg" : "debian: fix empty osmocom-bb-{trxcon,virtphy} packages", "paths" : [ { "editType" : "edit", "file" : "debian/rules" }, { "editType" : "add", "file" : "debian/osmocom-bb-trxcon.install" }, { "editType" : "add", "file" : "debian/osmocom-bb-layer23.install" }, { "editType" : "add", "file" : "debian/osmocom-bb-virtphy.install" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/osmocom-bb-layer23.install" ], "commitId" : "0e225f8628fc2b91fbc3005e5ba8bb103b3e178b", "timestamp" : 1757337404000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "debian: install /etc/osmocom/{mobile,modem}.cfg\u000a\u000aChange-Id: Ic405512330358e7d4cf81db6d4e83f5ffc920f64\u000aRelated: OS#6851\u000a", "date" : "2025-09-08 20:16:44 +0700", "id" : "0e225f8628fc2b91fbc3005e5ba8bb103b3e178b", "msg" : "debian: install /etc/osmocom/{mobile,modem}.cfg", "paths" : [ { "editType" : "edit", "file" : "debian/osmocom-bb-layer23.install" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/osmocom-bb-layer23.install" ], "commitId" : "bc21a9e918113770ed41f1a7c62f361ab572c26c", "timestamp" : 1757338016000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "debian: install *.cfg and *.lua examples\u000a\u000aChange-Id: I10ed0d68cd91126cefd431a1375b72dd6ae3f2d0\u000aRelated: OS#6851\u000a", "date" : "2025-09-08 20:26:56 +0700", "id" : "bc21a9e918113770ed41f1a7c62f361ab572c26c", "msg" : "debian: install *.cfg and *.lua examples", "paths" : [ { "editType" : "edit", "file" : "debian/osmocom-bb-layer23.install" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/osmocom-bb-osmocon.install", "debian/rules", "debian/osmocom-bb-gprsdecode.install", "debian/control" ], "commitId" : "19cd72bcb09e161a0f1a4e40d748b542415c8c60", "timestamp" : 1757339062000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "debian: add osmocom-bb-{gprsdecode,osmocon} packages\u000a\u000aChange-Id: Ia96c418a610863b5d9d0fc10c6d78b80163dc651\u000aRelated: OS#6851\u000a", "date" : "2025-09-08 20:44:22 +0700", "id" : "19cd72bcb09e161a0f1a4e40d748b542415c8c60", "msg" : "debian: add osmocom-bb-{gprsdecode,osmocon} packages", "paths" : [ { "editType" : "edit", "file" : "debian/control" }, { "editType" : "add", "file" : "debian/osmocom-bb-osmocon.install" }, { "editType" : "add", "file" : "debian/osmocom-bb-gprsdecode.install" }, { "editType" : "edit", "file" : "debian/rules" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "debian/osmocom-bb-doc.install", "debian/control", "debian/rules" ], "commitId" : "37e216a8eba7fa8ed2f36bd5bb8ea8dbe14bb0ba", "timestamp" : 1757371393000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, "authorEmail" : "vyanitskiy@sysmocom.de", "comment" : "debian: add osmocom-bb-doc (user manual)\u000a\u000aChange-Id: Ib04160287c98814a6f2ae104197abda563bdd5b9\u000aRelated: OS#6851\u000a", "date" : "2025-09-09 05:43:13 +0700", "id" : "37e216a8eba7fa8ed2f36bd5bb8ea8dbe14bb0ba", "msg" : "debian: add osmocom-bb-doc (user manual)", "paths" : [ { "editType" : "edit", "file" : "debian/control" }, { "editType" : "add", "file" : "debian/osmocom-bb-doc.install" }, { "editType" : "edit", "file" : "debian/rules" } ] }, { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "src/shared/libosmocore/configure.ac" ], "commitId" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "timestamp" : 1759241786000, "author" : { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, "authorEmail" : "osmith@sysmocom.de", "comment" : "WIP\u000a\u000aChange-Id: I8f4c41f2d1fe4af79ce7435494398394d719891d\u000a", "date" : "2025-09-30 16:16:26 +0200", "id" : "1d74c506c6144767290ca17dc7c24ba9e533ec1d", "msg" : "WIP", "paths" : [ { "editType" : "edit", "file" : "src/shared/libosmocore/configure.ac" } ] } ], "kind" : "git" }, "culprits" : [ { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/aeversberg", "fullName" : "Andreas Eversberg" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/msuraev", "fullName" : "msuraev" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/jolly", "fullName" : "jolly" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/kirr", "fullName" : "Kirill Smelkov" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/fixeria", "fullName" : "Vadim Yanitskiy" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/osmith", "fullName" : "Oliver Smith" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/pespin", "fullName" : "Pau Espin Pedrol" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/max", "fullName" : "Max" }, { "absoluteUrl" : "https://jenkins.osmocom.org/jenkins/user/laforge", "fullName" : "laforge" } ], "runs" : [ { "number" : 7774, "url" : "https://jenkins.osmocom.org/jenkins/view/SDR/job/master-osmocom-bb/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/7774/" } ] }