Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org000078254782541.05910591008416459095909795229c207405fc07709fc96dd3a448e88c712737a8929c207405fc07709fc96dd3a448e88c712737a89origin/master29c207405fc07709fc96dd3a448e88c712737a8929c207405fc07709fc96dd3a448e88c712737a89origin/master4893af54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/masteraf54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/master29c207405fc07709fc96dd3a448e88c712737a8929c207405fc07709fc96dd3a448e88c712737a89origin/masterhttps://gerrit.osmocom.org/osmo-pcaphttps://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7952/artifacthttps://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/changeshttps://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7952/https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7952/testReportfalse#79527825494948master-osmo-pcap #79527952falsefalse7952150496SUCCESS1782202806285https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7952/src/osmo_server_network.cf3c6fdb7a5cf16371ac50d66fd2e84ab1cb7c3631782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgserver: do not abort process on short conn message conn_read_cb() used OSMO_ASSERT() to check that the received message holds at least a full osmo_pcap_data header. Although conn_segmentation_cb2() should only ever hand up complete frames, asserting on a length derived from network input means a framing anomaly would abort the entire server (taking down all other clients' captures). Close the offending connection gracefully instead, consistent with the other error paths in this function. Change-Id: Ia102ff918ef8152d212e10a860f5dc70efec880b AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +0000f3c6fdb7a5cf16371ac50d66fd2e84ab1cb7c363server: do not abort process on short conn messageeditsrc/osmo_server_network.csrc/osmo_client_network.ccf35aeb857c61350989741dbb19cd047f5f929ed1782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgclient: Fix 32-bit overflow when computing pcapng EPB timestamp tv_sec * 1000 * 1000 was evaluated in int arithmetic. Where time_t / tv_sec is 32-bit, this overflows for any tv_sec > ~2147, corrupting the 64-bit timestamp_usec well before the year 2038. Cast tv_sec to uint64_t before the multiplication so the whole expression is computed in 64 bits. Change-Id: I20d3282b8cba1675ce2d0860e66027e5ee8245ef AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +0000cf35aeb857c61350989741dbb19cd047f5f929edclient: Fix 32-bit overflow when computing pcapng EPB timestampeditsrc/osmo_client_network.csrc/osmo_server_core.c3e9ac602a1f9a31a779cd50240acb0289d139cb01782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgserver: fix zmq message leak on send failure zmq_msg_send() only transfers ownership of the message to ZeroMQ on success. On failure the caller retains ownership, so the previously init'd zmq_msg_t was leaked on every failed publish. Close it explicitly on the error path. Change-Id: I501b1bf55bede4e69fa5d9b3f38d87341482ff49 AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +00003e9ac602a1f9a31a779cd50240acb0289d139cb0server: fix zmq message leak on send failureeditsrc/osmo_server_core.csrc/osmo_server_network.c29c207405fc07709fc96dd3a448e88c712737a891782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgserver: fix msgb leak on duplicate link header rx_link_hdr() takes ownership of msg on success (rx_link() only frees it on failure). Both branches that call update_conn_file_hdr_msg() free msg, but when an identical link header was already stored neither branch ran and msg was leaked. This happens on every duplicate PKT_LINK_HDR, e.g. a client that periodically resends its header. Free msg explicitly in that case. Change-Id: I79344fe942342f2a736878142b3cf036fc982eef AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +000029c207405fc07709fc96dd3a448e88c712737a89server: fix msgb leak on duplicate link headereditsrc/osmo_server_network.cgithttps://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforgeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-pcap" build number 7,9527952master-osmo-pcapjob/master-osmo-pcap/002274986749861.0000795229c207405fc07709fc96dd3a448e88c712737a8929c207405fc07709fc96dd3a448e88c712737a89origin/master29c207405fc07709fc96dd3a448e88c712737a8929c207405fc07709fc96dd3a448e88c712737a89origin/master4893af54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/masteraf54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/master29c207405fc07709fc96dd3a448e88c712737a8929c207405fc07709fc96dd3a448e88c712737a89origin/masterhttps://gerrit.osmocom.org/osmo-pcapfalse#79527498680556master-osmo-pcap » a1=default,a2=default,a3=default,a4=default,osmocom-master #79527952falsefalse7952150498SUCCESS1782202806285https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/7952/build4-deb12build-ansiblesrc/osmo_server_network.cf3c6fdb7a5cf16371ac50d66fd2e84ab1cb7c3631782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgserver: do not abort process on short conn message conn_read_cb() used OSMO_ASSERT() to check that the received message holds at least a full osmo_pcap_data header. Although conn_segmentation_cb2() should only ever hand up complete frames, asserting on a length derived from network input means a framing anomaly would abort the entire server (taking down all other clients' captures). Close the offending connection gracefully instead, consistent with the other error paths in this function. Change-Id: Ia102ff918ef8152d212e10a860f5dc70efec880b AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +0000f3c6fdb7a5cf16371ac50d66fd2e84ab1cb7c363server: do not abort process on short conn messageeditsrc/osmo_server_network.csrc/osmo_client_network.ccf35aeb857c61350989741dbb19cd047f5f929ed1782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgclient: Fix 32-bit overflow when computing pcapng EPB timestamp tv_sec * 1000 * 1000 was evaluated in int arithmetic. Where time_t / tv_sec is 32-bit, this overflows for any tv_sec > ~2147, corrupting the 64-bit timestamp_usec well before the year 2038. Cast tv_sec to uint64_t before the multiplication so the whole expression is computed in 64 bits. Change-Id: I20d3282b8cba1675ce2d0860e66027e5ee8245ef AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +0000cf35aeb857c61350989741dbb19cd047f5f929edclient: Fix 32-bit overflow when computing pcapng EPB timestampeditsrc/osmo_client_network.csrc/osmo_server_core.c3e9ac602a1f9a31a779cd50240acb0289d139cb01782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgserver: fix zmq message leak on send failure zmq_msg_send() only transfers ownership of the message to ZeroMQ on success. On failure the caller retains ownership, so the previously init'd zmq_msg_t was leaked on every failed publish. Close it explicitly on the error path. Change-Id: I501b1bf55bede4e69fa5d9b3f38d87341482ff49 AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +00003e9ac602a1f9a31a779cd50240acb0289d139cb0server: fix zmq message leak on send failureeditsrc/osmo_server_core.csrc/osmo_server_network.c29c207405fc07709fc96dd3a448e88c712737a891782202665000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgserver: fix msgb leak on duplicate link header rx_link_hdr() takes ownership of msg on success (rx_link() only frees it on failure). Both branches that call update_conn_file_hdr_msg() free msg, but when an identical link header was already stored neither branch ran and msg was leaked. This happens on every duplicate PKT_LINK_HDR, e.g. a client that periodically resends its header. Free msg explicitly in that case. Change-Id: I79344fe942342f2a736878142b3cf036fc982eef AI-Assisted: yes (Claude) 2026-06-23 08:17:45 +000029c207405fc07709fc96dd3a448e88c712737a89server: fix msgb leak on duplicate link headereditsrc/osmo_server_network.cgithttps://jenkins.osmocom.org/jenkins/user/laforgelaforge