Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org000084412844121.079747974092386797379737953bb3afc9454b00016635ea5e6dd9d9fd7f58d01cabb3afc9454b00016635ea5e6dd9d9fd7f58d01caorigin/masterbb3afc9454b00016635ea5e6dd9d9fd7f58d01cabb3afc9454b00016635ea5e6dd9d9fd7f58d01caorigin/master4893af54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/masteraf54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/masterbb3afc9454b00016635ea5e6dd9d9fd7f58d01cabb3afc9454b00016635ea5e6dd9d9fd7f58d01caorigin/masterhttps://gerrit.osmocom.org/osmo-pcaphttps://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7953/artifacthttps://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/changeshttps://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7953/https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7953/testReportfalse#79538441294948master-osmo-pcap #79537953falsefalse7953150518SUCCESS1782204008322https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/7953/src/osmo_client_core.c4ac87349a66b9e0dde9b2dbbbcbcd8587c99702d1782202672000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.declient: honor IPv4 header length in GPRS filter The GPRS-NS/BSSGP filter assumed a fixed 20-byte IPv4 header (IP_LEN) when locating the UDP header and payload. When the captured packet carries IPv4 options (ip_hl > 5), udp_data/payload_data pointed into the middle of the headers and check_gprs() parsed garbage, classifying packets incorrectly. Use the actual header length from ip_hl, reject malformed headers (ip_hl < 5), and re-validate that the larger headers fit within the captured length before computing the payload. Change-Id: Iac1fa9cc2a3c06cbe19c3e7799a0b335f2e3dda9 AI-Assisted: yes (Claude) 2026-06-23 08:17:52 +00004ac87349a66b9e0dde9b2dbbbcbcd8587c99702dclient: honor IPv4 header length in GPRS filtereditsrc/osmo_client_core.csrc/osmo_tls.c0f243b7e18ae8f0532dd394e80f2bd452a80cfe01782202676000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.detls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on read osmo_tls_client_bfd_cb() treated any non-positive return from gnutls_record_recv() as a fatal error and tore down the session. On a non-blocking socket gnutls_record_recv() can return GNUTLS_E_AGAIN or GNUTLS_E_INTERRUPTED (both negative but non-fatal), which would drop an otherwise healthy TLS session. Handle them as retryable, mirroring the existing logic in tls_write(). Change-Id: If2f842b202dd08c07dffe3770c51cf0ce886beee AI-Assisted: yes (Claude) 2026-06-23 08:17:56 +00000f243b7e18ae8f0532dd394e80f2bd452a80cfe0tls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on readeditsrc/osmo_tls.csrc/osmo_server_vty.ccc146605e0a53030e7a4d5c4e6835876cf67984f1782202679000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: vty: validate rotate-localtime modulus against the new interval apply_rotate_localtime() computed the maximum allowed modulus from pcap_server->rotate_localtime.intv, the currently-stored (old) interval, rather than the intv argument being applied. On first configuration the stored interval is the default 0, so the switch hit the default case and rejected an otherwise valid command; when changing intervals the modulus was bounds-checked against the wrong interval. Switch on intv instead. Change-Id: I0b367d4e255db3208b41e12adec682026b99cc18 AI-Assisted: yes (Claude) 2026-06-23 08:17:59 +0000cc146605e0a53030e7a4d5c4e6835876cf67984fserver: vty: validate rotate-localtime modulus against the new intervaleditsrc/osmo_server_vty.csrc/osmo_server_network.cbb3afc9454b00016635ea5e6dd9d9fd7f58d01ca1782202684000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix NULL deref of file_hdr_msg when store is disabled When a connection has storing disabled (no store), conn->file_hdr_msg is never populated. The previous link-header handling skipped the first branch (gated on conn->store) and fell through to the comparison branch, which dereferenced the still-NULL conn->file_hdr_msg, crashing the server on the first PKT_LINK_HDR from such a client. Gate the whole header tracking on conn->store and simply free the message when not storing, since osmo_pcap_conn_restart_trace() already no-ops in that case. Change-Id: I419e1b66d07307c3e49294984887c153cd8494c3 AI-Assisted: yes (Claude) 2026-06-23 08:18:04 +0000bb3afc9454b00016635ea5e6dd9d9fd7f58d01caserver: fix NULL deref of file_hdr_msg when store is disablededitsrc/osmo_server_network.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyfixeriaBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-pcap" build number 7,9537953master-osmo-pcapjob/master-osmo-pcap/002283663836631.00007953bb3afc9454b00016635ea5e6dd9d9fd7f58d01cabb3afc9454b00016635ea5e6dd9d9fd7f58d01caorigin/masterbb3afc9454b00016635ea5e6dd9d9fd7f58d01cabb3afc9454b00016635ea5e6dd9d9fd7f58d01caorigin/master4893af54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/masteraf54579bd49100c2d837044d7336d9df8377808faf54579bd49100c2d837044d7336d9df8377808frefs/remotes/origin/masterbb3afc9454b00016635ea5e6dd9d9fd7f58d01cabb3afc9454b00016635ea5e6dd9d9fd7f58d01caorigin/masterhttps://gerrit.osmocom.org/osmo-pcapfalse#79538366380556master-osmo-pcap » a1=default,a2=default,a3=default,a4=default,osmocom-master #79537953falsefalse7953150519SUCCESS1782204008322https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-osmo-pcap/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/7953/build4-deb12build-ansiblesrc/osmo_client_core.c4ac87349a66b9e0dde9b2dbbbcbcd8587c99702d1782202672000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.declient: honor IPv4 header length in GPRS filter The GPRS-NS/BSSGP filter assumed a fixed 20-byte IPv4 header (IP_LEN) when locating the UDP header and payload. When the captured packet carries IPv4 options (ip_hl > 5), udp_data/payload_data pointed into the middle of the headers and check_gprs() parsed garbage, classifying packets incorrectly. Use the actual header length from ip_hl, reject malformed headers (ip_hl < 5), and re-validate that the larger headers fit within the captured length before computing the payload. Change-Id: Iac1fa9cc2a3c06cbe19c3e7799a0b335f2e3dda9 AI-Assisted: yes (Claude) 2026-06-23 08:17:52 +00004ac87349a66b9e0dde9b2dbbbcbcd8587c99702dclient: honor IPv4 header length in GPRS filtereditsrc/osmo_client_core.csrc/osmo_tls.c0f243b7e18ae8f0532dd394e80f2bd452a80cfe01782202676000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.detls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on read osmo_tls_client_bfd_cb() treated any non-positive return from gnutls_record_recv() as a fatal error and tore down the session. On a non-blocking socket gnutls_record_recv() can return GNUTLS_E_AGAIN or GNUTLS_E_INTERRUPTED (both negative but non-fatal), which would drop an otherwise healthy TLS session. Handle them as retryable, mirroring the existing logic in tls_write(). Change-Id: If2f842b202dd08c07dffe3770c51cf0ce886beee AI-Assisted: yes (Claude) 2026-06-23 08:17:56 +00000f243b7e18ae8f0532dd394e80f2bd452a80cfe0tls: do not treat GNUTLS_E_AGAIN/INTERRUPTED as fatal on readeditsrc/osmo_tls.csrc/osmo_server_vty.ccc146605e0a53030e7a4d5c4e6835876cf67984f1782202679000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: vty: validate rotate-localtime modulus against the new interval apply_rotate_localtime() computed the maximum allowed modulus from pcap_server->rotate_localtime.intv, the currently-stored (old) interval, rather than the intv argument being applied. On first configuration the stored interval is the default 0, so the switch hit the default case and rejected an otherwise valid command; when changing intervals the modulus was bounds-checked against the wrong interval. Switch on intv instead. Change-Id: I0b367d4e255db3208b41e12adec682026b99cc18 AI-Assisted: yes (Claude) 2026-06-23 08:17:59 +0000cc146605e0a53030e7a4d5c4e6835876cf67984fserver: vty: validate rotate-localtime modulus against the new intervaleditsrc/osmo_server_vty.csrc/osmo_server_network.cbb3afc9454b00016635ea5e6dd9d9fd7f58d01ca1782202684000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deserver: fix NULL deref of file_hdr_msg when store is disabled When a connection has storing disabled (no store), conn->file_hdr_msg is never populated. The previous link-header handling skipped the first branch (gated on conn->store) and fell through to the comparison branch, which dereferenced the still-NULL conn->file_hdr_msg, crashing the server on the first PKT_LINK_HDR from such a client. Gate the whole header tracking on conn->store and simply free the message when not storing, since osmo_pcap_conn_restart_trace() already no-ops in that case. Change-Id: I419e1b66d07307c3e49294984887c153cd8494c3 AI-Assisted: yes (Claude) 2026-06-23 08:18:04 +0000bb3afc9454b00016635ea5e6dd9d9fd7f58d01caserver: fix NULL deref of file_hdr_msg when store is disablededitsrc/osmo_server_network.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy