Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org00009477679477671.00541154112045e5f56dd35f1b2347a59f88b401b59997798fff67e5f56dd35f1b2347a59f88b401b59997798fff67refs/remotes/origin/pmaier/fixgre5f56dd35f1b2347a59f88b401b59997798fff67e5f56dd35f1b2347a59f88b401b59997798fff67refs/remotes/origin/pmaier/fixgr2131ba01cb7afffa0141e4e9476d566366801773c416ba01cb7afffa0141e4e9476d566366801773c416refs/remotes/origin/pmaier/rcpba01cb7afffa0141e4e9476d566366801773c416ba01cb7afffa0141e4e9476d566366801773c416refs/remotes/origin/pmaier/rcp2141ef58c94dfeaa489085846ba40ae6ac90903df12eef58c94dfeaa489085846ba40ae6ac90903df12eorigin/masteref58c94dfeaa489085846ba40ae6ac90903df12eef58c94dfeaa489085846ba40ae6ac90903df12eorigin/master13208f289234f74045496c3752bf1bb9397302f3e9128f289234f74045496c3752bf1bb9397302f3e912refs/remotes/origin/pmaier/ara-m8f289234f74045496c3752bf1bb9397302f3e9128f289234f74045496c3752bf1bb9397302f3e912refs/remotes/origin/pmaier/ara-m13533d815859830197b9c55e0a49a1bd2532f71285e13d815859830197b9c55e0a49a1bd2532f71285e1refs/remotes/origin/pmaier/keepfiles3d815859830197b9c55e0a49a1bd2532f71285e13d815859830197b9c55e0a49a1bd2532f71285e1refs/remotes/origin/pmaier/keepfiles1421568e8ae9b817ec2473907bfdd30870410890ffb0568e8ae9b817ec2473907bfdd30870410890ffb0refs/remotes/origin/pmaier/fixapdu568e8ae9b817ec2473907bfdd30870410890ffb0568e8ae9b817ec2473907bfdd30870410890ffb0refs/remotes/origin/pmaier/fixapdu14676a555ac5ccad9ee2cae5e0ba247990f824f8e9b66a555ac5ccad9ee2cae5e0ba247990f824f8e9b6refs/remotes/origin/pmaier/aramtest6a555ac5ccad9ee2cae5e0ba247990f824f8e9b66a555ac5ccad9ee2cae5e0ba247990f824f8e9b6refs/remotes/origin/pmaier/aramtest1816e4ea1c997348370ba1d7415bfd926ac873b58c87e4ea1c997348370ba1d7415bfd926ac873b58c87refs/remotes/origin/osmith/wipe4ea1c997348370ba1d7415bfd926ac873b58c87e4ea1c997348370ba1d7415bfd926ac873b58c87refs/remotes/origin/osmith/wip2022f57f047c627392c40fbe349b1a73ccebe05dc005f57f047c627392c40fbe349b1a73ccebe05dc005refs/remotes/origin/pmaier/otatestf57f047c627392c40fbe349b1a73ccebe05dc005f57f047c627392c40fbe349b1a73ccebe05dc005refs/remotes/origin/pmaier/otatest4024f888a0414101dee4f20aa12579491fcc71707b34f888a0414101dee4f20aa12579491fcc71707b3refs/remotes/origin/master4f888a0414101dee4f20aa12579491fcc71707b34f888a0414101dee4f20aa12579491fcc71707b3refs/remotes/origin/masteref58c94dfeaa489085846ba40ae6ac90903df12eef58c94dfeaa489085846ba40ae6ac90903df12eorigin/masterhttps://gerrit.osmocom.org/pysimfalse#2141947767948120master-pysim #21412141falsefalse2141116573SUCCESS1778678406602https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-pysim/2141/pySim/card_key_provider.pypySim-shell.py3cd5c41fb4879d630123240033ff2b852d8a57961778255673000https://jenkins.osmocom.org/jenkins/user/pmaierpmaier@sysmocom.depmaier@sysmocom.decard_key_provider: move boiler-plate code into helper functions in pySim-shell.py we add the commandline options for the card key provider and do the setup accordingly. Let's put this boilerplate code into helper functions instead, so that we can re-use it in other pySim programs as well. Let's use pySim.transport as a pattern. Related: SYS#6959 Change-Id: I6d095cbb644e608f4a751a1d0749b1484cdc781d 2026-05-08 17:54:33 +02003cd5c41fb4879d630123240033ff2b852d8a5796card_key_provider: move boiler-plate code into helper functionseditpySim/card_key_provider.pyeditpySim-shell.pytests/unittests/test_card_key_provider.pypySim/card_key_provider.py58a324126e8227d3d63dd581dcbbd8b878d08f141778255673000https://jenkins.osmocom.org/jenkins/user/pmaierpmaier@sysmocom.depmaier@sysmocom.decard_key_provider: pass CardKeyFieldCryptor to constructor We currently create the CardKeyFieldCryptor object inside the constructor of the concrete CardKeyProvider classes. There is currently no problem with that, but when we create the CardKeyFieldCryptor object first and then pass it as parameter to the constructor, we gain more flexibility in case we want to support other CardKeyFieldCryptor variants in the future. Related: SYS#6959 Change-Id: If43552740aadacab9126f8a002749a9582eef8f4 2026-05-08 17:54:33 +020058a324126e8227d3d63dd581dcbbd8b878d08f14card_key_provider: pass CardKeyFieldCryptor to constructoredittests/unittests/test_card_key_provider.pyeditpySim/card_key_provider.pypySim/card_key_provider.py7d11f917785a88689e67255d786f1191e04b3ff41778255673000https://jenkins.osmocom.org/jenkins/user/pmaierpmaier@sysmocom.depmaier@sysmocom.decard_key_provider: add a static method to parse --column-keys args The contents of the --column-keys arguments are currently parsed in init_card_key_provider. Let's add a static method in CardKeyFieldCryptor to simplify re-usage of the CardKeyFieldCryptor Related: SYS#6959 Change-Id: Ic955f271b1de1b1b855b21c82ed10343044e45fa 2026-05-08 17:54:33 +02007d11f917785a88689e67255d786f1191e04b3ff4card_key_provider: add a static method to parse --column-keys argseditpySim/card_key_provider.pypySim/log.py66d3b54f923788aece1063918ed15e12e97b31401778255673000https://jenkins.osmocom.org/jenkins/user/pmaierpmaier@sysmocom.depmaier@sysmocom.depySimLogger: fix default log format string In format string we prepend when we log in verbose mode. We use %(module)s as format string quaifier. This qualifier is replaced with the name of the module from where the logger was called. This is mostly equal to the logger name (__name__) we pass when we create the logger. However, this is not the behavior we actually want. We want to log the logger name that we passed when the logger was created. For this, we must use %(name)s as qualifier. Related: SYS#6959 Change-Id: I3951a70ad6ce864a7158b093cba46ae9fc1cb5bd 2026-05-08 17:54:33 +020066d3b54f923788aece1063918ed15e12e97b3140pySimLogger: fix default log format stringeditpySim/log.pypySim/app.py810c51c38fe0f552eecb032857e81964d84b72cb1778255673000https://jenkins.osmocom.org/jenkins/user/pmaierpmaier@sysmocom.depmaier@sysmocom.depySim/app: use pySimLogger instead of print let's replace the stray print statements with proper logger calls. Related: SYS#6959 Change-Id: I95b4536cc8853e7ba6a5dd573b903dfb85e56b9a 2026-05-08 17:54:33 +0200810c51c38fe0f552eecb032857e81964d84b72cbpySim/app: use pySimLogger instead of printeditpySim/app.pypySim/filesystem.pyef58c94dfeaa489085846ba40ae6ac90903df12e1778255673000https://jenkins.osmocom.org/jenkins/user/pmaierpmaier@sysmocom.depmaier@sysmocom.depySim/filesystem: use pySimLogger instead of print let's replace the stray print statements with proper logger calls. Related: SYS#6959 Change-Id: I3a7188ad33706df66b2113e15cc7d06004c9bc39 2026-05-08 17:54:33 +0200ef58c94dfeaa489085846ba40ae6ac90903df12epySim/filesystem: use pySimLogger instead of printeditpySim/filesystem.pygithttps://jenkins.osmocom.org/jenkins/user/pmaierpmaier@sysmocom.de2141https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-pysim/JOB_TYPE=card-test,a1=default,a3=default,a4=default,label=simtester/2141/2141https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-pysim/JOB_TYPE=distcheck,a1=default,a3=default,a4=default,label=osmocom-master/2141/2141https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-pysim/JOB_TYPE=docs,a1=default,a3=default,a4=default,label=osmocom-master/2141/2141https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-pysim/JOB_TYPE=pylint,a1=default,a3=default,a4=default,label=osmocom-master/2141/2141https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-pysim/JOB_TYPE=test,a1=default,a3=default,a4=default,label=osmocom-master/2141/2112https://jenkins.osmocom.org/jenkins/view/Sysmocom/job/master-pysim/JOB_TYPE=test,a1=default,a3=default,a4=default,label=simtester/2112/