Started by timerBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org00114717594717591.0000635d0e6a1b119120eb657490785cb9b72d22682e361d0e6a1b119120eb657490785cb9b72d22682e361origin/masterd0e6a1b119120eb657490785cb9b72d22682e361d0e6a1b119120eb657490785cb9b72d22682e361origin/master5b52b9704ed57386959a73c98e946c756e0188e6cb52b9704ed57386959a73c98e946c756e0188e6crefs/remotes/origin/osmith/wipb52b9704ed57386959a73c98e946c756e0188e6cb52b9704ed57386959a73c98e946c756e0188e6crefs/remotes/origin/osmith/wip253c7c48718ba3637e29fc6a7af4e2e39ba0679bb8dc7c48718ba3637e29fc6a7af4e2e39ba0679bb8drefs/remotes/origin/masterc7c48718ba3637e29fc6a7af4e2e39ba0679bb8dc7c48718ba3637e29fc6a7af4e2e39ba0679bb8drefs/remotes/origin/masterd0e6a1b119120eb657490785cb9b72d22682e361d0e6a1b119120eb657490785cb9b72d22682e361origin/masterhttps://gerrit.osmocom.org/pysimfalse#635471759472452simtester-sanitize #635635falsefalse635150162SUCCESS1782175380407https://jenkins.osmocom.org/jenkins/view/all/job/simtester-sanitize/635/simtester- pySim/esim/saip/personalization.pya7c762eb2e2d7b617f99f2637a1e07d6fcb21c991781987378000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deConfigurableParameter: do not magically overwrite the 'name' attribute
The ClassVarMeta metaclass used to derive each ConfigurableParameter's
'name' attribute automatically from the Python class name (via
camel_to_snake()). Stop doing this, for three reasons:
1) Python class names follow constraints that do not fit the naming
commonly used in CSV files. For example, a name like
"5GS-SUCI-CalcInfo" starts with a digit and contains dashes,
neither of which is permissible in a class name.
2) Python class names live in their own namespace, distinct from the
one used to present eSIM parameters to end users. Deriving the UI
name from the class name couples these two namespaces together.
Taken together, (1) and (2) mean that automatic naming both imposes
class-name constraints on the user-visible names and merges the
internal Python namespace with the publicly shown one - a layer
violation from the perspective of UI design.
3) Overriding 'name' from __new__() makes manual naming impossible: a
subclass that sets 'name = "bar"' as a class attribute would still
end up with the value computed by the metaclass, which is
surprising and hard to track down:
class MySuper(metaclass=...): # __new__ sets name = 'foo'
...
class MySub(MySuper):
name = 'bar'
print(MySub().name) # 'foo', not 'bar' as one would expect
Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169
Jenkins: skip-card-test
2026-06-21 03:29:38 +0700a7c762eb2e2d7b617f99f2637a1e07d6fcb21c99ConfigurableParameter: do not magically overwrite the 'name' attributeeditpySim/esim/saip/personalization.py
- tests/unittests/test_configurable_parameters.pytests/unittests/xo/test_configurable_parameterstests/unittests/smdpp_datapySim/esim/saip/personalization.py3974e9693301d23104bae4a995cb22639ac5e0c21781987402000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deadd test_configurable_parameters.py
Add ConfigurableParameterTest, which applies each parameter to a real
UPP DER template and reads it back, comparing results against a stored
expected-output snapshot (xo/test_configurable_parameters).
Add TestValidateVal covering validate_val() for Iccid, Imsi, Pin1, Puk1
and K, testing both valid inputs and invalid ones expected to raise
ValueError.
Add TestEnumParam covering the EnumParam methods (validate_val,
map_name_to_val, map_val_to_name, name_normalize, clean_name_str) using
AlgorithmID as the concrete subclass, including fuzzy name matching.
Also add get_value_from_pes() to ConfigurableParameter as a convenience
wrapper around get_values_from_pes() that asserts all returned values
are identical and returns the single result.
Change-Id: Ia55f0d11f8197ca15a948a83a34b3488acf1a0b4
Co-authored-by: Vadim Yanitskiy <vyanitskiy@sysmocom.de>
Jenkins: skip-card-test
2026-06-21 03:30:02 +07003974e9693301d23104bae4a995cb22639ac5e0c2add test_configurable_parameters.pyeditpySim/esim/saip/personalization.pyaddtests/unittests/test_configurable_parameters.pyaddtests/unittests/smdpp_dataaddtests/unittests/xo/test_configurable_parameters
- tests/unittests/test_configurable_parameters.pytests/unittests/xo/test_configurable_parameterspySim/esim/saip/personalization.pyef0a2fcb375d3715d68d6f7f61e70c65e4dc48911781987402000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.depersonalization.ConfigurableParameter: fix BytesIO() input
Change-Id: I0ad160eef9015e76eef10baee7c6b606fe249123
Jenkins: skip-card-test
2026-06-21 03:30:02 +0700ef0a2fcb375d3715d68d6f7f61e70c65e4dc4891personalization.ConfigurableParameter: fix BytesIO() inputedittests/unittests/test_configurable_parameters.pyeditpySim/esim/saip/personalization.pyedittests/unittests/xo/test_configurable_parameters
- tests/unittests/test_configurable_parameters.pytests/unittests/xo/test_configurable_parameterspySim/esim/saip/personalization.pybfdfcad22cb124bdd97e132396bb72ec1b20c4121781987402000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.depersonalization: add int as input type for BinaryParameter
Change-Id: I31d8142cb0847a8b291f8dc614d57cb4734f0190
Jenkins: skip-card-test
2026-06-21 03:30:02 +0700bfdfcad22cb124bdd97e132396bb72ec1b20c412personalization: add int as input type for BinaryParameteredittests/unittests/test_configurable_parameters.pyeditpySim/esim/saip/personalization.pyedittests/unittests/xo/test_configurable_parameters
- pySim/esim/saip/param_source.py4307cffc8223260012509a3e231b70e6a7dc24fe1781987402000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deparam_source: allow plugging a random implementation (for testing)
Change-Id: Idce2b18af70c17844d6f09f7704efc869456ac39
Jenkins: skip-card-test
2026-06-21 03:30:02 +07004307cffc8223260012509a3e231b70e6a7dc24feparam_source: allow plugging a random implementation (for testing)editpySim/esim/saip/param_source.py
- tests/unittests/test_param_src.pytests/unittests/xo/test_param_srcb5ba274583cf9988fe266aa5a75f575df87511351781987402000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deadd test_param_src.py
Change-Id: I03087b84030fddae98b965e0075d44e04ec6ba5c
Jenkins: skip-card-test
2026-06-21 03:30:02 +0700b5ba274583cf9988fe266aa5a75f575df8751135add test_param_src.pyaddtests/unittests/xo/test_param_srcaddtests/unittests/test_param_src.py
- pySim/esim/saip/param_source.py512aba8b1dacae25e3ad74d990fa9fd1e2f6ac651781988126000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deparam_source: use random.SystemRandom as random nr source
Python's random module uses a PRNG (Mersenne Twister) which is
utterly insecure for key generation - it was so far only used for
testing. Replace it with random.SystemRandom(), which draws from
/dev/urandom and is suitable for generating cryptographic key material.
Change-Id: I6de38c14ac6dd55bc84d53974192509c18d02bfa
Jenkins: skip-card-test
2026-06-21 03:42:06 +0700512aba8b1dacae25e3ad74d990fa9fd1e2f6ac65param_source: use random.SystemRandom as random nr sourceeditpySim/esim/saip/param_source.py
- pySim/esim/saip/param_source.pyaad92f2b73ce7742c4aa1191d6984261d2eaecee1781988371000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deparam_source: use secrets.SystemRandom as secure random nr source
secrets.SystemRandom is defined as the most secure random source
available on the given operating system.
Change-Id: I8049cd1292674b3ced82b0926569128535af6efe
Jenkins: skip-card-test
2026-06-21 03:46:11 +0700aad92f2b73ce7742c4aa1191d6984261d2eaeceeparam_source: use secrets.SystemRandom as secure random nr sourceeditpySim/esim/saip/param_source.py
- pySim/esim/saip/param_source.pyce039d69ba0ccc31ea504f62d55e33d6bdb461881781988376000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.desaip/param_source: try to not repeat random values
Change-Id: I4fa743ef5677580f94b9df16a5051d1d178edeb0
Jenkins: skip-card-test
2026-06-21 03:46:16 +0700ce039d69ba0ccc31ea504f62d55e33d6bdb46188saip/param_source: try to not repeat random valueseditpySim/esim/saip/param_source.py
- tests/unittests/test_esim_saip.pytests/unittests/test_configurable_parameters.pytests/unittests/xo/test_configurable_parameterspyproject.tomlpySim/esim/saip/personalization.pye9ff4f3b93c173fb8c619452636a2b6f8314c9271781988376000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.depersonalization: generate sdkey classes from a list
Change-Id: Ic92ddea6e1fad8167ea75baf78ffc3eb419838c4
Jenkins: skip-card-test
2026-06-21 03:46:16 +0700e9ff4f3b93c173fb8c619452636a2b6f8314c927personalization: generate sdkey classes from a listedittests/unittests/test_configurable_parameters.pyeditpySim/esim/saip/personalization.pyeditpyproject.tomledittests/unittests/xo/test_configurable_parametersedittests/unittests/test_esim_saip.py
- pySim/esim/saip/batch.py98af3dd2e956fdb6acdcb41ddc42b645bb44b3481781988376000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deUppAudit: better indicate exception cause
Change-Id: I4d986b89a473a5b12ed56b4710263b034876a33e
Jenkins: skip-card-test
2026-06-21 03:46:16 +070098af3dd2e956fdb6acdcb41ddc42b645bb44b348UppAudit: better indicate exception causeeditpySim/esim/saip/batch.py
- pySim/esim/saip/personalization.pyc5e7e599282891412868d57ba0ad186c633fafb51781988376000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deConfigurableParameter: safer val length check
validate_val() calls len() to check the value against allow_len,
min_len and max_len. len() requires the object to have a __len__()
method, which integers do not — calling len() on an int raises
TypeError.
Fix this by checking for __len__ first: if present, use len(val) as
usual; otherwise fall back to len(str(val)), which gives the number
of decimal digits for integer values.
Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4
Jenkins: skip-card-test
2026-06-21 03:46:16 +0700c5e7e599282891412868d57ba0ad186c633fafb5ConfigurableParameter: safer val length checkeditpySim/esim/saip/personalization.py
- pySim/esim/saip/personalization.py38f93d974b3a0e4696f6aa5519cf483d521a2eb51781997474000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deSmspTpScAddr: fix SMSP record length and alpha_id padding
apply_val() was re-encoding the SMSP with the minimum total_len of 28,
which produces a 28-byte body with no alpha_id field. After a DER
round-trip, the profile machinery re-pads the body to the original
record length using the template's fill pattern, which may not be 0xFF.
Those non-0xFF fill bytes end up in the alpha_id area, and GSM 7-bit
decoding then fails with a KeyError when the modified profile is read
back.
Fix by:
- setting alpha_id = '' so the field is present but empty
- setting f_smsp.rec_len = 42 (28 fixed bytes + 14 bytes of alpha_id
padding) so the re-encoded body carries 0xFF-padded alpha_id space
and the efFileSize in the fileDescriptor stays consistent
- passing total_len=f_smsp.rec_len to encode_record_bin() so the
alpha_id area is actually padded to that length
Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296
Jenkins: skip-card-test
2026-06-21 06:17:54 +070038f93d974b3a0e4696f6aa5519cf483d521a2eb5SmspTpScAddr: fix SMSP record length and alpha_id paddingeditpySim/esim/saip/personalization.py
- tests/unittests/test_configurable_parameters.pytests/unittests/xo/test_configurable_parametersb576e8fcff3f286158c986844c10e1529cd171b11782132532000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.detest_configurable_parameters.py: add tests for new parameters
For:
SmspTpScAddr
MilenageRotation
MilenageXoringConstants
TuakNrOfKeccak
Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001
Jenkins: skip-card-test
2026-06-22 19:48:52 +0700b576e8fcff3f286158c986844c10e1529cd171b1test_configurable_parameters.py: add tests for new parametersedittests/unittests/xo/test_configurable_parametersedittests/unittests/test_configurable_parameters.py
- pySim/esim/saip/personalization.py861ed0a1d8b75e72a0d930ed66444fbc369735671782132989000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deadd comment about not updating existing key_usage_qualifier
Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a
Jenkins: skip-card-test
2026-06-22 19:56:29 +0700861ed0a1d8b75e72a0d930ed66444fbc36973567add comment about not updating existing key_usage_qualifiereditpySim/esim/saip/personalization.py
- pySim/esim/saip/personalization.pycfe2b94f6758e3708bf550310c98fde0e7427a181782132989000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.desaip SmspTpScAddr.get_values_from_pes: allow empty values
Change-Id: Ibbdd08f96160579238b50699091826883f2e9f5a
Jenkins: skip-card-test
2026-06-22 19:56:29 +0700cfe2b94f6758e3708bf550310c98fde0e7427a18saip SmspTpScAddr.get_values_from_pes: allow empty valueseditpySim/esim/saip/personalization.py
- pySim/esim/saip/personalization.py728940efb2a4e5eb46d822dabc092756b32a2da81782132989000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.desaip: add numeric_base indicator to ConfigurableParameter
By default, numeric_base = None, to indicate that there are no explicit
limitations on the number space.
For parameters that are definitely decimal, set numeric_base = 10.
For definitely hexadecimal, set numeric_base = 16.
Do the same for ConfigurableParameter as well as ParamSource, so callers
can match them up: if a parameter is numeric_base = 10, then omit
sources that are numeric_base = 16, and vice versa.
Change-Id: Ib0977bbdd9a85167be7eb46dd331fedd529dae01
Jenkins: skip-card-test
2026-06-22 19:56:29 +0700728940efb2a4e5eb46d822dabc092756b32a2da8saip: add numeric_base indicator to ConfigurableParametereditpySim/esim/saip/personalization.py
- pySim/euicc.py980282cc12b7c89e29d82e397e47b0d2701ef6371782147784000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgeuicc: extend get_profiles_info to retrieve all known tags
get_profiles_info only request for the default tag list, but
not all tags.
Add --all to the function to request for all known tags.
Change-Id: Ia6878519a480bd625bb1fa2567c1fd2e0e89b071
2026-06-22 17:03:04 +0000980282cc12b7c89e29d82e397e47b0d2701ef637euicc: extend get_profiles_info to retrieve all known tagseditpySim/euicc.py
- pySim/euicc.pyd0e6a1b119120eb657490785cb9b72d22682e3611782147784000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgeuicc: get_profiles_info: add additional tags
Add definitions for ProfileOwner (decoded),
Notification Configuration Info, SM-DP+ proprietary data,
Profile Policy Rules.
Change-Id: I727dbe34d87a42bb3b526bd7a8accd687d20a208
2026-06-22 17:03:04 +0000d0e6a1b119120eb657490785cb9b72d22682e361euicc: get_profiles_info: add additional tagseditpySim/euicc.py
githttps://jenkins.osmocom.org/jenkins/user/laforgelaforgehttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy