Skip to content
Success

Changes

Summary

  1. hnbgw: fixup for expect_compl_l3_success (details)
  2. hnbgw: Rename RAB helper functions to be CS specific (details)
  3. hnbgw: Use g_pars.mgcp_pars directly during RAB CS setup (details)
  4. hnbgw/expected-results: update (details)
  5. testenv: make podman stop more robust (details)
Commit cd30b5380cfc6f0400989852fea35d74ce7c9ec6 by Oliver Smith
hnbgw: fixup for expect_compl_l3_success

During my rebase of Neels patch, I've missed setting
expect_compl_l3_success in t_pars(), leading to:

  HNBGW_Tests.ttcn:571 Dynamic test case error: Text encoder: Encoding an unbound boolean value.

For a lot of tests. Also add the parameter to f_TestHdlrParams() for
consistency.

Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN")
Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c
The file was modifiedhnbgw/ConnHdlr.ttcn
The file was modifiedhnbgw/HNBGW_Tests.ttcn
Commit 2f6d1bb9be96a48414bf402201b949c75e0e13bb by Pau Espin Pedrol
hnbgw: Rename RAB helper functions to be CS specific

Change-Id: If8a97fe847083e95a480006d147ff59be695b713
The file was modifiedhnbgw/HNBGW_Tests.ttcn
The file was modifiedhnbgw/ConnHdlr.ttcn
Commit ab24560830c80b1f676b33ba8c8beeec636ea394 by Pau Espin Pedrol
hnbgw: Use g_pars.mgcp_pars directly during RAB CS setup

Change-Id: I1f699e197e29f912ad06378f10563063aa291af3
The file was modifiedhnbgw/ConnHdlr.ttcn
The file was modifiedhnbgw/HNBGW_Tests.ttcn
Commit a487d2b0e8c349d50f68e7f5c43c0ef939b07736 by Oliver Smith
hnbgw/expected-results: update

Add:
* TC_hnb_disconnected_timeout
* TC_mscpool_L3Compl_no_cn
* TC_sgsnpool_L3Compl_no_cn

Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN")
Change-Id: Ib126ff53aa9edfeb94f5e7e058145bd4fbe7b604
The file was modifiedhnbgw/expected-results.xml
Commit 9eb5e696a0997e0de8db0248ba8be31ebb2cdac9 by Oliver Smith
testenv: make podman stop more robust

Terminate the watchdog process before killing the podman container. This
avoids bogus errors from a race condition where the container gets
killed first, and then the watchdog process tries to feed the watchdog
and fails:

  [testenv] Stopping podman container
  [testenv] + ['podman', 'kill', 'testenv-hnbgw-all-osmocom-latest-20241031-1222-f34534a5-1']
  e41700779a8ca5daf18ac5daa27d59a84d8442196e352f2756a19baf0592cf89
  Error: no container with name or ID testenv-hnbgw-all-osmocom-latest-20241031-1222-f34534a5-1 found: no such container
  [testenv] podman container crashed!

While at it, use "check=False" with the "podman kill" command, so we
avoid additional error messages if the container was already killed at
that point (could happen through a bug). If we fail to kill it here, it
is not a problem because the watchdog will ensure it terminates shortly
after the watchdog process was stopped.

Related: OS#6607
Change-Id: I6c67273af5b6a80ae0c94e14cb92e3784807c21d
The file was modified_testenv/testenv/podman.py