Started by upstream project "gerrit-osmo-bts" build number 1,1291129gerrit-osmo-btsjob/gerrit-osmo-bts/COMMENT_TYPEDISTROGERRIT_BRANCHmasterGERRIT_CHANGE_NUMBER42524GERRIT_HOSTgerrit.osmocom.orgGERRIT_PATCHSET_NUMBER1GERRIT_PATCHSET_REVISION4c6324213ac87f9979df7e6d0f596f175ddb27f6GERRIT_PATCHSET_UPLOADER_NAMEfixeriaGERRIT_PORT29418GERRIT_PROJECTosmo-btsGERRIT_REFSPECrefs/changes/24/42524/1GERRIT_REPO_URLssh://jenkins@gerrit.osmocom.org:29418/osmo-btsPIPELINE_BUILD_URLhttps://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bts/1129/PROJECT_NAMEosmo-btsBRANCH_CImaster4029402900525352531.008440844022254addc0dc1fd76c9868a774d2532faa2995eafff31addc0dc1fd76c9868a774d2532faa2995eafff31osmith/1.9.1addc0dc1fd76c9868a774d2532faa2995eafff31addc0dc1fd76c9868a774d2532faa2995eafff31osmith/1.9.1126733f0bbe398e16513906d29802d058a87655fceaf13f0bbe398e16513906d29802d058a87655fceaf1osmith/1.9.23f0bbe398e16513906d29802d058a87655fceaf13f0bbe398e16513906d29802d058a87655fceaf1osmith/1.9.211680f79a23bab0e43959d25363d2a4903127e0a1cb3af79a23bab0e43959d25363d2a4903127e0a1cb3aosmith/1.7.1f79a23bab0e43959d25363d2a4903127e0a1cb3af79a23bab0e43959d25363d2a4903127e0a1cb3aosmith/1.7.1

151155d83526f60cc31c3e56eaf43381f06b5b99671a05d83526f60cc31c3e56eaf43381f06b5b99671a0rel-1.4.25d83526f60cc31c3e56eaf43381f06b5b99671a05d83526f60cc31c3e56eaf43381f06b5b99671a0rel-1.4.2

6890b6c5f67456fc4426f577d0feeb343918475cdba1b6c5f67456fc4426f577d0feeb343918475cdba1rel-1.4.1b6c5f67456fc4426f577d0feeb343918475cdba1b6c5f67456fc4426f577d0feeb343918475cdba1rel-1.4.1

12353f97c53bc9ce0c76493378b9f44f170bb70f74f48f97c53bc9ce0c76493378b9f44f170bb70f74f48ewild/1.6.1f97c53bc9ce0c76493378b9f44f170bb70f74f48f97c53bc9ce0c76493378b9f44f170bb70f74f48ewild/1.6.11308275a087d16ba2539b8bcf05102b41d820e818724175a087d16ba2539b8bcf05102b41d820e8187241osmith/1.7.275a087d16ba2539b8bcf05102b41d820e818724175a087d16ba2539b8bcf05102b41d820e8187241osmith/1.7.2393481335271b9f8c74cbafceeb11ccede5074bc93cc81335271b9f8c74cbafceeb11ccede5074bc93ccosmith/1.5.181335271b9f8c74cbafceeb11ccede5074bc93cc81335271b9f8c74cbafceeb11ccede5074bc93ccosmith/1.5.1

11859a713b3379249b7f852ce0cc51cf8c2374dd9069ca713b3379249b7f852ce0cc51cf8c2374dd9069crel-1.8.1a713b3379249b7f852ce0cc51cf8c2374dd9069ca713b3379249b7f852ce0cc51cf8c2374dd9069crel-1.8.1

748332684e36390bbc9bd1e76b61521712e534d16aeb32684e36390bbc9bd1e76b61521712e534d16aebosmith/0.1.332684e36390bbc9bd1e76b61521712e534d16aeb32684e36390bbc9bd1e76b61521712e534d16aebosmith/0.1.3

26993becbf0b374b0186d667d070cf795909910070432becbf0b374b0186d667d070cf795909910070432pespin/release-basebecbf0b374b0186d667d070cf795909910070432becbf0b374b0186d667d070cf795909910070432pespin/release-base

4955fffe26107673689522789803c5c1dfd4a7b1f26cfffe26107673689522789803c5c1dfd4a7b1f26cpespin/1.10.0fffe26107673689522789803c5c1dfd4a7b1f26cfffe26107673689522789803c5c1dfd4a7b1f26cpespin/1.10.0<_2023q1 _class='hudson.plugins.git.util.Build'>6884231f67ebb207a0a871043fc429a1b6f763ba880b231f67ebb207a0a871043fc429a1b6f763ba880b2023q1231f67ebb207a0a871043fc429a1b6f763ba880b231f67ebb207a0a871043fc429a1b6f763ba880b2023q1

2268020a99327773ee8bfe2555bc2aee0bf6cee4e3b8520a99327773ee8bfe2555bc2aee0bf6cee4e3b85rel-2.0.120a99327773ee8bfe2555bc2aee0bf6cee4e3b8520a99327773ee8bfe2555bc2aee0bf6cee4e3b85rel-2.0.1

215145e2d10bcfc0339ca363d8f11d58fc50266599e325e2d10bcfc0339ca363d8f11d58fc50266599e32pespin/base5e2d10bcfc0339ca363d8f11d58fc50266599e325e2d10bcfc0339ca363d8f11d58fc50266599e32pespin/base

19788b4311b73ec543c01237406b5e1c44ba44198704eb4311b73ec543c01237406b5e1c44ba44198704epespin/rel-1.5.0b4311b73ec543c01237406b5e1c44ba44198704eb4311b73ec543c01237406b5e1c44ba44198704epespin/rel-1.5.0

40929680549e0a4eb2ee2d52e77534bf366fb9587a5d9680549e0a4eb2ee2d52e77534bf366fb9587a5drel-1.10.19680549e0a4eb2ee2d52e77534bf366fb9587a5d9680549e0a4eb2ee2d52e77534bf366fb9587a5drel-1.10.1

17435ee14219d4b764d6d1eabd122fbec150cace7044aee14219d4b764d6d1eabd122fbec150cace7044arel-1.12.1ee14219d4b764d6d1eabd122fbec150cace7044aee14219d4b764d6d1eabd122fbec150cace7044arel-1.12.1

74936aefb798af203a38e919d91de268392f3ac9ae7b6aefb798af203a38e919d91de268392f3ac9ae7bosmith/1.10.16aefb798af203a38e919d91de268392f3ac9ae7b6aefb798af203a38e919d91de268392f3ac9ae7bosmith/1.10.1

269916e56c58fed8d13544fda7aa80f7c8828279ade0f6e56c58fed8d13544fda7aa80f7c8828279ade0fpespin/rel-1.14.06e56c58fed8d13544fda7aa80f7c8828279ade0f6e56c58fed8d13544fda7aa80f7c8828279ade0fpespin/rel-1.14.0

25962e442ea2878aa99946837b66704d7d8b590868eb9e442ea2878aa99946837b66704d7d8b590868eb9pespin/rel-1.12.0e442ea2878aa99946837b66704d7d8b590868eb9e442ea2878aa99946837b66704d7d8b590868eb9pespin/rel-1.12.0

204484a0f1f4213671190d3163ba38fe9f58534dd6a6f4a0f1f4213671190d3163ba38fe9f58534dd6a6fosmith/1.12.34a0f1f4213671190d3163ba38fe9f58534dd6a6f4a0f1f4213671190d3163ba38fe9f58534dd6a6fosmith/1.12.3

21056a32a6ee4a6532e0c1d358ecebb8f13b8acc75dc1a32a6ee4a6532e0c1d358ecebb8f13b8acc75dc1pespin/rel-1.10.0a32a6ee4a6532e0c1d358ecebb8f13b8acc75dc1a32a6ee4a6532e0c1d358ecebb8f13b8acc75dc1pespin/rel-1.10.0

2045649dde81223667770bea72f3f0cc4b378d2c0ea4849dde81223667770bea72f3f0cc4b378d2c0ea48osmith/1.12.449dde81223667770bea72f3f0cc4b378d2c0ea4849dde81223667770bea72f3f0cc4b378d2c0ea48osmith/1.12.4185808d37827695908fe36ff594eeef82f4d89d99bf3d8d37827695908fe36ff594eeef82f4d89d99bf3dosmith/1.12.18d37827695908fe36ff594eeef82f4d89d99bf3d8d37827695908fe36ff594eeef82f4d89d99bf3dosmith/1.12.119888be6bd146db7c2cf181bd0797ef8f9ebcee6902cbbe6bd146db7c2cf181bd0797ef8f9ebcee6902cbosmith/1.12.2be6bd146db7c2cf181bd0797ef8f9ebcee6902cbbe6bd146db7c2cf181bd0797ef8f9ebcee6902cbosmith/1.12.225150846fcd7a3d8fc68490971c8c67489ee8be84dbf1846fcd7a3d8fc68490971c8c67489ee8be84dbf1osmith/2.1.2846fcd7a3d8fc68490971c8c67489ee8be84dbf1846fcd7a3d8fc68490971c8c67489ee8be84dbf1osmith/2.1.225256fc0a9591a449a0d346eb62003e4e150215f95deffc0a9591a449a0d346eb62003e4e150215f95defosmith/2.1.3fc0a9591a449a0d346eb62003e4e150215f95deffc0a9591a449a0d346eb62003e4e150215f95defosmith/2.1.3

162167cc276b31e36239c7e521a5282dd4c146d8dfb147cc276b31e36239c7e521a5282dd4c146d8dfb14for-1.87cc276b31e36239c7e521a5282dd4c146d8dfb147cc276b31e36239c7e521a5282dd4c146d8dfb14for-1.8

958f0be4e4360a716ed6294fad5b7d32f1305cf5c2af0be4e4360a716ed6294fad5b7d32f1305cf5c2aarehbein/wipf0be4e4360a716ed6294fad5b7d32f1305cf5c2af0be4e4360a716ed6294fad5b7d32f1305cf5c2aarehbein/wip19864422b47d3e92765e6f86bf679f32ff40e70a68b30422b47d3e92765e6f86bf679f32ff40e70a68b30osmith/1.6.2422b47d3e92765e6f86bf679f32ff40e70a68b30422b47d3e92765e6f86bf679f32ff40e70a68b30osmith/1.6.2

174349ea42126ccc55dbc13e1eda0249570590e4462f39ea42126ccc55dbc13e1eda0249570590e4462f3rel-1.5.19ea42126ccc55dbc13e1eda0249570590e4462f39ea42126ccc55dbc13e1eda0249570590e4462f3rel-1.5.1

968874e999ceb2b49cf499c00799fae4b5069e4b2e7c74e999ceb2b49cf499c00799fae4b5069e4b2e7cosmo-iuh/master74e999ceb2b49cf499c00799fae4b5069e4b2e7c74e999ceb2b49cf499c00799fae4b5069e4b2e7cosmo-iuh/master

24424ea1b5c4c6f9f80686a6b17541184d79fafc980a0ea1b5c4c6f9f80686a6b17541184d79fafc980a0osmith/1.6.1ea1b5c4c6f9f80686a6b17541184d79fafc980a0ea1b5c4c6f9f80686a6b17541184d79fafc980a0osmith/1.6.1

165593a1bb866bbc481b379034723ede51a2e4e8b9c653a1bb866bbc481b379034723ede51a2e4e8b9c65rel-1.9.13a1bb866bbc481b379034723ede51a2e4e8b9c653a1bb866bbc481b379034723ede51a2e4e8b9c65rel-1.9.1

15109b09f62ec759c5b12fdb292aa22baddc6e04bc448b09f62ec759c5b12fdb292aa22baddc6e04bc448rel-1.5.2b09f62ec759c5b12fdb292aa22baddc6e04bc448b09f62ec759c5b12fdb292aa22baddc6e04bc448rel-1.5.2

244277fa7e786f710504bd88c71498a21e97ff7999d7d7fa7e786f710504bd88c71498a21e97ff7999d7dosmith/0.2.17fa7e786f710504bd88c71498a21e97ff7999d7d7fa7e786f710504bd88c71498a21e97ff7999d7dosmith/0.2.1

1656755ea51049775e623880f62026ad827f580aec7a255ea51049775e623880f62026ad827f580aec7a2rel-1.9.355ea51049775e623880f62026ad827f580aec7a255ea51049775e623880f62026ad827f580aec7a2rel-1.9.3

19789c500f9282259c40a801538f46d84cb9aaefe46dec500f9282259c40a801538f46d84cb9aaefe46depespin/rel-1.6.0c500f9282259c40a801538f46d84cb9aaefe46dec500f9282259c40a801538f46d84cb9aaefe46depespin/rel-1.6.0

9486f278c456b927c5a498e608e2928510786656e096f278c456b927c5a498e608e2928510786656e09arehbein/ttcn3-dumpcap-changes6f278c456b927c5a498e608e2928510786656e096f278c456b927c5a498e608e2928510786656e09arehbein/ttcn3-dumpcap-changes

7886d75a0cca8117b609da75111388bf8baea5dac0a5d75a0cca8117b609da75111388bf8baea5dac0a5arehbein/osmo_io_ipad75a0cca8117b609da75111388bf8baea5dac0a5d75a0cca8117b609da75111388bf8baea5dac0a5arehbein/osmo_io_ipa

2276787de74a9f5835fb56a4758860aea3e673c29060e87de74a9f5835fb56a4758860aea3e673c29060erel-1.11.187de74a9f5835fb56a4758860aea3e673c29060e87de74a9f5835fb56a4758860aea3e673c29060erel-1.11.1

245359727f06feadcac22571a01b6bc777a7b6792b5bd9727f06feadcac22571a01b6bc777a7b6792b5bdpespin/rel-1.13.19727f06feadcac22571a01b6bc777a7b6792b5bd9727f06feadcac22571a01b6bc777a7b6792b5bdpespin/rel-1.13.1

130780941436d417c109893da48649464e8a3c811b44b0941436d417c109893da48649464e8a3c811b44bosmith/1.11.10941436d417c109893da48649464e8a3c811b44b0941436d417c109893da48649464e8a3c811b44bosmith/1.11.1

257548700c3509ebe7cda28ee848462c0ef0ff4c13c948700c3509ebe7cda28ee848462c0ef0ff4c13c94pespin/rel-1.13.08700c3509ebe7cda28ee848462c0ef0ff4c13c948700c3509ebe7cda28ee848462c0ef0ff4c13c94pespin/rel-1.13.0

17722aa177c0f4457df953e3e6e121e8806a4cf403d72aa177c0f4457df953e3e6e121e8806a4cf403d72osmith/wipaa177c0f4457df953e3e6e121e8806a4cf403d72aa177c0f4457df953e3e6e121e8806a4cf403d72osmith/wip252180cd176646030a2bf2c484e12efb8bdde4b79462f0cd176646030a2bf2c484e12efb8bdde4b79462fosmith/1.13.30cd176646030a2bf2c484e12efb8bdde4b79462f0cd176646030a2bf2c484e12efb8bdde4b79462fosmith/1.13.32442122a11a35e3feec31b86738d19f3d85406feb099a22a11a35e3feec31b86738d19f3d85406feb099aosmith/1.11.222a11a35e3feec31b86738d19f3d85406feb099a22a11a35e3feec31b86738d19f3d85406feb099aosmith/1.11.2244335365df321a7edf12131f02e50e2a267bd4e45dd85365df321a7edf12131f02e50e2a267bd4e45dd8osmith/1.13.15365df321a7edf12131f02e50e2a267bd4e45dd85365df321a7edf12131f02e50e2a267bd4e45dd8osmith/1.13.12529117ca3339e13d779a330781334e92f48d7ea87d3617ca3339e13d779a330781334e92f48d7ea87d36osmith/1.11.317ca3339e13d779a330781334e92f48d7ea87d3617ca3339e13d779a330781334e92f48d7ea87d36osmith/1.11.3190620106387dd31af6c606c7e6e1a2638a3e587614d00106387dd31af6c606c7e6e1a2638a3e587614d0pespin/2.0.00106387dd31af6c606c7e6e1a2638a3e587614d00106387dd31af6c606c7e6e1a2638a3e587614d0pespin/2.0.0

23079d2b9b7e0a826ce789952ab87758815041a1aa302d2b9b7e0a826ce789952ab87758815041a1aa302pespin/rel-2.1.0d2b9b7e0a826ce789952ab87758815041a1aa302d2b9b7e0a826ce789952ab87758815041a1aa302pespin/rel-2.1.0

278284c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6master

26602b722ba007bd3056febe0fe273d2fdd72eca09db8b722ba007bd3056febe0fe273d2fdd72eca09db8ttcn3-bts-testb722ba007bd3056febe0fe273d2fdd72eca09db8b722ba007bd3056febe0fe273d2fdd72eca09db8ttcn3-bts-test

130433a3e544a39fb3f60f91c554d17a3c7692beb7f263a3e544a39fb3f60f91c554d17a3c7692beb7f26osmith/1.4.03a3e544a39fb3f60f91c554d17a3c7692beb7f263a3e544a39fb3f60f91c554d17a3c7692beb7f26osmith/1.4.0748765e8411336ec02ce019447cd751e475a80fb45c065e8411336ec02ce019447cd751e475a80fb45c0osmith/1.4.165e8411336ec02ce019447cd751e475a80fb45c065e8411336ec02ce019447cd751e475a80fb45c0osmith/1.4.1110735b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.25b5785af7a089b2a4f0c6963fdeebfc48fb225405b5785af7a089b2a4f0c6963fdeebfc48fb22540osmith/0.8.24c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6master$GERRIT_REPO_URLfalse#2782852535133gerrit-lint #2782827828falsefalse2782874533SUCCESS1774792091158https://jenkins.osmocom.org/jenkins/view/gerrit/job/gerrit-lint/27828/build4-deb12build-ansiblesrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.hgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy