/* OsmoBTS VTY interface */

/* (C) 2011-2014 by Harald Welte <laforge@gnumonks.org>
 *
 * All Rights Reserved
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published by
 * the Free Software Foundation; either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

#include "btsconfig.h"

#include <inttypes.h>
#include <limits.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <arpa/inet.h>
#include <ctype.h>
#include <errno.h>

#include <osmocom/core/talloc.h>
#include <osmocom/gsm/abis_nm.h>
#include <osmocom/gsm/protocol/gsm_04_08.h>
#include <osmocom/vty/vty.h>
#include <osmocom/vty/stats.h>
#include <osmocom/vty/command.h>
#include <osmocom/vty/logging.h>
#include <osmocom/vty/misc.h>
#include <osmocom/vty/ports.h>
#include <osmocom/vty/tdef_vty.h>
#include <osmocom/core/gsmtap.h>
#include <osmocom/core/utils.h>
#include <osmocom/core/sockaddr_str.h>
#include <osmocom/core/fsm.h>
#include <osmocom/codec/codec.h>

#include <osmo-bts/logging.h>
#include <osmo-bts/gsm_data.h>
#include <osmo-bts/phy_link.h>
#include <osmo-bts/abis.h>
#include <osmo-bts/bts.h>
#include <osmo-bts/bts_sm.h>
#include <osmo-bts/rsl.h>
#include <osmo-bts/oml.h>
#include <osmo-bts/signal.h>
#include <osmo-bts/bts_model.h>
#include <osmo-bts/paging.h>
#include <osmo-bts/pcuif_proto.h>
#include <osmo-bts/measurement.h>
#include <osmo-bts/vty.h>
#include <osmo-bts/l1sap.h>
#include <osmo-bts/osmux.h>
#include <osmo-bts/rtp_abstract.h>

#define VTY_STR	"Configure the VTY\n"

#define BTS_NR_STR "BTS Number\n"
#define TRX_NR_STR "TRX Number\n"
#define TS_NR_STR "Timeslot Number\n"
#define LCHAN_NR_STR "Logical Channel Number\n"
#define BTS_TRX_STR BTS_NR_STR TRX_NR_STR
#define BTS_TRX_TS_STR BTS_TRX_STR TS_NR_STR
#define BTS_TRX_TS_LCHAN_STR BTS_TRX_TS_STR LCHAN_NR_STR
/* INT32_MAX, because osmo_wqueue_init takes int as an argument
 * and INT_MAX can't be stringified as a decimal */
#define BTS_CFG_PCU_SOCK_WQUEUE_LEN_MAX_MAX 2147483647

#define X(x) (1 << x)

int g_vty_port_num = OSMO_VTY_PORT_BTS;

static const struct value_string gsmtap_sapi_names[] = {
	{ GSMTAP_CHANNEL_BCCH,	"BCCH" },
	{ GSMTAP_CHANNEL_CCCH,	"CCCH" },
	{ GSMTAP_CHANNEL_RACH,	"RACH" },
	{ GSMTAP_CHANNEL_AGCH,	"AGCH" },
	{ GSMTAP_CHANNEL_PCH,	"PCH" },
	{ GSMTAP_CHANNEL_SDCCH,	"SDCCH" },
	{ GSMTAP_CHANNEL_TCH_F,	"TCH/F" },
	{ GSMTAP_CHANNEL_TCH_H,	"TCH/H" },
	{ GSMTAP_CHANNEL_PACCH,	"PACCH" },
	{ GSMTAP_CHANNEL_PDCH,	"PDTCH" },
	{ GSMTAP_CHANNEL_PTCCH,	"PTCCH" },
	{ GSMTAP_CHANNEL_CBCH51,"CBCH" },
	{ GSMTAP_CHANNEL_ACCH,  "SACCH" },
	{ 0, NULL }
};

struct phy_instance *vty_get_phy_instance(struct vty *vty, int phy_nr, int inst_nr)
{
	struct phy_link *plink = phy_link_by_num(phy_nr);
	struct phy_instance *pinst;

	if (!plink) {
		vty_out(vty, "%% Cannot find PHY link number %d%s",
			phy_nr, VTY_NEWLINE);
		return NULL;
	}

	pinst = phy_instance_by_num(plink, inst_nr);
	if (!pinst) {
		vty_out(vty, "%% Cannot find PHY instance number %d%s",
			inst_nr, VTY_NEWLINE);
		return NULL;
	}
	return pinst;
}

int bts_vty_go_parent(struct vty *vty)
{
	switch (vty->node) {
	case PHY_INST_NODE:
		vty->node = PHY_NODE;
		{
			struct phy_instance *pinst = vty->index;
			vty->index = pinst->phy_link;
		}
		break;
	case TRX_NODE:
		vty->node = BTS_NODE;
		{
			struct gsm_bts_trx *trx = vty->index;
			vty->index = trx->bts;
		}
		break;
	case PHY_NODE:
	default:
		vty->node = CONFIG_NODE;
	}
	return vty->node;
}

static const char osmobts_copyright[] =
	"Copyright (C) 2010-2011 by Harald Welte, Andreas Eversberg and On-Waves\r\n"
	"Copyright (C) 2011-2022 by sysmocom - s.f.m.c. GmbH\r\n"
	"License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n"
	"This is free software: you are free to change and redistribute it.\r\n"
	 "There is NO WARRANTY, to the extent permitted by law.\r\n";

struct vty_app_info bts_vty_info = {
	.name		= "OsmoBTS",
	.version	= PACKAGE_VERSION,
	.copyright	= osmobts_copyright,
	.go_parent_cb	= bts_vty_go_parent,
	.usr_attr_desc	= {
		[BTS_VTY_ATTR_NEW_LCHAN] = \
			"This command applies for newly created lchans",
		[BTS_VTY_TRX_POWERCYCLE] = \
			"This command applies when the TRX powercycles or restarts",
	},
	.usr_attr_letters = {
		[BTS_VTY_ATTR_NEW_LCHAN] = 'l',
		[BTS_VTY_TRX_POWERCYCLE] = 'p',
	},
};

static struct cmd_node bts_node = {
	BTS_NODE,
	"%s(bts)# ",
	1,
};

static struct cmd_node trx_node = {
	TRX_NODE,
	"%s(trx)# ",
	1,
};

static struct cmd_node osmux_node = {
	OSMUX_NODE,
	"%s(osmux)# ",
	1,
};

static struct cmd_node twjit_node = {
	TWJIT_NODE,
	"%s(twjit)# ",
	1,
};

gDEFUN(cfg_bts_auto_band, cfg_bts_auto_band_cmd,
	"auto-band",
	"Automatically select band for ARFCN based on configured band\n")
{
	struct gsm_bts *bts = vty->index;

	bts->auto_band = 1;
	return CMD_SUCCESS;
}

gDEFUN(cfg_bts_no_auto_band, cfg_bts_no_auto_band_cmd,
	"no auto-band",
	NO_STR "Automatically select band for ARFCN based on configured band\n")
{
	struct gsm_bts *bts = vty->index;

	bts->auto_band = 0;
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_osmux, cfg_bts_osmux_cmd,
	   "osmux",
	   "Configure Osmux\n",
	   CMD_ATTR_IMMEDIATE)
{
	vty->node = OSMUX_NODE;
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_osmux_use, cfg_bts_osmux_use_cmd,
	   "use (off|on|only)",
	   "Configure Osmux usage\n"
	   "Never use Osmux\n"
	   "Use Osmux if requested by BSC (default)\n"
	   "Always use Osmux, reject non-Osmux BSC requests\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;
	if (strcmp(argv[0], "off") == 0)
		bts->osmux.use = OSMUX_USAGE_OFF;
	else if (strcmp(argv[0], "on") == 0)
		bts->osmux.use = OSMUX_USAGE_ON;
	else if (strcmp(argv[0], "only") == 0)
		bts->osmux.use = OSMUX_USAGE_ONLY;
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_osmux_ip,
      cfg_bts_osmux_ip_cmd,
      "local-ip " VTY_IPV46_CMD,
      IP_STR
      "IPv4 Address to bind to\n"
      "IPv6 Address to bind to\n")
{
	struct gsm_bts *bts = vty->index;
	osmo_talloc_replace_string(bts, &bts->osmux.local_addr, argv[0]);
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_osmux_port,
      cfg_bts_osmux_port_cmd,
      "local-port <1-65535>",
      "Osmux port\n" "UDP port\n")
{
	struct gsm_bts *bts = vty->index;
	bts->osmux.local_port = atoi(argv[0]);
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_osmux_batch_factor,
      cfg_bts_osmux_batch_factor_cmd,
      "batch-factor <1-8>",
      "Batching factor\n" "Number of messages in the batch\n")
{
	struct gsm_bts *bts = vty->index;
	bts->osmux.batch_factor = atoi(argv[0]);
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_osmux_batch_size,
      cfg_bts_osmux_batch_size_cmd,
      "batch-size <1-65535>",
      "Batch size\n" "Batch size in bytes\n")
{
	struct gsm_bts *bts = vty->index;
	bts->osmux.batch_size = atoi(argv[0]);
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_osmux_dummy_padding,
      cfg_bts_osmux_dummy_padding_cmd,
      "dummy-padding (on|off)",
      "Dummy padding\n"
      "Enable dummy padding\n"
      "Disable dummy padding (default)\n")
{
	struct gsm_bts *bts = vty->index;
	if (strcmp(argv[0], "on") == 0)
		bts->osmux.dummy_padding = true;
	else if (strcmp(argv[0], "off") == 0)
		bts->osmux.dummy_padding = false;
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_twjit, cfg_bts_twjit_cmd,
	   "twjit",
	   "Configure TW jitter buffer",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	vty->node = TWJIT_NODE;
	vty->index = bts->twjit_cfg;
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_trx, cfg_bts_trx_cmd,
	   "trx <0-254>",
	   "Select a TRX to configure\n" "TRX number\n",
	   CMD_ATTR_IMMEDIATE)
{
	int trx_nr = atoi(argv[0]);
	struct gsm_bts *bts = vty->index;
	struct gsm_bts_trx *trx;


	if (trx_nr > bts->num_trx) {
		vty_out(vty, "%% The next unused TRX number is %u%s",
			bts->num_trx, VTY_NEWLINE);
		return CMD_WARNING;
	} else if (trx_nr == bts->num_trx) {
		/* Allocate a new TRX
		 * Remark: TRX0 was already created during gsm_bts_alloc() and
		 * 	   initialized in bts_init(), not here.
		 */
		trx = gsm_bts_trx_alloc(bts);
		if (trx)
			bts_model_trx_init(trx);
	} else
		trx = gsm_bts_trx_num(bts, trx_nr);

	if (!trx) {
		vty_out(vty, "%% Unable to allocate TRX %u%s",
			trx_nr, VTY_NEWLINE);
		return CMD_WARNING;
	}

	vty->index = trx;
	vty->index_sub = &trx->description;
	vty->node = TRX_NODE;

	return CMD_SUCCESS;
}

static void config_write_dpc_params(struct vty *vty, const char *prefix,
				    const struct gsm_power_ctrl_params *params)
{
	const struct gsm_power_ctrl_meas_params *mp = &params->rxlev_meas;

	if (mp->lower_thresh != power_ctrl_params_def.rxlev_meas.lower_thresh ||
	    mp->upper_thresh != power_ctrl_params_def.rxlev_meas.upper_thresh) {
		int target = (mp->lower_thresh + mp->upper_thresh) / 2;
		int hyst = (mp->upper_thresh - mp->lower_thresh) / 2;

		vty_out(vty, " %s-power-target %d", prefix, rxlev2dbm(target));
		if (hyst > 0)
			vty_out(vty, " hysteresis %d", hyst);
		vty_out(vty, "%s", VTY_NEWLINE);
	}

	/* MS Tx power filtering algorithm and parameters */
	switch (mp->algo) {
	case GSM_PWR_CTRL_MEAS_AVG_ALGO_OSMO_EWMA: /* EWMA is the default */
		if (mp->ewma.alpha != power_ctrl_params_def.rxlev_meas.ewma.alpha)
			vty_out(vty, " %s-power-filtering algo ewma beta %u%s",
				prefix, 100 - mp->ewma.alpha, VTY_NEWLINE);
		break;
	/* Other algorithm cannot be set via the VTY */
	case BTS_PF_ALGO_NONE:
	default:
		vty_out(vty, " no %s-power-filtering%s", prefix, VTY_NEWLINE);
		break;
	}
}

static void config_write_osmux(struct vty *vty, const char *prefix, const struct gsm_bts *bts)
{
	vty_out(vty, "%sosmux%s", prefix, VTY_NEWLINE);
	vty_out(vty, "%s use ", prefix);
	switch (bts->osmux.use) {
	case OSMUX_USAGE_ON:
		vty_out(vty, "on%s", VTY_NEWLINE);
		break;
	case OSMUX_USAGE_ONLY:
		vty_out(vty, "only%s", VTY_NEWLINE);
		break;
	case OSMUX_USAGE_OFF:
	default:
		vty_out(vty, "off%s", VTY_NEWLINE);
		break;
	}
	vty_out(vty, "%s local-ip %s%s", prefix, bts->osmux.local_addr, VTY_NEWLINE);
	vty_out(vty, "%s local-port %u%s", prefix, bts->osmux.local_port, VTY_NEWLINE);
	vty_out(vty, "%s batch-factor %d%s", prefix, bts->osmux.batch_factor, VTY_NEWLINE);
	vty_out(vty, "%s batch-size %u%s", prefix, bts->osmux.batch_size, VTY_NEWLINE);
	vty_out(vty, "%s dummy-padding %s%s", prefix, bts->osmux.dummy_padding ? "on" : "off", VTY_NEWLINE);
}

static void config_write_bts_single(struct vty *vty, const struct gsm_bts *bts)
{
	const struct gsm_bts_trx *trx;
	const char *sapi_buf;
	int i;
	struct bsc_oml_host *bsc_oml_host;

	vty_out(vty, "bts %u%s", bts->nr, VTY_NEWLINE);
	if (bts->description)
		vty_out(vty, " description %s%s", bts->description, VTY_NEWLINE);
	vty_out(vty, " band %s%s", gsm_band_name(bts->band), VTY_NEWLINE);
	if (bts->auto_band)
		vty_out(vty, " auto-band%s", VTY_NEWLINE);
	vty_out(vty, " ipa unit-id %u %u%s",
		bts->ip_access.site_id, bts->ip_access.bts_id, VTY_NEWLINE);
	llist_for_each_entry(bsc_oml_host, &bts->bsc_oml_hosts, list)
		vty_out(vty, " oml remote-ip %s%s", bsc_oml_host->addr, VTY_NEWLINE);
	vty_out(vty, " rtp jitter-buffer %u", bts->rtp_jitter_buf_ms);
	if (bts->rtp_jitter_adaptive)
		vty_out(vty, " adaptive");
	vty_out(vty, "%s", VTY_NEWLINE);
	vty_out(vty, " rtp port-range %u %u%s", bts->rtp_port_range_start,
		bts->rtp_port_range_end, VTY_NEWLINE);
	if (bts->rtp_ip_dscp != -1)
		vty_out(vty, " rtp ip-dscp %d%s", bts->rtp_ip_dscp, VTY_NEWLINE);
	if (bts->rtp_priority != -1)
		vty_out(vty, " rtp socket-priority %d%s", bts->rtp_priority, VTY_NEWLINE);
	/* We write out "rtp library" setting only when it differs from the
	 * default.  This policy is necessary in order to make the new default
	 * take effect for 'indifferent' users when we change it - and finally,
	 * this vty setting will disappear altogether when we eventually drop
	 * ortp support and make twrtp mandatory.
	 * In the meantime, however, extra attention is required to keep
	 * the following code in sync with changes in the default!
	 */
#ifdef HAVE_ORTP
	if (bts->use_twrtp)
		vty_out(vty, " rtp library twrtp%s", VTY_NEWLINE);
#endif
	if (bts->rtp_nogaps_mode)
		vty_out(vty, " rtp continuous-streaming%s", VTY_NEWLINE);
	vty_out(vty, " %srtp internal-uplink-ecu%s",
		bts->use_ul_ecu ? "" : "no ", VTY_NEWLINE);
	vty_out(vty, " rtp hr-format %s%s",
		bts->emit_hr_rfc5993 ? "rfc5993" : "ts101318", VTY_NEWLINE);
	vty_out(vty, " paging queue-size %u%s", paging_get_queue_max(bts->paging_state),
		VTY_NEWLINE);
	vty_out(vty, " paging lifetime %u%s", paging_get_lifetime(bts->paging_state),
		VTY_NEWLINE);

	/* Fall-back MS Power Control parameters may be changed by the user */
	config_write_dpc_params(vty, "uplink", &bts->ms_dpc_params);

	if (bts->agch_queue.thresh_level != GSM_BTS_AGCH_QUEUE_THRESH_LEVEL_DEFAULT
		 || bts->agch_queue.low_level != GSM_BTS_AGCH_QUEUE_LOW_LEVEL_DEFAULT
		 || bts->agch_queue.high_level != GSM_BTS_AGCH_QUEUE_HIGH_LEVEL_DEFAULT)
		vty_out(vty, " agch-queue-mgmt threshold %d low %d high %d%s",
			bts->agch_queue.thresh_level, bts->agch_queue.low_level,
			bts->agch_queue.high_level, VTY_NEWLINE);

	if (bts->gsmtap.remote_host != NULL)
		vty_out(vty, " gsmtap-remote-host %s%s",
			bts->gsmtap.remote_host,
			VTY_NEWLINE);
	if (bts->gsmtap.local_host != NULL)
		vty_out(vty, " gsmtap-local-host %s%s",
			bts->gsmtap.local_host,
			VTY_NEWLINE);
	for (i = 0; i < sizeof(uint32_t) * 8; i++) {
		if (bts->gsmtap.sapi_mask & ((uint32_t) 1 << i)) {
			sapi_buf = get_value_string_or_null(gsmtap_sapi_names, i);
			if (sapi_buf == NULL)
				continue;
			sapi_buf = osmo_str_tolower(sapi_buf);
			vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE);
		}
	}
	if (bts->gsmtap.sapi_acch) {
		sapi_buf = osmo_str_tolower(get_value_string(gsmtap_sapi_names, GSMTAP_CHANNEL_ACCH));
		vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE);
	}
	if (bts->gsmtap.rlp) {
		if (bts->gsmtap.rlp_skip_null)
			vty_out(vty, " gsmtap-rlp skip-null%s", VTY_NEWLINE);
		else
			vty_out(vty, " gsmtap-rlp%s", VTY_NEWLINE);
	}
	vty_out(vty, " min-qual-rach %d%s", bts->min_qual_rach,
		VTY_NEWLINE);
	vty_out(vty, " min-qual-norm %d%s", bts->min_qual_norm,
		VTY_NEWLINE);
	vty_out(vty, " max-ber10k-rach %u%s", bts->max_ber10k_rach,
		VTY_NEWLINE);
	if (strcmp(bts->pcu.sock_path, PCU_SOCK_DEFAULT))
		vty_out(vty, " pcu-socket %s%s", bts->pcu.sock_path, VTY_NEWLINE);
	if (bts->pcu.sock_wqueue_len_max != BTS_CFG_PCU_SOCK_WQUEUE_LEN_MAX_MAX)
		vty_out(vty, " pcu-socket-wqueue-length %u%s", bts->pcu.sock_wqueue_len_max, VTY_NEWLINE);
	if (bts->supp_meas_toa256)
		vty_out(vty, " supp-meas-info toa256%s", VTY_NEWLINE);
	vty_out(vty, " smscb queue-max-length %d%s", bts->smscb_queue_max_len, VTY_NEWLINE);
	vty_out(vty, " smscb queue-target-length %d%s", bts->smscb_queue_tgt_len, VTY_NEWLINE);
	vty_out(vty, " smscb queue-hysteresis %d%s", bts->smscb_queue_hyst, VTY_NEWLINE);

	config_write_osmux(vty, " ", bts);
	vty_out(vty, " twjit%s", VTY_NEWLINE);
	osmo_twjit_config_write(vty, bts->twjit_cfg, " ");

	bts_model_config_write_bts(vty, bts);

	llist_for_each_entry(trx, &bts->trx_list, list) {
		const struct trx_power_params *tpp = &trx->power_params;
		const struct phy_instance *pinst = trx_phy_instance(trx);
		vty_out(vty, " trx %u%s", trx->nr, VTY_NEWLINE);

		if (tpp->user_gain_mdB)
			vty_out(vty, "  user-gain %u mdB%s",
				tpp->user_gain_mdB, VTY_NEWLINE);
		vty_out(vty, "  power-ramp max-initial %d mdBm%s",
			tpp->ramp.max_initial_pout_mdBm, VTY_NEWLINE);
		vty_out(vty, "  power-ramp step-size %d mdB%s",
			tpp->ramp.step_size_mdB, VTY_NEWLINE);
		vty_out(vty, "  power-ramp step-interval %d%s",
			tpp->ramp.step_interval_sec, VTY_NEWLINE);
		vty_out(vty, "  ms-power-control %s%s",
			trx->ms_pwr_ctl_soft ? "osmo" : "dsp",
			VTY_NEWLINE);
		vty_out(vty, "  ta-control interval %u%s",
			trx->ta_ctrl_interval, VTY_NEWLINE);
		vty_out(vty, "  phy %u instance %u%s", pinst->phy_link->num,
			pinst->num, VTY_NEWLINE);

		bts_model_config_write_trx(vty, trx);
	}
}

static int config_write_bts(struct vty *vty)
{
	const struct gsm_bts *bts;

	llist_for_each_entry(bts, &g_bts_sm->bts_list, list)
		config_write_bts_single(vty, bts);

	osmo_tdef_vty_groups_write(vty, "");
	return CMD_SUCCESS;
}

static void config_write_phy_single(struct vty *vty, const struct phy_link *plink)
{
	int i;

	vty_out(vty, "phy %u%s", plink->num, VTY_NEWLINE);
	bts_model_config_write_phy(vty, plink);

	for (i = 0; i < 255; i++) {
		const struct phy_instance *pinst = phy_instance_by_num(plink, i);
		if (!pinst)
			break;
		vty_out(vty, " instance %u%s", pinst->num, VTY_NEWLINE);
		bts_model_config_write_phy_inst(vty, pinst);
	}
}

static int config_write_phy(struct vty *vty)
{
	int i;

	for (i = 0; i < 255; i++) {
		const struct phy_link *plink = phy_link_by_num(i);
		if (!plink)
			break;
		config_write_phy_single(vty, plink);
	}

	return CMD_SUCCESS;
}

static int config_write_dummy(struct vty *vty)
{
	return CMD_SUCCESS;
}

DEFUN(cfg_vty_telnet_port, cfg_vty_telnet_port_cmd,
	"vty telnet-port <0-65535>",
	VTY_STR "Set the VTY telnet port\n"
	"TCP Port number\n")
{
	g_vty_port_num = atoi(argv[0]);
	return CMD_SUCCESS;
}

/* per-BTS configuration */
DEFUN_ATTR(cfg_bts,
	   cfg_bts_cmd,
	   "bts BTS_NR",
	   "Select a BTS to configure\n"
	   "BTS Number\n",
	   CMD_ATTR_IMMEDIATE)
{
	int bts_nr = atoi(argv[0]);
	struct gsm_bts *bts;

	if (bts_nr >= g_bts_sm->num_bts) {
		vty_out(vty, "%% Unknown BTS number %u (num %u)%s",
			bts_nr, g_bts_sm->num_bts, VTY_NEWLINE);
		return CMD_WARNING;
	} else
		bts = gsm_bts_num(g_bts_sm, bts_nr);

	vty->index = bts;
	vty->index_sub = &bts->description;
	vty->node = BTS_NODE;

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_unit_id,
      cfg_bts_unit_id_cmd,
      "ipa unit-id <0-65534> <0-255>",
      "ip.access RSL commands\n"
      "Set the Unit ID of this BTS\n"
      "Site ID\n" "Unit ID\n")
{
	struct gsm_bts *bts = vty->index;
	int site_id = atoi(argv[0]);
	int bts_id = atoi(argv[1]);

	bts->ip_access.site_id = site_id;
	bts->ip_access.bts_id = bts_id;

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_band,
      cfg_bts_band_cmd,
      "band (450|GSM450|480|GSM480|750|GSM750|810|GSM810|850|GSM850|900|GSM900|1800|DCS1800|1900|PCS1900)",
      "Set the frequency band of this BTS\n"
      "Alias for GSM450\n450Mhz\n"
      "Alias for GSM480\n480Mhz\n"
      "Alias for GSM750\n750Mhz\n"
      "Alias for GSM810\n810Mhz\n"
      "Alias for GSM850\n850Mhz\n"
      "Alias for GSM900\n900Mhz\n"
      "Alias for DCS1800\n1800Mhz\n"
      "Alias for PCS1900\n1900Mhz\n")
{
	struct gsm_bts *bts = vty->index;
	int band = gsm_band_parse(argv[0]);

	/* This should not happen with the recent versions of libosmovty,
	 * but old versions may pass incomplete choice values like 'GSM9'. */
	if (band < 0) {
		vty_out(vty, "%% BAND '%s' is not a valid GSM band%s",
			argv[0], VTY_NEWLINE);
		return CMD_WARNING;
	}

	bts->band = band;

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_oml_ip,
      cfg_bts_oml_ip_cmd,
      "oml remote-ip A.B.C.D",
      "OML Parameters\n" "OML IP Address\n" "OML IP Address\n")
{
	struct gsm_bts *bts = vty->index;
	struct bsc_oml_host *bsc_oml_host;

	/* stop when the address is already in the list */
	llist_for_each_entry(bsc_oml_host, &bts->bsc_oml_hosts, list) {
		if (strcmp(argv[0], bsc_oml_host->addr) == 0) {
			vty_out(vty, "%% duplicate BSC (A-Bis/OML) ip address configured ('%s')%s",
				argv[0], VTY_NEWLINE);
			return CMD_WARNING;
		}
	}

	bsc_oml_host = talloc_zero(bts, struct bsc_oml_host);
	OSMO_ASSERT(bsc_oml_host);
	bsc_oml_host->addr = talloc_strdup(bsc_oml_host, argv[0]);
	OSMO_ASSERT(bsc_oml_host->addr);
	llist_add_tail(&bsc_oml_host->list, &bts->bsc_oml_hosts);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_no_oml_ip,
      cfg_bts_no_oml_ip_cmd,
      "no oml remote-ip A.B.C.D",
      NO_STR "OML Parameters\n" "OML IP Address\n" "OML IP Address\n")
{
	struct gsm_bts *bts = vty->index;
	struct bsc_oml_host *bsc_oml_host;
	struct bsc_oml_host *bsc_oml_host_del = NULL;

	llist_for_each_entry(bsc_oml_host, &bts->bsc_oml_hosts, list) {
		if (strcmp(argv[0], bsc_oml_host->addr) == 0)
			bsc_oml_host_del = bsc_oml_host;
	}

	if (bsc_oml_host_del) {
		if (bts->abis_link_fi) {
			osmo_fsm_inst_dispatch(bts->abis_link_fi, ABIS_LINK_EV_VTY_RM_ADDR, bsc_oml_host_del);
			llist_del(&bsc_oml_host_del->list);
			talloc_free(bsc_oml_host_del);
		}
	} else {
		vty_out(vty, "%% no such BSC (A-Bis/OML) ip address configured ('%s')%s",
			argv[0], VTY_NEWLINE);
		return CMD_WARNING;
	}

	return CMD_SUCCESS;
}

#define RTP_STR "RTP parameters\n"

DEFUN_DEPRECATED(cfg_bts_rtp_bind_ip,
      cfg_bts_rtp_bind_ip_cmd,
      "rtp bind-ip A.B.C.D",
      RTP_STR "RTP local bind IP Address\n" "RTP local bind IP Address\n")
{
	vty_out(vty, "%% rtp bind-ip is now deprecated%s", VTY_NEWLINE);

	return CMD_WARNING;
}

DEFUN_USRATTR(cfg_bts_rtp_jitbuf,
	      cfg_bts_rtp_jitbuf_cmd,
	      X(BTS_VTY_ATTR_NEW_LCHAN),
	      "rtp jitter-buffer <0-10000> [adaptive]",
	      RTP_STR "RTP jitter buffer\n"
	      "Jitter buffer in ms\n"
	      "Enable adaptive RTP jitter buffering\n")
{
	struct gsm_bts *bts = vty->index;

	bts->rtp_jitter_buf_ms = atoi(argv[0]);
	if (argc > 1)
		bts->rtp_jitter_adaptive = true;

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_rtp_port_range,
      cfg_bts_rtp_port_range_cmd,
      "rtp port-range <1-65534> <1-65534>",
      RTP_STR "Range of local ports to use for RTP/RTCP traffic\n"
      "Port range start (inclusive)\n" "Port range end (inclusive)\n")
{
	struct gsm_bts *bts = vty->index;
	unsigned int start;
	unsigned int end;

	start = atoi(argv[0]);
	end = atoi(argv[1]);

	if (end < start) {
		vty_out(vty, "%% Range end port (%u) must be greater than the range start port (%u)!%s",
			end, start, VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (start & 1) {
		vty_out(vty, "%% Range must begin at an even port number! (%u is odd)%s",
			start, VTY_NEWLINE);
		return CMD_WARNING;
	}

	if ((end & 1) == 0) {
		vty_out(vty, "%% Range must end at an odd port number! (%u is even)%s",
			end, VTY_NEWLINE);
		return CMD_WARNING;
	}

	bts->rtp_port_range_start = start;
	bts->rtp_port_range_end = end;
	bts->rtp_port_range_next = bts->rtp_port_range_start;

	return CMD_SUCCESS;
}

DEFUN_USRATTR(cfg_bts_rtp_ip_dscp,
	      cfg_bts_rtp_ip_dscp_cmd,
	      X(BTS_VTY_ATTR_NEW_LCHAN),
	      "rtp ip-dscp <0-63>",
	      RTP_STR "Specify DSCP for RTP/IP packets\n" "The DSCP value (upper 6 bits of TOS)\n")
{
	struct gsm_bts *bts = vty->index;
	int dscp = atoi(argv[0]);

	bts->rtp_ip_dscp = dscp;

	return CMD_SUCCESS;
}

DEFUN_USRATTR(cfg_bts_rtp_priority,
	      cfg_bts_rtp_priority_cmd,
	      X(BTS_VTY_ATTR_NEW_LCHAN),
	      "rtp socket-priority <0-255>",
	      RTP_STR "Specify socket priority for RTP/IP packets\n"
	      "The socket priority value (> 6 requires CAP_NET_ADMIN)\n")
{
	struct gsm_bts *bts = vty->index;
	int prio = atoi(argv[0]);

	bts->rtp_priority = prio;

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_rtp_library,
	   cfg_bts_rtp_library_cmd,
	   "rtp library (ortp|twrtp)",
	   RTP_STR "RTP library selection\n"
	   "Belledonne ortp\n" "Themyscira twrtp\n",
	   BTS_VTY_ATTR_NEW_LCHAN)
{
	struct gsm_bts *bts = vty->index;
	bool use_twrtp;

	use_twrtp = !strcmp(argv[0], "twrtp");
#ifndef HAVE_ORTP
	if (!use_twrtp) {
		vty_out(vty,
			"%% Error: OsmoBTS was built without ortp support%s",
			VTY_NEWLINE);
		return CMD_WARNING;
	}
#endif
	bts->use_twrtp = use_twrtp;
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_rtp_cont_stream,
      cfg_bts_rtp_cont_stream_cmd,
      "rtp continuous-streaming",
      RTP_STR "Always emit an RTP packet every 20 ms\n")
{
	struct gsm_bts *bts = vty->index;

	bts->rtp_nogaps_mode = true;
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_no_rtp_cont_stream,
      cfg_bts_no_rtp_cont_stream_cmd,
      "no rtp continuous-streaming",
      NO_STR RTP_STR "Always emit an RTP packet every 20 ms\n")
{
	struct gsm_bts *bts = vty->index;

	bts->rtp_nogaps_mode = false;
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_rtp_int_ul_ecu,
      cfg_bts_rtp_int_ul_ecu_cmd,
      "rtp internal-uplink-ecu",
      RTP_STR "Apply a BTS-internal ECU to the uplink traffic frame stream\n")
{
	struct gsm_bts *bts = vty->index;

	bts->use_ul_ecu = true;
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_no_rtp_int_ul_ecu,
      cfg_bts_no_rtp_int_ul_ecu_cmd,
      "no rtp internal-uplink-ecu",
      NO_STR RTP_STR "Apply a BTS-internal ECU to the uplink traffic frame stream\n")
{
	struct gsm_bts *bts = vty->index;

	bts->use_ul_ecu = false;
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_rtp_hr_format,
	   cfg_bts_rtp_hr_format_cmd,
	   "rtp hr-format (rfc5993|ts101318)",
	   RTP_STR "HRv1 codec output format\n" "RFC 5993\n" "TS 101 318\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->emit_hr_rfc5993 = !strcmp(argv[0], "rfc5993");
	return CMD_SUCCESS;
}

#define PAG_STR "Paging related parameters\n"

DEFUN_ATTR(cfg_bts_paging_queue_size,
	   cfg_bts_paging_queue_size_cmd,
	   "paging queue-size <1-1024>",
	   PAG_STR "Maximum length of BTS-internal paging queue\n"
	   "Maximum length of BTS-internal paging queue (default " OSMO_STRINGIFY_VAL(NUM_PAGING_MAX_DEFAULT) ")\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	paging_set_queue_max(bts->paging_state, atoi(argv[0]));

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_paging_lifetime,
	   cfg_bts_paging_lifetime_cmd,
	   "paging lifetime <0-60>",
	   PAG_STR "Maximum lifetime of a paging record\n"
	   "Maximum lifetime of a paging record (secods)\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	paging_set_lifetime(bts->paging_state, atoi(argv[0]));

	return CMD_SUCCESS;
}

#define AGCH_QUEUE_STR "AGCH queue mgmt\n"

DEFUN_ATTR(cfg_bts_agch_queue_mgmt_params,
	   cfg_bts_agch_queue_mgmt_params_cmd,
	   "agch-queue-mgmt threshold <0-100> low <0-100> high <0-100000>",
	   AGCH_QUEUE_STR
	   "Threshold to start cleanup\nin % of the maximum queue length\n"
	   "Low water mark for cleanup\nin % of the maximum queue length\n"
	   "High water mark for cleanup\nin % of the maximum queue length\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->agch_queue.thresh_level = atoi(argv[0]);
	bts->agch_queue.low_level = atoi(argv[1]);
	bts->agch_queue.high_level = atoi(argv[2]);

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_agch_queue_mgmt_default,
	   cfg_bts_agch_queue_mgmt_default_cmd,
	   "agch-queue-mgmt default",
	   AGCH_QUEUE_STR
	   "Reset clean parameters to default values\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->agch_queue.thresh_level = GSM_BTS_AGCH_QUEUE_THRESH_LEVEL_DEFAULT;
	bts->agch_queue.low_level = GSM_BTS_AGCH_QUEUE_LOW_LEVEL_DEFAULT;
	bts->agch_queue.high_level = GSM_BTS_AGCH_QUEUE_HIGH_LEVEL_DEFAULT;

	return CMD_SUCCESS;
}

#define UL_POWER_TARGET_CMD \
	"uplink-power-target <-110-0>"
#define UL_POWER_TARGET_CMD_DESC \
	"Set the nominal target Rx Level for uplink power control loop\n" \
	"Target uplink Rx level in dBm\n"

#define UL_POWER_DEPR_MSG(fmt, args...) \
	vty_out(vty, "%% Command '%s' has been deprecated.%s" \
		     "%% MS/BS Power control parameters should be configured in osmo-bsc: " \
		     fmt, self->string, VTY_NEWLINE, ##args)

DEFUN_ATTR(cfg_bts_ul_power_target, cfg_bts_ul_power_target_cmd,
	   UL_POWER_TARGET_CMD, UL_POWER_TARGET_CMD_DESC,
	   CMD_ATTR_DEPRECATED)
{
	struct gsm_power_ctrl_meas_params *mp;
	struct gsm_bts *bts = vty->index;
	int rxlev_dbm = atoi(argv[0]);
	int hyst = 0;

	if (argc > 1) /* optional argument */
		hyst = atoi(argv[1]);

	mp = &bts->ms_dpc_params.rxlev_meas;
	mp->lower_thresh = dbm2rxlev(rxlev_dbm - hyst);
	mp->upper_thresh = dbm2rxlev(rxlev_dbm + hyst);

	UL_POWER_DEPR_MSG("use 'rxlev-thresh lower %u upper %u'.%s",
			  mp->lower_thresh, mp->upper_thresh,
			  VTY_NEWLINE);

	return CMD_SUCCESS;
}

/* FIXME: libosmovty is unable to handle 'foo <-110-0> [bar <1-25>]' */
DEFUN_CMD_ELEMENT(cfg_bts_ul_power_target,
		  cfg_bts_ul_power_target_hysteresis_cmd,
		  UL_POWER_TARGET_CMD " hysteresis <1-25>",
		  UL_POWER_TARGET_CMD_DESC
		  "Target Rx Level hysteresis\n"
		  "Tolerable deviation in dBm\n",
		  CMD_ATTR_DEPRECATED, 0);

DEFUN_ATTR(cfg_no_bts_ul_power_filter,
	   cfg_bts_no_ul_power_filter_cmd,
	   "no uplink-power-filtering",
	   NO_STR "Disable filtering for uplink power control loop\n",
	   CMD_ATTR_DEPRECATED)
{
	struct gsm_power_ctrl_meas_params *mp;
	struct gsm_bts *bts = vty->index;

	mp = &bts->ms_dpc_params.rxlev_meas;
	mp->algo = GSM_PWR_CTRL_MEAS_AVG_ALGO_NONE;

	UL_POWER_DEPR_MSG("use 'no rxlev-avg'.%s", VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_ul_power_filter_ewma,
	   cfg_bts_ul_power_filter_ewma_cmd,
	   "uplink-power-filtering algo ewma beta <1-99>",
	   "Configure filtering for uplink power control loop\n"
	   "Select the filtering algorithm\n"
	   "Exponentially Weighted Moving Average (EWMA)\n"
	   "Smoothing factor (in %): beta = (100 - alpha)\n"
	   "1% - lowest smoothing, 99% - highest smoothing\n",
	   CMD_ATTR_DEPRECATED)
{
	struct gsm_power_ctrl_meas_params *mp;
	struct gsm_bts *bts = vty->index;

	mp = &bts->ms_dpc_params.rxlev_meas;
	mp->algo = GSM_PWR_CTRL_MEAS_AVG_ALGO_OSMO_EWMA;
	mp->ewma.alpha = 100 - atoi(argv[0]);

	UL_POWER_DEPR_MSG("use 'rxlev-avg algo osmo-ewma beta %s'.%s",
			  argv[0], VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_min_qual_rach, cfg_bts_min_qual_rach_cmd,
	   "min-qual-rach <-100-100>",
	   "Set the minimum link quality level of Access Bursts to be accepted\n"
	   "C/I (Carrier-to-Interference) ratio in centiBels (10e-2 B or 10e-1 dB)\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->min_qual_rach = atoi(argv[0]);

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_min_qual_norm, cfg_bts_min_qual_norm_cmd,
	   "min-qual-norm <-100-100>",
	   "Set the minimum link quality level of Normal Bursts to be accepted\n"
	   "C/I (Carrier-to-Interference) ratio in centiBels (10e-2 B or 10e-1 dB)\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->min_qual_norm = atoi(argv[0]);

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_max_ber_rach, cfg_bts_max_ber_rach_cmd,
	   "max-ber10k-rach <0-10000>",
	   "Set the maximum BER for valid RACH requests\n"
	   "BER in 1/10000 units (0=no BER; 100=1% BER)\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->max_ber10k_rach = strtoul(argv[0], NULL, 10);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_pcu_sock_path, cfg_bts_pcu_sock_path_cmd,
	"pcu-socket PATH",
	"Configure the PCU socket file/path name\n"
	"UNIX socket path\n")
{
	struct gsm_bts *bts = vty->index;

	osmo_talloc_replace_string(bts, &bts->pcu.sock_path, argv[0]);

	/* FIXME: re-open the interface? */
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_pcu_sock_ql, cfg_bts_pcu_sock_ql_cmd,
	"pcu-socket-wqueue-length <1-" OSMO_STRINGIFY_VAL(BTS_CFG_PCU_SOCK_WQUEUE_LEN_MAX_MAX) ">",
	"Configure the PCU socket queue length\n"
	"Queue length\n")
{
	struct gsm_bts *bts = vty->index;
	bts->pcu.sock_wqueue_len_max = atoi(argv[0]);
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_supp_meas_toa256, cfg_bts_supp_meas_toa256_cmd,
	   "supp-meas-info toa256",
	   "Configure the RSL Supplementary Measurement Info\n"
	   "Report the TOA in 1/256th symbol periods\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->supp_meas_toa256 = true;
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_no_supp_meas_toa256, cfg_bts_no_supp_meas_toa256_cmd,
	   "no supp-meas-info toa256",
	   NO_STR "Configure the RSL Supplementary Measurement Info\n"
	   "Report the TOA in 1/256th symbol periods\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;

	bts->supp_meas_toa256 = false;
	return CMD_SUCCESS;
}

#define SMSCB_STR \
	"SMSCB (SMS Cell Broadcast) / CBCH configuration\n"

DEFUN_ATTR(cfg_bts_smscb_max_qlen, cfg_bts_smscb_max_qlen_cmd,
	   "smscb queue-max-length <1-60>",
	   SMSCB_STR "Maximum length of the SMSCB (CBCH) queue\n"
	   "Length in count of messages/pages (default: 15)\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;
	bts->smscb_queue_max_len = atoi(argv[0]);
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_smscb_tgt_qlen, cfg_bts_smscb_tgt_qlen_cmd,
	   "smscb queue-target-length <1-30>",
	   SMSCB_STR "Target length of the SMSCB (CBCH) queue\n"
	   "Length in count of messages/pages (default: 2)\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;
	bts->smscb_queue_tgt_len = atoi(argv[0]);
	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_bts_smscb_qhyst, cfg_bts_smscb_qhyst_cmd,
	   "smscb queue-hysteresis <0-30>",
	   SMSCB_STR "Hysteresis of the SMSCB (CBCH) queue\n"
	   "In count of messages/pages (default: 2)\n",
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts *bts = vty->index;
	bts->smscb_queue_hyst = atoi(argv[0]);
	return CMD_SUCCESS;
}


#define DB_MDB_STR 							\
	"Unit is dB (decibels)\n"					\
	"Unit is mdB (milli-decibels, or rather 1/10000 bel)\n"

static int parse_mdbm(const char *valstr, const char *unit)
{
	int val = atoi(valstr);

	if (!strcmp(unit, "dB") || !strcmp(unit, "dBm"))
		return val * 1000;
	else
		return val;
}

DEFUN_ATTR(cfg_trx_user_gain,
	   cfg_trx_user_gain_cmd,
	   "user-gain <-100000-100000> (dB|mdB)",
	   "Inform BTS about additional, user-provided gain or attenuation at TRX output\n"
	   "Value of user-provided external gain(+)/attenuation(-)\n" DB_MDB_STR,
	   CMD_ATTR_IMMEDIATE)
{
	struct gsm_bts_trx *trx = vty->index;

	trx->power_params.user_gain_mdB = parse_mdbm(argv[0], argv[1]);

	return CMD_SUCCESS;
}

#define PR_STR "Power-Ramp settings\n"
DEFUN(cfg_trx_pr_max_initial, cfg_trx_pr_max_initial_cmd,
	"power-ramp max-initial <-10000-100000> (dBm|mdBm)",
	PR_STR "Maximum initial power\n"
	"Value\n" DB_MDB_STR)
{
	struct gsm_bts_trx *trx = vty->index;

	trx->power_params.ramp.max_initial_pout_mdBm =
				parse_mdbm(argv[0], argv[1]);

	return CMD_SUCCESS;
}

DEFUN(cfg_trx_pr_step_size, cfg_trx_pr_step_size_cmd,
	"power-ramp step-size <1-100000> (dB|mdB)",
	PR_STR "Power increase by step\n"
	"Step size\n" DB_MDB_STR)
{
	struct gsm_bts_trx *trx = vty->index;

	trx->power_params.ramp.step_size_mdB =
				parse_mdbm(argv[0], argv[1]);
	return CMD_SUCCESS;
}

DEFUN(cfg_trx_pr_step_interval, cfg_trx_pr_step_interval_cmd,
	"power-ramp step-interval <1-100>",
	PR_STR "Power increase by step\n"
	"Step time in seconds\n")
{
	struct gsm_bts_trx *trx = vty->index;

	trx->power_params.ramp.step_interval_sec = atoi(argv[0]);
	return CMD_SUCCESS;
}

DEFUN(cfg_trx_ms_power_control, cfg_trx_ms_power_control_cmd,
	"ms-power-control (dsp|osmo)",
	"Mobile Station Power Level Control\n"
	"Handled by DSP\n" "Handled by OsmoBTS\n")
{
	struct gsm_bts_trx *trx = vty->index;
	bool soft = !strcmp(argv[0], "osmo");

	if (!soft && !bts_internal_flag_get(trx->bts, BTS_INTERNAL_FLAG_MS_PWR_CTRL_DSP)) {
		/* NOTE: osmo-bts-trx used to have its own (low-level) MS Power Control loop, which
		 * has been ripped out in favour of the common implementation. Configuration files
		 * may still contain 'dsp', so let's be tolerant and override 'dsp' by 'osmo'. */
		if (trx->bts->variant == BTS_OSMO_TRX && vty->type == VTY_FILE) {
			vty_out(vty, "%% BTS model 'osmo-bts-trx' has no DSP/HW MS Power Control support, "
				     "consider updating your configuration file!%s", VTY_NEWLINE);
			soft = true; /* override */
		} else {
			vty_out(vty, "%% This BTS model has no DSP/HW MS Power Control support%s", VTY_NEWLINE);
			return CMD_WARNING;
		}
	}

	trx->ms_pwr_ctl_soft = soft;
	return CMD_SUCCESS;
}

DEFUN(cfg_ta_ctrl_interval, cfg_ta_ctrl_interval_cmd,
	"ta-control interval <0-31>",
	"Timing Advance Control Parameters\n"
	"Set TA control loop interval\n"
	"As in P_CON_INTERVAL, in units of 2 SACCH periods (0.96 seconds) (default=0, every SACCH block)\n")
{
	struct gsm_bts_trx *trx = vty->index;

	trx->ta_ctrl_interval = atoi(argv[0]);

	return CMD_SUCCESS;
}

DEFUN(cfg_trx_phy, cfg_trx_phy_cmd,
	"phy <0-255> instance <0-255>",
	"Configure PHY Link+Instance for this TRX\n"
	"PHY Link number\n" "PHY instance\n" "PHY Instance number")
{
	struct gsm_bts_trx *trx = vty->index;
	struct phy_link *plink = phy_link_by_num(atoi(argv[0]));
	struct phy_instance *pinst;

	if (!plink) {
		vty_out(vty, "%% phy%s does not exist%s",
			argv[0], VTY_NEWLINE);
		return CMD_WARNING;
	}

	pinst = phy_instance_by_num(plink, atoi(argv[1]));
	if (!pinst) {
		vty_out(vty, "%% phy%s instance %s does not exit%s",
			argv[0], argv[1], VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (pinst->trx != NULL) {
		vty_out(vty, "%% phy%s instance %s is already bound to %s%s",
			argv[0], argv[1], gsm_trx_name(pinst->trx), VTY_NEWLINE);
		return CMD_WARNING;
	}

	phy_instance_link_to_trx(pinst, trx);

	return CMD_SUCCESS;
}

/* ======================================================================
 * SHOW
 * ======================================================================*/

static void net_dump_nmstate(struct vty *vty, const struct gsm_nm_state *nms)
{
	vty_out(vty,"Oper '%s', Admin '%s', Avail '%s'%s",
		abis_nm_opstate_name(nms->operational),
		get_value_string(abis_nm_adm_state_names, nms->administrative),
		abis_nm_avail_name(nms->availability), VTY_NEWLINE);
}

static void bts_dump_vty_features(struct vty *vty, const struct gsm_bts *bts)
{
	unsigned int i;
	bool no_features;

	vty_out(vty, "  Features:%s", VTY_NEWLINE);

	for (i = 0, no_features = true; i < _NUM_BTS_FEAT; i++) {
		if (osmo_bts_has_feature(bts->features, i)) {
			vty_out(vty, "    %03u ", i);
			vty_out(vty, "%-40s%s", osmo_bts_features_desc(i), VTY_NEWLINE);
			no_features = false;
		}
	}

	if (no_features)
		vty_out(vty, "    (not available)%s", VTY_NEWLINE);

	vty_out(vty, "  BTS model specific (internal) flags:%s", VTY_NEWLINE);

	for (i = 0, no_features = true; i < _BTS_INTERNAL_FLAG_NUM; i++) {
		if (bts_internal_flag_get(bts, i)) {
			vty_out(vty, "    %03u ", i);
			vty_out(vty, "%-40s%s", get_value_string(bts_impl_flag_desc, i), VTY_NEWLINE);
			no_features = false;
		}
	}

	if (no_features)
		vty_out(vty, "    (not available)%s", VTY_NEWLINE);
}

static const char *stringify_radio_link_timeout(int val)
{
	static char buf[32];
	if (val == -1)
		snprintf(buf, sizeof(buf), "%s", "infinite");
	else
		snprintf(buf, sizeof(buf), "%d SACCH blocks", val);
	return buf;
}

static void bts_dump_vty(struct vty *vty, const struct gsm_bts *bts)
{
	const struct gsm_bts_trx *trx;

	vty_out(vty, "BTS %u is of type '%s', in band %s, has CI %u LAC %u, "
		"BSIC %u and %u TRX%s",
		bts->nr, btsvariant2str(bts->variant),
		gsm_band_name(bts->band),
		bts->cell_identity,
		bts->location_area_code, bts->bsic,
		bts->num_trx, VTY_NEWLINE);
	vty_out(vty, "  Description: %s%s",
		bts->description ? bts->description : "(null)", VTY_NEWLINE);
	vty_out(vty, "  Unit ID: %u/%u/0, OML Stream ID 0x%02x%s",
			bts->ip_access.site_id, bts->ip_access.bts_id,
			bts->oml_link ? bts->oml_link->tei : 0x00,
			VTY_NEWLINE);
	vty_out(vty, "  NM State: ");
	net_dump_nmstate(vty, &bts->mo.nm_state);
	vty_out(vty, "  Site Mgr NM State: ");
	net_dump_nmstate(vty, &g_bts_sm->mo.nm_state);
	if (strnlen(bts->pcu_version, MAX_VERSION_LENGTH))
		vty_out(vty, "  PCU version %s connected%s",
			bts->pcu_version, VTY_NEWLINE);
	vty_out(vty, "  Paging: Queue size %u, occupied %u, lifetime %us%s",
		paging_get_queue_max(bts->paging_state), paging_queue_length(bts->paging_state),
		paging_get_lifetime(bts->paging_state), VTY_NEWLINE);
	vty_out(vty, "  AGCH: Queue limit %u, occupied %d, "
		"dropped %"PRIu64", merged %"PRIu64", rejected %"PRIu64", "
		"ag-res %"PRIu64", non-res %"PRIu64"%s",
		bts->agch_queue.max_length, bts->agch_queue.length,
		bts->agch_queue.dropped_msgs, bts->agch_queue.merged_msgs,
		bts->agch_queue.rejected_msgs, bts->agch_queue.agch_msgs,
		bts->agch_queue.pch_msgs,
		VTY_NEWLINE);
	vty_out(vty, "  CBCH queue target: %d, hysteresis: %d, maximum: %d%s",
		bts->smscb_queue_tgt_len, bts->smscb_queue_max_len, bts->smscb_queue_hyst, VTY_NEWLINE);
	vty_out(vty, "  CBCH backlog queue length (BASIC): %d%s",
		bts->smscb_basic.queue_len, VTY_NEWLINE);
	vty_out(vty, "  CBCH backlog queue length (EXTENDED): %u%s",
		bts->smscb_extended.queue_len, VTY_NEWLINE);
	vty_out(vty, "  Paging: queue length %d, buffer space %d%s",
		paging_queue_length(bts->paging_state), paging_buffer_space(bts->paging_state),
		VTY_NEWLINE);
	vty_out(vty, "  OML Link state: %s.%s",
		bts->oml_link ? "connected" : "disconnected", VTY_NEWLINE);
	vty_out(vty, "  PH-RTS.ind FN advance average: %d, min: %d, max: %d%s",
		bts_get_avg_fn_advance(bts), bts->fn_stats.min, bts->fn_stats.max, VTY_NEWLINE);
	vty_out(vty, "  Radio Link Timeout (OML): %s%s",
		stringify_radio_link_timeout(bts->radio_link_timeout.oml), VTY_NEWLINE);
	if (bts->radio_link_timeout.vty_override) {
		vty_out(vty, "  Radio Link Timeout (OVERRIDE): %s%s",
			stringify_radio_link_timeout(bts->radio_link_timeout.current), VTY_NEWLINE);
	}
	if (bts->c0_power_red_db > 0) {
		vty_out(vty, "  BCCH carrier power reduction: %u dB%s",
			bts->c0_power_red_db, VTY_NEWLINE);
	}

	llist_for_each_entry(trx, &bts->trx_list, list) {
		const struct phy_instance *pinst = trx_phy_instance(trx);
		vty_out(vty, "  TRX %u%s", trx->nr, VTY_NEWLINE);
		if (pinst) {
			vty_out(vty, "    phy %d %s", pinst->num, pinst->version);
			if (pinst->description)
				vty_out(vty, " (%s)", pinst->description);
			vty_out(vty, "%s", VTY_NEWLINE);
		}
	}

	bts_dump_vty_features(vty, bts);
	vty_out_rate_ctr_group(vty, "  ", bts->ctrs);
}


DEFUN(show_bts, show_bts_cmd, "show bts [<0-255>]",
      SHOW_STR "Display information about a BTS\n"
      BTS_NR_STR)
{
	int bts_nr;

	if (argc != 0) {
		/* use the BTS number that the user has specified */
		bts_nr = atoi(argv[0]);
		if (bts_nr >= g_bts_sm->num_bts) {
			vty_out(vty, "%% can't find BTS '%s'%s", argv[0],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		bts_dump_vty(vty, gsm_bts_num(g_bts_sm, bts_nr));
		return CMD_SUCCESS;
	}
	/* print all BTS's */
	for (bts_nr = 0; bts_nr < g_bts_sm->num_bts; bts_nr++)
		bts_dump_vty(vty, gsm_bts_num(g_bts_sm, bts_nr));

	return CMD_SUCCESS;
}

static void gprs_dump_vty(struct vty *vty, const struct gsm_bts *bts)
{
	unsigned int i;
	const struct gsm_gprs_nse *nse = &bts->site_mgr->gprs.nse;

	/* GPRS parameters received from the BSC */
	vty_out(vty, "BTS %u, RAC %u, NSEI %u, BVCI %u%s",
		bts->nr, bts->gprs.rac,
		nse->nsei,
		bts->gprs.cell.bvci,
		VTY_NEWLINE);

	vty_out(vty, "  Cell NM state: ");
	net_dump_nmstate(vty, &bts->gprs.cell.mo.nm_state);
	vty_out(vty, "  NSE NM state: ");
	net_dump_nmstate(vty, &nse->mo.nm_state);

	for (i = 0; i < ARRAY_SIZE(nse->nsvc); i++) {
		const struct gsm_gprs_nsvc *nsvc = &nse->nsvc[i];

		vty_out(vty, "  NSVC%u (NSVCI %u) NM state: ", i, nsvc->nsvci);
		net_dump_nmstate(vty, &nsvc->mo.nm_state);

		if (nsvc->mo.nm_state.operational == NM_OPSTATE_ENABLED) {
			struct osmo_sockaddr_str remote;
			struct osmo_sockaddr_str local;

			if (osmo_sockaddr_str_from_sockaddr(&remote, &nsvc->remote.u.sas) != 0)
				remote = (struct osmo_sockaddr_str) { .ip = "<INVALID>" };
			if (osmo_sockaddr_str_from_sockaddr(&local, &nsvc->local.u.sas) != 0)
				local = (struct osmo_sockaddr_str) { .ip = "<INVALID>" };

			/* Work around for over-defensiveness of OSMO_SOCKADDR_STR_FMT_ARGS():
			 *  error: the address of ‘remote’ will always evaluate as ‘true’
			 *  error: the address of ‘local’ will always evaluate as ‘true’ */
			const struct osmo_sockaddr_str *r = &remote;
			const struct osmo_sockaddr_str *l = &local;

			/* Getting remote/local address info has never been so easy, right? */
			vty_out(vty, "    Address: r=" OSMO_SOCKADDR_STR_FMT
					       "<->l=" OSMO_SOCKADDR_STR_FMT "%s",
				OSMO_SOCKADDR_STR_FMT_ARGS(r),
				OSMO_SOCKADDR_STR_FMT_ARGS(l),
				VTY_NEWLINE);
		}
	}
}

DEFUN(show_bts_gprs, show_bts_gprs_cmd,
      "show bts <0-255> gprs",
      SHOW_STR "Display information about a BTS\n"
      BTS_NR_STR "GPRS/EGPRS configuration\n")
{
	const struct gsm_bts *bts;

	bts = gsm_bts_num(g_bts_sm, atoi(argv[0]));
	if (bts == NULL) {
		vty_out(vty, "%% can't find BTS '%s'%s",
			argv[0], VTY_NEWLINE);
		return CMD_WARNING;
	}

	/* TODO: also print info about PCUIF connection */
	gprs_dump_vty(vty, bts);
	return CMD_SUCCESS;
}

/* "show running-config" cannot reliably indicate which RTP library is
 * selected because we have to omit "rtp library" setting when it matches
 * the default, and that default is expected to change as we progress
 * toward eventual removal of ortp.  This additional show command
 * allows an operator to see unambiguously which RTP library is in use.
 */
DEFUN(show_bts_rtp, show_bts_rtp_cmd,
      "show bts <0-255> rtp",
      SHOW_STR "Display information about a BTS\n"
      BTS_NR_STR "RTP library selection\n")
{
	const struct gsm_bts *bts;

	bts = gsm_bts_num(g_bts_sm, atoi(argv[0]));
	if (bts == NULL) {
		vty_out(vty, "%% can't find BTS '%s'%s",
			argv[0], VTY_NEWLINE);
		return CMD_WARNING;
	}

	vty_out(vty, "RTP library: %s%s",
		bts->use_twrtp ? "Themyscira twrtp" : "Belledonne ortp",
		VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN(test_send_failure_event_report, test_send_failure_event_report_cmd, "test send-failure-event-report <0-255>",
      "Various testing commands\n"
      "Send a test OML failure event report to the BSC\n" BTS_NR_STR)
{
	int bts_nr = atoi(argv[0]);
	const struct gsm_bts *bts;

	if (bts_nr >= g_bts_sm->num_bts) {
		vty_out(vty, "%% can't find BTS '%s'%s", argv[0], VTY_NEWLINE);
		return CMD_WARNING;
	}

	bts = gsm_bts_num(g_bts_sm, bts_nr);
	oml_tx_failure_event_rep(&bts->mo, NM_SEVER_MINOR, OSMO_EVT_WARN_SW_WARN, "test message sent from VTY");

	return CMD_SUCCESS;
}

DEFUN_HIDDEN(radio_link_timeout, radio_link_timeout_cmd, "bts <0-0> radio-link-timeout (oml|infinite|<4-64>)",
		"BTS Specific Commands\n" BTS_NR_STR "Manually override Radio Link Timeout\n"
		"Use value provided by BSC via A-bis OML (Connection Failure Criterion)\n"
		"Use infinite timeout (DANGEROUS: only use during testing!)\n"
		"Number of lost SACCH blocks\n")
{
	int bts_nr = atoi(argv[0]);
	struct gsm_bts *bts = gsm_bts_num(g_bts_sm, bts_nr);

	if (!bts) {
		vty_out(vty, "%% can't find BTS '%s'%s", argv[0], VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (!strcmp(argv[1], "oml")) {
		bts->radio_link_timeout.current = bts->radio_link_timeout.oml;
		bts->radio_link_timeout.vty_override = false;
	} else if (!strcmp(argv[1], "infinite")) {
		bts->radio_link_timeout.current = -1;
		bts->radio_link_timeout.vty_override = true;
		vty_out(vty, "%% INFINITE RADIO LINK TIMEOUT, USE ONLY FOR BTS RF TESTING%s", VTY_NEWLINE);
	} else {
		bts->radio_link_timeout.current = atoi(argv[1]);
		bts->radio_link_timeout.vty_override = true;
	}

	return CMD_SUCCESS;
}

DEFUN(bts_c0_power_red,
      bts_c0_power_red_cmd,
      "bts <0-0> c0-power-red <0-6>",
      "BTS Specific Commands\n" BTS_NR_STR
      "BCCH carrier power reduction operation\n"
      "Power reduction value (in dB, even numbers only)\n")
{
	const int bts_nr = atoi(argv[0]);
	const int red = atoi(argv[1]);
	struct gsm_bts *bts;

	bts = gsm_bts_num(g_bts_sm, atoi(argv[0]));
	if (bts == NULL) {
		vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (red % 2 != 0) {
		vty_out(vty, "%% Incorrect BCCH power reduction value, "
			"an even number is expected%s", VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (bts_set_c0_pwr_red(bts, red) != 0) {
		vty_out(vty, "%% BCCH carrier power reduction operation mode "
			"is not supported for BTS (%d)%s", bts_nr, VTY_NEWLINE);
		return CMD_WARNING;
	}

	return CMD_SUCCESS;
}

/* TODO: generalize and move indention handling to libosmocore */
#define cfg_out(vty, fmt, args...) \
	vty_out(vty, "%*s" fmt, indent, "", ##args)

static void dump_dpc_meas_params(struct vty *vty, const unsigned int indent,
				 const struct gsm_power_ctrl_meas_params *mp,
				 const char *pname, const unsigned int pn)
{
	cfg_out(vty, "Lower threshold (L_%s_XX_P): %u%s",
		pname, mp->lower_thresh, VTY_NEWLINE);
	cfg_out(vty, "Upper threshold (U_%s_XX_P): %u%s",
		pname, mp->upper_thresh, VTY_NEWLINE);

	cfg_out(vty, "Lower threshold comparators: P%u=%02u / N%u=%02u%s",
		pn, mp->lower_cmp_p, pn, mp->lower_cmp_n, VTY_NEWLINE);
	cfg_out(vty, "Upper threshold comparators: P%u=%02u / N%u=%02u%s",
		pn + 1, mp->upper_cmp_p, pn + 1, mp->upper_cmp_n, VTY_NEWLINE);

	cfg_out(vty, "Pre-processing algorithm: ");
	switch (mp->algo) {
	case GSM_PWR_CTRL_MEAS_AVG_ALGO_UNWEIGHTED:
		vty_out(vty, "unweighted average%s", VTY_NEWLINE);
		break;
	case GSM_PWR_CTRL_MEAS_AVG_ALGO_WEIGHTED:
		vty_out(vty, "weighted average%s", VTY_NEWLINE);
		break;
	case GSM_PWR_CTRL_MEAS_AVG_ALGO_MOD_MEDIAN:
		vty_out(vty, "modified median%s", VTY_NEWLINE);
		break;
	case GSM_PWR_CTRL_MEAS_AVG_ALGO_OSMO_EWMA:
		vty_out(vty, "EWMA (alpha=%u)%s",
			mp->ewma.alpha, VTY_NEWLINE);
		break;
	case GSM_PWR_CTRL_MEAS_AVG_ALGO_NONE:
		vty_out(vty, "disabled (pass-through)%s", VTY_NEWLINE);
		return;
	default:
		vty_out(vty, "unknown%s", VTY_NEWLINE);
		return;
	}

	cfg_out(vty, "Pre-processing parameters: Hreqave=%u / Hreqt=%u%s",
		mp->h_reqave, mp->h_reqt, VTY_NEWLINE);
}

static void dump_dpc_params(struct vty *vty, const unsigned int indent,
			    const struct gsm_power_ctrl_params *cp, bool uplink)
{
	cfg_out(vty, "Power control interval: %u ms (every %u SACCH block(s))%s",
		cp->ctrl_interval ? cp->ctrl_interval * 2 * 480 : 480,
		cp->ctrl_interval ? cp->ctrl_interval * 2 : 1,
		VTY_NEWLINE);

	cfg_out(vty, "Power increase step size: %u%s",
		cp->inc_step_size_db, VTY_NEWLINE);
	cfg_out(vty, "Power reduce step size: %u%s",
		cp->red_step_size_db, VTY_NEWLINE);

	cfg_out(vty, "RxLev measurement processing:%s", VTY_NEWLINE);
	dump_dpc_meas_params(vty, indent + 2, &cp->rxlev_meas, "RXLEV", 1);

	cfg_out(vty, "RxQual measurement processing:%s", VTY_NEWLINE);
	dump_dpc_meas_params(vty, indent + 2, &cp->rxqual_meas, "RXQUAL", 3);

	if (uplink) {
		cfg_out(vty, "C/I measurement processing (FR/EFR):%s", VTY_NEWLINE);
		dump_dpc_meas_params(vty, indent + 2, &cp->ci_fr_meas, "CI_FR", 0);

		cfg_out(vty, "C/I measurement processing (HR):%s", VTY_NEWLINE);
		dump_dpc_meas_params(vty, indent + 2, &cp->ci_hr_meas, "CI_HR", 0);

		cfg_out(vty, "C/I measurement processing (AMR-FR):%s", VTY_NEWLINE);
		dump_dpc_meas_params(vty, indent + 2, &cp->ci_amr_fr_meas, "CI_AMR_FR", 0);

		cfg_out(vty, "C/I measurement processing (AMR-HR):%s", VTY_NEWLINE);
		dump_dpc_meas_params(vty, indent + 2, &cp->ci_amr_hr_meas, "CI_AMR_HR", 0);

		cfg_out(vty, "C/I measurement processing (SDCCH):%s", VTY_NEWLINE);
		dump_dpc_meas_params(vty, indent + 2, &cp->ci_sdcch_meas, "CI_SDCCH", 0);

		cfg_out(vty, "C/I measurement processing (GPRS):%s", VTY_NEWLINE);
		dump_dpc_meas_params(vty, indent + 2, &cp->ci_gprs_meas, "CI_GPRS", 0);
	}
}

static void trx_dump_vty(struct vty *vty, const struct gsm_bts_trx *trx)
{
	vty_out(vty, "TRX %u of BTS %u is on ARFCN %u%s",
		trx->nr, trx->bts->nr, trx->arfcn, VTY_NEWLINE);
	vty_out(vty, "Description: %s%s",
		trx->description ? trx->description : "(null)", VTY_NEWLINE);
	vty_out(vty, "  RF Nominal Power: %d dBm, reduced by %u dB, "
		"resulting BS power: %d dBm%s",
		trx->nominal_power, trx->max_power_red,
		trx->nominal_power - trx->max_power_red, VTY_NEWLINE);

	vty_out(vty, "  BS Power control parameters (%s):%s",
		trx->bs_dpc_params == &trx->bts->bs_dpc_params ?
			"fall-back" : "from BSC",
		VTY_NEWLINE);
	dump_dpc_params(vty, 4, trx->bs_dpc_params, false);

	vty_out(vty, "  MS Power control parameters (%s):%s",
		trx->ms_dpc_params == &trx->bts->ms_dpc_params ?
			"fall-back" : "from BSC",
		VTY_NEWLINE);
	dump_dpc_params(vty, 4, trx->ms_dpc_params, true);

	vty_out(vty, "  NM State: ");
	net_dump_nmstate(vty, &trx->mo.nm_state);
	vty_out(vty, "  RSL State: %s%s", trx->bb_transc.rsl.link ? "connected" : "disconnected", VTY_NEWLINE);
	vty_out(vty, "  Baseband Transceiver NM State: ");
	net_dump_nmstate(vty, &trx->bb_transc.mo.nm_state);
	vty_out(vty, "  IPA stream ID: 0x%02x%s", trx->bb_transc.rsl.tei, VTY_NEWLINE);
}

static inline void print_all_trx(struct vty *vty, const struct gsm_bts *bts)
{
	uint8_t trx_nr;
	for (trx_nr = 0; trx_nr < bts->num_trx; trx_nr++)
		trx_dump_vty(vty, gsm_bts_trx_num(bts, trx_nr));
}

DEFUN(show_trx,
      show_trx_cmd,
      "show trx [<0-255>] [<0-255>]",
	SHOW_STR "Display information about a TRX\n"
	BTS_TRX_STR)
{
	const struct gsm_bts *bts = NULL;
	int bts_nr, trx_nr;

	if (argc >= 1) {
		/* use the BTS number that the user has specified */
		bts_nr = atoi(argv[0]);
		if (bts_nr >= g_bts_sm->num_bts) {
			vty_out(vty, "%% can't find BTS '%s'%s", argv[0],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		bts = gsm_bts_num(g_bts_sm, bts_nr);
	}
	if (argc >= 2) {
		trx_nr = atoi(argv[1]);
		if (trx_nr >= bts->num_trx) {
			vty_out(vty, "%% can't find TRX '%s'%s", argv[1],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		trx_dump_vty(vty, gsm_bts_trx_num(bts, trx_nr));
		return CMD_SUCCESS;
	}
	if (bts) {
		/* print all TRX in this BTS */
		print_all_trx(vty, bts);
		return CMD_SUCCESS;
	}

	for (bts_nr = 0; bts_nr < g_bts_sm->num_bts; bts_nr++)
		print_all_trx(vty, gsm_bts_num(g_bts_sm, bts_nr));

	return CMD_SUCCESS;
}


static void ts_dump_vty(struct vty *vty, const struct gsm_bts_trx_ts *ts)
{
	vty_out(vty, "BTS %u, TRX %u, Timeslot %u, phys cfg %s, TSC %u",
		ts->trx->bts->nr, ts->trx->nr, ts->nr,
		gsm_pchan_name(ts->pchan), ts->tsc);
	if (ts->pchan == GSM_PCHAN_TCH_F_PDCH)
		vty_out(vty, " (%s mode)",
			ts->flags & TS_F_PDCH_ACTIVE ? "PDCH" : "TCH/F");
	vty_out(vty, "%s", VTY_NEWLINE);
	vty_out(vty, "  NM State: ");
	net_dump_nmstate(vty, &ts->mo.nm_state);
}

DEFUN(show_ts,
      show_ts_cmd,
      "show timeslot [<0-255>] [<0-255>] [<0-7>]",
	SHOW_STR "Display information about a TS\n"
	BTS_TRX_TS_STR)
{
	const struct gsm_bts *bts = NULL;
	const struct gsm_bts_trx *trx = NULL;
	const struct gsm_bts_trx_ts *ts = NULL;
	int bts_nr, trx_nr, ts_nr;

	if (argc >= 1) {
		/* use the BTS number that the user has specified */
		bts_nr = atoi(argv[0]);
		if (bts_nr >= g_bts_sm->num_bts) {
			vty_out(vty, "%% can't find BTS '%s'%s", argv[0],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		bts = gsm_bts_num(g_bts_sm, bts_nr);
	}
	if (argc >= 2) {
		trx_nr = atoi(argv[1]);
		if (trx_nr >= bts->num_trx) {
			vty_out(vty, "%% can't find TRX '%s'%s", argv[1],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		trx = gsm_bts_trx_num(bts, trx_nr);
	}
	if (argc >= 3) {
		ts_nr = atoi(argv[2]);
		if (ts_nr >= TRX_NR_TS) {
			vty_out(vty, "%% can't find TS '%s'%s", argv[2],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		/* Fully Specified: print and exit */
		ts = &trx->ts[ts_nr];
		ts_dump_vty(vty, ts);
		return CMD_SUCCESS;
	}

	if (bts && trx) {
		/* Iterate over all TS in this TRX */
		for (ts_nr = 0; ts_nr < TRX_NR_TS; ts_nr++) {
			ts = &trx->ts[ts_nr];
			ts_dump_vty(vty, ts);
		}
	} else if (bts) {
		/* Iterate over all TRX in this BTS, TS in each TRX */
		for (trx_nr = 0; trx_nr < bts->num_trx; trx_nr++) {
			trx = gsm_bts_trx_num(bts, trx_nr);
			for (ts_nr = 0; ts_nr < TRX_NR_TS; ts_nr++) {
				ts = &trx->ts[ts_nr];
				ts_dump_vty(vty, ts);
			}
		}
	} else {
		/* Iterate over all BTS, TRX in each BTS, TS in each TRX */
		for (bts_nr = 0; bts_nr < g_bts_sm->num_bts; bts_nr++) {
			bts = gsm_bts_num(g_bts_sm, bts_nr);
			for (trx_nr = 0; trx_nr < bts->num_trx; trx_nr++) {
				trx = gsm_bts_trx_num(bts, trx_nr);
				for (ts_nr = 0; ts_nr < TRX_NR_TS; ts_nr++) {
					ts = &trx->ts[ts_nr];
					ts_dump_vty(vty, ts);
				}
			}
		}
	}

	return CMD_SUCCESS;
}

/* call vty_out() to print a string like " as TCH/H" for dynamic timeslots.
 * Don't do anything if the ts is not dynamic. */
static void vty_out_dyn_ts_status(struct vty *vty, const struct gsm_bts_trx_ts *ts)
{
	switch (ts->pchan) {
	case GSM_PCHAN_OSMO_DYN:
		if (ts->dyn.pchan_is == ts->dyn.pchan_want)
			vty_out(vty, " as %s",
				gsm_pchan_name(ts->dyn.pchan_is));
		else
			vty_out(vty, " switching %s -> %s",
				gsm_pchan_name(ts->dyn.pchan_is),
				gsm_pchan_name(ts->dyn.pchan_want));
		break;
	case GSM_PCHAN_TCH_F_PDCH:
		if ((ts->flags & TS_F_PDCH_PENDING_MASK) == 0)
			vty_out(vty, " as %s",
				(ts->flags & TS_F_PDCH_ACTIVE)? "PDCH"
							      : "TCH/F");
		else
			vty_out(vty, " switching %s -> %s",
				(ts->flags & TS_F_PDCH_ACTIVE)? "PDCH"
							      : "TCH/F",
				(ts->flags & TS_F_PDCH_ACT_PENDING)? "PDCH"
								   : "TCH/F");
		break;
	default:
		/* no dyn ts */
		break;
	}
}

static void lchan_bs_power_ctrl_state_dump(struct vty *vty, unsigned int indent,
					   const struct gsm_lchan *lchan)
{
	const struct lchan_power_ctrl_state *st = &lchan->bs_power_ctrl;
	const struct gsm_bts_trx *trx = lchan->ts->trx;

	cfg_out(vty, "BS (Downlink) Power Control (%s mode):%s",
		st->dpc_enabled ? "dynamic" : "static", VTY_NEWLINE);
	indent += 2;

	cfg_out(vty, "Channel reduction: %u dB", st->current);
	if (st->dpc_enabled)
		vty_out(vty, " (max %u dB)", st->max);
	vty_out(vty, "%s", VTY_NEWLINE);

	cfg_out(vty, "TRX reduction: %u dB%s",
		trx->max_power_red, VTY_NEWLINE);

	int actual = trx->nominal_power - (trx->max_power_red + st->current);
	cfg_out(vty, "Actual / Nominal power: %d dBm / %d dBm%s",
		actual, trx->nominal_power, VTY_NEWLINE);

	if (!st->dpc_enabled)
		return;

	cfg_out(vty, "Power Control parameters:%s", VTY_NEWLINE);
	dump_dpc_params(vty, indent + 2, &st->dpc_params, false);
}

static void lchan_ms_power_ctrl_state_dump(struct vty *vty, unsigned int indent,
					   const struct gsm_lchan *lchan)
{
	const struct lchan_power_ctrl_state *st = &lchan->ms_power_ctrl;
	const struct gsm_bts_trx *trx = lchan->ts->trx;

	cfg_out(vty, "MS (Uplink) Power Control (%s):%s",
		st->dpc_enabled ? "dynamic" : "static", VTY_NEWLINE);
	indent += 2;

	int current_dbm = ms_pwr_dbm(trx->bts->band, st->current);
	int max_dbm = ms_pwr_dbm(trx->bts->band, st->max);

	cfg_out(vty, "Current power level: %u, %d dBm",
		st->current, current_dbm);
	if (st->dpc_enabled)
		vty_out(vty, " (max %u, %d dBm)", st->max, max_dbm);
	vty_out(vty, "%s", VTY_NEWLINE);

	if (!st->dpc_enabled)
		return;

	cfg_out(vty, "Power Control parameters:%s", VTY_NEWLINE);
	dump_dpc_params(vty, indent + 2, &st->dpc_params, true);
}

static void lchan_acch_rep_state_dump(struct vty *vty, unsigned int indent,
				      const struct gsm_lchan *lchan)
{
	cfg_out(vty, "ACCH repetition:%s", VTY_NEWLINE);
	indent += 2;
	if (lchan->rep_acch_cap.rxqual)
		cfg_out(vty, "Enable RXQUAL threshold: %u%s",
			lchan->rep_acch_cap.rxqual, VTY_NEWLINE);
	else
		cfg_out(vty, "Enable RXQUAL threshold: (none, alway on)%s",
			VTY_NEWLINE);

	cfg_out(vty, "DL-FACCH:%s", VTY_NEWLINE);
	indent += 2;
	if (lchan->rep_acch_cap.dl_facch_all)
		cfg_out(vty, "retramsit all LAPDM block types%s", VTY_NEWLINE);
	else if (lchan->rep_acch_cap.dl_facch_cmd)
		cfg_out(vty, "retramsit only LAPDM command blocks%s",
			VTY_NEWLINE);
	else
		cfg_out(vty, "no retransmission (disabled)%s", VTY_NEWLINE);
	if (lchan->rep_acch.dl_facch_active)
		cfg_out(vty, "retransmission currently active%s", VTY_NEWLINE);
	else
		cfg_out(vty, "retransmission currently inactive%s",
			VTY_NEWLINE);
	indent -= 2;

	cfg_out(vty, "DL-SACCH:%s", VTY_NEWLINE);
	indent += 2;
	if (lchan->rep_acch_cap.ul_sacch)
		cfg_out(vty, "retramsit all SACCH blocks for SAPI=0%s",
			VTY_NEWLINE);
	else
		cfg_out(vty, "no retransmission (disabled)%s", VTY_NEWLINE);
	if (lchan->rep_acch.dl_sacch_active)
		cfg_out(vty, "retransmission currently active%s", VTY_NEWLINE);
	else
		cfg_out(vty, "retransmission currently inactive%s",
			VTY_NEWLINE);
	indent -= 2;

	cfg_out(vty, "UL-SACCH:%s", VTY_NEWLINE);
	indent += 2;
	if (lchan->rep_acch_cap.dl_sacch)
		cfg_out(vty, "retramsit all SACCH blocks for SAPI=0%s",
			VTY_NEWLINE);
	else
		cfg_out(vty, "no retransmission (disabled)%s", VTY_NEWLINE);
	if (lchan->rep_acch.ul_sacch_active)
		cfg_out(vty, "retransmission currently active%s", VTY_NEWLINE);
	else
		cfg_out(vty, "retransmission currently inactive%s",
			VTY_NEWLINE);
	indent -= 2;
}

static void lchan_acch_top_state_dump(struct vty *vty, unsigned int indent,
				      const struct gsm_lchan *lchan)
{
	if (lchan->top_acch_cap.overpower_db == 0)
		return;

	cfg_out(vty, "Temporary ACCH overpower:%s", VTY_NEWLINE);
	indent += 2;

	cfg_out(vty, "Overpower value: %u dB%s",
		lchan->top_acch_cap.overpower_db, VTY_NEWLINE);

	cfg_out(vty, "SACCH overpower: %sabled%s",
		lchan->top_acch_cap.sacch_enable ? "en" : "dis",
		VTY_NEWLINE);
	cfg_out(vty, "FACCH overpower: %sabled%s",
		lchan->top_acch_cap.facch_enable ? "en" : "dis",
		VTY_NEWLINE);

	if (lchan->top_acch_cap.rxqual == 0) {
		cfg_out(vty, "RxQual threshold: disabled "
			"(overpower is always on)%s", VTY_NEWLINE);
	} else {
		cfg_out(vty, "RxQual threshold: %u%s",
			lchan->top_acch_cap.rxqual, VTY_NEWLINE);
	}
}

static void lchan_dump_full_vty(struct vty *vty, const struct gsm_lchan *lchan)
{
	struct in_addr ia;

	vty_out(vty, "BTS %u, TRX %u, Timeslot %u (%s), Lchan %u: Type %s%s",
		lchan->ts->trx->bts->nr, lchan->ts->trx->nr, lchan->ts->nr,
		lchan->ts->vamos.is_shadow ? "shadow" : "primary",
		lchan->nr, gsm_lchant_name(lchan->type), VTY_NEWLINE);
	/* show dyn TS details, if applicable */
	switch (lchan->ts->pchan) {
	case GSM_PCHAN_OSMO_DYN:
		vty_out(vty, "  Osmocom Dyn TS:");
		vty_out_dyn_ts_status(vty, lchan->ts);
		vty_out(vty, VTY_NEWLINE);
		break;
	case GSM_PCHAN_TCH_F_PDCH:
		vty_out(vty, "  IPACC Dyn PDCH TS:");
		vty_out_dyn_ts_status(vty, lchan->ts);
		vty_out(vty, VTY_NEWLINE);
		break;
	default:
		/* no dyn ts */
		break;
	}
	vty_out(vty, "  State: %s%s%s%s",
		gsm_lchans_name(lchan->state),
		lchan->state == LCHAN_S_BROKEN ? " Error reason: " : "",
		lchan->state == LCHAN_S_BROKEN ? lchan->broken_reason : "",
		VTY_NEWLINE);
	vty_out(vty, "  Channel Mode / Codec: %s%s",
		gsm48_chan_mode_name(lchan->tch_mode),
		VTY_NEWLINE);
	if (lchan->rsl_cmode == RSL_CMOD_SPD_DATA) {
		vty_out(vty, "  CSD mode: %s%s",
			lchan_csd_mode_desc(lchan->csd_mode),
			VTY_NEWLINE);
	}
	if (lchan->tch_mode == GSM48_CMODE_SPEECH_AMR) {
		const struct amr_multirate_conf *amr_mrc = &lchan->tch.amr_mr;
		const struct gsm48_multi_rate_conf *mr_conf =
			(const struct gsm48_multi_rate_conf *) amr_mrc->gsm48_ie;
		vty_out(vty, "  AMR Multi-Rate Configuration: ICMI=%u, Start Mode=%u gsm48=%02x%02x%s",
			mr_conf->icmi, mr_conf->smod, amr_mrc->gsm48_ie[0], amr_mrc->gsm48_ie[1], VTY_NEWLINE);
		for (uint8_t i = 0; i < amr_mrc->num_modes; i++) {
			const struct amr_mode *amode = &amr_mrc->mode[i];
			vty_out(vty, "    AMR Mode %u (%s), threshold=%u, hysteresis=%u%s",
				amode->mode, osmo_amr_type_name(amode->mode),
				amode->threshold, amode->hysteresis, VTY_NEWLINE);
		}
	}

	if (lchan->abis_ip.bound_ip) {
		ia.s_addr = htonl(lchan->abis_ip.bound_ip);
		vty_out(vty, "  Bound IP: %s Port %u CONN_ID=%u",
			inet_ntoa(ia), lchan->abis_ip.bound_port,
			lchan->abis_ip.conn_id);
		if (lchan->abis_ip.osmux.use)
			vty_out(vty, " Osmux_CID=%u%s", lchan->abis_ip.osmux.local_cid, VTY_NEWLINE);
		else
			vty_out(vty, " RTP_TYPE2=%u%s", lchan->abis_ip.rtp_payload2, VTY_NEWLINE);
	}
	if (lchan->abis_ip.connect_ip) {
		ia.s_addr = htonl(lchan->abis_ip.connect_ip);
		vty_out(vty, "  Conn. IP: %s Port %u SPEECH_MODE=0x%02x",
			inet_ntoa(ia), lchan->abis_ip.connect_port,
			lchan->abis_ip.speech_mode);
		if (lchan->abis_ip.osmux.use)
			vty_out(vty, " Osmux_CID=%u%s", lchan->abis_ip.osmux.remote_cid, VTY_NEWLINE);
		else
			vty_out(vty, " RTP_TYPE=%u%s", lchan->abis_ip.rtp_payload, VTY_NEWLINE);
	}
#define LAPDM_ESTABLISHED(link, sapi_idx) \
		(link).datalink[sapi_idx].dl.state == LAPD_STATE_MF_EST
	vty_out(vty, "  LAPDm SAPIs: DCCH %c%c, SACCH %c%c%s",
		LAPDM_ESTABLISHED(lchan->lapdm_ch.lapdm_dcch, DL_SAPI0) ? '0' : '-',
		LAPDM_ESTABLISHED(lchan->lapdm_ch.lapdm_dcch, DL_SAPI3) ? '3' : '-',
		LAPDM_ESTABLISHED(lchan->lapdm_ch.lapdm_acch, DL_SAPI0) ? '0' : '-',
		LAPDM_ESTABLISHED(lchan->lapdm_ch.lapdm_acch, DL_SAPI3) ? '3' : '-',
		VTY_NEWLINE);
#undef LAPDM_ESTABLISHED
	vty_out(vty, "  Valid System Information: 0x%08x%s",
		lchan->si.valid, VTY_NEWLINE);
	/* TODO: L1 SAPI (but those are BTS speific :( */
	/* TODO: AMR bits */
	vty_out(vty, "  MS Timing Offset: %d, propagation delay: %d symbols %s",
		lchan->ms_t_offs, lchan->p_offs, VTY_NEWLINE);
	if (lchan->encr.alg_id) {
		vty_out(vty, "  Ciphering A5/%u State: %s, N(S)=%u%s",
			lchan->encr.alg_id-1, lchan_ciph_state_name(lchan->ciph_state),
			lchan->ciph_ns, VTY_NEWLINE);
	}
	if (lchan->loopback)
		vty_out(vty, "  RTP/PDCH Loopback Enabled%s", VTY_NEWLINE);
	vty_out(vty, "  Radio Link Failure Counter 'S': %d%s", lchan->s, VTY_NEWLINE);

	/* Interference levels */
	if (lchan->meas.interf_meas_avg_dbm != 0) {
		vty_out(vty, "  Interference: %d dBm (band %d)%s",
			lchan->meas.interf_meas_avg_dbm,
			lchan->meas.interf_band,
			VTY_NEWLINE);
	}

	/* BS/MS Power Control state and parameters */
	lchan_bs_power_ctrl_state_dump(vty, 2, lchan);
	lchan_ms_power_ctrl_state_dump(vty, 2, lchan);

	/* ACCH repetition / overpower state */
	lchan_acch_rep_state_dump(vty, 2, lchan);
	lchan_acch_top_state_dump(vty, 2, lchan);
}

static void lchan_dump_short_vty(struct vty *vty, const struct gsm_lchan *lchan)
{
	const struct gsm_meas_rep_unidir *mru = &lchan->meas.ul_res;

	vty_out(vty, "BTS %u, TRX %u, Timeslot %u (%s) %s",
		lchan->ts->trx->bts->nr, lchan->ts->trx->nr, lchan->ts->nr,
		lchan->ts->vamos.is_shadow ? "shadow" : "primary",
		gsm_pchan_name(lchan->ts->pchan));
	vty_out_dyn_ts_status(vty, lchan->ts);
	vty_out(vty, ", Lchan %u, Type %s, State %s - "
		"RXL-FULL-ul: %4d dBm%s",
		lchan->nr,
		gsm_lchant_name(lchan->type), gsm_lchans_name(lchan->state),
		rxlev2dbm(mru->full.rx_lev),
		VTY_NEWLINE);
}

static int dump_lchan_trx_ts(const struct gsm_bts_trx_ts *ts, struct vty *vty,
			     void (*dump_cb)(struct vty *, const struct gsm_lchan *))
{
	int lchan_nr;
	for (lchan_nr = 0; lchan_nr < TS_MAX_LCHAN; lchan_nr++) {
		const struct gsm_lchan *lchan = &ts->lchan[lchan_nr];
		if (lchan->state == LCHAN_S_NONE)
			continue;
		switch (lchan->type) {
		case GSM_LCHAN_SDCCH:
		case GSM_LCHAN_TCH_F:
		case GSM_LCHAN_TCH_H:
			dump_cb(vty, lchan);
			break;
		default:
			continue;
		}
	}

	return CMD_SUCCESS;
}

static int dump_lchan_trx(const struct gsm_bts_trx *trx, struct vty *vty,
			  void (*dump_cb)(struct vty *, const struct gsm_lchan *))
{
	int ts_nr;

	for (ts_nr = 0; ts_nr < TRX_NR_TS; ts_nr++) {
		const struct gsm_bts_trx_ts *ts = &trx->ts[ts_nr];
		dump_lchan_trx_ts(ts, vty, dump_cb);
		if (ts->vamos.peer != NULL) /* VAMOS: shadow timeslot */
			dump_lchan_trx_ts(ts->vamos.peer, vty, dump_cb);
	}

	return CMD_SUCCESS;
}

static int dump_lchan_bts(const struct gsm_bts *bts, struct vty *vty,
			  void (*dump_cb)(struct vty *, const struct gsm_lchan *))
{
	int trx_nr;

	for (trx_nr = 0; trx_nr < bts->num_trx; trx_nr++) {
		const struct gsm_bts_trx *trx = gsm_bts_trx_num(bts, trx_nr);
		dump_lchan_trx(trx, vty, dump_cb);
	}

	return CMD_SUCCESS;
}

static int lchan_summary(struct vty *vty, int argc, const char **argv,
			 void (*dump_cb)(struct vty *, const struct gsm_lchan *))
{
	const struct gsm_bts *bts = NULL; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */
	const struct gsm_bts_trx *trx = NULL; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */
	const struct gsm_bts_trx_ts *ts = NULL; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */
	const struct gsm_lchan *lchan;
	int bts_nr, trx_nr, ts_nr, lchan_nr;

	if (argc >= 1) {
		/* use the BTS number that the user has specified */
		bts_nr = atoi(argv[0]);
		if (bts_nr >= g_bts_sm->num_bts) {
			vty_out(vty, "%% can't find BTS %s%s", argv[0],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		bts = gsm_bts_num(g_bts_sm, bts_nr);

		if (argc == 1)
			return dump_lchan_bts(bts, vty, dump_cb);
	}
	if (argc >= 2) {
		trx_nr = atoi(argv[1]);
		if (trx_nr >= bts->num_trx) {
			vty_out(vty, "%% can't find TRX %s%s", argv[1],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		trx = gsm_bts_trx_num(bts, trx_nr);

		if (argc == 2)
			return dump_lchan_trx(trx, vty, dump_cb);
	}
	if (argc >= 3) {
		ts_nr = atoi(argv[2]);
		if (ts_nr >= TRX_NR_TS) {
			vty_out(vty, "%% can't find TS %s%s", argv[2],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		ts = &trx->ts[ts_nr];

		if (argc == 3)
			return dump_lchan_trx_ts(ts, vty, dump_cb);
	}
	if (argc >= 4) {
		lchan_nr = atoi(argv[3]);
		if (lchan_nr >= TS_MAX_LCHAN) {
			vty_out(vty, "%% can't find LCHAN %s%s", argv[3],
				VTY_NEWLINE);
			return CMD_WARNING;
		}
		lchan = &ts->lchan[lchan_nr];
		dump_cb(vty, lchan);
		return CMD_SUCCESS;
	}

	for (bts_nr = 0; bts_nr < g_bts_sm->num_bts; bts_nr++) {
		bts = gsm_bts_num(g_bts_sm, bts_nr);
		dump_lchan_bts(bts, vty, dump_cb);
	}

	return CMD_SUCCESS;
}

DEFUN(show_lchan,
	show_lchan_cmd,
	"show lchan [<0-255>] [<0-255>] [<0-7>] [<0-7>]",
	SHOW_STR "Display information about a logical channel\n"
	BTS_TRX_TS_LCHAN_STR)
{
	return lchan_summary(vty, argc, argv, lchan_dump_full_vty);
}

DEFUN(show_lchan_summary,
	show_lchan_summary_cmd,
	"show lchan summary [<0-255>] [<0-255>] [<0-7>] [<0-7>]",
	SHOW_STR "Display information about a logical channel\n"
	"Short summary\n"
	BTS_TRX_TS_LCHAN_STR)
{
	return lchan_summary(vty, argc, argv, lchan_dump_short_vty);
}

static struct gsm_lchan *resolve_lchan(const char **argv, int idx)
{
	int bts_nr = atoi(argv[idx+0]);
	int trx_nr = atoi(argv[idx+1]);
	int ts_nr = atoi(argv[idx+2]);
	bool shadow = argv[idx+3][0] == 's';
	int lchan_nr = atoi(argv[idx+4]);
	struct gsm_bts *bts;
	struct gsm_bts_trx *trx;
	struct gsm_bts_trx_ts *ts;

	bts = gsm_bts_num(g_bts_sm, bts_nr);
	if (!bts)
		return NULL;

	trx = gsm_bts_trx_num(bts, trx_nr);
	if (!trx)
		return NULL;

	if (ts_nr >= ARRAY_SIZE(trx->ts))
		return NULL;
	ts = &trx->ts[ts_nr];
	if (shadow) { /* VAMOS shadow */
		if (ts->vamos.peer == NULL)
			return NULL;
		ts = ts->vamos.peer;
	}

	if (lchan_nr >= ARRAY_SIZE(ts->lchan))
		return NULL;

	return &ts->lchan[lchan_nr];
}

#define BTS_T_T_L_CMD \
	"bts <0-0> trx <0-255> ts <0-7> (lchan|shadow-lchan) <0-7>"
#define BTS_T_T_L_STR			\
	"BTS related commands\n"	\
	"BTS number\n"			\
	"TRX related commands\n"	\
	"TRX number\n"			\
	"timeslot related commands\n"	\
	"timeslot number\n"		\
	"Primary logical channel commands\n"	\
	"Shadow logical channel commands\n"	\
	"logical channel number\n"

DEFUN(cfg_bts_gsmtap_remote_host,
      cfg_bts_gsmtap_remote_host_cmd,
      "gsmtap-remote-host [HOSTNAME]",
      "Enable GSMTAP Um logging (see also 'gsmtap-sapi')\n"
      "Remote IP address or hostname ('localhost' if omitted)\n")
{
	struct gsm_bts *bts = vty->index;

	osmo_talloc_replace_string(bts, &bts->gsmtap.remote_host,
				   argc > 0 ? argv[0] : "localhost");

	if (vty->type != VTY_FILE)
		vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_gsmtap_local_host,
      cfg_bts_gsmtap_local_host_cmd,
      "gsmtap-local-host HOSTNAME",
      "Enable local bind for GSMTAP Um logging (see also 'gsmtap-sapi')\n"
      "Local IP address or hostname\n")
{
	struct gsm_bts *bts = vty->index;

	osmo_talloc_replace_string(bts, &bts->gsmtap.local_host, argv[0]);

	if (vty->type != VTY_FILE)
		vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_no_gsmtap_remote_host,
      cfg_bts_no_gsmtap_remote_host_cmd,
      "no gsmtap-remote-host",
      NO_STR "Disable GSMTAP Um logging\n")
{
	struct gsm_bts *bts = vty->index;

	if (bts->gsmtap.remote_host != NULL)
		talloc_free(bts->gsmtap.remote_host);
	bts->gsmtap.remote_host = NULL;

	if (vty->type != VTY_FILE)
		vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_no_gsmtap_local_host,
      cfg_bts_no_gsmtap_local_host_cmd,
      "no gsmtap-local-host",
      NO_STR "Disable local bind for GSMTAP Um logging\n")
{
	struct gsm_bts *bts = vty->index;

	if (bts->gsmtap.local_host != NULL)
		talloc_free(bts->gsmtap.local_host);

	bts->gsmtap.local_host = NULL;

	if (vty->type != VTY_FILE)
		vty_out(vty, "%% This command requires restart%s", VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_gsmtap_sapi_all, cfg_bts_gsmtap_sapi_all_cmd,
	"gsmtap-sapi (enable-all|disable-all)",
	"Enable/disable sending of UL/DL messages over GSMTAP\n"
	"Enable all kinds of messages (all SAPI)\n"
	"Disable all kinds of messages (all SAPI)\n")
{
	struct gsm_bts *bts = vty->index;

	if (argv[0][0] == 'e') {
		bts->gsmtap.sapi_mask = UINT32_MAX;
		bts->gsmtap.sapi_acch = 1;
	} else {
		bts->gsmtap.sapi_mask = 0x00;
		bts->gsmtap.sapi_acch = 0;
	}

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_gsmtap_sapi, cfg_bts_gsmtap_sapi_cmd,
	"HIDDEN", "HIDDEN")
{
	struct gsm_bts *bts = vty->index;
	int sapi;

	sapi = get_string_value(gsmtap_sapi_names, argv[0]);
	OSMO_ASSERT(sapi >= 0);

	if (sapi == GSMTAP_CHANNEL_ACCH)
		bts->gsmtap.sapi_acch = 1;
	else
		bts->gsmtap.sapi_mask |= (1 << sapi);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_no_gsmtap_sapi, cfg_bts_no_gsmtap_sapi_cmd,
	"HIDDEN", "HIDDEN")
{
	struct gsm_bts *bts = vty->index;
	int sapi;

	sapi = get_string_value(gsmtap_sapi_names, argv[0]);
	OSMO_ASSERT(sapi >= 0);

	if (sapi == GSMTAP_CHANNEL_ACCH)
		bts->gsmtap.sapi_acch = 0;
	else
		bts->gsmtap.sapi_mask &= ~(1 << sapi);

	return CMD_SUCCESS;
}

DEFUN(cfg_bts_gsmtap_rlp, cfg_bts_gsmtap_rlp_cmd,
	"gsmtap-rlp [skip-null]",
	"Enable generation of GSMTAP frames for RLP (non-transparent CSD)\n"
	"Skip the generation of GSMTAP for RLP NULL frames\n")
{
	struct gsm_bts *bts = vty->index;
	bts->gsmtap.rlp = true;
	if (argc >= 1 && !strcmp(argv[0], "skip-null"))
		bts->gsmtap.rlp_skip_null = true;
	else
		bts->gsmtap.rlp_skip_null = false;
	return CMD_SUCCESS;
}

DEFUN(cfg_bts_no_gsmtap_rlp, cfg_bts_no_gsmtap_rlp_cmd,
	"no gsmtap-rlp",
	NO_STR "Disable generation of GSMTAP frames for RLP (non-transparent CSD)\n")
{
	struct gsm_bts *bts = vty->index;
	bts->gsmtap.rlp = false;
	return CMD_SUCCESS;
}

static struct cmd_node phy_node = {
	PHY_NODE,
	"%s(phy)# ",
	1,
};

static struct cmd_node phy_inst_node = {
	PHY_INST_NODE,
	"%s(phy-inst)# ",
	1,
};

DEFUN_ATTR(cfg_phy, cfg_phy_cmd,
	   "phy <0-255>",
	   "Select a PHY to configure\n" "PHY number\n",
	   CMD_ATTR_IMMEDIATE)
{
	int phy_nr = atoi(argv[0]);
	struct phy_link *plink;

	plink = phy_link_by_num(phy_nr);
	if (!plink)
		plink = phy_link_create(tall_bts_ctx, phy_nr);
	if (!plink)
		return CMD_WARNING;

	vty->index = plink;
	vty->index_sub = &plink->description;
	vty->node = PHY_NODE;

	return CMD_SUCCESS;
}

DEFUN_ATTR(cfg_phy_inst, cfg_phy_inst_cmd,
	   "instance <0-255>",
	   "Select a PHY instance to configure\n" "PHY Instance number\n",
	   CMD_ATTR_IMMEDIATE)
{
	int inst_nr = atoi(argv[0]);
	struct phy_link *plink = vty->index;
	struct phy_instance *pinst;

	pinst = phy_instance_by_num(plink, inst_nr);
	if (!pinst) {
		pinst = phy_instance_create(plink, inst_nr);
		if (!pinst) {
			vty_out(vty, "%% Unable to create phy%u instance %u%s",
				plink->num, inst_nr, VTY_NEWLINE);
			return CMD_WARNING;
		}
	}

	vty->index = pinst;
	vty->index_sub = &pinst->description;
	vty->node = PHY_INST_NODE;

	return CMD_SUCCESS;
}

DEFUN(cfg_phy_no_inst, cfg_phy_no_inst_cmd,
	"no instance <0-255>",
	NO_STR "Select a PHY instance to remove\n" "PHY Instance number\n")
{
	int inst_nr = atoi(argv[0]);
	struct phy_link *plink = vty->index;
	struct phy_instance *pinst;

	pinst = phy_instance_by_num(plink, inst_nr);
	if (!pinst) {
		vty_out(vty, "%% No such instance %u%s", inst_nr, VTY_NEWLINE);
		return CMD_WARNING;
	}

	phy_instance_destroy(pinst);

	return CMD_SUCCESS;
}

#if 0
DEFUN(cfg_phy_type, cfg_phy_type_cmd,
	"type (sysmobts|osmo-trx|virtual)",
	"configure the type of the PHY\n"
	"sysmocom sysmoBTS PHY\n"
	"OsmoTRX based PHY\n"
	"Virtual PHY (GSMTAP based)\n")
{
	struct phy_link *plink = vty->index;

	if (plink->state != PHY_LINK_SHUTDOWN) {
		vty_out(vty, "%% Cannot change type of active PHY%s", VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (!strcmp(argv[0], "sysmobts"))
		plink->type = PHY_LINK_T_SYSMOBTS;
	else if (!strcmp(argv[0], "osmo-trx"))
		plink->type = PHY_LINK_T_OSMOTRX;
	else if (!strcmp(argv[0], "virtual"))
		plink->type = PHY_LINK_T_VIRTUAL;
}
#endif

DEFUN(bts_t_t_l_jitter_buf,
	bts_t_t_l_jitter_buf_cmd,
	BTS_T_T_L_CMD " rtp jitter-buffer <0-10000>",
	BTS_T_T_L_STR "RTP settings\n"
	"Jitter buffer\n" "Size of jitter buffer in (ms)\n")
{
	struct gsm_lchan *lchan;
	int jitbuf_ms = atoi(argv[4]), rc;

	lchan = resolve_lchan(argv, 0);
	if (!lchan) {
		vty_out(vty, "%% Could not resolve logical channel%s", VTY_NEWLINE);
		return CMD_WARNING;
	}
	if (!lchan->abis_ip.rtp_socket) {
		vty_out(vty, "%% this channel has no active RTP stream%s",
			VTY_NEWLINE);
		return CMD_WARNING;
	}
	rc = rtp_abst_socket_set_param(lchan->abis_ip.rtp_socket,
				  lchan->ts->trx->bts->rtp_jitter_adaptive,
				  jitbuf_ms);
	if (rc < 0)
		vty_out(vty, "%% error setting jitter parameters: %s%s",
			strerror(-rc), VTY_NEWLINE);
	else
		vty_out(vty, "%% jitter parameters set: %d%s", rc, VTY_NEWLINE);

	return CMD_SUCCESS;
}

DEFUN_ATTR(bts_t_t_l_loopback,
	   bts_t_t_l_loopback_cmd,
	   BTS_T_T_L_CMD " loopback",
	   BTS_T_T_L_STR "Set loopback\n",
	   CMD_ATTR_HIDDEN)
{
	struct gsm_lchan *lchan;

	lchan = resolve_lchan(argv, 0);
	if (!lchan) {
		vty_out(vty, "%% Could not resolve logical channel%s", VTY_NEWLINE);
		return CMD_WARNING;
	}
	lchan->loopback = 1;

	return CMD_SUCCESS;
}

DEFUN_ATTR(no_bts_t_t_l_loopback,
	   no_bts_t_t_l_loopback_cmd,
	   "no " BTS_T_T_L_CMD " loopback",
	   NO_STR BTS_T_T_L_STR "Set loopback\n",
	   CMD_ATTR_HIDDEN)
{
	struct gsm_lchan *lchan;

	lchan = resolve_lchan(argv, 0);
	if (!lchan) {
		vty_out(vty, "%% Could not resolve logical channel%s", VTY_NEWLINE);
		return CMD_WARNING;
	}
	lchan->loopback = 0;

	return CMD_SUCCESS;
}

#define LCHAN_PWR_CTRL_CMD \
	BTS_T_T_L_CMD " (bs-power-ctrl|ms-power-ctrl)"
#define LCHAN_PWR_CTRL_STR \
	BTS_T_T_L_STR "BS power control\n" "MS power control\n"

DEFUN_ATTR(bts_t_t_l_power_ctrl_mode,
	   bts_t_t_l_power_ctrl_mode_cmd,
	   LCHAN_PWR_CTRL_CMD " mode (static|dynamic)",
	   LCHAN_PWR_CTRL_STR "Change power control mode\n"
	   "Disable the power control loop\n"
	   "Enable the power control loop\n",
	   CMD_ATTR_HIDDEN)
{
	struct lchan_power_ctrl_state *state;
	const char **args = argv + 4;
	struct gsm_lchan *lchan;

	lchan = resolve_lchan(argv, 0);
	if (!lchan) {
		vty_out(vty, "%% Could not resolve logical channel%s", VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (strcmp(args[0], "bs-power-ctrl") == 0)
		state = &lchan->bs_power_ctrl;
	else/* ms-power-ctrl */
		state = &lchan->ms_power_ctrl;

	if (strcmp(args[1], "dynamic") == 0)
		state->dpc_enabled = true;
	else
		state->dpc_enabled = false;

	return CMD_SUCCESS;
}

DEFUN_ATTR(bts_t_t_l_power_ctrl_current_max,
	   bts_t_t_l_power_ctrl_current_max_cmd,
	   LCHAN_PWR_CTRL_CMD " value (current|max) <0-255>",
	   LCHAN_PWR_CTRL_STR "Change current power value\n"
	   "Current value (for both dynamic and static modes)\n"
	   "Maximum value (for dynamic mode only)\n"
	   "BS power reduction (in dB) or MS power level\n",
	   CMD_ATTR_HIDDEN)
{
	struct lchan_power_ctrl_state *state;
	const char **args = argv + 4;
	struct gsm_lchan *lchan;

	lchan = resolve_lchan(argv, 0);
	if (!lchan) {
		vty_out(vty, "%% Could not resolve logical channel%s", VTY_NEWLINE);
		return CMD_WARNING;
	}

	if (strcmp(args[0], "bs-power-ctrl") == 0)
		state = &lchan->bs_power_ctrl;
	else /* ms-power-ctrl */
		state = &lchan->ms_power_ctrl;

	if (strcmp(args[1], "current") == 0)
		state->current = atoi(args[2]);
	else
		state->max = atoi(args[2]);

	return CMD_SUCCESS;
}

DEFUN(logging_fltr_l1_sapi, logging_fltr_l1_sapi_cmd, "HIDDEN", "HIDDEN")
{
	int sapi = get_string_value(l1sap_common_sapi_names, argv[0]);
	struct log_target *tgt = osmo_log_vty2tgt(vty);
	uint16_t *sapi_mask;

	OSMO_ASSERT(sapi >= 0);
	OSMO_ASSERT(sapi <= 31);
	if (!tgt)
		return CMD_WARNING;

	sapi_mask = log_get_filter_data(tgt, LOG_FLT_L1_SAPI);

	if (!sapi_mask)
		sapi_mask = talloc_zero(tgt, uint16_t);

	*sapi_mask |= (1 << sapi);
	log_set_filter_data(tgt, LOG_FLT_L1_SAPI, sapi_mask);
	log_set_filter(tgt, LOG_FLT_L1_SAPI, true);

	return CMD_SUCCESS;
}

DEFUN(no_logging_fltr_l1_sapi, no_logging_fltr_l1_sapi_cmd, "HIDDEN", "HIDDEN")
{
	int sapi = get_string_value(l1sap_common_sapi_names, argv[0]);
	struct log_target *tgt = osmo_log_vty2tgt(vty);
	uint16_t *sapi_mask;

	OSMO_ASSERT(sapi >= 0);
	OSMO_ASSERT(sapi <= 31);
	if (!tgt)
		return CMD_WARNING;
	sapi_mask = (uint16_t *)log_get_filter_data(tgt, LOG_FLT_L1_SAPI);
	if (!sapi_mask)
		return CMD_SUCCESS;
	*sapi_mask &= ~(1 << sapi);

	if (*sapi_mask == 0x0000) {
		log_set_filter_data(tgt, LOG_FLT_L1_SAPI, NULL);
		log_set_filter(tgt, LOG_FLT_L1_SAPI, false);
		talloc_free(sapi_mask);
	}

	return CMD_SUCCESS;
}

int bts_vty_init(void *ctx)
{
	cfg_bts_gsmtap_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,
						"gsmtap-sapi (",
						"|",")", VTY_DO_LOWER);
	cfg_bts_gsmtap_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,
						"Enable sending of UL/DL messages over GSMTAP\n",
						"\n", "", 0);

	cfg_bts_no_gsmtap_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,
						"no gsmtap-sapi (",
						"|",")", VTY_DO_LOWER);
	cfg_bts_no_gsmtap_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,
						NO_STR "Disable sending of UL/DL messages over GSMTAP\n",
						"\n", "", 0);

	logging_fltr_l1_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, l1sap_common_sapi_names,
						"logging filter l1-sapi (",
						"|", ")", VTY_DO_LOWER);
	logging_fltr_l1_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, l1sap_common_sapi_names,
						LOGGING_STR FILTER_STR "L1 SAPI\n",
						"\n", "", 0);

	no_logging_fltr_l1_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, l1sap_common_sapi_names,
						"no logging filter l1-sapi (",
						"|", ")", VTY_DO_LOWER);
	no_logging_fltr_l1_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, l1sap_common_sapi_names,
						NO_STR LOGGING_STR FILTER_STR "L1 SAPI\n",
						"\n", "", 0);

	install_element_ve(&show_bts_cmd);
	install_element_ve(&show_trx_cmd);
	install_element_ve(&show_ts_cmd);
	install_element_ve(&show_lchan_cmd);
	install_element_ve(&show_lchan_summary_cmd);
	install_element_ve(&show_bts_gprs_cmd);
	install_element_ve(&show_bts_rtp_cmd);

	install_element_ve(&logging_fltr_l1_sapi_cmd);
	install_element_ve(&no_logging_fltr_l1_sapi_cmd);

	install_node(&bts_node, config_write_bts);
	install_element(CONFIG_NODE, &cfg_bts_cmd);
	install_element(CONFIG_NODE, &cfg_vty_telnet_port_cmd);

	osmo_tdef_vty_groups_init(CONFIG_NODE, bts_tdef_groups);

	install_element(BTS_NODE, &cfg_bts_unit_id_cmd);
	install_element(BTS_NODE, &cfg_bts_oml_ip_cmd);
	install_element(BTS_NODE, &cfg_bts_no_oml_ip_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_bind_ip_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_jitbuf_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_port_range_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_ip_dscp_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_priority_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_library_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_cont_stream_cmd);
	install_element(BTS_NODE, &cfg_bts_no_rtp_cont_stream_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_int_ul_ecu_cmd);
	install_element(BTS_NODE, &cfg_bts_no_rtp_int_ul_ecu_cmd);
	install_element(BTS_NODE, &cfg_bts_rtp_hr_format_cmd);
	install_element(BTS_NODE, &cfg_bts_band_cmd);
	install_element(BTS_NODE, &cfg_description_cmd);
	install_element(BTS_NODE, &cfg_no_description_cmd);
	install_element(BTS_NODE, &cfg_bts_paging_queue_size_cmd);
	install_element(BTS_NODE, &cfg_bts_paging_lifetime_cmd);
	install_element(BTS_NODE, &cfg_bts_agch_queue_mgmt_default_cmd);
	install_element(BTS_NODE, &cfg_bts_agch_queue_mgmt_params_cmd);
	install_element(BTS_NODE, &cfg_bts_ul_power_target_cmd);
	install_element(BTS_NODE, &cfg_bts_ul_power_target_hysteresis_cmd);
	install_element(BTS_NODE, &cfg_bts_no_ul_power_filter_cmd);
	install_element(BTS_NODE, &cfg_bts_ul_power_filter_ewma_cmd);
	install_element(BTS_NODE, &cfg_bts_min_qual_rach_cmd);
	install_element(BTS_NODE, &cfg_bts_min_qual_norm_cmd);
	install_element(BTS_NODE, &cfg_bts_max_ber_rach_cmd);
	install_element(BTS_NODE, &cfg_bts_pcu_sock_path_cmd);
	install_element(BTS_NODE, &cfg_bts_pcu_sock_ql_cmd);
	install_element(BTS_NODE, &cfg_bts_supp_meas_toa256_cmd);
	install_element(BTS_NODE, &cfg_bts_no_supp_meas_toa256_cmd);
	install_element(BTS_NODE, &cfg_bts_smscb_max_qlen_cmd);
	install_element(BTS_NODE, &cfg_bts_smscb_tgt_qlen_cmd);
	install_element(BTS_NODE, &cfg_bts_smscb_qhyst_cmd);

	install_element(BTS_NODE, &cfg_bts_gsmtap_remote_host_cmd);
	install_element(BTS_NODE, &cfg_bts_no_gsmtap_remote_host_cmd);
	install_element(BTS_NODE, &cfg_bts_gsmtap_local_host_cmd);
	install_element(BTS_NODE, &cfg_bts_no_gsmtap_local_host_cmd);
	install_element(BTS_NODE, &cfg_bts_gsmtap_sapi_all_cmd);
	install_element(BTS_NODE, &cfg_bts_gsmtap_sapi_cmd);
	install_element(BTS_NODE, &cfg_bts_no_gsmtap_sapi_cmd);
	install_element(BTS_NODE, &cfg_bts_gsmtap_rlp_cmd);
	install_element(BTS_NODE, &cfg_bts_no_gsmtap_rlp_cmd);

	/* Osmux Node */
	install_element(BTS_NODE, &cfg_bts_osmux_cmd);
	install_node(&osmux_node, config_write_dummy);

	install_element(OSMUX_NODE, &cfg_bts_osmux_use_cmd);
	install_element(OSMUX_NODE, &cfg_bts_osmux_ip_cmd);
	install_element(OSMUX_NODE, &cfg_bts_osmux_port_cmd);
	install_element(OSMUX_NODE, &cfg_bts_osmux_batch_factor_cmd);
	install_element(OSMUX_NODE, &cfg_bts_osmux_batch_size_cmd);
	install_element(OSMUX_NODE, &cfg_bts_osmux_dummy_padding_cmd);

	/* twjit config node */
	install_element(BTS_NODE, &cfg_bts_twjit_cmd);
	install_node(&twjit_node, config_write_dummy);
	osmo_twjit_vty_init(TWJIT_NODE);

	/* add and link to TRX config node */
	install_element(BTS_NODE, &cfg_bts_trx_cmd);
	install_node(&trx_node, config_write_dummy);

	install_element(TRX_NODE, &cfg_trx_user_gain_cmd);
	install_element(TRX_NODE, &cfg_trx_pr_max_initial_cmd);
	install_element(TRX_NODE, &cfg_trx_pr_step_size_cmd);
	install_element(TRX_NODE, &cfg_trx_pr_step_interval_cmd);
	install_element(TRX_NODE, &cfg_trx_ms_power_control_cmd);
	install_element(TRX_NODE, &cfg_ta_ctrl_interval_cmd);
	install_element(TRX_NODE, &cfg_trx_phy_cmd);

	install_element(ENABLE_NODE, &bts_t_t_l_jitter_buf_cmd);
	install_element(ENABLE_NODE, &bts_t_t_l_loopback_cmd);
	install_element(ENABLE_NODE, &no_bts_t_t_l_loopback_cmd);
	install_element(ENABLE_NODE, &bts_t_t_l_power_ctrl_mode_cmd);
	install_element(ENABLE_NODE, &bts_t_t_l_power_ctrl_current_max_cmd);
	install_element(ENABLE_NODE, &test_send_failure_event_report_cmd);
	install_element(ENABLE_NODE, &radio_link_timeout_cmd);
	install_element(ENABLE_NODE, &bts_c0_power_red_cmd);

	install_element(CONFIG_NODE, &cfg_phy_cmd);
	install_node(&phy_node, config_write_phy);
	install_element(PHY_NODE, &cfg_phy_inst_cmd);
	install_element(PHY_NODE, &cfg_phy_no_inst_cmd);

	install_node(&phy_inst_node, config_write_dummy);

	/* Install variant-specific VTY options */
	return bts_model_vty_init(ctx);
}
