Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org ewild@sysmocom.de000010584105841.0071237123264722209f9a2dfe45642722c25a5aa00629c41ef71022209f9a2dfe45642722c25a5aa00629c41ef710origin/master22209f9a2dfe45642722c25a5aa00629c41ef71022209f9a2dfe45642722c25a5aa00629c41ef710origin/master14593761545fcf173ea975494dafe4516e0f4c6690813761545fcf173ea975494dafe4516e0f4c669081refs/remotes/origin/master3761545fcf173ea975494dafe4516e0f4c6690813761545fcf173ea975494dafe4516e0f4c669081refs/remotes/origin/master22209f9a2dfe45642722c25a5aa00629c41ef71022209f9a2dfe45642722c25a5aa00629c41ef710origin/masterhttps://gerrit.osmocom.org/osmo-asf4-dfufalse#2647105848029master-osmo-asf4-dfu #26472647falsefalse264757602SUCCESS1773346508146https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-asf4-dfu/2647/- usb/class/dfu/device/dfudf.cdd7bde04a38d65ce352f126faf4ec63f62ed66251773226823000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.eudfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed
In theory a device which is manifestintolerant and completed the manifestation should
not reach MANIFEST_SYNC again.
Remove the state transistion to WAIT-RESET and stay in the current state and
wait for the main loop to change the state is safer.
Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d
2026-03-11 12:00:23 +0100dd7bde04a38d65ce352f126faf4ec63f62ed6625dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant &editusb/class/dfu/device/dfudf.c
- usb_start.c0ec23458edfd7480eb190c71e8cd70b5e8f09e021773226823000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.eudfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical section
In the MANIFEST state, the IRQ won't move the state, but
to prevent incosistency between dfu_manifestation_complete &
dfu_state, use a critical section.
Change-Id: Idf5fb7d55b4051ba7e235dfa409a4de18a8f208c
2026-03-11 12:00:23 +01000ec23458edfd7480eb190c71e8cd70b5e8f09e02dfu: protect USB_DFU_STATE_DFU_MANIFEST by a critical sectioneditusb_start.c
- usb_flash_main.c0122e647cadc04245ae75f05be6403b413d551d91773226823000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.euReplace snprintf() to free 4 kb
Change-Id: Ide644648bda86d4ae77a6713d1e140a4b78ba835
2026-03-11 12:00:23 +01000122e647cadc04245ae75f05be6403b413d551d9Replace snprintf() to free 4 kbeditusb_flash_main.c
- usb_start.cusb/class/dfu/device/dfudf.cusb/class/dfu/device/dfudf.h6b44e8f58537f45a3810979d6b14bdd2e23b83631773229266000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.eudfu: download: flash the first block in manifest phase
To prevent half flashed applications, erase the first page
when dfu downloading starts and save the first block for later.
In manifest stage, flash the first block.
If the first 4 byte are 0xffffffff, the board won't boot
into application and go into the dfu bootloader.
Change-Id: I894f3ee71587ccb287e92d7025039954991c631f
2026-03-11 11:41:06 +00006b44e8f58537f45a3810979d6b14bdd2e23b8363dfu: download: flash the first block in manifest phaseeditusb_start.ceditusb/class/dfu/device/dfudf.heditusb/class/dfu/device/dfudf.c
- usb_start.c7d3c3b8b3b4f8fbc1cdff23f531e2c6db8cd4af01773230490000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.eudfu: flash: protect parsing of rc of flashing
Otherwise it is not guaranteed that both dfu_status and dfu_state
are in sync when the IRQ handler is running.
Change-Id: Ifc0d56d779ec31382855d6c367478104bc04e1e7
2026-03-11 12:01:30 +00007d3c3b8b3b4f8fbc1cdff23f531e2c6db8cd4af0dfu: flash: protect parsing of rc of flashingeditusb_start.c
- usb/class/dfu/device/dfudf.cusb/class/dfu/device/dfudf.hc56c1c21a8378cee3476bd824c4249531fbe3f091773230492000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.eudfu: download: make variables between IRQ and main loop volatile
Both are access by IRQ and mainloop and are written by the IRQ handler.
Change-Id: Ic3dccd77eff7feb164f9f07047680eef3f7c2516
2026-03-11 12:01:32 +0000c56c1c21a8378cee3476bd824c4249531fbe3f09dfu: download: make variables between IRQ and main loop volatileeditusb/class/dfu/device/dfudf.ceditusb/class/dfu/device/dfudf.h
- usb/class/dfu/device/dfudf.c22209f9a2dfe45642722c25a5aa00629c41ef7101773241074000https://jenkins.osmocom.org/jenkins/user/lynxislynxislynxis@fe80.eudfu: download: align download data buffer
The download data buffer is given to the usb stack.
Ensure the data buffer is dma capable to prevent an
additional memcpy() by the usb hal.
Change-Id: I01191a125aa62c2198e38d5e5fcd27d4e421c62e
2026-03-11 15:57:54 +010022209f9a2dfe45642722c25a5aa00629c41ef710dfu: download: align download data buffereditusb/class/dfu/device/dfudf.c
githttps://jenkins.osmocom.org/jenkins/user/lynxislynxis2647https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-asf4-dfu/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/2647/