Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org00002299702299701.066276627023659766256625113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btshttps://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/11397/artifacthttps://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/changeshttps://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/11397/https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/11397/testReportfalse#11397229970196510master-osmo-bts #1139711397falsefalse1139775175SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/11397/src/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditinclude/osmo-bts/tx_power.heditsrc/common/tx_power.ceditsrc/common/bts_shutdown_fsm.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyfixeriaBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00001017711017711.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#11397101771104050master-osmo-bts » lc15,master,1,default,osmocom-master #1139711397falsefalse1139775176SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=lc15,FIRMWARE_VERSION=master,WITH_MANUALS=1,a4=default,label=osmocom-master/11397/build4-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditinclude/osmo-bts/tx_power.heditsrc/common/tx_power.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/000068992689921.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113976899264544master-osmo-bts » lc15,origin/nrw/litecell15,0,default,osmocom-master #1139711397falsefalse1139775182SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=lc15,FIRMWARE_VERSION=origin%2Fnrw%2Flitecell15,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build4-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditinclude/osmo-bts/tx_power.heditsrc/common/tx_power.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/000068996689961.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113976899666372master-osmo-bts » lc15,v2017.01,0,default,osmocom-master #1139711397falsefalse1139775177SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=lc15,FIRMWARE_VERSION=v2017.01,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build4-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditinclude/osmo-bts/tx_power.heditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00001207741207741.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#11397120774107387master-osmo-bts » oc2g,master,1,default,osmocom-master #1139711397falsefalse1139775178SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=oc2g,FIRMWARE_VERSION=master,WITH_MANUALS=1,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.heditsrc/common/bts_shutdown_fsm.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00788377883762538625381.004444113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113976253872131master-osmo-bts » oc2g,origin/nrw/oc2g,0,default,osmocom-master #1139711397falsefalse1139775188SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=oc2g,FIRMWARE_VERSION=origin%2Fnrw%2Foc2g,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.hgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/0083881838811024831024831.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#11397102483105874master-osmo-bts » oct,master,1,default,osmocom-master #1139711397falsefalse1139775190SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=oct,FIRMWARE_VERSION=master,WITH_MANUALS=1,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.heditsrc/common/bts_shutdown_fsm.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00001017461017461.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#11397101746104658master-osmo-bts » oct+trx,master,1,default,osmocom-master #1139711397falsefalse1139775184SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=oct+trx,FIRMWARE_VERSION=master,WITH_MANUALS=1,a4=default,label=osmocom-master/11397/build4-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.hgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00791357913560797607971.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113976079766970master-osmo-bts » sysmo,femtobts_v2.7,0,default,osmocom-master #1139711397falsefalse1139775189SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=sysmo,FIRMWARE_VERSION=femtobts_v2.7,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/tx_power.ceditsrc/common/bts_shutdown_fsm.ceditinclude/osmo-bts/tx_power.hgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00001105581105581.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#11397110558102790master-osmo-bts » sysmo,master,1,default,osmocom-master #1139711397falsefalse1139775183SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=sysmo,FIRMWARE_VERSION=master,WITH_MANUALS=1,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditinclude/osmo-bts/tx_power.heditsrc/common/tx_power.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/000074619746191.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113977461966733master-osmo-bts » sysmo,superfemto_v2.4,0,default,osmocom-master #1139711397falsefalse1139775179SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v2.4,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditinclude/osmo-bts/tx_power.heditsrc/common/tx_power.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/000074559745591.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113977455966683master-osmo-bts » sysmo,superfemto_v3.0.1pre,0,default,osmocom-master #1139711397falsefalse1139775180SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v3.0.1pre,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.hgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/000074628746281.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113977462865511master-osmo-bts » sysmo,superfemto_v3.1,0,default,osmocom-master #1139711397falsefalse1139775181SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v3.1,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build5-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.hgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00722417224161503615031.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#113976150363871master-osmo-bts » sysmo,superfemto_v5.1,0,default,osmocom-master #1139711397falsefalse1139775185SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=sysmo,FIRMWARE_VERSION=superfemto_v5.1,WITH_MANUALS=0,a4=default,label=osmocom-master/11397/build4-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.ceditinclude/osmo-bts/tx_power.hgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00002234042234041.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#11397223404192746master-osmo-bts » trx,master,0,default,raspbian #1139711397falsefalse1139775187SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=trx,FIRMWARE_VERSION=master,WITH_MANUALS=0,a4=default,label=raspbian/11397/lx2-raspbian12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditsrc/common/bts_shutdown_fsm.ceditinclude/osmo-bts/tx_power.heditsrc/common/tx_power.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim YanitskiyBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-bts" build number 11,39711397master-osmo-btsjob/master-osmo-bts/00726897268997648976481.0000113974c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/master110037db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip7db79cc39a265a6838206df836d1bee28be1acee7db79cc39a265a6838206df836d1bee28be1aceerefs/remotes/origin/osmith/wip761473773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master73773447715c57075ad5acb96a5346ff23d7e91f73773447715c57075ad5acb96a5346ff23d7e91frefs/remotes/origin/master4c6324213ac87f9979df7e6d0f596f175ddb27f64c6324213ac87f9979df7e6d0f596f175ddb27f6origin/masterhttps://gerrit.osmocom.org/osmo-btsfalse#1139797648102183master-osmo-bts » trx,master,1,default,osmocom-master #1139711397falsefalse1139775186SUCCESS1774862887007https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-bts/BTS_MODEL=trx,FIRMWARE_VERSION=master,WITH_MANUALS=1,a4=default,label=osmocom-master/11397/build4-deb12build-ansiblesrc/osmo-bts-trx/sched_lchan_xcch.c796965d72b96ca6a9e40848a8b3397fa01d9883d1774606183000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea 2026-03-27 17:09:43 +0700796965d72b96ca6a9e40848a8b3397fa01d9883dosmo-bts-trx: rx_data_fn(): fix copy-paste in commenteditsrc/osmo-bts-trx/sched_lchan_xcch.csrc/osmo-bts-trx/sched_lchan_rach.ca158425c0c586dc7a80d2c076194869a64531e241774606334000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deosmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 2026-03-27 17:12:14 +0700a158425c0c586dc7a80d2c076194869a64531e24osmo-bts-trx: rx_rach_fn(): remove redundant fall-backeditsrc/osmo-bts-trx/sched_lchan_rach.csrc/common/tx_power.cinclude/osmo-bts/tx_power.hsrc/common/bts_shutdown_fsm.c4c6324213ac87f9979df7e6d0f596f175ddb27f61774610689000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.debts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 2026-03-27 18:24:49 +07004c6324213ac87f9979df7e6d0f596f175ddb27f6bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSEDeditinclude/osmo-bts/tx_power.heditsrc/common/bts_shutdown_fsm.ceditsrc/common/tx_power.cgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy