Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org00001251991251991.0090949094134842ef24d62ab9c1489eb87ac3aaeece084676e76b52ef24d62ab9c1489eb87ac3aaeece084676e76b5origin/master2ef24d62ab9c1489eb87ac3aaeece084676e76b52ef24d62ab9c1489eb87ac3aaeece084676e76b5origin/master889363eefabdde87df4dac9ed071df6535eed4f748c363eefabdde87df4dac9ed071df6535eed4f748c3refs/remotes/origin/master63eefabdde87df4dac9ed071df6535eed4f748c363eefabdde87df4dac9ed071df6535eed4f748c3refs/remotes/origin/master2ef24d62ab9c1489eb87ac3aaeece084676e76b52ef24d62ab9c1489eb87ac3aaeece084676e76b5origin/masterhttps://gerrit.osmocom.org/osmo-hlrfalse#13484125199119887master-osmo-hlr #1348413484falsefalse13484169525SUCCESS1784118249540https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-hlr/13484/debian/postinstcontrib/osmo-hlr-post-upgrade.shcontrib/systemd/osmo-hlr.servicedebian/osmo-hlr.installcontrib/osmo-hlr-db-upgrade.shcontrib/Makefile.am2ef24d62ab9c1489eb87ac3aaeece084676e76b51784109296000https://jenkins.osmocom.org/jenkins/user/osmithOliver Smithosmith@sysmocom.desystemd: run db-upgrade script in ExecStartPre We have seen in CI jobs that calling the DB upgrade script from debian/postinst does not work reliably. When doing a fresh install of osmo-hlr, it usually works as expected: Setting up osmo-hlr (1.9.2) ... osmo-hlr-post-upgrade: nothing to do (no existing database) But sometimes: Setting up osmo-hlr (1.9.2) ... osmo-hlr-post-upgrade: database upgrade is required osmo-hlr-post-upgrade: stopping osmo-hlr service osmo-hlr-post-upgrade: creating backup: /var/lib/osmocom/hlr.db.20260706135658.bak osmo-hlr-post-upgrade: performing database upgrade <0001> db.c:600 using database: /var/lib/osmocom/hlr.db <0001> db.c:103 (283) recovered 4 frames from WAL file /var/lib/osmocom/hlr.db-wal <0001> db.c:679 Database '/var/lib/osmocom/hlr.db' has HLR DB schema version 0 <0001> db.c:103 (1) duplicate column name: last_lu_seen in "ALTER TABLE subscriber ADD COLUMN last_lu_seen TIMESTAMP default NULL" <0001> db.c:248 Unable to prepare SQL statement 'ALTER TABLE subscriber ADD COLUMN last_lu_seen TIMESTAMP default NULL' <0001> db.c:318 Unable to update HLR database schema to version 1 <0001> db.c:685 Failed to upgrade HLR DB schema to version 1: (rc=1) duplicate column name: last_lu_seen <0000> hlr_db_tool.c:509 Error opening database It seems that osmo-hlr can get started before the osmo-hlr-post-upgrade script runs, then starts to create the database with the current schema, and gets stopped before it is done, leading to the failure above. Rename the script to osmo-hlr-db-upgrade.sh, remove logic for stopping and starting the service and let systemd call it in ExecStartPre. That way we are sure that it runs *before* osmo-hlr starts up. Related: SYS#8125 Change-Id: If13f4c8b49397e6630956e92a7825843c7d55ebd 2026-07-15 11:54:56 +02002ef24d62ab9c1489eb87ac3aaeece084676e76b5systemd: run db-upgrade script in ExecStartPreeditdebian/postinsteditcontrib/Makefile.ameditcontrib/systemd/osmo-hlr.serviceaddcontrib/osmo-hlr-db-upgrade.sheditdebian/osmo-hlr.installdeletecontrib/osmo-hlr-post-upgrade.shgithttps://jenkins.osmocom.org/jenkins/user/osmithOliver Smith13484https://jenkins.osmocom.org/jenkins/view/no-generated/job/master-osmo-hlr/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/13484/