Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org000073356733561.059195919079275591759172938af717d3b73a97dafc2bbd5cba382266909a51942af717d3b73a97dafc2bbd5cba382266909a51942origin/masteraf717d3b73a97dafc2bbd5cba382266909a51942af717d3b73a97dafc2bbd5cba382266909a51942origin/master1667c69d5c8da71c3320fc18308b95aded4aa949ddd3c69d5c8da71c3320fc18308b95aded4aa949ddd3refs/remotes/origin/masterc69d5c8da71c3320fc18308b95aded4aa949ddd3c69d5c8da71c3320fc18308b95aded4aa949ddd3refs/remotes/origin/masteraf717d3b73a97dafc2bbd5cba382266909a51942af717d3b73a97dafc2bbd5cba382266909a51942origin/masterhttps://gerrit.osmocom.org/osmo-remsimhttps://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-remsim/2938/artifacthttps://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-remsim/changeshttps://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-remsim/2938/https://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-remsim/2938/testReportfalse#29387335673307master-osmo-remsim #29382938falsefalse2938102151SUCCESS1777332246843https://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-remsim/2938/src/bankd/bankd_main.cb17b7c1d247c91febd592234c76f3444ae59dd641777295231000https://jenkins.osmocom.org/jenkins/user/aeversbergAndreas Eversbergaeversberg@sysmocom.deFix: Remove slot mapping at bankd when client disconnects If a client disconnects before removing the slot mapping, the worker must undefine its 'bank_id' and 'slot_nr' and must change its state to 'UNMAPPED'. send_signal_to_worker() searches for a worker that has a given bank and slot. If a client re-connects to a different worker and if the bank and slot would be still assigned to the old worker, the old worker could receive signals when assigning or removing slot mapping. The new worker would not be mapped. Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 2026-04-27 15:07:11 +0200b17b7c1d247c91febd592234c76f3444ae59dd64Fix: Remove slot mapping at bankd when client disconnectseditsrc/bankd/bankd_main.csrc/slotmap.csrc/bankd/bankd_main.csrc/slotmap.h9be3d184f97958f18ee16802941a9a3e712855d11777295988000https://jenkins.osmocom.org/jenkins/user/aeversbergAndreas Eversbergaeversberg@sysmocom.deFix: Prevent race conditions when accessing slotmap in bankd If a client connects to a worker, the worker will check if there is an existing mapping between a reader and this client. If it exists, slotmap_by_client() will return a pointer. If the mapping is deleted at this time by the server, the worker uses a pointer to a mapping entry that has just been freed. To prevent this, the worker locks the slot map and calls the new function slotmap_by_client_nolock(). After it has finished working with the returned pointer, it unlocks the slot map again. A possible delete by the main thread would be delayed. Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 2026-04-27 15:19:48 +02009be3d184f97958f18ee16802941a9a3e712855d1Fix: Prevent race conditions when accessing slotmap in bankdeditsrc/slotmap.ceditsrc/slotmap.heditsrc/bankd/bankd_main.csrc/bankd/bankd_main.c2cc1aa57418e6388e463fb1de1295640fab2413f1777302517000https://jenkins.osmocom.org/jenkins/user/aeversbergAndreas Eversbergaeversberg@sysmocom.deFix: Prevent bankd from exiting upon SIGPIPE If a client disconnects from a worker thread while the worker is responding to a to a request from that client, the socket is closed and SIGPIPE is sent to the worker, causing the application to exit. To prevent this, all workers have a dummy handler to prevent this. Now the worker can handle the closing of the socket. Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf 2026-04-27 17:08:37 +02002cc1aa57418e6388e463fb1de1295640fab2413fFix: Prevent bankd from exiting upon SIGPIPEeditsrc/bankd/bankd_main.csrc/rspro_util.caf717d3b73a97dafc2bbd5cba382266909a519421777332175000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgrspro_util: asn1 decode: fix memleak when decoding fails Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 2026-04-27 23:22:55 +0000af717d3b73a97dafc2bbd5cba382266909a51942rspro_util: asn1 decode: fix memleak when decoding failseditsrc/rspro_util.cgithttps://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforgehttps://jenkins.osmocom.org/jenkins/user/aeversbergAndreas EversbergaeversbergBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.orgStarted by upstream project "master-osmo-remsim" build number 2,9382938master-osmo-remsimjob/master-osmo-remsim/000071602716021.00002938af717d3b73a97dafc2bbd5cba382266909a51942af717d3b73a97dafc2bbd5cba382266909a51942origin/masteraf717d3b73a97dafc2bbd5cba382266909a51942af717d3b73a97dafc2bbd5cba382266909a51942origin/master1667c69d5c8da71c3320fc18308b95aded4aa949ddd3c69d5c8da71c3320fc18308b95aded4aa949ddd3refs/remotes/origin/masterc69d5c8da71c3320fc18308b95aded4aa949ddd3c69d5c8da71c3320fc18308b95aded4aa949ddd3refs/remotes/origin/masteraf717d3b73a97dafc2bbd5cba382266909a51942af717d3b73a97dafc2bbd5cba382266909a51942origin/masterhttps://gerrit.osmocom.org/osmo-remsimfalse#29387160271401master-osmo-remsim » a1=default,a2=default,a3=default,a4=default,osmocom-master #29382938falsefalse2938102152SUCCESS1777332246843https://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-remsim/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/2938/build5-deb12build-ansiblesrc/bankd/bankd_main.cb17b7c1d247c91febd592234c76f3444ae59dd641777295231000https://jenkins.osmocom.org/jenkins/user/aeversbergAndreas Eversbergaeversberg@sysmocom.deFix: Remove slot mapping at bankd when client disconnects If a client disconnects before removing the slot mapping, the worker must undefine its 'bank_id' and 'slot_nr' and must change its state to 'UNMAPPED'. send_signal_to_worker() searches for a worker that has a given bank and slot. If a client re-connects to a different worker and if the bank and slot would be still assigned to the old worker, the old worker could receive signals when assigning or removing slot mapping. The new worker would not be mapped. Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 2026-04-27 15:07:11 +0200b17b7c1d247c91febd592234c76f3444ae59dd64Fix: Remove slot mapping at bankd when client disconnectseditsrc/bankd/bankd_main.csrc/bankd/bankd_main.csrc/slotmap.csrc/slotmap.h9be3d184f97958f18ee16802941a9a3e712855d11777295988000https://jenkins.osmocom.org/jenkins/user/aeversbergAndreas Eversbergaeversberg@sysmocom.deFix: Prevent race conditions when accessing slotmap in bankd If a client connects to a worker, the worker will check if there is an existing mapping between a reader and this client. If it exists, slotmap_by_client() will return a pointer. If the mapping is deleted at this time by the server, the worker uses a pointer to a mapping entry that has just been freed. To prevent this, the worker locks the slot map and calls the new function slotmap_by_client_nolock(). After it has finished working with the returned pointer, it unlocks the slot map again. A possible delete by the main thread would be delayed. Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 2026-04-27 15:19:48 +02009be3d184f97958f18ee16802941a9a3e712855d1Fix: Prevent race conditions when accessing slotmap in bankdeditsrc/slotmap.heditsrc/bankd/bankd_main.ceditsrc/slotmap.csrc/bankd/bankd_main.c2cc1aa57418e6388e463fb1de1295640fab2413f1777302517000https://jenkins.osmocom.org/jenkins/user/aeversbergAndreas Eversbergaeversberg@sysmocom.deFix: Prevent bankd from exiting upon SIGPIPE If a client disconnects from a worker thread while the worker is responding to a to a request from that client, the socket is closed and SIGPIPE is sent to the worker, causing the application to exit. To prevent this, all workers have a dummy handler to prevent this. Now the worker can handle the closing of the socket. Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf 2026-04-27 17:08:37 +02002cc1aa57418e6388e463fb1de1295640fab2413fFix: Prevent bankd from exiting upon SIGPIPEeditsrc/bankd/bankd_main.csrc/rspro_util.caf717d3b73a97dafc2bbd5cba382266909a519421777332175000https://jenkins.osmocom.org/jenkins/user/laforgelaforgelaforge@osmocom.orgrspro_util: asn1 decode: fix memleak when decoding fails Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 2026-04-27 23:22:55 +0000af717d3b73a97dafc2bbd5cba382266909a51942rspro_util: asn1 decode: fix memleak when decoding failseditsrc/rspro_util.cgithttps://jenkins.osmocom.org/jenkins/user/laforgelaforgehttps://jenkins.osmocom.org/jenkins/user/aeversbergAndreas Eversberg