Started by an SCM changeBRANCHmasterEMAIL_NOTIFICATIONSjenkins-notifications@lists.osmocom.org laforge@gnumonks.org000073344733441.00610161017380f796cc231437d84edf58218c28ae193110115c10f796cc231437d84edf58218c28ae193110115c1origin/master0f796cc231437d84edf58218c28ae193110115c10f796cc231437d84edf58218c28ae193110115c1origin/master0f796cc231437d84edf58218c28ae193110115c10f796cc231437d84edf58218c28ae193110115c1origin/masterhttps://gerrit.osmocom.org/erlang/osmo-s1gwfalse#7387334474245master-osmo-s1gw #738738falsefalse73855217SUCCESS1773135366988https://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-s1gw/738/src/erab_fsm.erl2c0df591f5a6ec6b41fcf1a3662542f082aea6f81772827244000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deerab_fsm: fix comment inaccuracies and a typo Two comments copy-pasted from session_establish were left saying "ESTABLISH Req" in session_modify and session_delete handlers where "MODIFY Req" and "DELETE Req" are correct respectively. Also fix typo "unieue" -> "unique" in init/1. Change-Id: If84638142988767363aa080012b44082dee39f90 2026-03-07 03:00:44 +07002c0df591f5a6ec6b41fcf1a3662542f082aea6f8erab_fsm: fix comment inaccuracies and a typoeditsrc/erab_fsm.erlsrc/pfcp_peer.erld988d804b52d2d9e9f557f9b208faedd7d7e786b1772827244000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.depfcp_peer: wrap seq_nr at 24-bit boundary PFCP sequence numbers are 24-bit (3GPP TS 29.244 section 7.2.2.2), but the counter was incremented without wrapping, eventually exceeding the type spec after 16,777,215 requests. Introduce PFCP_SEQ_NR_MAX and use it in the type spec and in the increment expression. Change-Id: Ie269894add9a82c36698320379df3aca3f7ffea8 2026-03-07 03:00:44 +0700d988d804b52d2d9e9f557f9b208faedd7d7e786bpfcp_peer: wrap seq_nr at 24-bit boundaryeditsrc/pfcp_peer.erlsrc/pfcp_peer.erl933290c40c646fda1bfc14c7749d19c0feaa25861772827244000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.depfcp_peer: replace deprecated erlang:timestamp/0 with os:system_time/1 erlang:timestamp/0 is deprecated since OTP 18. os:system_time(second) is the modern replacement and yields the result directly in seconds, removing the need to reassemble the {MegaSec, Sec, _} tuple. Change-Id: I4ad886a2222f0cee8a668b42efe8bfac800a55ac 2026-03-07 03:00:44 +0700933290c40c646fda1bfc14c7749d19c0feaa2586pfcp_peer: replace deprecated erlang:timestamp/0 with os:system_time/1editsrc/pfcp_peer.erlsrc/pfcp_peer.erlbee7ada183e009fc7ee3cf7d74ecbf192e837ce61772828565000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.depfcp_peer: replace watchdog process with a timer The watchdog process is spawned bare (no link/monitor), so if it crashes its failure goes unnoticed, and if pfcp_peer restarts the orphaned watchdog may fire a stale cast at the new process. The watchdog process exists solely to send a delayed message to pfcp_peer on timeout, and to be cancelled (by receiving heartbeat_response) when the response arrives. That's exactly what erlang:start_timer/3 does natively - no separate process needed. Change-Id: I8d71ad8300feefb0aecbf690a825a2b4e9f1102c 2026-03-07 03:22:45 +0700bee7ada183e009fc7ee3cf7d74ecbf192e837ce6pfcp_peer: replace watchdog process with a timereditsrc/pfcp_peer.erlsrc/s1ap_proxy.erl2e50684fd3f0e5e9e6a226186426397f1fe008be1772828765000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.des1ap_proxy: fix discarded result of handle_ies/3 in HO REQ ACK handler The call processing the optional E-RABFailedToSetupListHOReqAck IE did not pattern-match its return value, causing any errors returned by handle_ies/3 to be silently swallowed. Bind the result to {_, S2} to make the intent explicit. Change-Id: I1c8feeb63fe23876ae443784980e9dc22a450c54 2026-03-07 03:26:05 +07002e50684fd3f0e5e9e6a226186426397f1fe008bes1ap_proxy: fix discarded result of handle_ies/3 in HO REQ ACK handlereditsrc/s1ap_proxy.erlsrc/enb_registry.erld664769b0ea52104fc94bea8e0097c3b318ba54d1773049437000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deenb_registry: call enb_metrics_register/1 from a proper place enb_metrics_register/1 requires the Global-eNB-ID to register per-eNB metrics. Calling it for every event, which may or may not contain the Global-eNB-ID, is suboptimal. Instead, invoke it from the enb_handle_event/2 clause that handles the {s1setup, GENBId} event, where the Global-Enb-ID is guaranteed to be available. Change-Id: I38237463aa9c968f89bf4f195407a18cba7e73c9 2026-03-09 16:43:57 +0700d664769b0ea52104fc94bea8e0097c3b318ba54denb_registry: call enb_metrics_register/1 from a proper placeeditsrc/enb_registry.erlsrc/enb_registry.erl40b2e5fc04cb667846470aa8d02f822a83861a4b1773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deenb_registry: fix pattern match in handle_info 'DOWN' handler PIDs maps pid() => enb_handle() (an integer), so maps:find/2 returns {ok, SomeHandle}. The old pattern {ok, Pid} tried to match an integer against the already-bound pid() variable, which never succeeds. This handler is only called on abnormal termination (process crash), so the broken match caused the registry entry to never be cleaned up in that case. Fix by using a fresh {ok, Handle} binding and removing the now-redundant follow-up maps:get/2 call. Change-Id: I4cb044e8071c4ae2fc48c507f8733af6c617ec46 2026-03-09 17:40:37 +070040b2e5fc04cb667846470aa8d02f822a83861a4benb_registry: fix pattern match in handle_info 'DOWN' handlereditsrc/enb_registry.erlsrc/enb_registry.erla3022395de343157fb769ae0134308afe55ad7121773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deenb_registry: fix duplicate registration check in enb_register/0 next_handle was bound in the function head and reused in the case pattern {ok, Handle}, turning what looks like a binding into an equality test against next_handle. The duplicate check therefore only fired if the previously assigned handle happened to equal the current next_handle counter, which is essentially never true. Fix by removing next_handle from the function head pattern and reading it with S#state.next_handle inside the error branch, so that Handle in {ok, Handle} is always a fresh binding that matches any existing handle. Change-Id: Ia64f3e2e79bea055e5c37df9bce91a4bcbf7184c 2026-03-09 17:40:37 +0700a3022395de343157fb769ae0134308afe55ad712enb_registry: fix duplicate registration check in enb_register/0editsrc/enb_registry.erlsrc/enb_registry.erlaf9b9f6f8dbf911bbce126c4ebb88f24ce9c589a1773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deenb_registry: fix addr/port filter logic (use andalso) In Erlang a function body returns only its last expression. The comma between the two enb_filter_by_sub_field/2 calls caused the result of the addr check to be silently discarded, so the filter only tested the port. Replace the comma with andalso to require both to match. Change-Id: I8061636cd1077a4f3a9e9d37a31224f5e373becb 2026-03-09 17:40:37 +0700af9b9f6f8dbf911bbce126c4ebb88f24ce9c589aenb_registry: fix addr/port filter logic (use andalso)editsrc/enb_registry.erlpriv/openapi.jsonsrc/enb_registry.erldoc/osmo-s1gw-cli.mdcontrib/openapi.yamlsrc/enb_proxy.erl1ddab3c7c1ffda391ff76a5349a81f40fb610c681773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.deenb_registry: rework handling of eNB property updates The idea of an enb_event/0 containing the current MME connection state and the associated information (Global-eNB-ID, eNB/MME conn info) looked promising initially, however turned out to be impractical in light of ongoing MME pooling related changes. * remove type enb_state/0 * rename type enb_event/0 -> enb_prop/0 * rename function enb_event/2 -> enb_update/2 (now private) * enb_prop/0: separate the state from other properties * enb_update/2: accept a list of enb_prop/0 - enb_proplist/0 * add typed notify_*() helpers that group related property updates, ensuring consistency and serving as the sole public call sites * notify_mme_connecting(): explicitly clears mme_conn_info * openapi: EnbItem.state reflects the actual enb_proxy FSM state Change-Id: Ib5c5dedce729151cd7350390987fdd008b254ef4 Related: SYS#7052 2026-03-09 17:40:37 +07001ddab3c7c1ffda391ff76a5349a81f40fb610c68enb_registry: rework handling of eNB property updateseditsrc/enb_registry.erleditpriv/openapi.jsoneditsrc/enb_proxy.erleditdoc/osmo-s1gw-cli.mdeditcontrib/openapi.yamlsrc/mme_registry.erltest/mme_registry_test.erlsrc/osmo_s1gw_sup.erlade7e52c542f043b29f49b3b2683d421a9f99d8f1773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.demme_registry: the MME registry (pool) implementation Change-Id: Id5480222439bf93eca2e994b291c619dff823b01 Related: SYS#7052 2026-03-09 17:40:37 +0700ade7e52c542f043b29f49b3b2683d421a9f99d8fmme_registry: the MME registry (pool) implementationaddtest/mme_registry_test.erladdsrc/mme_registry.erleditsrc/osmo_s1gw_sup.erlpriv/openapi.jsondoc/osmo-s1gw-cli.mdcontrib/osmo-s1gw-cli.pysrc/rest_server.erlcontrib/openapi.yaml63ce2c91cb71185f710931b30a0e88311a9a3f1c1773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.de[REST] Add MmeList, MmeAdd, MmeInfo, MmeDelete Change-Id: Iad249aed99face9e35fd19e0596cf2364ade4c77 Related: SYS#7052 2026-03-09 17:40:37 +070063ce2c91cb71185f710931b30a0e88311a9a3f1c[REST] Add MmeList, MmeAdd, MmeInfo, MmeDeleteeditcontrib/osmo-s1gw-cli.pyeditsrc/rest_server.erleditcontrib/openapi.yamleditdoc/osmo-s1gw-cli.mdeditpriv/openapi.jsontest/s1ap_utils_test.erldef69ca5d00c6f7ae3168ec5a45b13e5d2ef379b1773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.des1ap_utils_test: fix: expected value goes first Change-Id: Ib7c6478b95a78c9797e86180a89c098e75b615e0 2026-03-09 17:40:37 +0700def69ca5d00c6f7ae3168ec5a45b13e5d2ef379bs1ap_utils_test: fix: expected value goes firstedittest/s1ap_utils_test.erltest/s1ap_utils_test.erlsrc/s1ap_utils.erltest/s1ap_samples.erl0f796cc231437d84edf58218c28ae193110115c11773052837000https://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiyvyanitskiy@sysmocom.des1ap_utils: add API for building S1 SETUP FAILURE PDU This API will be used in a follow-up patch adding the MME pooling. Take a chance to add a parsing test for the new PDU blob. Change-Id: I5a4e060e0a2ebdfbcfafac42f9de2e49ac3583b8 Related: SYS#7052 2026-03-09 17:40:37 +07000f796cc231437d84edf58218c28ae193110115c1s1ap_utils: add API for building S1 SETUP FAILURE PDUedittest/s1ap_utils_test.erleditsrc/s1ap_utils.erledittest/s1ap_samples.erlgithttps://jenkins.osmocom.org/jenkins/user/fixeriaVadim Yanitskiy738https://jenkins.osmocom.org/jenkins/view/registry/job/master-osmo-s1gw/a1=default,a2=default,a3=default,a4=default,label=osmocom-master/738/