Skip to content
[Jenkins]Jenkins
log insign up
Failed

Changes

Summary

  1. jobs/ttcn3-testsuites: run remsim with testenv (details)
  2. *.py: fix imported but unused (details)
  3. *.py: fix variable assigned to but never used (details)
  4. *.py: ignore: E722 Do not use bare `except` (details)
  5. OBS: fix f-string without any placeholders (details)
  6. scripts/verify_log_statements: fix undefined name (details)
  7. lint: run 'ruff' on various repositories (details)
Commit 7d7df727072c4ce8e6983b3888a3a766994efa9b by Oliver Smith
jobs/ttcn3-testsuites: run remsim with testenv

Related: OS#6494
Change-Id: Ibaa638408c130335e5d14590111e641493cdc194
The file was modifiedjobs/ttcn3-testsuites-testenv.yml
The file was modifiedjobs/ttcn3-testsuites.yml
Commit 8dfedc315945fdf273af4a7362a3bbd2d473292a by Oliver Smith
*.py: fix imported but unused

Prepare to run "ruff check" on this repository by first fixing what it
complains about in this and following patches.

Change-Id: I89fa4a50a28f6ceab48cce939ca0c076967d43fd
The file was modifiedscripts/obs/sync_obs_projects.py
The file was modifiedlint/checkpatch/checkpatch_json.py
The file was modifiedscripts/osmo-depcheck/buildstack.py
The file was modifiedscripts/obs/lib/srcpkg.py
The file was modifiedscripts/obs/lib/osc.py
Commit e224a518c2b20a3130eac768012c90584c0efb46 by Oliver Smith
*.py: fix variable assigned to but never used

Change-Id: I6aca8f9aab10e7ee395980b53316a720ab2e2469
The file was modifiedscripts/obs/lib/metapkg.py
The file was modifiedscripts/obs/lib/debian.py
The file was modifiedscripts/verify_log_statements.py
Commit e28454ea4b120a7ab96e133589a7b7b3ee8c0846 by Oliver Smith
*.py: ignore: E722 Do not use bare `except`

Let the ruff linter not complain about the existing cases of "Do not use
bare `except`" so we get the linter to pass without changing the
existing logic here. With this we don't disable the check globally, so
we can consider making stricter excepts in new code.

Change-Id: Iaef20d47cd171aab23e516e7f7516caf98264249
The file was modifiedscripts/verify_log_statements.py
The file was modifiedscripts/obs/lib/srcpkg.py
Commit 9f2eea23f83a6bf2343e10e631e2b025c1237d22 by Oliver Smith
OBS: fix f-string without any placeholders

Change-Id: I9b7b11a41930a99819a3569f817a0da5586e30a3
The file was modifiedscripts/obs/sync_obs_projects.py
Commit c8ec5d58507718165b863c36b51e29e9afd1a4a1 by Oliver Smith
scripts/verify_log_statements: fix undefined name

Append it to "errors_found" instead of undefined variable "ignored".
This makes it work similarly to further above:

      # Skip 'LOG("bla" fmt )' strings that typically appear as #defines.
      if fmt_re.match(quoted):
        if debug:
          errors_found.append(error_found(f, log.start(), 'Skipping define', log.group(0)))
        continue

Fix the following bug:

  scripts/verify_log_statements.py:92:11: F821 Undefined name `ignored`
     |
  90 |         # hopefully eval broke because of some '## args' macro def
  91 |         if debug:
  92 |           ignored.append(error_found(f, log.start(), 'Ignoring', log.group(0)))
     |           ^^^^^^^ F821
  93 |         continue
     |

Change-Id: I4661d4677a1f0fc8d595985e73e2632b9a83b7d6
The file was modifiedscripts/verify_log_statements.py
Commit 35336da8665e2294fa8e153afc1f4bcd405b055a by Oliver Smith
lint: run 'ruff' on various repositories

Lint the python code with "ruff check" and "ruff format" where they are
known to pass.

Related: https://docs.astral.sh/ruff/
Change-Id: I5c2ede1a7b2a204ca3deb24c55008c7585c289a0
The file was modifiedlint/lint_diff.sh