Skip to content
Failed

Changes

Summary

  1. jenkins-gerrit: print the URLs this script reads (details)
  2. jenkins-gerrit: binpkgs: ignore decode errors (details)
  3. jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean (details)
Commit 41c933c85109b3500ae7cb286be6f685afc6920e by Oliver Smith
jenkins-gerrit: print the URLs this script reads

Make errors easier to understand by printing all URLs that the script is
reading from.

Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5
The file was modifiedscripts/jenkins-gerrit/comment_generate.py
Commit bc5dbb3093b47a5dfdca8f956d85e2cd5a7bcba1 by Oliver Smith
jenkins-gerrit: binpkgs: ignore decode errors

The output of recent osmo-s1gw jobs for building binary packages
contains invalid utf-8 characters, even though it should be utf-8
according to the HTTP header:
  content-type: text/plain;charset=utf-8

We only need to get the distro name from the output here, so simply
ignore any decode errors.

Fix for:
  $ ./comment_generate.py https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417/ -o gerrit_report.json -t result
  Reading https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417//consoleText
  Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17255/consoleText
  Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17260/consoleText
  Traceback (most recent call last):
    File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 270, in <module>
      main()
    File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 257, in main
      comment = get_comment_result(args.build_url, args.notify_on_success)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 198, in get_comment_result
      pipeline = parse_pipeline(build_url)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 89, in parse_pipeline
      stage = stage_from_job_name(job_name, job_url)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 59, in stage_from_job_name
      return stage_binpkgs_from_url(job_url)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 46, in stage_binpkgs_from_url
      content = response.read().decode("utf-8")
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  UnicodeDecodeError: 'utf-8' codec can't decode byte 0xef in position 237446: invalid continuation byte

Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b
The file was modifiedscripts/jenkins-gerrit/comment_generate.py
Commit cf88fab8cda55362233afbbd54aba0b99a263d44 by Vadim Yanitskiy
jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean

It's easy to break the build verification [for everybody] by
submitting a patch that creates a symlink to a non-existent file.
The workspace is not wiped, so the stale symlink remains and results
in failures like this:

(cd sgsn && ./gen_links.sh && ./regen_makefile.sh)
ttcn3_makefilegen: error: Cannot find any source file for argument `NAS_Templates.ttcn'.
make: *** [Makefile:131: _build/sgsn/Makefile] Error 1

Let's invoke the 'clean' recipe before 'compile' to avoid this.

Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af
The file was modifiedjobs/gerrit-verifications.yml