Skip to content
Success

#22247 (Jun 20, 2026, 9:05:57 PM)

Started 8 hr 4 min ago
Took 1 min 18 sec on build5-deb12build-ansible

Started by upstream project gerrit-osmo-pcap build number 253
originally caused by:

This run spent:

  • 5.9 sec waiting;
  • 1 min 18 sec build duration;
  • 1 min 24 sec total from scheduled to completion.
Revision: f0d4360da16dd7c4a1d08f27c025526e508764b3
Repository: $GERRIT_REPO_URL
  • master
tls: fix broken certificate hostname verification

verify_cert_cb() retrieved the gnutls session pointer and passed it to
gnutls_certificate_verify_peers3() as the expected hostname.  But the
session pointer is set to the osmo_tls_session struct (it is needed by
cert_callback()), not a hostname string.  Hostname matching was
therefore performed against raw struct bytes, rendering verification
meaningless and potentially reading out of bounds, even when
"tls verify-cert" was enabled.

Store the configured hostname in struct osmo_tls_session and have
verify_cert_cb() read it from there.  Also drop the stray
gnutls_certificate_verify_peers3() call in the client setup: it ran
before any handshake (so there were no peer certificates yet) and its
result was ignored; the real verification happens via the registered
callback during the handshake.

Change-Id: If64950a698bfcfbf556a37ef1be3e68abc124384
AI-Assisted: yes (Claude)
Vadim Yanitskiy at