Skip to content
Sign in
Success

#22455 (Jul 28, 2026, 7:03:59 PM)

Started 8 hr 47 min ago
Took 2 min 17 sec on build4-deb12build-ansible

Started by upstream project gerrit-simtrace2 build number 120
originally caused by:

This run spent:

  • 5.5 sec waiting;
  • 2 min 17 sec build duration;
  • 2 min 22 sec total from scheduled to completion.
Revision: b1d9b3ad99544d2f39fb61b5c3cddbb303b024c9
Repository: $GERRIT_REPO_URL
  • master
firmware: sniffer: fix ~INS procedure byte comparison

(~g_tpdu.packet[1]) == byte can never be true.
Unary ~ applies the integer promotions first,
so for tpdu INS = 0xA4 lhs should be 0x5B but as int
it gets zero extended to at least 16 bits and then flipped,
so it is 0xFFFFFF5B = -165, byte promotes to 0..255.

The ack was therefore dead code -> fallthrough to SW1
branch, fails 0x6x/0x9x test, TPDU gets flagged
SNIFF_DATA_FLAG_ERROR_MALFORMED from what I can tell.
But I am losing track of all these arcane issues to be honest.

Narrow the complement back to 8 bits.
Fyi this is unrelated to signedness and not specific to ARM.

Change-Id: I800f50ef35356429d07aa685ea919e70ec34946e
ewild at