Skip to content
Success

Changes

Summary

  1. rate_ctr,CTRL[1/2]: GET using rate_ctr_group_set_name() (details)
Commit 61d71904c1b0957ab34f6a643f9145beacb26b7d by Neels Hofmeyr
rate_ctr,CTRL[1/2]: GET using rate_ctr_group_set_name()

In CTRL, add keyword "by_id" to use the given name for group instance
lookup. IOW, in addition to currently:

  GET 123 rate_ctr.abs.hnb.0.iuh:established

also implement:

  GET 123 rate_ctr.abs.hnb.by_id.001-01-L2342-R0-S55-C1.iuh:established

Some objects always have fixed indexes, because they come from the
config file (think "bts.0" or "msc.0").

However, some object IDs are created dynamically, which makes it
"impossible" to verify them in tests. In osmo-hnbgw, the same hNodeB may
show up as hnb.0, hnb.1, etc.

We do already have the rate_ctr_group_set_name() API which allows
tagging an identifier on a rate counter group. For above example,
osmo-hnbgw sets rate_ctr_group_set_name(cell_id_str).

When merging this patch, magically all rate_ctr_groups in all osmo
programs will become accessible by their given rate_ctr_group_set_name()
IDs. See the following patch for identifier validation.

Related: OS#6545
Change-Id: I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137
The file was modifiedsrc/core/libosmocore.map
The file was modifiedsrc/core/rate_ctr.c
The file was modifiedinclude/osmocom/core/rate_ctr.h
The file was modifiedsrc/ctrl/control_if.c