![[Jenkins]](/jenkins/static/b68c8964/images/svgs/logo.svg){kind=logo}
Started by upstream project "gerrit-osmo-sgsn" build number 400 originally caused by: Triggered by Gerrit: https://gerrit.osmocom.org/c/osmo-sgsn/+/39560 in silent mode. Running as SYSTEM Building remotely on build4-deb12build-ansible (ttcn3 obs osmo-gsm-tester-build ttcn3_with_linux_6.1_or_higher qemu io_uring osmocom-gerrit coverity osmocom-master) in workspace /home/osmocom-build/jenkins/workspace/gerrit-lint [ssh-agent] Looking for ssh-agent implementation... $ ssh-agent SSH_AUTH_SOCK=/tmp/ssh-XXXXXXcqtn5S/agent.987199 SSH_AGENT_PID=987205 [ssh-agent] Started. Running ssh-add (command line suppressed) Identity added: /home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_9202272894841434751.key (/home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_9202272894841434751.key) [ssh-agent] Using credentials jenkins (gerrit.osmocom.org) The recommended git tool is: NONE using credential d5eda5e9-b59d-44ba-88d2-43473cb6e42d Wiping out workspace first. Cloning the remote Git repository Cloning repository ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn > git init /home/osmocom-build/jenkins/workspace/gerrit-lint/code-from-gerrit # timeout=10 Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn > git --version # timeout=10 > git --version # 'git version 2.39.2' using GIT_SSH to set credentials gerrit.osmocom.org Verifying host key using known hosts file, will automatically accept unseen keys > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn # timeout=10 Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn using GIT_SSH to set credentials gerrit.osmocom.org Verifying host key using known hosts file, will automatically accept unseen keys > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn refs/changes/60/39560/1 # timeout=10 > git rev-parse FETCH_HEAD^{commit} # timeout=10 Checking out Revision 71c7834dbf07a77ad10455cc89d959bcd87d98a1 (master) > git config core.sparsecheckout # timeout=10 > git checkout -f 71c7834dbf07a77ad10455cc89d959bcd87d98a1 # timeout=10 Commit message: "add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2" > git rev-parse FETCH_HEAD^{commit} # timeout=10 > git rev-list --no-walk df6580685fa13ac16cbfe870f195b42acb9f26dc # timeout=10 [gerrit-lint] $ /bin/sh -xe /tmp/jenkins8114697323210307663.sh + rm -rf osmo-ci + git clone --depth=1 --branch=master https://gerrit.osmocom.org/osmo-ci osmo-ci Cloning into 'osmo-ci'... + git -C osmo-ci log --oneline c792b8c coverity: use proper asn1c branch + cd code-from-gerrit + ../osmo-ci/lint/lint_diff.sh HEAD~1 Running docker_run_rm.sh on the whole tree... Running checkpatch on 'git diff HEAD~1'... include/osmocom/vlr/vlr.h:121: WARNING:MISORDERED_TYPE: type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order src/libvlr/vlr.c:238: ERROR:SPACING: spaces required around that '?' (ctx:VxW) src/libvlr/vlr.c:242: ERROR:SPACING: spaces required around that '?' (ctx:VxW) src/libvlr/vlr.c:246: ERROR:SPACING: spaces required around that '?' (ctx:VxW) src/libvlr/vlr.c:258: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr.c:263: ERROR:STRCPY_OSMO: Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() src/libvlr/vlr.c:380: ERROR:SPACING: spaces required around that '?' (ctx:VxW) src/libvlr/vlr.c:705: ERROR:CODE_INDENT: code indent should use tabs where possible src/libvlr/vlr.c:810: ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar" src/libvlr/vlr.c:1447: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr.c:1455: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr.c:1457: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr.c:1459: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr.c:1716: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_access_req_fsm.c:111: ERROR:SPACING: spaces required around that '?' (ctx:VxW) src/libvlr/vlr_access_req_fsm.c:415: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return src/libvlr/vlr_access_req_fsm.c:421: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return src/libvlr/vlr_access_req_fsm.c:496: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_access_req_fsm.c:791: ERROR:SPACING: space prohibited before that ',' (ctx:WxE) src/libvlr/vlr_access_req_fsm.c:798: ERROR:SPACING: space prohibited before that ',' (ctx:WxE) src/libvlr/vlr_auth_fsm.c:199: ERROR:SPACING: spaces required around that '?' (ctx:VxW) src/libvlr/vlr_auth_fsm.c:216: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return src/libvlr/vlr_auth_fsm.c:543: ERROR:STRCPY_OSMO: Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() src/libvlr/vlr_lu_fsm.c:160: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_lu_fsm.c:272: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_lu_fsm.c:667: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_lu_fsm.c:1282: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_lu_fsm.c:1404: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_lu_fsm.c:1436: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_lu_fsm.c:1643: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" src/libvlr/vlr_lu_fsm.c:1691: ERROR:STRCPY_OSMO: Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() src/libvlr/vlr_sgs.c:324: WARNING:RETURN_VOID: void function return statements are not generally useful total: 27 errors, 5 warnings, 6729 lines checked Please fix the linting errors above. More information: https://osmocom.org/projects/cellular-infrastructure/wiki/Linting Leaving review comments in gerrit... + git diff -U0 HEAD~1 + /home/osmocom-build/jenkins/workspace/gerrit-lint/osmo-ci/lint/checkpatch/checkpatch_osmo.sh + true + cd .. + /home/osmocom-build/jenkins/workspace/gerrit-lint/osmo-ci/lint/checkpatch/checkpatch_json.py checkpatch_output gerrit_report.json jenkins-gerrit-lint-21542 https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/ checkpatch_output {"comments": [], "robot_comments": {"include/osmocom/vlr/vlr.h": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "121", "message": "type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order"}], "src/libvlr/vlr.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "238", "message": "spaces required around that '?' (ctx:VxW)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "242", "message": "spaces required around that '?' (ctx:VxW)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "246", "message": "spaces required around that '?' (ctx:VxW)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "258", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "263", "message": "Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "380", "message": "spaces required around that '?' (ctx:VxW)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "705", "message": "code indent should use tabs where possible"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "810", "message": "\"foo* bar\" should be \"foo *bar\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1447", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1455", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1457", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1459", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1716", "message": "\"(foo*)\" should be \"(foo *)\""}], "src/libvlr/vlr_access_req_fsm.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "111", "message": "spaces required around that '?' (ctx:VxW)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "415", "message": "else is not generally useful after a break or return"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "421", "message": "else is not generally useful after a break or return"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "496", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "791", "message": "space prohibited before that ',' (ctx:WxE)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "798", "message": "space prohibited before that ',' (ctx:WxE)"}], "src/libvlr/vlr_auth_fsm.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "199", "message": "spaces required around that '?' (ctx:VxW)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "216", "message": "else is not generally useful after a break or return"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "543", "message": "Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()"}], "src/libvlr/vlr_lu_fsm.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "160", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "272", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "667", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1282", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1404", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1436", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1643", "message": "\"(foo*)\" should be \"(foo *)\""}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "1691", "message": "Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()"}], "src/libvlr/vlr_sgs.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21542", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21542/", "line": "324", "message": "void function return statements are not generally useful"}]}} + ssh -p 29418 -l jenkins gerrit.osmocom.org gerrit review --project osmo-sgsn 39560,1 --json + exit 1 Build step 'Execute shell' marked build as failure $ ssh-agent -k unset SSH_AUTH_SOCK; unset SSH_AGENT_PID; echo Agent pid 987205 killed; [ssh-agent] Stopped. Finished: FAILURE