Console Output

Download View as plain text
Started by upstream project "gerrit-osmo-sgsn" build number 406
originally caused by:
 Triggered by Gerrit: https://gerrit.osmocom.org/c/osmo-sgsn/+/39562 in silent mode.
Running as SYSTEM
Building remotely on build4-deb12build-ansible (ttcn3 obs osmo-gsm-tester-build ttcn3_with_linux_6.1_or_higher qemu io_uring osmocom-gerrit coverity osmocom-master) in workspace /home/osmocom-build/jenkins/workspace/gerrit-lint
[ssh-agent] Looking for ssh-agent implementation...
$ ssh-agent
SSH_AUTH_SOCK=/tmp/ssh-XXXXXX53n1Qm/agent.1268459
SSH_AGENT_PID=1268466
[ssh-agent] Started.
Running ssh-add (command line suppressed)
Identity added: /home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_18083984498406703896.key (/home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_18083984498406703896.key)
[ssh-agent] Using credentials jenkins (gerrit.osmocom.org)
The recommended git tool is: NONE
using credential d5eda5e9-b59d-44ba-88d2-43473cb6e42d
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn
 > git init /home/osmocom-build/jenkins/workspace/gerrit-lint/code-from-gerrit # timeout=10
Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn
 > git --version # timeout=10
 > git --version # 'git version 2.39.2'
using GIT_SSH to set credentials gerrit.osmocom.org
Verifying host key using known hosts file, will automatically accept unseen keys
 > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn # timeout=10
Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn
using GIT_SSH to set credentials gerrit.osmocom.org
Verifying host key using known hosts file, will automatically accept unseen keys
 > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/39562/2 # timeout=10
 > git rev-parse FETCH_HEAD^{commit} # timeout=10
Checking out Revision 9239c8c7cc6b11ad74e35480cde6e780f0665d92 (master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 9239c8c7cc6b11ad74e35480cde6e780f0665d92 # timeout=10
Commit message: "Rework SGSN code to use new libvlr code"
 > git rev-parse FETCH_HEAD^{commit} # timeout=10
 > git rev-list --no-walk 1b546e87bd2b7e5cb77be40a6308a354e5cd2e27 # timeout=10
[gerrit-lint] $ /bin/sh -xe /tmp/jenkins14761567731395148202.sh
+ rm -rf osmo-ci
+ git clone --depth=1 --branch=master https://gerrit.osmocom.org/osmo-ci osmo-ci
Cloning into 'osmo-ci'...
+ git -C osmo-ci log --oneline
c792b8c coverity: use proper asn1c branch
+ cd code-from-gerrit
+ ../osmo-ci/lint/lint_diff.sh HEAD~1
Running docker_run_rm.sh on the whole tree...

Running checkpatch on 'git diff HEAD~1'...

src/sgsn/gprs_gmm.c:1220: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for any arm of this statement
src/sgsn/gprs_gmm.c:1290: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:1551: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:1555: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:1673: ERROR:OPEN_BRACE: that open brace { should be on the previous line
src/sgsn/gprs_gmm.c:1759: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:1787: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for any arm of this statement
src/sgsn/gprs_gmm.c:1817: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:1964: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
src/sgsn/gprs_gmm.c:2321: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:2345: WARNING:TYPO_SPELLING: 'loosing' may be misspelled - perhaps 'losing'?
src/sgsn/gprs_gmm.c:2372: ERROR:OPEN_BRACE: that open brace { should be on the previous line
src/sgsn/gprs_gmm.c:2387: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:2393: ERROR:SPACING: space required before the open parenthesis '('
src/sgsn/gprs_gmm.c:2431: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_rau_fsm.c:206: ERROR:SPACING: space required before the open parenthesis '('
src/sgsn/gprs_rau_fsm.c:231: ERROR:SPACING: space required before the open parenthesis '('
src/sgsn/gprs_rau_fsm.c:304: ERROR:SPACING: need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
src/sgsn/gprs_rau_fsm.c:310: ERROR:SPACING: need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
src/sgsn/gprs_rau_fsm.c:339: ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void)
src/sgsn/mmctx.c:619: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/sgsn_libgtp.c:537: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/sgsn_main.c:360: WARNING:LEADING_SPACE: please, no spaces at the start of a line
src/sgsn/sgsn_main.c:364: WARNING:LEADING_SPACE: please, no spaces at the start of a line
total: 8 errors, 16 warnings, 1864 lines checked

Please fix the linting errors above. More information:
https://osmocom.org/projects/cellular-infrastructure/wiki/Linting

Leaving review comments in gerrit...
+ git diff -U0 HEAD~1
+ /home/osmocom-build/jenkins/workspace/gerrit-lint/osmo-ci/lint/checkpatch/checkpatch_osmo.sh
+ true
+ cd ..
+ /home/osmocom-build/jenkins/workspace/gerrit-lint/osmo-ci/lint/checkpatch/checkpatch_json.py checkpatch_output gerrit_report.json jenkins-gerrit-lint-21547 https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/
checkpatch_output
{"comments": [], "robot_comments": {"src/sgsn/gprs_gmm.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1220", "message": "braces {} are not necessary for any arm of this statement"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1290", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1551", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1555", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1673", "message": "that open brace { should be on the previous line"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1759", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1787", "message": "braces {} are not necessary for any arm of this statement"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1817", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "1964", "message": "else is not generally useful after a break or return"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "2321", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "2345", "message": "'loosing' may be misspelled - perhaps 'losing'?"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "2372", "message": "that open brace { should be on the previous line"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "2387", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "2393", "message": "space required before the open parenthesis '('"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "2431", "message": "braces {} are not necessary for single statement blocks"}], "src/sgsn/gprs_rau_fsm.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "206", "message": "space required before the open parenthesis '('"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "231", "message": "space required before the open parenthesis '('"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "304", "message": "need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "310", "message": "need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "339", "message": "Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void)"}], "src/sgsn/mmctx.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "619", "message": "braces {} are not necessary for single statement blocks"}], "src/sgsn/sgsn_libgtp.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "537", "message": "braces {} are not necessary for single statement blocks"}], "src/sgsn/sgsn_main.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "360", "message": "please, no spaces at the start of a line"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21547", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21547/", "line": "364", "message": "please, no spaces at the start of a line"}]}}
+ ssh -p 29418 -l jenkins gerrit.osmocom.org gerrit review --project osmo-sgsn 39562,2 --json
+ exit 1
Build step 'Execute shell' marked build as failure
$ ssh-agent -k
unset SSH_AUTH_SOCK;
unset SSH_AGENT_PID;
echo Agent pid 1268466 killed;
[ssh-agent] Stopped.
Finished: FAILURE