Console Output

Download View as plain text
Started by upstream project "gerrit-osmo-sgsn" build number 417
originally caused by:
 Triggered by Gerrit: https://gerrit.osmocom.org/c/osmo-sgsn/+/39563 in silent mode.
Running as SYSTEM
Building remotely on build4-deb12build-ansible (ttcn3 obs osmo-gsm-tester-build ttcn3_with_linux_6.1_or_higher qemu io_uring osmocom-gerrit coverity osmocom-master) in workspace /home/osmocom-build/jenkins/workspace/gerrit-lint
[ssh-agent] Looking for ssh-agent implementation...
$ ssh-agent
SSH_AUTH_SOCK=/tmp/ssh-XXXXXX1JSTa0/agent.14977
SSH_AGENT_PID=14994
[ssh-agent] Started.
Running ssh-add (command line suppressed)
Identity added: /home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_9631682473531186462.key (/home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_9631682473531186462.key)
[ssh-agent] Using credentials jenkins (gerrit.osmocom.org)
The recommended git tool is: NONE
using credential d5eda5e9-b59d-44ba-88d2-43473cb6e42d
Wiping out workspace first.
Cloning the remote Git repository
Cloning repository ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn
 > git init /home/osmocom-build/jenkins/workspace/gerrit-lint/code-from-gerrit # timeout=10
Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn
 > git --version # timeout=10
 > git --version # 'git version 2.39.2'
using GIT_SSH to set credentials gerrit.osmocom.org
Verifying host key using known hosts file, will automatically accept unseen keys
 > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn # timeout=10
Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn
using GIT_SSH to set credentials gerrit.osmocom.org
Verifying host key using known hosts file, will automatically accept unseen keys
 > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-sgsn refs/changes/63/39563/4 # timeout=10
 > git rev-parse FETCH_HEAD^{commit} # timeout=10
Checking out Revision 97aaab99c17a00eb045e736dd0b17746c12d6b65 (master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 97aaab99c17a00eb045e736dd0b17746c12d6b65 # timeout=10
Commit message: "Add Gn support to allow MME->SGSN, SGSN->MME cell reselection"
 > git rev-parse FETCH_HEAD^{commit} # timeout=10
 > git rev-list --no-walk 51f0c4c45dde5f75aa33faba8c35c391238f76cd # timeout=10
[gerrit-lint] $ /bin/sh -xe /tmp/jenkins13911396205542144382.sh
+ rm -rf osmo-ci
+ git clone --depth=1 --branch=master https://gerrit.osmocom.org/osmo-ci osmo-ci
Cloning into 'osmo-ci'...
+ git -C osmo-ci log --oneline
c792b8c coverity: use proper asn1c branch
+ cd code-from-gerrit
+ ../osmo-ci/lint/lint_diff.sh HEAD~1
Running docker_run_rm.sh on the whole tree...

Running checkpatch on 'git diff HEAD~1'...

src/sgsn/gprs_gmm.c:2568: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:2597: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/gprs_gmm.c:2627: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
src/sgsn/gprs_rau_fsm.c:365: ERROR:SPACING: need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
src/sgsn/sgsn_libgtp.c:190: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/sgsn_libgtp.c:913: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
src/sgsn/sgsn_libgtp.c:918: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
src/sgsn/sgsn_libgtp.c:918: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
src/sgsn/sgsn_libgtp.c:1085: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'?
src/sgsn/sgsn_libgtp.c:1125: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
src/sgsn/sgsn_libgtp.c:1139: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
src/sgsn/sgsn_libgtp.c:1378: ERROR:STRCPY_OSMO: Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
src/sgsn/sgsn_libgtp.c:1388: WARNING:BRACES_NOT_NECESSARY: braces {} are not necessary for single statement blocks
total: 4 errors, 9 warnings, 936 lines checked

Please fix the linting errors above. More information:
https://osmocom.org/projects/cellular-infrastructure/wiki/Linting

Leaving review comments in gerrit...
+ git diff -U0 HEAD~1
+ /home/osmocom-build/jenkins/workspace/gerrit-lint/osmo-ci/lint/checkpatch/checkpatch_osmo.sh
+ true
+ cd ..
+ /home/osmocom-build/jenkins/workspace/gerrit-lint/osmo-ci/lint/checkpatch/checkpatch_json.py checkpatch_output gerrit_report.json jenkins-gerrit-lint-21558 https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/
checkpatch_output
{"comments": [], "robot_comments": {"src/sgsn/gprs_gmm.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "2568", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "2597", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "2627", "message": "else is not generally useful after a break or return"}], "src/sgsn/gprs_rau_fsm.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "365", "message": "need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)"}], "src/sgsn/sgsn_libgtp.c": [{"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "190", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "913", "message": "Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "918", "message": "Macros with multiple statements should be enclosed in a do - while loop"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "918", "message": "macros should not use a trailing semicolon"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "1085", "message": "'transfered' may be misspelled - perhaps 'transferred'?"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "1125", "message": "braces {} are not necessary for single statement blocks"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "1139", "message": "please, no space before tabs"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "1378", "message": "Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()"}, {"robot_id": "checkpatch", "robot_run_id": "jenkins-gerrit-lint-21558", "url": "https://jenkins.osmocom.org/jenkins/job/gerrit-lint/21558/", "line": "1388", "message": "braces {} are not necessary for single statement blocks"}]}}
+ ssh -p 29418 -l jenkins gerrit.osmocom.org gerrit review --project osmo-sgsn 39563,4 --json
+ exit 1
Build step 'Execute shell' marked build as failure
$ ssh-agent -k
unset SSH_AUTH_SOCK;
unset SSH_AGENT_PID;
echo Agent pid 14994 killed;
[ssh-agent] Stopped.
Finished: FAILURE