Started by upstream project "gerrit-osmo-ccid-firmware" build number 146 originally caused by: Triggered by Gerrit: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42504 in silent mode. Running as SYSTEM Building remotely on build4-deb12build-ansible (ttcn3 obs osmo-gsm-tester-build qemu io_uring linux-shallow-clone osmocom-gerrit coverity osmocom-master) in workspace /home/osmocom-build/jenkins/workspace/gerrit-lint [ssh-agent] Looking for ssh-agent implementation... $ ssh-agent SSH_AUTH_SOCK=/tmp/ssh-9qFGjk2SjQtP/agent.3202578 SSH_AGENT_PID=3202581 [ssh-agent] Started. Running ssh-add (command line suppressed) Identity added: /home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_14887664311672861534.key (/home/osmocom-build/jenkins/workspace/gerrit-lint@tmp/private_key_14887664311672861534.key) [ssh-agent] Using credentials jenkins (gerrit.osmocom.org) The recommended git tool is: NONE using credential d5eda5e9-b59d-44ba-88d2-43473cb6e42d Wiping out workspace first. Cloning the remote Git repository Cloning repository ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware > git init /home/osmocom-build/jenkins/workspace/gerrit-lint/code-from-gerrit # timeout=10 Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware > git --version # timeout=10 > git --version # 'git version 2.39.5' using GIT_SSH to set credentials gerrit.osmocom.org Verifying host key using known hosts file, will automatically accept unseen keys > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware # timeout=10 Fetching upstream changes from ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware using GIT_SSH to set credentials gerrit.osmocom.org Verifying host key using known hosts file, will automatically accept unseen keys > git fetch --tags --force --progress -- ssh://jenkins@gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/04/42504/1 # timeout=10 > git rev-parse FETCH_HEAD^{commit} # timeout=10 Checking out Revision e93dc72265cd548a59888e1db1e712928b091602 (master) > git config core.sparsecheckout # timeout=10 > git checkout -f e93dc72265cd548a59888e1db1e712928b091602 # timeout=10 Commit message: "firmware: add tear-free 64bit load/store helpers for jiffies" > git rev-parse FETCH_HEAD^{commit} # timeout=10 > git rev-list --no-walk 639db145ed16f59a3a1cee72dde4dfef32f3d545 # timeout=10 [gerrit-lint] $ /bin/sh -xe /tmp/jenkins15674981558320112486.sh + rm -rf osmo-ci + git clone --depth=1 --branch=master https://gerrit.osmocom.org/osmo-ci osmo-ci Cloning into 'osmo-ci'... + git -C osmo-ci log --oneline 5d6b88b manuals: osmo-s1gw: adjust build_publish_manuals + readlink -f /tmp/ssh-9qFGjk2SjQtP/agent.3202578 + docker run --rm -e GERRIT_HOST=gerrit.osmocom.org -e GERRIT_PORT=29418 -e GERRIT_PROJECT=osmo-ccid-firmware -e GERRIT_CHANGE_NUMBER=42504 -e GERRIT_PATCHSET_NUMBER=1 -e JENKINS_HOME=1 -e SSH_AUTH_SOCK=/ssh-agent -u build -v /tmp/ssh-9qFGjk2SjQtP/agent.3202578:/ssh-agent -v ./code-from-gerrit:/build/code-from-gerrit -v ./osmo-ci:/build/osmo-ci -w /build/code-from-gerrit osmocom-build/debian-trixie-build /build/osmo-ci/lint/lint_diff.sh HEAD~1 Running docker_run_rm.sh on the whole tree... Running checkpatch on 'git diff HEAD~1'... config: .checkpatch.conf Running clang-format on 'git diff HEAD~1'... Debian clang-format version 19.1.7 (3+b1) --- ccid_common/atomic_u64.h (before formatting) +++ ccid_common/atomic_u64.h (after formatting) @@ -12,12 +12,11 @@ static inline uint64_t ldrd_u64(const volatile uint64_t *p) { uint32_t lo, hi; - __asm__ volatile ( + __asm__ volatile( "ldrd %0, %1, [%2] " : "=&r"(lo), "=&r"(hi) : "r"(p) - : "memory" - ); + : "memory"); return ((uint64_t)hi << 32) | lo; } @@ -25,14 +24,19 @@ { uint32_t lo = (uint32_t)v; uint32_t hi = (uint32_t)(v >> 32); - __asm__ volatile ( + __asm__ volatile( "strd %1, %2, [%0] " : : "r"(p), "r"(lo), "r"(hi) - : "memory" - ); + : "memory"); } #else /* host */ -static inline uint64_t ldrd_u64(const volatile uint64_t *p) { return *p; } -static inline void strd_u64(volatile uint64_t *p, uint64_t v) { *p = v; } +static inline uint64_t ldrd_u64(const volatile uint64_t *p) +{ + return *p; +} +static inline void strd_u64(volatile uint64_t *p, uint64_t v) +{ + *p = v; +} #endif --- sysmoOCTSIM/libosmo_emb.h (before formatting) +++ sysmoOCTSIM/libosmo_emb.h (after formatting) @@ -15,12 +15,11 @@ static inline uint64_t ldrd_u64(const volatile uint64_t *p) { uint32_t lo, hi; - __asm__ volatile ( + __asm__ volatile( "ldrd %0, %1, [%2] " : "=&r"(lo), "=&r"(hi) : "r"(p) - : "memory" - ); + : "memory"); return ((uint64_t)hi << 32) | lo; } @@ -28,16 +27,21 @@ { uint32_t lo = (uint32_t)v; uint32_t hi = (uint32_t)(v >> 32); - __asm__ volatile ( + __asm__ volatile( "strd %1, %2, [%0] " : : "r"(p), "r"(lo), "r"(hi) - : "memory" - ); + : "memory"); } #else /* host */ -static inline uint64_t ldrd_u64(const volatile uint64_t *p) { return *p; } -static inline void strd_u64(volatile uint64_t *p, uint64_t v) { *p = v; } +static inline uint64_t ldrd_u64(const volatile uint64_t *p) +{ + return *p; +} +static inline void strd_u64(volatile uint64_t *p, uint64_t v) +{ + *p = v; +} #endif uint64_t get_jiffies(void); Please fix the linting errors above. More information: https://osmocom.org/projects/cellular-infrastructure/wiki/Linting Leaving review comments in gerrit... + /build/osmo-ci/lint/checkpatch/checkpatch_osmo.sh + git diff -U0 HEAD~1 + cd .. + /build/osmo-ci/lint/checkpatch/checkpatch_json.py checkpatch_output gerrit_report.json checkpatch_output {"comments": [], "robot_comments": {}} + ssh -o UserKnownHostsFile=/build/osmo-ci/lint/../contrib/known_hosts -p 29418 -l jenkins gerrit.osmocom.org gerrit review --project osmo-ccid-firmware 42504,1 --json + exit 1 Build step 'Execute shell' marked build as failure $ ssh-agent -k unset SSH_AUTH_SOCK; unset SSH_AGENT_PID; echo Agent pid 3202581 killed; [ssh-agent] Stopped. Finished: FAILURE