Skip to content
Success

Changes

Summary

  1. gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 (details)
Commit f602ace7169d773f813a2c8bda653f636271a9e0 by Vadim Yanitskiy
gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

This IE is defined in 3GPP TS 44.060 Table 12.5a.2.1.  Each presence
bit indicates presence of the next two entries, not one.

This patch does affect the output of csn1_ts_44_060_test, though it
does not fix decoding because it's caused by an unrelated problem.
Early versions of 3GPP TS 44.060 required to use the standard
2b-padding.  Later versions added release extensions and say that 0 **
(zero padding) shall be used.  This does not take backwards
compatibility into account, and makes it hard to parse RLC/MAC PDUs
originated by old phones.  In this case the PDU has 2b2b2b at the end,
but we implement the recent version of 3GPP, so we try to parse padding
and run into problems...

Related: libosmo-gprs.git Iac4de18ef25386f774bb409201b7a7996d1c8824
Change-Id: I061ac16df5e6413266de08884f791f0264791192
The file was modifiedtests/rlcmac/RLCMACTest.err
The file was modifiedsrc/gsm_rlcmac.c