Skip to content

Changes

Started 2 hr 6 min ago
Queued 6.9 sec
Took 1 min 35 sec on built-in
asp: Support setting timer xua beat 0 through VTY

Previous VTY configured range for the set of tdefs in timer xua didn't
allow to pass a 0 to it, which "timer xua beat 0" should be able to
accept in order to disable heartbeat procedure on the ASP.
In order to fix it:
* Change VTY range to minimal accepted value to 0 for the whole tdef
  set.
* Make sure the VTY command validates and rejects user trying to set a
  value outside the accepted range of the specific timer.
* Set .min_val=1 in SS7_ASP_XUA_T_ACK, so it can't accept value 0.
  According to spec, T(ack) is always expected to be set, even if the
  resulting timeout may be handled by LM instead of simply
  retransmitting the packet.
* Write vty tests to validate the restrictions are followed properly in
  the VTY.

Related: SYS#8156
Change-Id: Iadd7c6751ab09640fd2df214afa2ec87274a3210
Pau Espin Pedrol at
asp: vty: Explicitly test timer lm value ranges

Validate the value to be set provided by user over VTY is actually
within the range of the specific tdef being set.
Mark all of them explicitly as min_val=1 in its tdef, since they are not
expected to be set to 0 (see also gen_asp_timer_lm_cmd_strs() defining a
VTY range <1..999999>).

Change-Id: I9b2c426a1eaceb6e7c5fbe35872ada324fef5733
Pau Espin Pedrol at