Skip to content
Success

Changes

Summary

  1. ipa: Store ASP IPA SLS into its own field (details)
  2. asp: Rename and clarify asp_id field (details)
  3. asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK (details)
  4. asp: Expect optional ASP Identifier in Rx ASPUP ACK (details)
  5. xua_as_fsm: Remove unneeded double call to fill_notify_statchg_pars() (details)
  6. Unify amount of supported rctx items in IE to 128 (details)
  7. asp: Rework s/get_all_rctx_for_asp/ss7_asp_get_all_rctx_be/g (details)
Commit b8fe5e4a1adfb54f265efc81432eab6252e9b04f by Pau Espin Pedrol
ipa: Store ASP IPA SLS into its own field

Storing the 4-bit SLS into asp_id field is a total hack which just
pollutes the code and makes it more difficult to understand.

Add a new field into ss7_asp to store that information cleanly.

Moreover, asp_id field itself is right now a total mess on its own,
since it is used both for local and remote ASP Identifiers at the same
time. This will be fixed in a follow-up commitset.

Change-Id: I6ec346417ceeabfce9c7b856040be2179c59195e
The file was modifiedsrc/osmo_ss7_asp.c
The file was modifiedsrc/xua_asp_fsm.c
The file was modifiedsrc/ss7_asp.h
Commit b756c71195cc9820ce986ae0cfd3cd05f0b9a539 by Pau Espin Pedrol
asp: Rename and clarify asp_id field

The asp_id (RFC4666 ASP Identifier) can be (and may be) different on
each SGP peer of an ASP. Previously, we were storing in the same field
the value provided by the peer, and using this same value when sending
our own ASP Identifier during ASPUP.
This was not causing a problem since actually we have no real way to set
asp_id_present on our own in ASP mode yet, so no local ASP Identifier is
ever being transmitted.

This patch renames the asp_id field to remote_asp_id, since that's the
meaning it has in almost all places where it is being used.
The only place where it is being used so far, during Tx ASPUP, has been
documented and disabled since in reality the asp_id_present was not set
as mentioned above.

Furthermore, the remote ASP Identifier we receive from the peer ASP is
actually meaningful within a given AS, meaning that if an ASP is part of
several AS, we should be storing 1 remote ASP identifier for each AS it
serves. This is documented in ss7_asp7.h for later

Change-Id: I8e4304099db6fb12cf4b40a5b9a4aa3a83c95fde
The file was modifiedsrc/xua_as_fsm.c
The file was modifiedsrc/xua_asp_fsm.c
The file was modifiedsrc/ss7_asp.h
Commit 017e07c79fd315ca1ab5d52f74bad08bc9d2c3a8 by Pau Espin Pedrol
asp: Document misisng Optional ASP Identifier in Tx ASPUP ACK

This will basically use the same code logic as ASPUP branch above, so
document it here so that it is added in both places at the same time.

Change-Id: I9d8fabd8dccea4d45d78c6934737bfea25385e4a
The file was modifiedsrc/xua_asp_fsm.c
Commit 5ed8171da10fe66191e3a467769561c47d183462 by Pau Espin Pedrol
asp: Expect optional ASP Identifier in Rx ASPUP ACK

Change-Id: Idaa1a547d835402ca82e4abbae90681a3286d4da
The file was modifiedsrc/xua_asp_fsm.c
The file was modifiedtests/ss7/ss7_test.c
Commit ebd0adf4aeb15875cd29223c2de4b93546e8f8fa by Pau Espin Pedrol
xua_as_fsm: Remove unneeded double call to fill_notify_statchg_pars()

Recent commit introduced the helper func fill_notify_statchg_pars(), and
while doing so it wrongly added calls to it twice in
xua_as_fsm_onenter().
The first one is actually not needed, so remove it.

Fixes: f2e324e2f82efc93fd2a1124fa216d680659ed40
Change-Id: I5d1e2768de13e9ab5ede849b3c06347c8669de1c
The file was modifiedsrc/xua_as_fsm.c
Commit ca9b82be24489de28e2c78558e35c6a6df9d15ce by Pau Espin Pedrol
Unify amount of supported rctx items in IE to 128

Change-Id: I703c9e62ed909dc1cd9c3e943612205856edbf2c
The file was modifiedinclude/osmocom/sigtran/osmo_ss7.h
The file was modifiedsrc/xua_asp_fsm.c
The file was modifiedsrc/xua_snm.c
Commit 64c8e3b9c6393f8172db00de0cc2facd31ca7538 by Pau Espin Pedrol
asp: Rework s/get_all_rctx_for_asp/ss7_asp_get_all_rctx_be/g

This function will gain other users in other files in follow-up patches.
While at it, constify and reorder params.

Change-Id: Ic3a1c0bd663fe33ab14828e30e057a8beaa84c3f
The file was modifiedsrc/xua_snm.c
The file was modifiedsrc/osmo_ss7_asp.c
The file was modifiedsrc/ss7_asp.h