Commit
b8fe5e4a1adfb54f265efc81432eab6252e9b04f
by Pau Espin Pedrol
ipa: Store ASP IPA SLS into its own field
Storing the 4-bit SLS into asp_id field is a total hack which just pollutes the code and makes it more difficult to understand.
Add a new field into ss7_asp to store that information cleanly.
Moreover, asp_id field itself is right now a total mess on its own, since it is used both for local and remote ASP Identifiers at the same time. This will be fixed in a follow-up commitset.
Commit
b756c71195cc9820ce986ae0cfd3cd05f0b9a539
by Pau Espin Pedrol
asp: Rename and clarify asp_id field
The asp_id (RFC4666 ASP Identifier) can be (and may be) different on each SGP peer of an ASP. Previously, we were storing in the same field the value provided by the peer, and using this same value when sending our own ASP Identifier during ASPUP. This was not causing a problem since actually we have no real way to set asp_id_present on our own in ASP mode yet, so no local ASP Identifier is ever being transmitted.
This patch renames the asp_id field to remote_asp_id, since that's the meaning it has in almost all places where it is being used. The only place where it is being used so far, during Tx ASPUP, has been documented and disabled since in reality the asp_id_present was not set as mentioned above.
Furthermore, the remote ASP Identifier we receive from the peer ASP is actually meaningful within a given AS, meaning that if an ASP is part of several AS, we should be storing 1 remote ASP identifier for each AS it serves. This is documented in ss7_asp7.h for later
Commit
ebd0adf4aeb15875cd29223c2de4b93546e8f8fa
by Pau Espin Pedrol
xua_as_fsm: Remove unneeded double call to fill_notify_statchg_pars()
Recent commit introduced the helper func fill_notify_statchg_pars(), and while doing so it wrongly added calls to it twice in xua_as_fsm_onenter(). The first one is actually not needed, so remove it.