Skip to content
Sign in

Changes

Started 3 hr 50 min ago
Queued 6.2 sec
Took 1 min 33 sec on built-in

Summary

  1. xua_default_fsm: Support IPSP role (details)
  2. xua_as_fsm: Trigger PC (un)availability to upper layers in IPSP (details)
  3. xua_aspm_fsm: Remove unneeded workaround submitting (details)
  4. sua: Support rx SCON in role=ASP (details)
  5. sua: Support rx SCON in role=SG (details)
  6. sua: Support rx SCON in role=IPSP (details)
  7. xua: Allow rx DAUD in IPSP with quirk daud_in_asp (details)
  8. xua: Improve logging around unexpected snm messages (details)
  9. xua_snm: assert for unexpected condition (details)
  10. cosmetic: ss7_asp.h: Drop comment no longer valid (details)
Commit f76fdc38f5557a6b3a865030bbab580985639a39 by Pau Espin Pedrol
xua_default_fsm: Support IPSP role

Change-Id: Id9ad8bbfce5cf15fedcba83034ae383e61d3b3a3
The file was modifiedsrc/xua_default_lm_fsm.c
Commit 196844d96bfdb409491593e3f15443ef516bf440 by Pau Espin Pedrol
xua_as_fsm: Trigger PC (un)availability to upper layers in IPSP

Same as done in ASP. This is specially important in IPSP in order to
trigger availability/unavailability of PCs defined in the SCCP
addressbook.

Change-Id: I0e6015f04ad0647cc151d3c772355a18cb55547a
The file was modifiedsrc/xua_as_fsm.c
Commit a684997f9fe36ed74bc3b984fa85f194028af685 by Pau Espin Pedrol
xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ

Sending that kind of event is up to the layer manager.
Right now, all ASPs (except ipa_aspm_fsm, which doesn't need that event
because there's no ACTIVATE in IPA) have an associated layer manager
FSM, so that workaround is not needed.

Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
The file was modifiedsrc/xua_asp_fsm.c
Commit d6a0dc8f2da901808bce9223cf0d86baacd70bf6 by Pau Espin Pedrol
sua: Support rx SCON in role=ASP

Change-Id: I1e4146c2cb8fab460d5e810b602c20293272c2e4
The file was modifiedsrc/sua.c
Commit b977a9bd7e8408ce1a5fefd3f71181f70148ac85 by Pau Espin Pedrol
sua: Support rx SCON in role=SG

Change-Id: Ide2b4f876ddbdb1bb0bfed11fad6fc13aaf1afda
The file was modifiedsrc/sua.c
Commit a8b83c073b92a40eefe36760fc6187eaa24887ff by Pau Espin Pedrol
sua: Support rx SCON in role=IPSP

Change-Id: I3f46b634084c1d71643812828d4f114ab45dffde
The file was modifiedsrc/sua.c
The file was modifiedsrc/xua_snm.c
Commit b5060a568f53d5d86a8cd91bbf1b5e2db8e6ede0 by Pau Espin Pedrol
xua: Allow rx DAUD in IPSP with quirk daud_in_asp

That quirk was added back in time most probably when interacting with
some peer who claimed to be in SG mode but actually was in IPSP mode.
Hence, to be on the safe side, be relaxed and allow accepting DAUD also
if the quirk is added, otherwise it may be impossible to continue
communication with that faulty peer.
In theory according to spec DAUD should only be sent ASP->SG.

Change-Id: I8ad0889f4584446f8b01f1255498f57e0cd34012
The file was modifiedsrc/sua.c
The file was modifiedsrc/m3ua.c
Commit f98a44e6a2e69086985ce8312ac6a47dd810cb93 by Pau Espin Pedrol
xua: Improve logging around unexpected snm messages

Log rx of unexpected message type according to configured role.
Decrease verbosity of DAUD logging to match the new logging.

For SUA we can use M3UA's m3ua_snm_msgt_names because the value/strings
are the same and they are actually used through m3ua_msg_class_snm in
xua_dialect_sua.

Change-Id: I697e52dfd733cb9ee260bba133204a7462c4e8ee
The file was modifiedsrc/xua_internal.h
The file was modifiedsrc/sua.c
The file was modifiedsrc/m3ua.c
Commit e6845d7a1a5e7c4185e22750bf340c0e41dc74d2 by Pau Espin Pedrol
xua_snm: assert for unexpected condition

The rx DUNA/DAVA/DUPU paths are already guarded at m3ua.c and sua.c to
only call xua_snm_rx_{duna,dava,dupu}() in ASP role. Hence, calling
those functions is expected to always happen in ASP role.

Change-Id: I24bb335a2a856bf1a5ca255f7afbfe103ebcd86f
The file was modifiedsrc/xua_snm.c
Commit e3701bac30d60848db6c46f93249776e80337d9e by Pau Espin Pedrol
cosmetic: ss7_asp.h: Drop comment no longer valid

Since a while ago, only the remote asp ID is stored in
asp->remote_asp_id. The SLS has its own field (ipa.sls).

Fixes: b8fe5e4a1adfb54f265efc81432eab6252e9b04f
Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23
The file was modifiedsrc/ss7_asp.h