Skip to content
Success

Changes

Summary

  1. socket_compat.h improvements to always have struct osmo_sockaddr (details)
  2. remove references to define EMBEDDED in public headers (details)
  3. logging: Move log target file to its own file (details)
Commit b3171b0851d46fdf3453ff991583ab99ae6dfde8 by Pau Espin Pedrol
socket_compat.h improvements to always have struct osmo_sockaddr available

Having a #if (!EMBEDDED) based on compiler defined variable is not a
good idea. Instead, add minimal sys/socket.h and netient/in.h to always
have the definition of struct osmo_sockaddr available.

Change-Id: I5b10e09770727c72812af15360ab3385b957509b
The file was modifiedinclude/osmocom/core/Makefile.am
The file was modifiedinclude/osmocom/core/socket.h
The file was modifiedconfigure.ac
The file was modifiedinclude/osmocom/core/socket_compat.h.tpl
Commit ef1484af3273f070604ada30d138c26121936d59 by Pau Espin Pedrol
remove references to define EMBEDDED in public headers

It's not a good idea to base opt-in/out of code in public headers based
on some specific non-standard define being set at compile time when
calling the compiler. Get rid of those references; Now that
osmocom/core/socket.h can be included thanks to improved
osmocom/core/socket_compat.h, it shouldn't be a problem.

Change-Id: I7a657d67077dfbe861959c6123eb9163bc791694
The file was modifiedinclude/osmocom/core/tun.h
The file was modifiedinclude/osmocom/gsm/gsup.h
The file was modifiedinclude/osmocom/core/netdev.h
Commit ede60a131a607b52afbae951a92497ccb620e473 by Pau Espin Pedrol
logging: Move log target file to its own file

We already have all other log_target implementations each on its own
file. Move the file (and stderr, a specific case of file) into its own
file too, properly separating most file-specific logic from general
logging logic.

Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad
The file was modifiedsrc/core/logging.c
The file was modifiedsrc/core/Makefile.am
The file was addedsrc/core/logging_file.c
The file was modifiedinclude/osmocom/core/logging_internal.h