Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. osmo_io: segmentation cb: Initialize null ptr every iteration (details)
  2. osmo_io: Use early return to simplify code (details)
  3. osmo_io: uring: Setup connect_notify internal ofd during register() op (details)
  4. osmo_io: poll: connect_notify: Avoid calling register (details)
  5. osmo_io: close() op in backend only takes care of closing (details)
  6. osmo_io: Track IOFD_FLAG_FD_REGISTERED in all backends (details)
  7. osmo_io: segmented_read: Avoid triggering read events if user (details)
Commit 37caff62cf4dea1a01dfd030b2d268f7d3f2215c by Pau Espin Pedrol
osmo_io: segmentation cb: Initialize null ptr every iteration

Change-Id: I0fcaa6afb9cf2f88243280f01c278fa2d72e69a6
The file was modifiedsrc/core/osmo_io.c
Commit b6a3d4002910248dbe0b104ee55e268155de215c by Pau Espin Pedrol
osmo_io: Use early return to simplify code

Change-Id: Idd4c4f2da7f15b86ddd4765c60680130af08b22d
The file was modifiedsrc/core/osmo_io_uring.c
Commit 80a73815015bd6ba62d88470bc2b876c562bee34 by Pau Espin Pedrol
osmo_io: uring: Setup connect_notify internal ofd during register() op

osmo_fd used internally should only be registered during
osmo_iofd_register() time, not before.
Unregistering was already placed at the proper place.

Change-Id: Ifac374170736a9fe922362e95059a18c2a3ccaac
The file was modifiedsrc/core/osmo_io_uring.c
Commit 8071ffbbf195aad38f1181471a09a943af66e06e by Pau Espin Pedrol
osmo_io: poll: connect_notify: Avoid calling register

osmo_fd used internally should only be registered during
osmo_iofd_register() time, not before.

Change-Id: I8757259edf07a65f19019cf2b2e5886201d31983
The file was modifiedsrc/core/osmo_io_poll.c
Commit 4909945ee8282417b88251609b7fbef2b6353686 by Pau Espin Pedrol
osmo_io: close() op in backend only takes care of closing

Move dependent steps such as unregister to be done at the common path,
and leave the close() op on each backend to implement only the specific
close operations.

Change-Id: I0150afcc0b83ea8b2d00d108658ed688ce487f7f
The file was modifiedsrc/core/osmo_io_uring.c
The file was modifiedsrc/core/osmo_io_poll.c
The file was modifiedsrc/core/osmo_io.c
Commit df1ee8568b97dbf6d5268a83d1715a1c1fffb2de by Pau Espin Pedrol
osmo_io: Track IOFD_FLAG_FD_REGISTERED in all backends

This will be used in common segmentation handling code to figure out
whether the iofd is still registered or was unregistered by the user
during the read cb, in order to know whether to continue submitting read
events upwards or to discard the handling.

Change-Id: Id5e92aa22ce1c5d76028c539784118be227b9d5a
The file was modifiedsrc/core/osmo_io_poll.c
The file was modifiedsrc/core/osmo_io.c
Commit 353638e2ff94b1ae4f46132b30edbacc99259852 by Pau Espin Pedrol
osmo_io: segmented_read: Avoid triggering read events if user unregisters

The user code doesn't expect to receive any more read cb events after
unregistering the FD. Avoid keep calling the read cb if several entire
messages were received at once in a single tcp chunk.

Related: SYS#7063
Change-Id: Id2199b9aa805cc7e7793c1a8aecd10b61f2b4c90
The file was modifiedsrc/core/osmo_io.c