The config structure sent to the BTS with BTS_CONF_DATA includes an IE that enables or disables Rx diversity. In the original code this setting was hard-coded to enabled state; make it configurable via vty.
The previous vty tuning range for this timer (allowing up to 100 s) is not sufficient for Flexi Multiradio BTS, where we need 120 s minimum or 130 s for some margin. Raise the upper limit for vty config of this parameter to 5 min, which should be long enough to not require further revisiting.
In some cases, Flexi Multiradio BTS sends us BTS_COMMISS_TEST_REQ during its init process, and expects us to respond with BTS_COMMISS_TEST_COMPL, indicating that we did the requested commissioning tests. While we don't do any actual tests currently, and we have not yet reached an understanding of the exact conditions as to when the BTS makes this query of us, if it does send us BTS_COMMISS_TEST_REQ, we need to respond with BTS_COMMISS_TEST_COMPL to make it happy.
rsl: don't send legacy Chan Ident IE for Nokia BTS
The description of CHAN ACTIV command message in TS 48.058 section 8.4.1 lists Channel Identification as an optional IE, with a note that reads "Included if compatibility with phase1 is required." This note may have been misinterpreted as referring to compatibility with Phase 1 phones - but since this network-internal Abis detail is invisible to phones, the real intent of GSM spec authors here must have been compatibility with Phase 1 BTS.
Previous versions of OsmoBSC would always include this IE, and it appears that all previously supported BTS models would simply ignore it. However, newer Nokia BTS models (observed on Flexi Multiradio at least) dislike this IE and return CHAN ACTIV NACK with an optional IE error cause if it is included.
To avoid changing OsmoBSC behavior for other users, let us conditionalize removal of this legacy IE on Nokia BTS for now. This change has been tested on InSite, MetroSite and Flexi Multiradio - no adverse effects on previously supported *Site models.
