Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode for NT CSD (details)
  2. vty: lchan_dump_full_vty(): print CSD mode (details)
Commit aeb78dcc778099077e6a56e8344be1acda680745 by Vadim Yanitskiy
rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode for NT CSD

In commit 66eae187, I skipped assigning LCHAN_CSD_M_NT (0) to
lchan->csd_mode for non-transparent channel modes.  I assumed that
the entire gsm_lchan struct was zero-initialized during activation
or release procedures, but this assumption was incorrect.

In fact, some lchan fields are initialized during activation, while
others are initialized during release.  Specifically, lchan->csd_mode
is zero-initialized when the process starts, and then updated only
for transparent mode requests.  For non-transparent mode requests,
this field is not updated, meaning it retains its previous value.

This bug caused incorrect E1/E2/E3 bit settings and missing GSMTAP
RLP output for channels that were previously used for transparent
CSD calls.  This patch is fixing it.

Change-Id: I793ab4dc25fa852eade6f7a3b67ae961ceb7a093
Fixes: 66eae187 "rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode"
Related: OS#1572, OS#6579
The file was modifiedsrc/common/rsl.c
Commit 82d500ccac605d30c31a114369b377478b9f3abd by Vadim Yanitskiy
vty: lchan_dump_full_vty(): print CSD mode

Change-Id: Ibcf489eff73d6d117e94dee06a5a82a3404368f2
Related: OS#1572, OS#6579
The file was modifiedinclude/osmo-bts/lchan.h
The file was modifiedsrc/common/lchan.c
The file was modifiedsrc/common/vty.c