Skip to content
Sign in

Changes

Started 3 hr 46 min ago
Queued 7.2 sec
Took 3 min 42 sec on built-in

Summary

  1. osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure (details)
  2. osmo-bts-trx: apply 'max-initial' value before POWERON (details)
  3. power_control: lchan_ms_pwr_ctrl(): always log input values (details)
Commit a7b480c9635560947a5ecf7e6bd01207fca9b056 by Vadim Yanitskiy
osmo-bts-trx: trx_provision_fsm: do not send *_CNF events on failure

The trx_provision_fsm currently does not check the event data (rc),
causing failed operations (rc != 0) to be treated as successful
confirmations.  Avoid emitting *_CNF events when a command fails,
ensuring that only successful operations generate confirmation events.

Change-Id: Id85fb19c6621f55a9c46882df24bec534864a9dc
The file was modifiedsrc/osmo-bts-trx/trx_provision_fsm.c
Commit 92e984274140372fd3865d2148b2f030317cb43a by Vadim Yanitskiy
osmo-bts-trx: apply 'max-initial' value before POWERON

Not applying this value before powering the transceiver on results
in transmission at full Tx power for a certain amount of time before
the power ramping begins.

Change-Id: Iff03d4dcb74f67629a59c8d6f8bb60929d9f6ddd
Related: OS#6939
The file was modifiedsrc/osmo-bts-trx/trx_provision_fsm.c
The file was modifiedsrc/osmo-bts-trx/l1_if.h
The file was modifiedsrc/osmo-bts-trx/trx_provision_fsm.h
Commit b98399bef740c9e6040d1286f11f6757b6bff227 by Vadim Yanitskiy
power_control: lchan_ms_pwr_ctrl(): always log input values

Depending on the power control interval (P_Con_INTERVAL), the MS power
loop may delay the power control decision for a certain amount of SACCH
block periods.  In this case lchan_ms_pwr_ctrl() returns early and no
logging is printed at all.

Let's always log the input values (reported level, UL measurements)
early in lchan_ms_pwr_ctrl().  This is useful for debugging, and
this is exactly what lchan_bs_pwr_ctrl() does.

Change-Id: I3b8466f062624fc8a2ea6f8220c057d3812f2c35
The file was modifiedtests/power/ms_power_loop_test.err
The file was modifiedsrc/common/power_control.c