Skip to content
Success

Changes

Summary

  1. ggsn: Avoid forwarding IPv6 solicited-node multicast addr to tun device (details)
  2. ggsn: Rename confusing functions (details)
  3. tun.h: Remove non-existent tun_decaps() (details)
  4. Rename tun_encaps -> tun_inject_pkt (details)
Commit 1d7e86ae4891bc34056e66a42766d4384dd29033 by Pau Espin Pedrol
ggsn: Avoid forwarding IPv6 solicited-node multicast addr to tun device

There's no need to forward those. Morevoer, they cannot be forwarded
when using gtpu kernel mode since it doesn't support reinjecting packets
we got from it, so avoid erroring out when trying to inject them later
on.

Related: OS#6600
Related: OS#6382
Change-Id: Iac8f14083620d86f3872aa951930fbe8f680ff24
The file was modifiedlib/icmpv6.h
The file was modifiedlib/icmpv6.c
The file was modifiedggsn/ggsn.c
Commit d73801ebea09739d930007407ab2081f1df20555 by Pau Espin Pedrol
ggsn: Rename confusing functions

It's really confusing having a function operating on a rx path called
"encaps" since it's not really encapsulating anything.
This confuses the reader by thinking this is the function encapsulating
packets into GTP-U.

Change-Id: I7ff54f5e57ccc2c436becd1be1b0f728cbcdb12c
The file was modifiedggsn/ggsn.c
The file was modifiedsgsnemu/sgsnemu.c
Commit 234cd12ea5c6189d43b5383288241197e3058ff8 by Pau Espin Pedrol
tun.h: Remove non-existent tun_decaps()

Change-Id: If9cc5d2d54b87e38feefa55cb9410715fa9bd11f
The file was modifiedlib/tun.h
Commit ad03073219b14b7e2be963e0a290c912fcff0a01 by Pau Espin Pedrol
Rename tun_encaps -> tun_inject_pkt

The terminology of "encapsulating" used in tun_encaps is confusing,
since in this case we are not really encapsulating anything, but
actually delivering ("injecting") the packet to the system network
stack.
Using the "encapsulating" term is also confusing because readers may
think it may be doing the GTP-U encapsulation, which is not.

Change-Id: Ibb17c792b81668571e69d79918f3adf0e9e0f6c8
The file was modifiedggsn/ggsn.c
The file was modifiedlib/tun.h
The file was modifiedlib/tun.c
The file was modifiedsgsnemu/sgsnemu.c