Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. mgcp-cli: Improve error handling around mgcp_msg_gen() return (details)
  2. mgcp-cli: Fix filling in wrong local IP address of SDP Origin o= (details)
  3. mgw: Drop own MGCP extension 'noanswer' (details)
  4. cosmetic: mgw: Fix indentation whitespace (details)
Commit e6ef4e7484a132cce812396c776f7ab2a291cf8e by Pau Espin Pedrol
mgcp-cli: Improve error handling around mgcp_msg_gen() return

Change-Id: Ib9b02b7e6b37472c8e38b3380bc990a2bbac0657
The file was modifiedsrc/libosmo-mgcp-client/mgcp_client.c
The file was modifiedsrc/libosmo-mgcp-client/mgcp_client_fsm.c
Commit 1f99c3aaaef24284a670b96ff4acf40b54bbfb9b by Pau Espin Pedrol
mgcp-cli: Fix filling in wrong local IP address of SDP Origin o=

If user (VTY) configured the local IP address to use for MGCP, and that
IP address was not the one selected by kernel routing table lookup, the
IP address filled in the MGCP message would be wrong, not matching the
one sending the MGCP message.

Change-Id: I35624db853dc1f0fee85503105960613f70473c6
The file was modifiedsrc/libosmo-mgcp-client/mgcp_client.c
Commit 6676e63c893b5d5bd4d11b775e3faa0468d924d0 by Pau Espin Pedrol
mgw: Drop own MGCP extension 'noanswer'

This was added in e3d16bb77530f2b3f08fdaf9640dd98bd9e730fa 14 years ago:
"""
[mgcp] Protocol extension to not generate answers.

    For the NAT we want to send requests in a send and forget
    way and we are not interested in seeing the answers, so tell
    the gateway to not answer them.
"""

So this code is most probably related to osmo-bsc_mgcp time, and we
don't really need this feature in osmo-mgw, it really makes no sense.
Drop it.

Change-Id: Ica2d3d54cda41e0c6416913ab056843a0cd80c17
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c
Commit d46cdd80def537763e32ca8228aec97a12ae285b by Pau Espin Pedrol
cosmetic: mgw: Fix indentation whitespace

Change-Id: Ic5b267108b5c5cba064ddddbe688705f9dc29ac8
The file was modifiedsrc/libosmo-mgcp/mgcp_protocol.c