Skip to content
Success

Changes

Summary

  1. vlr: refactor and rename vlr_timer into vlr_timer_val (details)
  2. vlr: add functions for vlr_is_cs() vlr_is_ps() (details)
  3. vlr: set the correct CN domain on GSUP messages (details)
  4. vlr: add the location update type to the callbacks tx_lu_acc/tx_lu_rej (details)
  5. vlr_auth_fsm: fix missing space (details)
  6. msc_net_init: replace spaces with tabs as indention (details)
Commit 64e4ae7bb7cdb2494ae652e2aa5af17b28630c96 by lynxis
vlr: refactor and rename vlr_timer into vlr_timer_val

Use correct types for vlr_timer. A timer T is always a signed integer.
Also osmo_tdef_get returns an unsigned long. Match the types from osmo_tdef.
Rename the vlr_timer() into vlr_timer_val() to make it more understandable.

Change-Id: Ic46ddb578962619fc08bd63645c76852e676fcc9
The file was modifiedtests/msc_vlr/msc_vlr_test_no_authen.c
The file was modifiedsrc/libvlr/vlr_access_req_fsm.c
The file was modifiedinclude/osmocom/vlr/vlr.h
The file was modifiedsrc/libvlr/vlr.c
The file was modifiedsrc/libvlr/vlr_auth_fsm.c
The file was modifiedsrc/libmsc/msc_vty.c
The file was modifiedsrc/libvlr/vlr_lu_fsm.c
Commit 5e13b6da050cc028988601ac8fe566ac05d2ca40 by lynxis
vlr: add functions for vlr_is_cs() vlr_is_ps()

Make the code more readable when checking for cs or ps.

Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d
The file was modifiedinclude/osmocom/vlr/vlr.h
Commit 45d9b166eb5d5297f7f533567e5742f8c3a375cf by lynxis
vlr: set the correct CN domain on GSUP messages

In preparation of splitting up the libvlr code, set the CN domain
on all required GSUP messages which allow the CN domain to be present.

The test cases expect the exact GSUP message. The additional TLV is
280102 (IE: CN domain, length 1, CS (2)).

Change-Id: I045f29647b0f122a653881030d09de35b64f4dd1
The file was modifiedsrc/libvlr/vlr.c
The file was modifiedtests/msc_vlr/msc_vlr_test_gsm_authen.err
The file was modifiedtests/msc_vlr/msc_vlr_test_umts_authen.err
The file was modifiedtests/msc_vlr/msc_vlr_test_umts_authen.c
The file was modifiedtests/msc_vlr/msc_vlr_test_gsm_authen.c
Commit 3832541c3f330a5cee9b267f10032d8c4a8ffe3e by lynxis
vlr: add the location update type to the callbacks tx_lu_acc/tx_lu_rej

The location update type (IMSI attach, periodic, location area change) is
required when the SGSN is using the vlr code to send back the correct PDU to the MS.
The MSC always sends Location Update Accept/Reject, but the SGSN has to transmit
either Routing Area Accept/Reject or Attach Accept/Reject.

Change-Id: I980a637333e92b15f2d516683feeaded910105b6
The file was modifiedinclude/osmocom/vlr/vlr.h
The file was modifiedsrc/libmsc/gsm_04_08.c
The file was modifiedtests/msc_vlr/msc_vlr_tests.c
The file was modifiedsrc/libvlr/vlr_lu_fsm.c
Commit b7e36255b8aa371db5953e4be5944f80df8b8eaf by lynxis
vlr_auth_fsm: fix missing space

Change-Id: I8976221ca7e314cc655f43c3ccffd9f15364cc0e
The file was modifiedsrc/libvlr/vlr_auth_fsm.c
Commit 2fb32932ec0d034ef3d3e7841d0301bd6e76e62f by lynxis
msc_net_init: replace spaces with tabs as indention

Change-Id: I9290cc585601dbadda3a85eddd50ccd0354b0b0b
The file was modifiedsrc/libmsc/msc_net_init.c