Skip to content
Success

Changes

Summary

  1. client: use osmo_stream_cli to transmit data to pcap-server (details)
  2. client: Avoid sending link frame over non-connected conn (details)
  3. client: constify args in can_forward_packet() (details)
Commit e5361555a766c23f04209cf91a58016ba56a5db4 by Pau Espin Pedrol
client: use osmo_stream_cli to transmit data to pcap-server

Similarly to previous work done in osmo-pcap-server, the switch to
osmo_stream doesn't cover the TLS-enabled scenario, since moving TLS
related code to osmo_stream requires significant amount of work and can
be done in a subsequent step.

Related: SYS#7290
Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860
The file was modifiedinclude/osmo-pcap/osmo_pcap_client.h
The file was modifiedsrc/osmo_client_network.c
The file was modifiedsrc/osmo_client_vty.c
The file was modifiedsrc/Makefile.am
Commit afb61a54d0ce153d4d6e952316ec912d49ea2951 by Pau Espin Pedrol
client: Avoid sending link frame over non-connected conn

Otherwise error messages appear upon start when starting the capture and
the conns haven't yet been established (they are started immediately
afterwards in main.c).
The errors are actually harmless since network code takes care of
sending a link frame upon connection TCP/TLS handshake completes.

Change-Id: I091523e1d9f644e97b114b4cc524307a83dd564f
The file was modifiedsrc/osmo_client_network.c
The file was modifiedsrc/osmo_client_core.c
The file was modifiedinclude/osmo-pcap/osmo_pcap_client.h
Commit 39f5c49945b58856fc04ed09c62b4570c3777542 by Pau Espin Pedrol
client: constify args in can_forward_packet()

Change-Id: I3568b962fea7d0e34b68f75cea7b59b1df158238
The file was modifiedsrc/osmo_client_core.c