Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. move gsm48_gmm_att_tlvdef into gprs_gmm_util (details)
  2. GMM: split parsing of a RA Update Request in a separate file (details)
  3. Use %d instead of %i (details)
Commit 8a2ed973361efd89ddb88b3ddbed7e5f19506a6b by lynxis
move gsm48_gmm_att_tlvdef into gprs_gmm_util

The gprs_gmm.c is huge. Move message parsing into gprs_gmm_util.c.

Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d
The file was modifiedsrc/sgsn/Makefile.am
The file was modifiedsrc/sgsn/gprs_gmm.c
The file was addedinclude/osmocom/sgsn/gprs_gmm_util.h
The file was addedsrc/sgsn/gprs_gmm_util.c
The file was modifiedtests/sgsn/Makefile.am
The file was modifiedinclude/osmocom/sgsn/Makefile.am
The file was modifiedtests/gprs_routing_area/Makefile.am
Commit 5b289e83cf730a76a43cc2fad350cfa9fea158f9 by lynxis
GMM: split parsing of a RA Update Request in a separate file

gprs_gmm.c is huge. Further split the general validation
and parsing of the message into an own function.

Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d
The file was modifiedinclude/osmocom/sgsn/gprs_gmm_util.h
The file was modifiedsrc/sgsn/gprs_gmm.c
The file was modifiedsrc/sgsn/gprs_gmm_util.c
Commit 7138f8eb931558388f8cda7aabeb818228b4f7f9 by lynxis
Use %d instead of %i

%d and %i has the same meaning when used in format string for printf.
The linter will warn when using %i. %i was only added to provide
symmetry between scanf() and printf().

Change-Id: Icd5f5f9b0d2ed8fd82afa406787acb4bd95358bf
The file was modifiedtests/v42bis/v42bis_test.c
The file was modifiedsrc/sgsn/slhc.c
The file was modifiedtests/sndcp_xid/sndcp_xid_test.c
The file was modifiedtests/xid/xid_test.c
The file was modifiedsrc/sgsn/gprs_ranap.c
The file was modifiedtests/slhc/slhc_test.c