Skip to content

Changes

Summary

  1. build/Makefile.asciidoc: fix GIT_DATE (details)
  2. Cosmetic: build/Makefile.asciidoc: remove comments (details)
Commit 9ff6ddaa6dce8ff0d0bef1544cbb5a0ec3967568 by Oliver Smith
build/Makefile.asciidoc: fix GIT_DATE

Omit the "../." parameter from git log. This is legacy from when all
manuals were in the osmo-gsm-manuals.git repository, and now causes the
wrong date to be used. After removal, it uses the date of the currently
checked out git commit again.

For most projects using osmo-gsm-manuals, the directory structure looks
like the following:

  ├── doc
  │   ├── manuals
  │   │   ├── build -> /usr/share/osmo-gsm-manuals/build
  │   │   ├── Makefile.am

Makefile.am includes build/Makefile.asciidoc.inc. With the "../."
parameter, git log parses the date of the last commit of the doc
directory. In case of osmo-hnbgw, this is:

  osmo-hnbgw/doc/manuals $ git log -n1 ../.
  commit 90928fb2467aef2b2b8419c1c96f7edae6fc2907
  Author: Neels Janosch Hofmeyr <nhofmeyr@sysmocom.de>
  Date:   Thu Nov 30 18:13:06 2023 +0100

      systemd,manual: set LimitNOFILE=65536

...which then leads to 2023-Nov-30 appearing in the document even though
the last commit in the repository is much newer.

Fixes: OS#6428
Change-Id: Id46d0d6928c0ad820214280cb36c0c3180f3bff1
The file was modified build/Makefile.asciidoc.inc
Commit 8819bd91ec607a42cda0574d16d3e5eccd63ef78 by Oliver Smith
Cosmetic: build/Makefile.asciidoc: remove comments

Remove some commented out code for renaming pdfs that we don't use, and
that is probably broken.

Change-Id: Ibfe9580976919175f1d1bf8f7b35e4bc295049ee
The file was modified build/Makefile.asciidoc.inc