Changes

Revert "testenv: use eclipse-titan 11 in Dockerfile"

We had a lot of fallout from this, revert to version 9.0.0 for now.

This reverts commit 8082d099e3f96da3dfe4348b0e1bd794d93b8b02.

Related: OS#6490
Change-Id: I0a00fd4e031410be102cd6e99ecab4a464503003

testenv: allow passing -j/--jobs together with -b/--binary-repo

Not only the -j/--jobs is used when building the IUT components,
but also when building the testsuite itself (PARALLEL_MAKE var).

Change-Id: I3eb596f2c4e5de1b624c238e34785e798d2099c3

Makefile: add global per-project clean target

Change-Id: I434ecbe3f3dd25ea770d8f2d7adfa62c67dc0c1d

msc: add TC_lu_and_ussd_notify_during_mt_call

This is a more realistic scenario (race condition) that reproduces
an assertion failure in osmo-msc (OS#6756).  We already do have
TC_mo_ussd_evil_ms reproducing the problem, but this scenario is
unrealistic when using a "normal" (not "evil") MS/UE.

Change-Id: I6935ad96aef7747c576505ae52f8b5d3e0611882
Related: osmo-msc.git I724f0f0c9ef8611d3c3653e9370361b252127f72
Related: OS#6756

library/MGCP_Emulation: Fix Dynamic test case error returning unbound value

As spotted today while running HNBGW_Tests.TC_rab_assignment, probably after upgrade to titan 11:
17:54:36.223786 1570 MGCP_Emulation.ttcn:241 Dynamic test case error: Copying an unbound charstring value.

The error happened because in that failure path the component running
the function was not stopped, and hence an unset variable was returned.
Hence, make sure we tear everything down (including component going
through the failure path).

Change-Id: Id1d28924e90ed80199b61a143dac35fc6f50de68

mme: Move LTE_CryptoFunction* to library/

S1AP_Emulation is already importing LTE_CryptoFunction.ttcn, so it
really belongs to library and not to mme/ directory.

While at it, split Snow3G algos to its own subdir so it can be easily
exported standalone, eg. when used by 5G NAS in the future.

Change-Id: I76f86beeb2c49110eea0fac6abffee8307a3c22c

S1AP_Emulation: Remove commented duplicated function

The function used is in library/LTE_CryptoFunctions.ttcn.

Change-Id: I1d6871d2a735a4bf39c87f6c976bd5d5630e9c04

5gc: Implement AKA authentication

deps/nas.git already has some Auth related functionaltities to calculate
XRES*, but I couldn't get them to generate proper output. Furthermore,
using them directly would include a lot of churn we don't want:
* ttcn: Otherwise ttcn/Lib_NG_NAS/LIB_NG_NAS_Functions.ttcn brings in
  tons of dependencies about Emulation stuff which is not interesting
  for us.
* .cc: We want to implement our own low level functions using our
  eclipse Titan API, as well as our own C lib dependencies (because some
  code for those dependencies is not really available in the repo).

Hence, instead use our own milenage.c implementation imported from
libosmocore (actually from a slightly modified self-contained copy we
already ported to some development branch of asterisk VoLTE project).

With this patch it is already possible to detect SQN Out-of-sync and
answer with an Auth Failure, then get a new Auth Req from network and
properly answer with an Auth Resp which the network likes and hence
answers with a Security Mode Command.

Change-Id: I11527f47e4310863124f3f02148e3f71da7d911e

5gc: Implement NAS integrity check of DL messages

Change-Id: I118081af10f260513734550854c3a1751e32cbb4

library: Improve some f_rnd_*() functions

Change-Id: I82535caf08aa628738c0cbc29b8b27d525ec78ce

NGAP_Emulation: Fix match on DownlinkNASTransport with different list of IEs

The existing receive templates match only a given set of parameters.
Some of them are optional, so they wouldn't match the template if added.
Match based on procedureCode instead.

Change-Id: Iaec861f8c0d55a2897896d695b9f70bca64af339

5gc: Implement UE registration

deps/Makefile nas.git is updated with new version containing tons of
fixes regarding LENGTHTO() in most IEs.

Change-Id: Ida0e5268c3109a25ecdd03c4f17d5ff8bce8e567

testenv/README: fix missing :

Change-Id: Ifa2f2c2ebcb4fca20c2cc88672ef2a27df197a0c

testenv: add titan_min to all configs

Add the minimum required eclipse-titan version to each testenv.cfg. This
is in preparation for a future patch that will allow using a different
eclipse-titan version, depending on titan_min in the config and a new
--titan-version argument.

Supporting this is desired because:
* We can't simply upgrade from 9.0.0 to 11.1.0 as there are regressions
  with some of the testsuites, but we need 11.1.0 for at least one new
  testsuite.
* By quickly switching between the versions we can check for regressions
  easily.

Related: OS#6490
Change-Id: Ibd81812227f947cf1f437bdc4b087779194bc5dc

testenv: move ttcn3_hacks_dir to __init__.py

Move testenv.testsuite.ttcn3_hacks_dir to testenv.ttcn3_hacks_dir. It
makes more sense there as the path to osmo-ttcn3-hacks is used by many
modules, not just the testenv.testsuite module, and it prevents a cyclic
import with future patches when testenv.testsuite will import
testenv.testenv_cfg.

Change-Id: I4280009da419e6f5b533805732656ec4cc05d5ac

testenv: support using multiple titan versions

Install eclipse-titan versions 9.0.0 and 11.1.0 into
/opt/eclipse-titan-$version inside the podman container by using the new
optdir packages. Choose the appropriate version by setting related
environment variables. Use the version in $PATH on the host, unless
/opt/eclipse-titan-$version is also present on the host system.

Add a new --titan-version argument to explicitly set a version to use
when running a testsuite.

Rewrite the version check code to take titan_min, --titan-version and
the host version (if not using optdir) into account.

Related: OS#6490
Change-Id: I48d711da57c874cf7cd557480a163eea1a4167bd

testenv: fix missing titan_min= error msg

Fixes: 98268b665 ("testenv: add titan_min to all configs")
Change-Id: I0eb99da16ba6ffd5ae936aa63bb770e2a73fdd25

pgw: initial testenv.cfg

All tests are passing with this config.

Related: OS#6494
Change-Id: I0f14ce56859c3303b2f6af57d7ab5722e0cbe8e0

stp: Expect and answer M3UA BEAT from IUT

This fixes tests failing with newer versions of libosmo-sigtran where
HEARTBEAT procedure is enabled by default.

Change-Id: Idb70acde0683bc053db20781ce4926fbc318f51f

IPA_Emulation.ttcn: Add call to support dis/enabling CCM management

This allows eg. a user to let the Emulation do the inital handshake, and
then pass control of eg. IPA PING/PONG messages directly to the user
afterwards.

Change-Id: If68e0ba36c3a56f021dd50aadf2156ddc696b816

stp: IPA: Introduce test TC_beat

Similar to the one already available in STP_Tests_M3UA, but testing
PING/PONG in IPA.

Change-Id: I3d762fb4780aaa9931c3841cce69da6ee95529f3

stp: IPA: Introduce test TC_beat_timeout

Change-Id: I6f16915238d7762faf1c63fdeccca7e4a5f20893
Related: SYS#7501
Related: OS#4072

stp: IPA: Introduce test TC_clnt_beat_timeout

Change-Id: I5a41857dbd9f0bfe40a3a539aaed8361bc29fd6b
Related: SYS#7501
Related: OS#4072

stp: Introduce test TC_(m3ua_tcp(clnt_))beat_timeout

Related: SYS#7501
Related: OS#4072
Change-Id: Ie0c430b7992881e8ae506fe6434f06946f8f6278

epdg/testenv/run_osmo_epdg…: fix ip link ls output

In the code that waits until the tun device is available, fix the
silencing of stdout and stderr.

Change-Id: I8ce8824930e8841dddd7a67d178d5140e4f71b84

epdg/testenv/run_osmo_epdg…: wait up to 30s

Wait up to 30s for the tun device as waiting 10s is not enough if
jenkins is under high load.

Related: https://jenkins.osmocom.org/jenkins/job/ttcn3-epdg-test-net-next/29/console
Change-Id: Ia7298275b92f30efc40e9d6afa1abc8d7c5536d6

Bump titan_min to 11.1.0 where possible

I ran the generic version of all testsuites in the Osmocom jenkins with
eclipse-titan 11.1.0. Bump titan_min where we have the same result as
with 9.0.0.

The only testsuite that still didn't work the same is the gbproxy
testsuite (OS#6800), keep titan_min=9.0.0 there for now.

Related: OS#6490
Change-Id: Iba562ace07e6f38a8cde15b17478a0a1680df2fc

testenv/podman_install: fix regex warning

Fix for the following warning with Python 3.12.3:

  …/testenv/podman_install.py:120: SyntaxWarning: invalid escape sequence '\d'
    pattern = re.compile("^\d+\.\d+\.\d+$")

Change-Id: I33ef4e16f3d3e4fa627f726d6fddd950b7826620

stp: m3ua: Introduce test TC_combinedlset_loadshare

Test combined linkset loadsharing on M3UA AS.

Related: SYS#7112
Change-Id: I20a67648072f4d9839b1d1fceded1680362bf979

stp: Add helper function to build SCCP UDT encoded octetstring

Change-Id: I67961807bba4853b58e4b6f87eb3f2b56e9bb027

stp: ipa: Introduce test TC_combinedlset_loadshare

Test combined linkset loadsharing on IPA AS.

Change-Id: I029ac9f3c664d2f30cddc36f6eb1b39295689247
Related: SYS#7112

Fix typo unknwon -> unknown

Change-Id: I483090332931d85a8808bd558c4d4ac4d36fa16b

stp: Fix recent regression introduced in TC_ipa_to_m3ua_patch_sccp

The introduced function f_SCCP_UDT() had the calling+called param order
swapped with regards to previous templates. Change the order to first
have "calling" (src) and then "called" (dst) as already done in
ts_SCCP_UDT.
While at it, change the ts_SCCP_UDT params to accept template (value) to
make it easier for callers.

Fixes: b686e914b60d6e2486667fa8227576a70a86c909
Change-Id: I0e158557dabdb7e94d1c00a6d67126f2d85bb4cd

pcu: TC_sns_del: improve test stability

Add a sleep 1 to ensure the BSSGP flow Ack flows before removing the SNS.
Further add a data weight to the other NSVC to have at least one valid
NSVC with data weights. Otherwise the NSEI would become unavailable.

Related: OS#6751
Change-Id: Icb32e5f46ba7950848343efc46aee67e2397de5d

remsim: bankd: add TC for creating a mapping with a busy client

Test if a busy client is implicit removed when creating a new mapping
for the same client with a different bankd slot.

After a desynchronisation between the server and bankd happen (e.g. restart the server),
the server might request a mapping between a client slot and a bankd slot
while the bankd still has a different mapping for the same client slot.

Example before this commit:
* server -> bankd: New Mapping (client 1/0, bankd 1/0)
* server <- bankd: Ack
* Restart server
* server -> bankd: New Mapping (client 1/0, bankd 2/0)
* server <- bankd: Ack (implicit remove mapping to bankd 1/0)

Related: SYS#7470
Change-Id: I57112758167c2a29fae9df0cf1e2691c5a8e7bed

bsc: generic: Introduce test TC_stat_msc_sctp_disconnected

Take the chance to properly configure all ASP/AS data statically, in
order to be able to access them through VTY as well as have the setup
properly documented in the config files.

Change-Id: I028a16e2742ff0c58bf3b51ee1233ccf947a5a6a
Related: OS#5917
Related: SYS#7501

stp: Support expect RFC466 4.5.1 DUNA after ASP ACT

libosmo-sigtran recently introduced support in SG role to send DUNA for
unreachablew destinations when a peer ASP becomes activated.
This is currently sent upon first ASP going active, since it's the time
where SG assumes the ASP peer may need that information.

Depends: libosmo-sigtran.git Id9d92c3fda7423a9c79fffac6b650abba9651853
Change-Id: I6bee0f890a8baaa62be193824b1ae2fceb53fb45

Cosmetic: testenv: tweak argparse formatting

Make all "add_argument" calls consistently have one function argument in
one line, instead of only having it in some places, and have all
arguments in one line in others. Having one function arg in one line is
enforced via ruff format when having a comma at the end of the function
call.

Change-Id: Ia1804f0313a27ddf8f7197ce0b2ad3b56421b290

testenv: add run --asan

Add a new --asan option for building Osmocom libraries and programs from
source with address sanitizer enabled. This works by adding
sanitize.opts to osmo-dev's gen_makefile.py, which in turn adds
--enable-sanitize to most Osmocom projects.

The --autoreconf-in-src-copy argument for gen_makefile.py must be moved
up, so the list of *.opts files is not interrupted by another type of
argument that causes argument parsing to fail.

Suggested-by: Pau Espin Pedrol <pespin@sysmocom.de>
Related: https://gitea.osmocom.org/osmocom/osmo-dev/src/branch/master/sanitize.opts
Change-Id: I1947dd3a7d9ce51dcbef9cffd5d7b402f236b9e2

bsc-sccplite: Fix override of opc of incoming msgs

This patch fixes a regression introduced recently in a patch. We
basically revert that line change. This fixes osmo-bsc crashes
spotted during ttcn3-bsc-test-sccplite.

Fixes: 40c73568c77ee3747a02fce2cf031d723a938207
Related: OS#6806
Change-Id: I9764f4020e80e954de61ff9ba4d8ce959359be8e

bsc: Avoid running TC_stat_msc_sctp_disconnected in latest

The osmo-stp in latest release, aside from not yet implementing the
"shutdown" cmd (which is known and hence test was expected to fail
there), has a side effect of ending up with a broken state after
restarting the ASP during got_parent() VTY node exit, where ASP is
ends up in ASP_DOWN and AS in AS_ACTIVE. This generates failures in all
tests after this one._

Change-Id: Icce4ec089b300f418e957ab67464759c782811a4
Related: OS#5917
Related: SYS#7501
Fixes: 40c73568c77ee3747a02fce2cf031d723a938207

PCU: TC_sns_del: expect NS Alive while preparing the test

f_outgoing_sns_chg_weight() should handle NS Alive until
it do the SNS Delete procedure.

Related: OS#6751
Change-Id: I7c0991819de48b59e763fbe1ef6df4567c38007c

RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures

Using hardcoded transaction ids are working, but for the TC_SNS_del it would
result in descending transaction ids.

Related: OS#6751
Change-Id: I1ea0424232ed925fee623568eb0edccdf1ae0368

RAN_Emulation.ttcnpp: Log ignored rx RANAP msg when no cb set

Change-Id: I15b6fea2d44ab9607db020e1152ee1fd79839a52

StatsD_Checker: Allow configuring timeout

Change-Id: I183ad5810468cba5bfec20eb584a27462fde980c

StatsD_Checker: Keep polling IUT if waiting for convergence

The wait_converge feature was implemented and used so far only against
IUTs which used also the snapshot feature, due to not having a VTY which
allows both resetting and triggering a status report manually. Instead,
those relied on IUT reporting changes at a given frequency.

If the wait_converge feature is requested and polling mode is used, then
make sure we poll once per second after last received statsd UDP msg.

Change-Id: Id78b46b88048206f74d1d88672b8309227e9438c

bsc: TC_mscpool_sccp_n_pcstate_detaches_msc: wait for AS to become unavailable

Otherwise race conditions can ocurr, specially since during some time
the AS can be in PENDING state until finally going into DOWN state and
notifying the peer.

Change-Id: Idc84929d89cbac4eb67cd2740f98844253dde70d

hnbgw: Use static sigtran config between osmo-hnbgw and osmo-stp

This allows referencing/accessing the specific ASP in osmo-stp, which
will be needed in a follow-up commit to test IUT behavior when the SCTP
conn is dropped.

Related: OS#5917
Change-Id: Icbec561e28db8e0da19a284b3ba73636ea5c8210

hnbgw: Introduce test TC_stat_stp_sctp_disconnected

Related: OS#5917
Depends: libosmo-sigtran.git Change-Id I7e4eedb65c4f2952f8b39ca4c539ca2f40e9946c
Change-Id: I079f2da09ff8d52e614ff6f5d267cd5429e4eb58

hnbgw: swap first MSC and SGSN PC to be usual default ones

0.23.1 and 0.23.4 are default remote PCs to be used by osmo-hnbgw to
reach MSC and SGSN respectively, if no config is provided. In this
testsuite config, however, they were swapped, which is confusing.
Swap back the values so they match the default ones in osmo-hnbgw.

Change-Id: Ib62258e340ecf8cbe1026e43ccccc6bf98932244

msc: Use static sigtran config between osmo-msc and osmo-stp

This allows referencing/accessing the specific ASP in osmo-stp, which
will be needed in a follow-up commit to test IUT behavior when the SCTP
conn is dropped.

Related: OS#5917

Change-Id: Id78aac528b10a8449b83075419b74315d838d4a4

RAN_Emulation: Fix handling of IMSI in RANAP Paging

The IMSI in RANAP Paging messages is encoded in octetstring BCD format.
We need to decode it before using it, since we use plain hexstrings
everywhere in the module to manage IMSIs.

Take the chance to clean up and improve logging on related lines, both
for BSSAP and RANAP.

Change-Id: Ia892a52bad41a4e331703bbab438d8c811b2025e

msc: Add suport to obtain statsd output

It will be used in a follow-up commit introducing a new test.

Change-Id: I66ffb278a7ddff975e43f72d9ec6b323705f720c

msc: Introduce test TC_stat_bsc_sctp_disconnected

Related: OS#5917
Depends: osmo-msc.git Change-Id Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf
Change-Id: I4cf30ea09cb1d1286bd5ab6975f3f27e39b9c183

GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ

I got this DTE while running SGSN_Tests_Iu.TC_attach_pdp_act_user:
"""
GSUP_Templates.ttcn:381 Dynamic test case error: Restriction `present' on template of type hexstring violated.
"""

According to GSUP documentation, the IMSI param is mandatory.
Upon fixing it, the compiler found the user causing the problem:
"""
BSSGP_ConnHdlr.ttcn:797.49: error: Restriction on template formal parameter does not allow usage of any or omit
"""

That error is also fixed in this same commit.

Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4

sgsn: Use static sigtran config between osmo-sgsn and osmo-stp

This allows referencing/accessing the specific ASP in osmo-stp, which
will be needed in a follow-up commit to test IUT behavior when the SCTP
conn is dropped.

Related: OS#5917

Change-Id: Ie52f4c1877587067af66add56ad8674b82b51718

sgsn: Introduce test TC_stat_rnc_sctp_disconnected

The commit doesn't validate everything it should, because passing the
indication from osmo-iuh's iu_client to app (osmo-sgsn) is not
supported in current API, and hence the statsd metrics are not yet
implemented in osmo-sgsn.

Still, this test already validates that osmo-sgsn is capable of
surviving an sctp link down event in IuPS, and continue to work
afterwards. IT also allows easily debugging this scenario by inspecting
pcap files, logs, etc.

Related: OS#5917
Change-Id: I35888630ea9e9005e1252677c5d42f66f84e177b

smlc: Use static sigtran config between osmo-msc and osmo-stp

This allows referencing/accessing the specific ASP in osmo-stp, which
will be needed in a follow-up commit to test IUT behavior when the SCTP
conn is dropped.

Change-Id: I008dba252da29f445c52151c7b65428ca7054ed0
Related: OS#5917

smlc: Add suport to obtain statsd output

It will be used in a follow-up commit introducing a new test.

Change-Id: I52813397890a85326a85b3580fd605f9ac10a26d

sctp: Introduce test TC_stat_bsc_sctp_disconnected

Change-Id: Ic67d9d8120e9bd09b0e54b237e93f49f79262be0
Related: OS#5917
Depends: osmo-smlc.git Change-Id Ib01576036f34ac7f21c5bce0155b50932eb9b72a

hnbgw: Use static sigtran config also in osmo-hnbgw-with-pfcp.cfg

Previous commit did set static configuration in osmo-hnbgw.cfg (generic)
but forgot to add the same to the with-pfcp scenario.

Fixes: 88d6666056d6cdc899d6c102fc379f8a469a725e
Change-Id: I20979cbd5cf7e9d8c109f72d5f84c4fbe26b44ca

smlc: fix running against latest

osmo-smlc from latest doesn't support statsd yet. Use a separate config
that doesn't have the statsd block and don't try to initialize it for
latest.

Change-Id: If7b1d46777703f0511ee15520571d0313bdfa5ed
Fixes: 5268d5 ("smlc: Add suport to obtain statsd output")

SGSN: Iu: use correct service request type

When the UE wants to transfer data, the Service Request
must have the type data.
Remove the default of f_service_request() to force
explicit defining it.

Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52

testenv/requirements: update link

Adjust the link, as the Latest_Builds wiki page was merged into
Binary_Packages.

Change-Id: Ie8a6df2f8fd08983532c8a757ae1849792fbd5b3

testenv: run requirements check before cfg init

When parsing testenv.cfg files, the titan_min version gets compared with
the installed titan version. This fails with a python trace if titan is
not installed. Catch this earlier by running the requirements check
first, which ensures ttcn3_compiler is avaiable or gives a helpful error
message:

  [testenv] Missing program: ttcn3_compiler
  [testenv]   Install eclipse-titan, e.g. from osmocom:latest:
  [testenv]   https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_Packages

Fixes: 18eef740 ("testenv: support using multiple titan versions")
Change-Id: I09ed7af5b236aeffd910d7c0a1a0b63a78631ade

testenv/requirements: simplify rsync checks

rsync is needed by osmo-dev for the autoreconf-in-src-copy feature that
testenv uses.

* Don't require rsync when running in podman. This is not necessary
  anymore since 92b3784 ("testenv: remove copy_ttcn3_hacks_dir").

* Combine the "if not testenv.args.binary_repo" code path with the
  "if not testenv.args.podman" code path, as --binary_repo can't be set
  without --podman.

Change-Id: I4fd885aa6c9b6801e18043f783bae357da716d19

NGAP_Templates: Fix wrong IEs passed to InitialContextSetupResponse

Change-Id: I7b385456e45505cb4655adda5ad5aba36fc96a4b

Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0)

Change-Id: I57c2f9adbb2f691f28ab936f09db3c24bdfeef5f