Skip to content
[Jenkins]Jenkins
log insign up
Success

Changes

Summary

  1. ggsn: README: document how to run with testenv (details)
  2. library/GTPv1C_Templates: Lots of improvements in template declarations (details)
  3. cosmetic: library/GTPv1C_Templates: remove extra indentation level (details)
  4. library/GTPv1C_Templates: Clean up PCO templates (details)
  5. mgw: Remove unneeded dep IPCP_Types.ttcn (details)
  6. s1gw: Remove unneeded dep IPCP_Types.ttcn (details)
  7. library: Move IPCP templates GTPv1C_Templates.ttcn -> (details)
  8. library/PCO_Types: Drop unused nonsense enum (details)
  9. library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum (details)
Commit 6734ee53b419cfe30e85bceb7e30cf8bb853de41 by Oliver Smith
ggsn: README: document how to run with testenv

It is possible to run the GGSN testsuite in a lot of ways (as it was
ported from docker-playground, which had the same variations but with a
less consistent way of running them).

Document how it is typically run for development / in jenkins. This
should make it easier for users, in addition to testenv already telling
which configs are available if trying to run the ggsn testsuite without
the -c argument, and to the general help output in "./testenv.py run -h".

$ ./testenv.py run ggsn
[testenv] Using testsuite ggsn_tests (via alias ggsn)
[testenv] Found multiple testenv.cfg files:
[testenv]  * testenv_open5gs.cfg
[testenv]  * testenv_osmo_ggsn_all.cfg
[testenv]  * testenv_osmo_ggsn_v4_only.cfg
[testenv]  * testenv_osmo_ggsn_v4v6_only.cfg
[testenv]  * testenv_osmo_ggsn_v6_only.cfg
[testenv] Select a specific config (e.g. '-c open5gs') or all ('-c all')

Change-Id: I49421151b199fa6536da784b6c412b03f3fdbd05
The file was modifiedggsn_tests/README.md
Commit 6bba94c76d17cf541f70ea5c975b6402b0820978 by Pau Espin Pedrol
library/GTPv1C_Templates: Lots of improvements in template declarations

Also most the compiler warnings are fixed, only some which require
special more complex attention are left as is.

Change-Id: I38a4b1c5874fda173a7b89122c84cb83ac71a036
The file was modifiedsgsn/SGSN_Tests.ttcn
The file was modifiedmme/MME_Tests.ttcn
The file was modifiedlibrary/GTPv1C_Templates.ttcn
Commit 2c10e94d32d53a476fe13a70c6e6ac10e80987c0 by Pau Espin Pedrol
cosmetic: library/GTPv1C_Templates: remove extra indentation level

The extra first indentation level around 99% of the file just loses
space which makes it difficult to keep templates at an acceptable width.
Do similarly to what we already do in lots of other template files which
were added later than this one.

Change-Id: I87755ec0a9023e79fb5f7a40c6c1734dca44696b
The file was modifiedlibrary/GTPv1C_Templates.ttcn
Commit 4d0d30a59b5d02995d4ac6be2dddf3d18e6422aa by Pau Espin Pedrol
library/GTPv1C_Templates: Clean up PCO templates

* Define a generic ProtoElem template and use it everywhere.
* User superset instead of "*, tr_..., *" construct.

Change-Id: I005a6dea0606bcb677260f85b24396b55a150153
The file was modifiedlibrary/GTPv1C_Templates.ttcn
Commit 2f102a80f19ca72cc42a7066d7e9bd0a1de597ac by Pau Espin Pedrol
mgw: Remove unneeded dep IPCP_Types.ttcn

Change-Id: I318f4ba78adf778820e8d65d5932e454bc5da670
The file was modifiedmgw/MGCP_Test.ttcn
The file was modifiedmgw/gen_links.sh
Commit 436fc24ff1c55b4cec4d5b001c5980e9b6d9bc32 by Pau Espin Pedrol
s1gw: Remove unneeded dep IPCP_Types.ttcn

Change-Id: Iad81c8d76efa2618ca7e354d2b73617a54a8d5ee
The file was modifieds1gw/gen_links.sh
Commit cca9a92cd01610a390a33fb97e1286193a9963b8 by Pau Espin Pedrol
library: Move IPCP templates GTPv1C_Templates.ttcn -> IPCP_Templates.ttcn

We already have an IPCP_Types.ttcn, and the GTPv1C_Types from
ProtocolModules dep we use doesn't actually specify any record for IPCP,
so those are totally protocol independent.

Change-Id: I233292ea886e1b69a2f9aa1a159c816791b47136
The file was modifiedggsn_tests/gen_links.sh
The file was modifiedmme/gen_links.sh
The file was modifiedsgsn/gen_links.sh
The file was modifiedlibrary/GTPv1C_Templates.ttcn
The file was modifiedgbproxy/gen_links.sh
The file was modifiedpgw/gen_links.sh
The file was modifiedhnodeb/gen_links.sh
The file was addedlibrary/IPCP_Templates.ttcn
The file was modifiedggsn_tests/GGSN_Tests.ttcn
Commit 45c9f8f5c9285c275e882a143b11c022e0d948cf by Pau Espin Pedrol
library/PCO_Types: Drop unused nonsense enum

That enum is PAP related, plus it doesn't really match the section
describing, plus it's not used anywhere.
Looks like a development artifact which was not dropped during submit.

Change-Id: Ic791d20dd600b039daa2abef7fa25aaa6780a448
The file was modifiedlibrary/PCO_Types.ttcn
Commit 3f2ed83e7307746b881e3c0a7ac4e2cf727fe735 by Pau Espin Pedrol
library/PCO_Types.ttcn: Drop unsued IPCP_OPT enum

It is unused, plus IPCP_Types.ttcn already defines a more complete enum
in IpcpConfigOptCode.

Change-Id: I867ab36063db262b46fc4546c17a902699a6e37c
The file was modifiedlibrary/PCO_Types.ttcn
The file was modifiedlibrary/IPCP_Types.ttcn